D7382: add markdown support

[Julian Wolff]

progwolff added inline comments.

INLINE COMMENTS

> aacid wrote in FindDiscount.cmake:22
> So the library is called discount but installs itself as libmarkdown?
> 
> Doesn't it have a pkg-config file?

At least the Arch Linux package (which is called "discount") does not install a 
pkg-config.

The naming seems a little inconsistent. The library, i.e. the specific 
implementation of a markdown converter is called "discount". The installed .so 
is called libmarkdown, which better describes the function it provides.

> aacid wrote in converter.cpp:56
> Have you tried mkd_document so we don't need a temp file?

I played around with this function, but could not get it to work. I'll take a 
deeper look into the source files of discount tomorrow, to check if we can get 
rid of the temporary file.

> aacid wrote in hi32-app-okular-md.svg:1
> Did you draw this SVG?

It's taken from here: https://github.com/dcurtis/markdown-mark
Licensed under Creative Commons Zero.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: aacid

[okular] [Bug 315552] Allow save annotations directly to original pdf file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=315552

--- Comment #16 from Nate Graham  ---
Haha whoops! Definitely didn't mean to do that. And now I can't remember which
bug I was trying to dupe it against, shoot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 315552] Allow save annotations directly to original pdf file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=315552

--- Comment #15 from Albert Astals Cid  ---
Duplicating a bug against itself is kind of cheating ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383675] highlight makes text disappear

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=383675

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Albert Astals Cid  ---
We're going to need that pdf file

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7382: add markdown support

[Albert Astals Cid]

aacid added a comment.


  Interesting work :)
  
  Some inline comments

INLINE COMMENTS

> FindDiscount.cmake:22
> +
> +  find_library (discount_LIBRARIES
> +NAMES markdown libmarkdown

So the library is called discount but installs itself as libmarkdown?

Doesn't it have a pkg-config file?

> converter.cpp:41
> +{
> +FILE *markdownFile = fopen( fileName.toStdString().c_str(), "rb" );
> +mDir = QDir( fileName.left( fileName.lastIndexOf( '/' ) ) );

You probably want toLocal8Bit here

> converter.cpp:56
> +FILE *tmpFile = fopen( tmpFileName.toStdString().c_str(), "w+" );
> +markdown( markdownHandle, tmpFile, MKD_FENCEDCODE | MKD_GITHUBTAGS | 
> MKD_AUTOLINK );
> +fclose( tmpFile );

Have you tried mkd_document so we don't need a temp file?

> hi32-app-okular-md.svg:1
> +
> +http://www.w3.org/2000/svg; version="1.1" width="208" 
> height="128" viewBox="0 0 208 128">

Did you draw this SVG?

> okularMd.desktop:10
> +Name[ca@valencia]=Okular
> +Name[cs]=Okular
> +Name[da]=Okular

You need to drop all translations from these and the rest of the files.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: aacid

[okular] [Bug 383675] New: highlight makes text disappear

[Germano Massullo]

https://bugs.kde.org/show_bug.cgi?id=383675

Bug ID: 383675
   Summary: highlight makes text disappear
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: germano.massu...@gmail.com
  Target Milestone: ---

Created attachment 107355
  --> https://bugs.kde.org/attachment.cgi?id=107355=edit
screenshot

Highlighting a text will make disappearing the entire text of PDF file. To
resume the text you have to erase the highlights and refresh.
See attachment

okular-16.12.3-1.fc26.x86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 151614] store annotations with documents

[Pieter De Decker]

https://bugs.kde.org/show_bug.cgi?id=151614

Pieter De Decker  changed:

   What|Removed |Added

 CC|pdedec...@gmail.com |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 151614] store annotations with documents

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=151614

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 263732] add a commandline flag for dynamically specifying reverse-search editor command

[Patrick Massot]

https://bugs.kde.org/show_bug.cgi?id=263732

Patrick Massot  changed:

   What|Removed |Added

 CC||patrickmas...@free.fr

--- Comment #1 from Patrick Massot  ---
It seems this is still not fixed in 1.0.3 and I see nothing indicating it's
fixed in git master branch.

I don't know anything about C but, if it were python, this would be a ten
minutes fix, so I guess it can't be much more than an hour of work to make
reverse-search actually usable in Okular. In its current state it's usable only
provided you have exactly one instance of the target editor opened, or else you
need to go to the preference dialog each time you open okular. Indeed, how
Okular could know which editor instance to communicate with?

Maybe we should be more explicit: what is needed is a command line flag
allowing to set the value of what is currently in the preference dialog
OkularSettings/editor/command.

It would be a great addition to Okular's greatness.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6268: HiDPI Support for Okular

[Oliver Sander]

sander added a comment.


  F3867184: okular-hidpi-render-glitch.png 


REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid

D6268: HiDPI Support for Okular

[Oliver Sander]

sander added a comment.


  I do see minor rendering artifacts every now and then.  Single rows of pixels 
seem to occur twice---possibly on tile boundaries.  See the attached example 
image: the center line of text is slightly stretched.  This happens at certain 
zoom levels.  I don't really know how to reproduce it reliably.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid

D7382: add markdown support

[Julian Wolff]

progwolff added a comment.


  F3867164: okularmd.png 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: aacid

D7382: add markdown support

[Julian Wolff]

progwolff retitled this revision from "add markdown support

BUG: 360603" to "add markdown support".
progwolff edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: aacid

D7382: add markdown supportBUG: 360603

[Julian Wolff]

progwolff created this revision.
Restricted Application added a project: Okular.

REVISION SUMMARY
  Adds support for Markdown documents

TEST PLAN
  Open a Markdown (.md) document in Okular

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7382

AFFECTED FILES
  cmake/modules/FindDiscount.cmake
  generators/CMakeLists.txt
  generators/markdown/16-apps-okular-md.png
  generators/markdown/32-apps-okular-md.png
  generators/markdown/48-apps-okular-md.png
  generators/markdown/CMakeLists.txt
  generators/markdown/Messages.sh
  generators/markdown/converter.cpp
  generators/markdown/converter.h
  generators/markdown/debug_md.h
  generators/markdown/generator_md.cpp
  generators/markdown/generator_md.h
  generators/markdown/hi32-app-okular-md.svg
  generators/markdown/libokularGenerator_md.json
  generators/markdown/okularApplication_md.desktop
  generators/markdown/okularMd.desktop
  generators/markdown/org.kde.mobile.okular_md.desktop
  generators/markdown/org.kde.okular-md.metainfo.xml
  okular.categories

To: progwolff, #okular
Cc: aacid

[okular] [Bug 301774] Wish: New option to save embedded annotation upon change/document close

[Inigo Aldazabal Mensa]

https://bugs.kde.org/show_bug.cgi?id=301774

Inigo Aldazabal Mensa  changed:

   What|Removed |Added

 CC||inigo_aldaza...@ehu.es

--- Comment #19 from Inigo Aldazabal Mensa  ---
(In reply to nizamov.shawkat from comment #13)

> 2) there may be an option of automatically saving the file with slightly
> modified filename (***-annotated.pdf). This way the original file remains
> intact, and all annotations go to the annotated file. Later if we open the
> file, and its filename conatins already "annotated" mark and there also
> exists a file with filename without this mark in the same folder (it means
> that we opened already annotated file and we have also an original file
> nearby), than the annotated file will be overwritten. What will you loose in
> the worst case is your annotations. This is how it works in Goodreader -
> very popular pdf annotation software which I use on ipad.
> 
> Preferably, both features should be combined - so that pressing "Save" will
> point to the folder with original file and suggest a filename with defined
> annotation mark. If it was detected that the file is already an annotated
> version of original, then annotated file will be overwritten without asking
> anything. 
> 
> [...]
>
> The advantage of such workflow is that original file is always retained - so
> this is safe. And you can always give someone the original file without
> annotations if required. 

I totally second this approach. In fact I was about suggesting exactly the same
thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.