ltoscano added a comment.
In https://phabricator.kde.org/D7949#150283, @ngraham wrote:
> Yes, your work here is much appreciated.
>
> Since this fixes grayscale printing, can you mark it with "BUG: 368758"?
As long as it fixes the issue only (if I understand it correctly) with
albertfreeman updated this revision to Diff 20077.
albertfreeman added a comment.
Reverted changes of accelerators that my Qt Designer automatically made.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8051?vs=20070=20077
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=383589
--- Comment #4 from Oliver Sander ---
I does.
--
You are receiving this mail because:
You are the assignee for the bug.
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
albertfreeman retitled this revision from "Enable custom background color to be
enabled and changed from settings" to "Custom background color to be enabled
and changed from settings".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc:
albertfreeman retitled this revision from "Custom background color to be
enabled and changed from settings" to "Custom background color".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid
albertfreeman edited the summary of this revision.
albertfreeman added a subscriber: aacid.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
ltoscano added a comment.
Can you please fix the summary so that it's not necessary to read the
reviewboard entry?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid
albertfreeman edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham
https://bugs.kde.org/show_bug.cgi?id=385200
Henrik Fehlauer changed:
What|Removed |Added
CC||rk...@lab12.net
--- Comment
https://bugs.kde.org/show_bug.cgi?id=385200
Bug ID: 385200
Summary: Low resolution rendering when using display scaling on
HiDPI monitor
Product: okular
Version: 1.2.1
Platform: Neon Packages
OS: Linux
ngraham edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6268
To: hetzenecker, davidedmundson, aacid
Cc: gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid
https://bugs.kde.org/show_bug.cgi?id=362856
Henrik Fehlauer changed:
What|Removed |Added
CC||rk...@lab12.net
https://bugs.kde.org/show_bug.cgi?id=362856
Christoph Feck changed:
What|Removed |Added
CC||markus@semantic-mediawiki.o
https://bugs.kde.org/show_bug.cgi?id=385200
Christoph Feck changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://bugs.kde.org/show_bug.cgi?id=267350
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=362996
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
ngraham added reviewers: aacid, elvisangelaccio, rkflx.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8051
To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx
Cc: aacid, ltoscano, ngraham
rkflx added a comment.
Thanks for bringing this to Phabricator and implementing my suggestion on
such short notice. I tested your patch and cannot find anything wrong with it
in terms of behaviour. For the code if have a trivial nitpick (see below) and I
have a comment regarding the commit
https://bugs.kde.org/show_bug.cgi?id=186531
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=377456
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=383651
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=382858
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
aacid added a comment.
I would really appreciate if you didn't unnecessarily change my summary.
REPOSITORY
R223 Okular
BRANCH
Applications/17.08
REVISION DETAIL
https://phabricator.kde.org/D7874
To: aacid, rkflx
Cc: rkflx, tobiasdeiminger, #okular, aacid
ngraham added a comment.
Sorry, I was under the impression that only "BUG: [number]" worked. I didn't
know that "BUGS:" worked too. Is that used to indicate multiple bugs?
REPOSITORY
R223 Okular
BRANCH
Applications/17.08
REVISION DETAIL
https://phabricator.kde.org/D7874
To: aacid,
https://bugs.kde.org/show_bug.cgi?id=330820
Albert Astals Cid changed:
What|Removed |Added
Ever confirmed|0 |1
https://bugs.kde.org/show_bug.cgi?id=357626
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=384147
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=377458
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=384700
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=380459
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=384695
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
ltoscano added a comment.
For the people that will land up here later: it seems that both are valid
(BUG and BUGS), see line 422 here:
https://websvn.kde.org/trunk/kde-common/svn/hooks/post-commit.pl?revision=1446260=markup
About the reviewers, you don't need to set the reviewer if
aacid added a comment.
~/okular:master$ git log | grep BUGS: | wc -l
258
;)
As far as i know it's just a synonym
REPOSITORY
R223 Okular
BRANCH
Applications/17.08
REVISION DETAIL
https://phabricator.kde.org/D7874
To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger,
aacid closed this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7874
To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger, #okular, aacid
aacid added a comment.
In https://phabricator.kde.org/D7874#149711, @rkflx wrote:
> I can confirm the fix and was not able to find any regressions (found an
unrelated bug, though).
>
> Sorry for not noticing this earlier. Maybe you'd interest more reviewers in
the future if you
36 matches
Mail list logo