D8379: PDF: Support the new poppler renderToImage with update callback

aacid added a comment. You can see a video of the difference here https://www.youtube.com/watch?v=NaUbWL6800Y REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8379 To: aacid, #okular Cc: #okular, aacid

D8378: Start the text generation request via a queued connection

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R223 Okular BRANCH queueTextRequest REVISION DETAIL https://phabricator.kde.org/D8378 To: aacid, #okular, mlaurent Cc: mlaurent, #okular, aacid

D8379: PDF: Support the new poppler renderToImage with update callback

mlaurent added inline comments. INLINE COMMENTS > generator_pdf.cpp:929 > +auto payload = static_cast(payloadA); > +QMetaObject::invokeMethod(payload->generator, > "signalPartialPixmapRequest", Qt::QueuedConnection, > Q_ARG(Okular::PixmapRequest *, payload->request), Q_ARG(QImage,

D8379: PDF: Support the new poppler renderToImage with update callback

aacid added a comment. One PDF that benefits from this is https://scalablemaps.com/download-request/dublin-center-street/pdf (even though this is not very slow it shows the difference) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8379 To: aacid, #okular Cc:

D8378: Start the text generation request via a queued connection

dvratil added inline comments. INLINE COMMENTS > generator.cpp:255 > d->mTextPageReady = false; > -d->textPageGenerationThread()->startGeneration( request->page() > ); > +// Queue the text generation request so that pixmap generation > gets a change to

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#157468, @ngraham wrote: > 1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything

D6696: Elide cut off text in sidebar header, remove restricted max width

ngraham added a comment. FWIW, I don't think eliding the text is controversial at all; could we maybe break that out into a new patch so we can get that merged quickly? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6696 To: rkflx, #okular, aacid, sander, pino Cc:

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. Here is another idea which should accommodate the use case of the bug reporter (not sure how difficult this would be to implement, though): In the Overview columns combobox, introduce an Auto mode, which depending on zoom level and window size dynamically adapts

D6696: Elide cut off text in sidebar header, remove restricted max width

rkflx planned changes to this revision. rkflx added a comment. Thanks Nate, you make a rational point (even if I do not agree fully). As promised above: > I will now try to find other reviewers. If they find the single edge case pictured above to be more important than the general case

D6696: Elide cut off text in sidebar header, remove restricted max width

ngraham added a comment. FWIW, Apple's Preview does something similar and limits the size of the sidebar to about 40% of the window's width. They elide the text, too. F5440829: PDF.png REPOSITORY R223 Okular REVISION DETAIL

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem updated this revision to Diff 21027. lexdem added a comment. Renamed all occurrences of word "less" REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8385?vs=21022=21027 REVISION DETAIL https://phabricator.kde.org/D8385 AFFECTED FILES

[okular] [Bug 385980] New: Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 Bug ID: 385980 Summary: Darstellungs Problem Product: okular Version: 0.24.0 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org

D8378: Start the text generation request via a queued connection

aacid added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8378 To: aacid, #okular Cc: #okular, aacid

D8379: PDF: Support the new poppler renderToImage with update callback

aacid added a reviewer: Okular. aacid added a comment. Upstream poppler patch needed: https://bugs.freedesktop.org/show_bug.cgi?id=103372 It's not mandatory but used with https://phabricator.kde.org/D8378 gives better results since that way we ensure that the pixmap generation takes

D8378: Start the text generation request via a queued connection

aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY so that pixmap generation gets a chance to start before the text generation This makes that on files where both the text generation and the

D8379: PDF: Support the new poppler renderToImage with update callback

aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY This way pages that take more than 500ms to render get updated every so often so that the user can see that the program didn't hang, it's just that

D8379: PDF: Support the new poppler renderToImage with update callback

aacid marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8379 To: aacid, #okular Cc: mlaurent, #okular, aacid

D8379: PDF: Support the new poppler renderToImage with update callback

aacid updated this revision to Diff 21008. aacid added a comment. Normalized Q_ARG param signature REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8379?vs=21001=21008 BRANCH updateCallback (branched from master) REVISION DETAIL

D8378: Start the text generation request via a queued connection

aacid updated this revision to Diff 21010. aacid added a comment. Fixed typo and normalized Q_ARG signature REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8378?vs=21000=21010 BRANCH queueTextRequest REVISION DETAIL https://phabricator.kde.org/D8378

D8378: Start the text generation request via a queued connection

aacid marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH queueTextRequest REVISION DETAIL https://phabricator.kde.org/D8378 To: aacid, #okular, mlaurent Cc: dvratil, mlaurent, #okular, aacid

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 --- Comment #2 from Claus-Peter Brockmann --- Sorry my English is not perfect, Translate with https://translate.google.com/ Presentation problem Problem of presentation, electronically captured PDF form Okular Version 0.24.2

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 --- Comment #4 from Ben Cooksley --- The content of attachment 108473 has been deleted for the following reason: Removing file with private information -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 --- Comment #5 from Ben Cooksley --- The content of attachment 108474 has been deleted for the following reason: Removing file with private information -- You are receiving this mail because: You are the assignee for the bug.

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem created this revision. lexdem added a reviewer: Okular. lexdem added a project: Okular. REVISION SUMMARY This is a patch for the following request: 355283 The principle is simple. User toggles the checkbox, which enables overriding the default columns for Overview mode, if the

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. 1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything you can count (e.g. fewer columns, fewer people, fewer lines of