[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

2017-10-22 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=385456

--- Comment #6 from bbdn...@gmail.com ---
Created attachment 108519
  --> https://bugs.kde.org/attachment.cgi?id=108519=edit
It is a log when printing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7662: Draw a dark rectangle around highlighted search results

2017-10-22 Thread Nathaniel Graham 
ngraham added a comment.


  Any progress on this?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7662

To: sander, #okular
Cc: cfeck, aacid, ngraham

[okular] [Bug 385458] pdf form remain blank in Bulgarian

2017-10-22 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=385458

--- Comment #5 from Albert Astals Cid  ---
i get "Sorry, we couldn’t find that page" when trying to view that vimeo page

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385419] Implement "fit text to column" and "Text reflow" in okular

2017-10-22 Thread Simon Andric 
https://bugs.kde.org/show_bug.cgi?id=385419

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  +1 here too.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular, rkflx, ngraham
Cc: ltoscano, aacid, rkflx, ngraham

D8415: Soften correctness of image file open check

2017-10-22 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks for the patch: The Summary needs some reformatting:
  
  - Add the special keyword "BUG 385384" on its own line
  - Remove the quote from the Bugzilla ticket; instead briefly explain the 
change in your own words
  - No need to explain the code change; it should be self-explanatory, or else 
have comments in the code itself
  
  Can/did you test this patch with other PNG files to make sure it didn't break 
for other files?
  
  Otherwise, this looks good to me.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid

[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

2017-10-22 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=385456

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #5 from Albert Astals Cid  ---
The file prints fine here.

Can you please describe a bit better why do you mean by "Okular do not print
PDF" ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386073] Access to smb is forbidden

2017-10-22 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=386073

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
waiting for answers to yuri

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386073] Access to smb is forbidden

2017-10-22 Thread Yuri Chornoivan 
https://bugs.kde.org/show_bug.cgi?id=386073

--- Comment #1 from Yuri Chornoivan  ---
Please report bugs in English, not in Russian.

Moreover, can you try some newer version of Okular?

Is it possible to read the files from this SMB share through other KDE
applications (e.g. KWrite or Kate)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386073] Access to smb is forbidden

2017-10-22 Thread Yuri Chornoivan 
https://bugs.kde.org/show_bug.cgi?id=386073

Yuri Chornoivan  changed:

   What|Removed |Added

Summary|доступ к smb запрещен   |Access to smb is forbidden
 CC||yurc...@ukr.net

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386073] New: доступ к smb запрещен

2017-10-22 Thread IgorIGN 
https://bugs.kde.org/show_bug.cgi?id=386073

Bug ID: 386073
   Summary: доступ к smb запрещен
   Product: okular
   Version: 0.24.0
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: igor@i.ua
  Target Milestone: ---

Невозможно открыть smb://admin@10.0.0.7/LINUX/GRUB/GRUB-zagruzchik_system.pdf.
Причина: Доступ к smb://admin@10.0.0.7/LINUX/GRUB/GRUB-zagruzchik_system.pdf
запрещён.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8415: Soften correctness of image file open check

2017-10-22 Thread Alexander Trufanov 
trufanov created this revision.
trufanov added reviewers: ngraham, Okular.
trufanov added a project: Okular.

REVISION SUMMARY
  resolves bug https://bugs.kde.org/show_bug.cgi?id=385384
  
  Bug 385384 - Some PNG files produced by acdsee can't be displayed
  
  > Hi,
  >  I've got a png file that could be opened in gwenview, GIMP and 
ImageMagick. But can't be viewed in Okular. My app had the same problem so I 
dig into gwenview sourcecode to find the solution and now would like to share 
my findings.
  > 
  > As gwenview my app uses Qt's QImage/QImageReader to load this png file. And 
Qt uses libpng1.6.28-1 that prints in std::cout "libpng error: Read Error" in 
both cases. But gwenview ignores this error and still able to show image. Bcs 
instead of `void QImage::load(...)` or `QImage QImageReader::read()` it invokes 
`bool QImageReader::read(QImage *)`. And it ignores its result value if 
returned QImage is valid.
  > 
  > This allowed me to workaround problem in my app.
  > 
  > Gwenviews code: 
  >  They log an error here 

 but as loadImageData() is a void function and mImage still contains valid 
image the app displays it as usual.
  
  My assumption is that png has incomplete or incorrect set of flags in header 
so libpng reports error while still loads image data to RAM.
  
  A test png is attached.
  I was told that this was a tiff file (result of scanning) that was converted 
to png with acdsee v3.1 under Win.
  
  Attachment 

TEST PLAN
  Try to open attached png file. It can't be opened.
  Apply patch (make sure Okular uses fixed okularGenerator_kimgio.so) - now it 
could be opened and displayed correctly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

AFFECTED FILES
  generators/kimgio/generator_kimgio.cpp

To: trufanov, ngraham, #okular
Cc: aacid

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Lex Dem 
lexdem added a comment.


  Thank you, I will wait for this :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular, rkflx
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Henrik Fehlauer 
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  Great, thank you. From my side this LGTM. As mentioned above, we'll wait a 
week for more comments and then commit on your behalf.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular, rkflx
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Lex Dem 
lexdem edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Lex Dem 
lexdem added a comment.


  Yep, sorry. Fixed

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Henrik Fehlauer 
rkflx added a comment.


  Sorry, you missed one more thing: Your summary still says
  
  > User toggles the checkbox
  
  which he cannot anymore…

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Lex Dem 
lexdem added a comment.


  In https://phabricator.kde.org/D8385#158072, @rkflx wrote:
  
  > In https://phabricator.kde.org/D8385#158066, @lexdem wrote:
  >
  > > @ngraham , changed to the "FEATURE"
  >
  >
  > You changed it to `**FEATURE**`, but the tooling handling this 

 is not part of Phabricator and probably won't understand markdown. Could you 
change it to just `FEATURE`, please?
  
  
  Yep, thanks. Thanks for pointing to that script :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Lex Dem 
lexdem edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-22 Thread Henrik Fehlauer 
rkflx added a comment.


  In https://phabricator.kde.org/D8385#158066, @lexdem wrote:
  
  > @ngraham , changed to the "FEATURE"
  
  
  You changed it to `**FEATURE**`, but the tooling handling this 

 is not part of Phabricator and probably won't understand markdown. Could you 
change it to just `FEATURE`, please?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham