D8677: Update okular docbook

2017-11-07 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R223:01ce40b955f9: Update okular docbook (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8677?vs=21953=22017#toc REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 96 - Still Unstable!

2017-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/96/ Project: Applications okular kf5-qt5 FedoraQt5.8 Date of build: Tue, 07 Nov 2017 10:03:08 + Build duration: 10 min and counting JUnit Tests

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff
https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff
https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added CC||wo...@julianwolff.de ---

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff
https://bugs.kde.org/show_bug.cgi?id=386600 Julian Wolff changed: What|Removed |Added CC||kosse...@kde.org ---

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Friedrich W . H . Kossebau
https://bugs.kde.org/show_bug.cgi?id=386600 --- Comment #3 from Friedrich W. H. Kossebau --- I do not have Okular from master branch, so cannot test this myself for Markdown documents. But the KParts plugin used should know about the mimetype, it is passed both when loading

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff
progwolff created this revision. progwolff added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY BUG: 386600 Applications using Okular as a KPart might set a file's mime type in the OpenUrlArguments.

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff
progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff
progwolff updated this revision to Diff 22028. progwolff added a comment. - add autotest REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8690?vs=22020=22028 BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D8690 AFFECTED FILES

D8642: Rework saving of annotations and form data

2017-11-07 Thread Michael Weghorn
michaelweghorn added a comment. > Open pdf file, add anotation, close app > You get dialog about losing changes, check that save, discard, cancel all do what they say This works as described. One additional thought on that: Some users may want to save the modified version to a new

D8704: Don't use exec() to open dialogs

2017-11-07 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Okular. Restricted Application added a project: Okular. REVISION SUMMARY exec() is blocking and should not be used if possible. Currently it makes impossible to interact with a 2nd okular window if the first window

D8704: Don't use exec() to open dialogs

2017-11-07 Thread Elvis Angelaccio
elvisangelaccio added a subscriber: okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8704 To: elvisangelaccio, #okular Cc: okular-devel, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Albert Astals Cid
aacid added a comment. Not sure that's the test we really want, i mean what we really want to check is that the proper backend was opened, no? I mean maybe what makes sense is to set the mimetype to txt and then giving it a pdf file and checking that the txt backend was used instead of

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff
progwolff added a comment. Right, this might be worth a test too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

[okular] [Bug 385384] Some PNG files produced by acdsee can't be displayed

2017-11-07 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=385384 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

D8415: Soften correctness of image file open check

2017-11-07 Thread Nathaniel Graham
ngraham added a comment. Could we add the local workaround here, and include a FIXME comment urging an upstream fix later? Gwenview already has this workaround... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular Cc: aacid,

[okular] [Bug 385384] Some PNG files produced by acdsee can't be displayed

2017-11-07 Thread Alexander Trufanov
https://bugs.kde.org/show_bug.cgi?id=385384 --- Comment #2 from Alexander Trufanov --- The workaround is proposed on https://phabricator.kde.org/D8415 -- You are receiving this mail because: You are the assignee for the bug.

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff
progwolff added inline comments. INLINE COMMENTS > part.cpp:1400 > { > -mimes << pathMime << argMime; > +mimes << argMime << pathMime; > } I changed the order here. Now mime types defined by OpenUrlArguments are prefered. This allows opening files with