KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

2018-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 02:27:28 + Build duration: 33 min and counting JUnit Tests

D10249: Option to exit after printing

2018-02-07 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > mainshelltest.cpp:320 > + if (externalProcessExpectPrintDialogAndExit) > +args << QStringLiteral("-print_and_exit"); > p.start(QStringLiteral(OKULAR_BINARY), args); Regarding this option: shouldn't it be -print-and-exit

D10249: Option to exit after printing

2018-02-07 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > part.cpp:3240 > > -void Part::doPrint(QPrinter ) > +bool Part::doPrint(QPrinter ) > { Can you please make doPrint return true on success and not on error? It's a much saner API. REPOSITORY R223 Okular REVISION DETAIL

D10048: [PATCH 2/4] Communicate calculate text change to formwidgets

2018-02-07 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D10048#202336, @aheinecke wrote: > I had another look at this and I could not get it to work with refreshPixmaps and I don't understand how the FormWidget should be updated if the text of the underlying FormField changes. The only

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-07 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kjs_field.cpp:222 > > +KJSObject JSField::wrapField( KJSContext *ctx, FormField *field) > +{ You really want ot use the verison with the page so refreshPixmaps happens REPOSITORY R223 Okular REVISION DETAIL

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

2018-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 04:11:54 + Build duration: 28 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

2018-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/27/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 06:00:25 + Build duration: 27 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

2018-02-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/26/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 04:52:14 + Build duration: 39 min and counting JUnit

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #2 from Michael D --- I'm using okular 1.3.1 and NOT using "save as" but just "save" after editing a file with annotations. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Huon
https://bugs.kde.org/show_bug.cgi?id=389668 Huon changed: What|Removed |Added CC||h...@plonq.org --- Comment #1 from Huon

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Huon
https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #3 from Huon --- @Michael D - 1.3.1? 3.2.0 was released in 2004. I tested saving with "Save" after adding annotations, still couldn't reproduce. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #4 from Michael D --- On this bug, the drop down the version maxes out at 1.3.1, "okular --version" says 1.3.1, and even through the help gui it says 1.3.1, so... Anyway, I can only reproduce it on certain files and

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Huon
https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #5 from Huon --- Hmm, I'm new to the KDE (dev) world, not sure why the package version (and versions on github) are different to the version reported by okular itself and the bugtracker. I am also using 1.3.1 as reported by

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-07 Thread Huon
https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #6 from Huon --- Could you try to extract a page or two to a separate file? Like a blank page or a page without copyrighted material? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de ---

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 Michael Weghorn changed: What|Removed |Added Version|unspecified |1.3.1 -- You are

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #2 from Attila --- I tried it on Fedora 27 with Okular 1.2.1 and with the latest version 1.3.1. It doesn't help. Same result. -- You are receiving this mail because: You are the assignee for the bug.

[frameworks-kwidgetsaddons] [Bug 389981] Info bar shows blue text on blue background

2018-02-07 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=389981 Kai Uwe Broulik changed: What|Removed |Added Component|general |general

D10048: [PATCH 2/4] Communicate calculate text change to formwidgets

2018-02-07 Thread Andre Heinecke
aheinecke added a comment. I had another look at this and I could not get it to work with refreshPixmaps and I don't understand how the FormWidget should be updated if the text of the underlying FormField changes. The only setTexts I see in the FormWidgets are in the Ctor or in the

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #4 from Attila --- (In reply to Michael Weghorn from comment #3) > I cannot reproduce the problem here. I can always reproduce it. > > Does it happen for every document you use? Can you attach one that is >

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #5 from Attila --- Created attachment 110395 --> https://bugs.kde.org/attachment.cgi?id=110395=edit Example to print -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #6 from Michael Weghorn --- (In reply to Attila from comment #4) > LogLevel is set to debug. Did a restart. No logfile is written. Maybe a new > bug. I wish I could send you the error_log. That's interesting... Does

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #7 from Attila --- The ErrorLog directive was syslog. You can check now the attached files error_log and the output of systemctl status cups.service -- You are receiving this mail because: You are the assignee

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #8 from Attila --- Created attachment 110402 --> https://bugs.kde.org/attachment.cgi?id=110402=edit error_log -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #9 from Attila --- Created attachment 110403 --> https://bugs.kde.org/attachment.cgi?id=110403=edit Output of systemctl status cups.service -- You are receiving this mail because: You are the assignee for the

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #10 from Michael Weghorn --- (In reply to Attila from comment #7) > You can check now the attached files error_log and the output of systemctl > status cups.service Thanks! At first glance, I don't see anything

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #11 from Attila --- Just two things to mention: - This "bug" is not only related to the printer HPM880. I get the same result on different printers. - The printer is served by a Cups server. Is that the reason,

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #13 from Attila --- Created attachment 110406 --> https://bugs.kde.org/attachment.cgi?id=110406=edit PPD file HPM880 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #12 from Attila --- Created attachment 110405 --> https://bugs.kde.org/attachment.cgi?id=110405=edit File generated by Okular -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #14 from Michael Weghorn --- Thanks for the additional information. (In reply to Attila from comment #11) > - The printer is served by a Cups server. Is that the reason, why you said > no "real" CUPS filters are