[okular] [Bug 341914] Allow Annotation Tools in Toolbar

https://bugs.kde.org/show_bug.cgi?id=341914 Simone Gaiarin changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 386578] Request: Allow annotation mode to "stick" for better use with a stylus

https://bugs.kde.org/show_bug.cgi?id=386578 Simone Gaiarin changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

https://bugs.kde.org/show_bug.cgi?id=385456 --- Comment #12 from bbdn...@gmail.com --- Created attachment 111000 --> https://bugs.kde.org/attachment.cgi?id=111000=edit screenshot Thank you for help. output of terminal. [user@archlinux ~]$ sudo pacman -Ss libspectre [sudo] user のパスワード:

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/46/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Feb 2018 02:21:30 + Build duration: 15 min and counting JUnit Tests

[okular] [Bug 354894] allow any graphic/symbol as stamp annotation

https://bugs.kde.org/show_bug.cgi?id=354894 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #5 from

[okular] [Bug 159007] Personal gallery od stamps

https://bugs.kde.org/show_bug.cgi?id=159007 Nate Graham changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #12 from

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

https://bugs.kde.org/show_bug.cgi?id=383652 Nate Graham changed: What|Removed |Added CC||alberthilb...@gmail.com ---

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

https://bugs.kde.org/show_bug.cgi?id=383652 Nate Graham changed: What|Removed |Added CC||lopeziba...@gmail.com --- Comment

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 18:16:28 + Build duration: 25 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 73 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/73/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 25 Feb 2018 18:03:03 + Build duration: 1 hr 4 min and counting

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/37/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 18:03:03 + Build duration: 23 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/38/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 18:27:03 + Build duration: 21 min and counting JUnit

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz added a comment. I agree. Any idea? Put the annotations containing a popup note in italic? Not my favorite choice though. I would like something subtle. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10797 To: simgunz, #okular Cc: ngraham,

D10797: Add asterisk when an annotation is associated to non-empty popup

ngraham added a comment. Doesn't an asterisk after a title typically denote an unsaved file? Maybe we should come up with a different UI metaphor here. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10797 To: simgunz, #okular Cc: ngraham, michaelweghorn, aacid

[okular] [Bug 389836] Distinguish highlights containing a non-empty popup note inreview pane

https://bugs.kde.org/show_bug.cgi?id=389836 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving

[okular] [Bug 387282] Highlighting of search results and text selection lost when rotating page

https://bugs.kde.org/show_bug.cgi?id=387282 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org

[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

https://bugs.kde.org/show_bug.cgi?id=385456 --- Comment #11 from Albert Astals Cid --- This is very confusing since i'm also on arch linux and it works for me. Just checking you have libspectre installed, right? also what's the output of locale on a terminal? -- You are

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/34/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:25:56 + Build duration: 15 min and counting JUnit

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213475 , @aacid wrote: > This is wrong because lots of the support for those file formats depends whether you have the backends or not, so this either should be made to depend on which dependencies where found

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 128 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/128/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 25 Feb 2018 11:26:06 + Build duration: 29 min and counting JUnit Tests

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213518 , @ltoscano wrote: > I think that this was already discussed, but would it make sense to have a function in extra-cmake-modules which generates the plist file based on some parameters (known from

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/35/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:41:20 + Build duration: 16 min and counting JUnit

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. I can hardly NOT accept this, given I'm the original author :) Adding document-type icons isn't strictly necessary. The Finder will display documents with the icon of the default

D8690: Fix use of OpenUrlArguments

progwolff closed this revision. progwolff added a comment. Thanks! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngraham, aacid

[okular] [Bug 371905] actions like trim margins, toggle sidebar deselect annotation/review tool

https://bugs.kde.org/show_bug.cgi?id=371905 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com -- You

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. This is wrong because lots of the support for those file formats depends whether you have the backends or not, so this either should be made to depend on which dependencies where

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:26:06 + Build duration: 16 min and counting JUnit Tests

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213518 , @ltoscano wrote: > I think that this was already discussed, but would it make sense to have a function in extra-cmake-modules which generates the plist file based on some parameters (known from

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 69 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/69/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 10:45:51 + Build duration: 9 min 25 sec and counting CONSOLE OUTPUT

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/43/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 10:45:51 + Build duration: 9 min 14 sec and counting CONSOLE OUTPUT

D8690: Fix use of OpenUrlArguments

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Ok, i'll commit that version. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn,

[okular] [Bug 386600] Okularpart renders markdown as regular text

https://bugs.kde.org/show_bug.cgi?id=386600 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213465 , @rjvbb wrote: > Adding document-type icons isn't strictly necessary. The Finder will display documents with the icon of the default application configured to open the type in question, or with the

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

ltoscano added a comment. I think that this was already discussed, but would it make sense to have a function in extra-cmake-modules which generates the plist file based on some parameters (known from somewhere else or passed explicitly) instead of hand-writing that file? REPOSITORY R223

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/127/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 25 Feb 2018 10:45:51 + Build duration: 16 min and counting CONSOLE

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/32/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 10:45:21 + Build duration: 18 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/33/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:04:15 + Build duration: 15 min and counting JUnit

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/70/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 11:26:06 + Build duration: 9 min 52 sec and counting JUnit Tests

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

rjvbb added a comment. My original implementation is used in conjunction with a build system that ensures all dependencies are available. I don't know if cmake is flexible enough to add the XML elements for the document types that a local build will support given the locally available

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213607 , @rjvbb wrote: > The task at hand seems more complex and I have my doubts as to how worth it would be the effort to implement support for doing this in the ECM. I'd say there are Mac-specific things

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 66 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/66/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 17:52:58 + Build duration: 5 min 4 sec and counting CONSOLE

[okular] [Bug 388228] Okular crashes when annotating a piece of text

https://bugs.kde.org/show_bug.cgi?id=388228 Albert Astals Cid changed: What|Removed |Added Latest Commit||https://commits.kde.org/oku

D9852: Fix crash due to dangling pointer in MouseAnnotation

This revision was automatically updated to reflect the committed changes. Closed by commit R223:3c4f16ea4b7e: Fix crash due to dangling pointer in MouseAnnotation (authored by tobiasdeiminger, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 67 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/67/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 18:03:03 + Build duration: 6 min 54 sec and counting JUnit

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

sbragin added a comment. In D10808#213672 , @rjvbb wrote: > Adding supported document types in the plist has zero interest if you don't modify the code so it catches Qt's `FileOpen` events I decided to divide it into two parts, FileOpen

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

rjvbb added a comment. Then again, all "not non-gui" applications need an application icon, and adding one is simple enough that it can be done in cmake with a few simple enough operations. And a little bit of extra care in the source code to avoid undoing the effect of ecm_add_app_icon.

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/36/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 17:52:58 + Build duration: 4 min 18 sec and counting

D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

ltoscano added a comment. In D10808#213531 , @sbragin wrote: > In D10808#213518 , @ltoscano wrote: > > > I think that this was already discussed, but would it make sense to have a function in

D9852: Fix crash due to dangling pointer in MouseAnnotation

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Honestly i don't understand the code but it fixes the crash so let's hope it doesn't create more regressions than it fixes :) I'll commit it in a minute REPOSITORY R223 Okular

KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 72 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/72/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 25 Feb 2018 17:52:58 + Build duration: 8 min 8 sec and counting

D10455: Add RTL support for search, copy & paste in pdf

chfanzil added a comment. I've tested this patch using 2 PDF files: One in Hebrew (it was downloaded using Wikipedia's Download-as-PDF option) the other in Arabic (it was supplied with the patch). F5729640: Open Source (Hebrew Wikipedia).pdf

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/68/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 18:09:58 + Build duration: 5 min 31 sec and counting JUnit