D11051: Remembering side navigation panel state

2018-03-09 Thread Oliver Sander
sander added a comment.


  I tried the patch and it does what it claims to do.  I have no further 
objections.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular
Cc: sander, #okular, michaelweghorn, ngraham, aacid


D11051: Remembering side navigation panel state

2018-03-09 Thread Albert Astals Cid
aacid added a comment.


  Do you think you can give it a try at adding an auto test for this?
  
  Also i'm not convinced it's a good idea to save the settings in sidebar.cpp 
but read them in part.cpp, seems a bit asymmetrical, can you explain your 
reasoning for it?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular
Cc: aacid, sander, #okular, michaelweghorn, ngraham


[okular] [Bug 391625] Okular displays blurry images when opening epub files

2018-03-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=391625

Nate Graham  changed:

   What|Removed |Added

  Component|general |EPub backend
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391625] Okular displays blurry images when opening epub files

2018-03-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=391625

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Nate Graham  ---
The file that reproduces the issue is available at
https://nofile.io/f/wx5M48ugyO9/10.1007_978-1-4302-6653-2.epub. I can't attach
it here because it's slightly too large for the 4MB file size limit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

GSoC Project: Verifying signatures of pdf files (Draft Proposal)

2018-03-09 Thread Ahmad Osama
Dear All;

I am interested to participate with Okular in GSoC, I have written a draft
proposal about the project I am interested to join.

Here is the link to my proposal:

https://docs.google.com/document/d/1DIQBvzPjuw8HdqEB0qXt4nkQ05bF_AV9_6kyrRcdJW8/edit?usp=sharing

I am still going through Okular and Poppler's source code to get a better
understanding and develop a better implementation plan.

Any feedback or suggestions are highly appreciated.

Regards,
Ahmad Osama


[okular] [Bug 391625] New: Okular displays blurry images when opening epub files

2018-03-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391625

Bug ID: 391625
   Summary: Okular displays blurry images when opening epub files
   Product: okular
   Version: 1.3.2
  Platform: Manjaro
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: huma...@posteo.de
  Target Milestone: ---

Created attachment 111286
  --> https://bugs.kde.org/attachment.cgi?id=111286=edit
Okular blurry images

When opening epub files, without exception, the images appear blurry even if
displayed at 100%. However, if I open the file with a image viewer such as
mcomix or convert it to pdf with ebook-convert, the image displays normally
without distortion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391625] Okular displays blurry images when opening epub files

2018-03-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391625

--- Comment #1 from huma...@posteo.de ---
Created attachment 111287
  --> https://bugs.kde.org/attachment.cgi?id=111287=edit
Same image opened im Mcomix

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10974: PDF: Make the "fit-to-page" print option configurable

2018-03-09 Thread Michael Weghorn
michaelweghorn updated this revision to Diff 29095.
michaelweghorn added a comment.


  (Don't) Set margins based on QPrinter::fullPage()
  
  This modifies the draft solution as I described in comment
  https://phabricator.kde.org/D10974#217969 .

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=28418=29095

BRANCH
  michaelweghorn/WIP_NEW_VERSION_D10974_makeMarginsOptional

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  core/fileprinter.cpp
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular
Cc: aacid, ngraham, michaelweghorn


D10974: PDF: Allow to ignore print margins

2018-03-09 Thread Michael Weghorn
michaelweghorn retitled this revision from "PDF: Make the "fit-to-page" print 
option configurable" to "PDF: Allow to ignore print margins".
michaelweghorn edited the summary of this revision.
michaelweghorn edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: aacid, ngraham, michaelweghorn