[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #9 from Albert Astals Cid --- (In reply to Kevin Burton from comment #5) > Wow.. Fascinating. Can you screenshot how you did that? or take a video? https://www.youtube.com/watch?v=5BBwYbacTMQ > I wonder if there some IFDEF

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #11 from Albert Astals Cid --- (In reply to Kevin Burton from comment #10) > ok.. so then maybe this bug is more about the fact that , at least on 1 > machine, strike through isn't an option. That's just not possible, see

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #5 from Kevin Burton --- Wow.. Fascinating. Can you screenshot how you did that? or take a video? That's definitely not on my machine. I don't even have 'strike out' as one of the options in type when

[okular] [Bug 394623] Region highlight annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394623 Albert Astals Cid changed: What|Removed |Added Resolution|--- |INVALID CC|

[okular] [Bug 394623] Region highlight annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394623 --- Comment #2 from Kevin Burton --- Just updating. https://imgur.com/a/UR9w77J I don't have those options. This is running from the latest unstable build too via docker container so I'm running the latest and

[okular] [Bug 394623] Region highlight annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394623 --- Comment #5 from Albert Astals Cid --- Then can you please open a new wishlist item saying you want rectangles? Because this bug title said regions and region highlights are supported. I understand rectangles are easier to control

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #10 from Kevin Burton --- ok.. so then maybe this bug is more about the fact that , at least on 1 machine, strike through isn't an option. -- You are receiving this mail because: You are the assignee

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #3 from Kevin Burton --- I wish I was wrong here but not on my 1.33 and not on unstable okular either. Here's what I have: https://imgur.com/a/UR9w77J Adding a new annotation shows less than the

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #7 from Kevin Burton --- OK.. I DO have polygon. Just not rectangle. Rectangle is important: 1. they're easy resize. 2. I can resize just the left, right, top , or bottom, or I can pick the corner to

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #8 from Albert Astals Cid --- you commented on the wrong bug, this is about strikethrough. -- You are receiving this mail because: You are the assignee for the bug.

D13072: add info about default/custom annotations

2018-05-23 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R223:7812952c85d2: add info about default/custom annotations (authored by lueck). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13072?vs=34738=34772 REVISION DETAIL

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

2018-05-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Applications okular kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 24 May 2018 04:58:05 + Build duration: 13 min and counting JUnit Tests

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 --- Comment #12 from Kevin Burton --- Thx.. I'm going to post to the forum and see if other users have a similar issue. I mean they literally don't show up on my machine so something here is weird. -- You are

D11723: Add FormFieldSignature to Okular namespace

2018-05-23 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > signatureinfo.h:33 > + */ > +virtual int signatureStatus() const; > + int is bad, this, certificateStatus and hashAlgorithm need to be enums, what am i supposed to do with this returning 3? What does 3 mean? > signatureinfo.h:58 >

[okular] [Bug 377688] No output to print for PDF since update to 1.0.3

2018-05-23 Thread Ian Newton
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #21 from Ian Newton --- Resolved the avahi-daemon failure as in https://bugzilla.redhat.com/show_bug.cgi?id=1050201 "I had some stale files in /var/run/avahi-daemon, cleaning those out seems to have fixed it" However

D12825: Fix recalculating forms twice

2018-05-23 Thread Andre Heinecke
aheinecke added a comment. I'll upload a new patch. (sorry for delaying my okular work, I'm currently still a bit swamped by the efail hype) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-05-23 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34717. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Updated API. Removed cases with no use cases. Removed redundant enums. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11723?vs=34307=34717

[okular] [Bug 394620] New: Annotations don't work in other PDF readers.

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394620 Bug ID: 394620 Summary: Annotations don't work in other PDF readers. Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

[okular] [Bug 394620] Annotations don't work in other PDF readers.

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394620 --- Comment #1 from Kevin Burton --- There's an OLD bug for poppler to provide these as default. But it looks like the bug was never fixed. I guess the solution is to pressure poppler?

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383651 Nate Graham changed: What|Removed |Added CC||burton+bugs.kde.org@inputne

[okular] [Bug 394620] Annotations don't work in other PDF readers.

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394620 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

D11723: Add FormFieldSignature to Okular namespace

2018-05-23 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > aacid wrote in form.cpp:284 > What's this used for? For other formfields it can be used to set their default states. But for signature field I have no idea. > aacid wrote in form.h:390 > What would be the usecase for this force? I never

[okular] [Bug 394621] New: support strikethrough annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394621 Bug ID: 394621 Summary: support strikethrough annotations Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 394623] New: Region highlight annotations

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=394623 Bug ID: 394623 Summary: Region highlight annotations Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394621 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #17 from Nate Graham --- I agree that this is important and fixing it should be a high priority. We have a number of other bugs relating to this subject: - https://bugs.kde.org/show_bug.cgi?id=275371 -

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #21 from Nate Graham --- I know, and I don't necessarily disagree with you. But as a fellow programmer someone who's watched this project for a while and advocated for the same things, let me tell you that disabling the

D13072: add info about default/custom annotations

2018-05-23 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Okular, Documentation. Restricted Application added projects: Okular, Documentation. Restricted Application added subscribers: kde-doc-english, okular-devel. lueck requested review of this revision. REVISION SUMMARY make it obvious that okular

[okular] [Bug 394621] support strikethrough annotations

2018-05-23 Thread Burkhard Lueck
https://bugs.kde.org/show_bug.cgi?id=394621 Burkhard Lueck changed: What|Removed |Added CC||lu...@hube-lueck.de ---

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #22 from Kevin Burton --- Do you have a thought on the poppler default annotation appearance issue? That's probably the greatest bang for the buck. If that fixes 80% of the problems then we should focus

D13072: add info about default/custom annotations

2018-05-23 Thread Yuri Chornoivan
yurchor accepted this revision as: yurchor. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13072 To: lueck, #okular, #documentation, yurchor Cc: okular-devel, kde-doc-english, ngraham, skadinna, aacid

D13072: add info about default/custom annotations

2018-05-23 Thread Burkhard Lück
lueck updated this revision to Diff 34738. lueck edited the summary of this revision. lueck added a comment. add regions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13072?vs=34736=34738 REVISION DETAIL https://phabricator.kde.org/D13072 AFFECTED

[okular] [Bug 394623] Region highlight annotations

2018-05-23 Thread Burkhard Lueck
https://bugs.kde.org/show_bug.cgi?id=394623 Burkhard Lueck changed: What|Removed |Added CC||lu...@hube-lueck.de ---

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #16 from Kevin Burton --- This bug is related to the issue of default annotation appearance handling. It isn't just "image stamp" handling. There are two bugs here.

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #18 from Kevin Burton --- Thanks Nate. I think one main concern I have is for other users of Okular using annotations. Some of these bugs are rather old and I suspect the issue of highlights and notes

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #19 from Nate Graham --- That has been discussed before and rejected, since that would represent a loss of functionality--a great deal of which *does* work in other viewers, and all of which works in Okular itself. Let's

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Kevin Burton
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #20 from Kevin Burton --- I am a programmer. I'm able to review them and will get to them. I'm curious if this is the best solution. If it means just revising the poppler patches and that's the best path

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #23 from Nate Graham --- I agree that we should focus on Poppler. If I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=23108#c21 correctly, patches were merged that handled some annotation types, but not all of them. We