D19717: Search function fails to find phrases split over two lines

joaonetto created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. joaonetto requested review of this revision. REVISION SUMMARY As reported by users, search would not find if the text was split across multiple lines, this fixes it, I added tests to prove

D19717: Search function fails to find phrases split over two lines

joaonetto added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19717 To: joaonetto, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D19539: Replace some iterator loops by range-based for

sander added a comment. Albert, is this okay now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: aacid, davidhurka, okular-devel, tfella, ngraham, darcyshen

D19702: Page changes triggered by mouse clicks should all happen on button release

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Previously this was inconsistent: left button clicks triggered page changes at release, but right

[okular] [Bug 405398] New: I'm unable to view the page number option

https://bugs.kde.org/show_bug.cgi?id=405398 Bug ID: 405398 Summary: I'm unable to view the page number option Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity:

[okular] [Bug 405398] I'm unable to view the page number option

https://bugs.kde.org/show_bug.cgi?id=405398 Yuri Chornoivan changed: What|Removed |Added Resolution|--- |NOT A BUG Status|REPORTED

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53738. ognarb added a comment. Use string.length > 0 instead of string == "". It's faster REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53338=53738 BRANCH arcpatch-D18658 REVISION DETAIL

[okular] [Bug 405396] New: I'm unable to see the page number coulmn in okular

https://bugs.kde.org/show_bug.cgi?id=405396 Bug ID: 405396 Summary: I'm unable to see the page number coulmn in okular Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED

[okular] [Bug 405396] I'm unable to see the page number coulmn in okular

https://bugs.kde.org/show_bug.cgi?id=405396 Yuri Chornoivan changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC|

D19702: Page changes triggered by mouse clicks should all happen on button release

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19702 To: sander, #okular, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

Re: D18118: Presentation mode: go to previous page when left-clicking on left half of the page

What is the exact language? I find the parenthesis to be an awkward sentence structure. If that is the actual language in the tool-tip. I would think something like "Tapping: Left half = previous page, Right Half = following page would suffice. or *Tapping: Left side = Previous, Right side =

D19702: Page changes triggered by mouse clicks should all happen on button release

aacid requested changes to this revision. aacid added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > presentationwidget.cpp:746 > // always means "show next page", so we unconditionally delegate to that > // action on mouse button press This comment

D18358: [WIP] Add buttons to collapse and expand all elements

joaonetto updated this revision to Diff 53762. joaonetto marked 2 inline comments as done. joaonetto added a comment. Updated with new icons, should use latest breeze-icons. Also fixed typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18358?vs=49808=53762

D18358: Add buttons to collapse and expand all elements

joaonetto retitled this revision from "[WIP] Add buttons to collapse and expand all elements" to "Add buttons to collapse and expand all elements". joaonetto edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto,

D18358: Add buttons to collapse and expand all elements

ndavis added a comment. In D18358#429972 , @aacid wrote: > How does it look when you don't have latest breeze? You wouldn't get any icons for "collapse/expand all" buttons without the latest breeze-icons. REPOSITORY R223 Okular

D18358: Add buttons to collapse and expand all elements

joaonetto added a comment. Just added some screenshots with the results. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg, ngraham Cc: ndavis, aacid, ngraham, okular-devel, tfella, darcyshen