D20437: Make selection scrolling go at 60 fps

2019-05-20 Thread kezi
kezik added a comment. @aacid ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander, ngraham Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen

D21266: [WIP] Improve documentation of area classes

2019-05-20 Thread David Hurka
davidhurka added a comment. Should the section “Coordinate System” of NormalizedPoint mention the “Trimmed Margins” feature? To prevent that someone sloppily codes a feature, which draws something on the page and fails if Trim Margins is active. INLINE COMMENTS > aacid wrote in area.h:36 >

D21266: [WIP] Improve documentation of area classes

2019-05-20 Thread David Hurka
davidhurka updated this revision to Diff 58380. davidhurka added a comment. - NormalizedPoint: Revert some stuff and mention mouse click events REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21266?vs=58231=58380 BRANCH

D21281: [RFC] Write a bit Documentation for Part and PageView

2019-05-20 Thread David Hurka
davidhurka added a comment. In D21281#467283 , @aacid wrote: > In D21281#466844 , @davidhurka wrote: > > > Is there some more KParts literature? I could find KParts on api.kde.org and the tutorials

D21281: [RFC] Write a bit Documentation for Part and PageView

2019-05-20 Thread Albert Astals Cid
aacid added a comment. The part is created by the shell, see around line 85. The basic idea is that shells and parts don't each other (in this particular case the shell is "cheating" a bit), and just use the query system. For example, ark will say, can i get a part that knows how to