D21332: Okular Annotation: add line start/end style config only for Straight Line tool
knambiar updated this revision to Diff 58625. knambiar marked 2 inline comments as done. knambiar added a comment. Add `Q_ASSERT` for the configs. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21332?vs=58571=58625 REVISION DETAIL https://phabricator.kde.org/D21332 AFFECTED FILES ui/annotationwidgets.cpp ui/annotationwidgets.h To: knambiar, #okular Cc: tobiasdeiminger, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
[okular] [Bug 407828] [Feature Request]: Adjust print area to whole page
https://bugs.kde.org/show_bug.cgi?id=407828 Rafael Linux User changed: What|Removed |Added CC||rafael.linux.u...@gmail.com --- Comment #2 from Rafael Linux User --- Ups, sorry. OpenSUSE 15.1 is still compiling 1.3.3 version. Thank you -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted
https://bugs.kde.org/show_bug.cgi?id=402017 --- Comment #5 from David Hurka --- Just discovered a class FileKeeper, which should do this. Added in commit 6531398b919e58def8c6ba4711d20ea517147189, eleven years ago. Just grep for #ifdef OKULAR_KEEP_FILE_OPEN -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407884] Previous/Next Bookmark don’t work like their section title suggests if triggered from Contents side panel context menu
https://bugs.kde.org/show_bug.cgi?id=407884 David Hurka changed: What|Removed |Added Summary|Previous/Next Bookmark |Previous/Next Bookmark |don’t work correctly if |don’t work like their |triggered from Contents |section title suggests if |side panel context menu |triggered from Contents ||side panel context menu --- Comment #4 from David Hurka --- Ok, I renamed the bug. IMHO they shouldn’t be in a context menu if they don’t respect the context of the menu. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407884] Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu
https://bugs.kde.org/show_bug.cgi?id=407884 --- Comment #3 from Albert Astals Cid --- yes, they do what they were coded to do, so it is intended they do that. You get confused by the heading, fair enough, my guess is that orignally there was no heading. It's basically the same menu that you get on the main page area and thus behaves the same. -- You are receiving this mail because: You are the assignee for the bug.
D21248: Add line annotation ending arrows for non PDF documents
aacid added inline comments.
INLINE COMMENTS
> pagepainter.cpp:947
> +{
> +double fImageWidth = (double) image.width();
> +double fImageHeight = (double) image.height();
const here and for fImageHeight and penWidth
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21248
To: tobiasdeiminger, #okular, aacid
Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfella, darcyshen, aacid
[okular] [Bug 407884] Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu
https://bugs.kde.org/show_bug.cgi?id=407884 --- Comment #2 from David Hurka --- So it’s intended that they don’t do what the menu says, but do what the menu would say if invoked another way? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407884] Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu
https://bugs.kde.org/show_bug.cgi?id=407884 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert Astals Cid --- the fact that they don't do what you want doesn't mean they don't work correctly. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407869] Okular KParts plugin steals space key events from shell
https://bugs.kde.org/show_bug.cgi?id=407869
--- Comment #3 from Albert Astals Cid ---
or this would probably make sense in okular
diff --git a/part.cpp b/part.cpp
index c831f8793..229ff7fcb 100644
--- a/part.cpp
+++ b/part.cpp
@@ -576,7 +576,7 @@ m_cliPresentation(false), m_cliPrint(false),
m_cliPrintAndExit(false), m_embedMo
setupViewerActions();
-if ( m_embedMode != ViewerWidgetMode )
+if ( m_embedMode != ViewerWidgetMode && m_embedMode != UnknownEmbedMode )
{
setupActions();
}
if anyone feels like testing
--
You are receiving this mail because:
You are the assignee for the bug.
[okular] [Bug 180443] Provide icons for entries in the View menu
https://bugs.kde.org/show_bug.cgi?id=180443 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407869] Okular KParts plugin steals space key events from shell
https://bugs.kde.org/show_bug.cgi?id=407869 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #2 from Albert Astals Cid --- you can pass "ViewerWidget" as arg to the part to get the "less aggressive" viewer. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407731] can't open amazon invoices
https://bugs.kde.org/show_bug.cgi?id=407731 Albert Astals Cid changed: What|Removed |Added CC||alf...@gmail.com --- Comment #10 from Albert Astals Cid --- *** Bug 407903 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407903] Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Albert Astals Cid --- *** This bug has been marked as a duplicate of bug 407731 *** -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407903] Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 --- Comment #4 from Nate Graham --- Is this fixed in a newer version of Okular or Popper? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407903] Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #3 from Albert Astals Cid --- yes, people need to stop using old crap -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407903] Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #2 from Nate Graham --- Crashing in signature stuff: Thread 1 (Thread 0x7f4221396200 (LWP 7021)): [KCrash Handler] #6 SECMOD_ReferenceModule (module=0x0) at pk11util.c:847 #7 0x7f41f5493c8c in SECMOD_AddModule (newModule=0x562e3ed8bd60) at pk11util.c:541 #8 0x7f41f5493d30 in SECMOD_AddNewModuleEx (moduleName=0x7f41f599e08d "Root Certs", dllPath=0x7f41f599e07f "libnssckbi.so", defaultMechanismFlags=0, cipherEnableFlags=0, modparms=, nssparms=) at pk11util.c:695 #9 0x7f41f594c8fe in SignatureHandler::init_nss() () from /usr/lib/x86_64-linux-gnu/libpoppler.so.73 #10 0x7f41f594cc99 in SignatureHandler::SignatureHandler(unsigned char*, int) () from /usr/lib/x86_64-linux-gnu/libpoppler.so.73 #11 0x7f41f586ec25 in FormFieldSignature::validateSignature(bool, bool, long) () from /usr/lib/x86_64-linux-gnu/libpoppler.so.73 #12 0x7f41f5c5dd55 in Poppler::FormFieldSignature::validate(int, QDateTime const&) const () from /usr/lib/x86_64-linux-gnu/libpoppler-qt5.so.1 #13 0x7f41f5c5e19f in Poppler::FormFieldSignature::validate(Poppler::FormFieldSignature::ValidateOptions) const () from /usr/lib/x86_64-linux-gnu/libpoppler-qt5.so.1 #14 0x7f41f5eac240 in PopplerFormFieldSignature::PopplerFormFieldSignature (this=0x562e3ed2cdc0, field=0x562e3ed26920) at ./generators/poppler/formfields.cpp:387 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407883] Previous/Next Bookmark actions not enabled/disabled correctly / do not cycle though bookmarks
https://bugs.kde.org/show_bug.cgi?id=407883 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are the assignee for the bug.
D21363: Fix build with poppler < 0.51
aacid added a comment. One proposal i have is actually saying we don't support poppler 0.50 poppler-0.50.0 was released on Dec 15, 2016, we require Qt 5.8.0 released on January 26, 2017 and KF5 5.44.0 released on March 10, 2018 Any reason you want to support such an old poppler? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21363 To: volkov, #okular, sander Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
D21332: Okular Annotation: add line start/end style config only for Straight Line tool
tobiasdeiminger added inline comments. INLINE COMMENTS > knambiar wrote in annotationwidgets.cpp:499 > Is the `nullptr` check really necessary? No, I'd accept anyways. I just think the implication "object pointer != nullptr" => "object valid" is more obvious to new contributors than "some member == some magic number" => "object valid". How about adding a `Q_ASSERT`as we did it in `TextAnnotationWidget::applyChanges`? If you go for it, please also initialize members (as done for `TextAnnotationWidget`in `annotationwidgets.h`). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21332 To: knambiar, #okular Cc: tobiasdeiminger, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
[okular] [Bug 407903] Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 --- Comment #1 from Alfeno Rodrigues --- Created attachment 120287 --> https://bugs.kde.org/attachment.cgi?id=120287=edit backtraces segmation faulf of okular. backtraces segmation faulf of okular for debug this issue. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407903] New: Okular Crashes when try to open a specific pdf file
https://bugs.kde.org/show_bug.cgi?id=407903 Bug ID: 407903 Summary: Okular Crashes when try to open a specific pdf file Product: okular Version: 1.7.1 Platform: Neon Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: alf...@gmail.com Target Milestone: --- Created attachment 120286 --> https://bugs.kde.org/attachment.cgi?id=120286=edit pdf file that makes okular crashed SUMMARY Every time when I tried to open a specific pdf file (attached in this issue) okular crashed. But others pdf viewer, open this pdf files without issue, like: Foxit reader for linux. STEPS TO REPRODUCE 1. open pdf file attached in this issue. 2. After that okular crashed. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.15.5 KDE Frameworks Version: 5.58.0 Qt Version: 5.12.0 ADDITIONAL INFORMATION Obs: I attached debug file of Segmentation fault Processor 4x Intel i7-5500U CPU @2.4Ghz Memory 7,7 Gbi of RAM Linux kde 4.15.0-50-generic #54-Ubuntu SMP Mon May 6 18:46:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this mail because: You are the assignee for the bug.
