D15580: New annotation toolbar

2019-06-05 Thread Simone Gaiarin
simgunz added a comment. > Or: Why is this still PageViewToolBar? It is not anymore in the PageView? I'll move it, added to TODO REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: anthonyfieroni, davidhurka, knambiar, ngraham,

D15580: New annotation toolbar

2019-06-05 Thread Simone Gaiarin
simgunz added a comment. In D15580#474436 , @simgunz wrote: > > Or: Why is this still PageViewToolBar? It is not anymore in the PageView? > > I'll move it, added to TODO Actually the code of the other toolbar (Browse, Zoom, Selection)

D15580: New annotation toolbar

2019-06-05 Thread David Hurka
davidhurka added a comment. In D15580#474457 , @simgunz wrote: > In D15580#474436 , @simgunz wrote: > > > > Or: Why is this still PageViewToolBar? It is not anymore in the PageView? > > > >

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408270 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #7 from Nate Graham

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

2019-06-05 Thread Matthew Trescott
https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #3 from Matthew Trescott --- Okay, but I think sacrificing accuracy for the sake of a few people with unusual documents is not really reasonable. Someone who needs full-bleed printing will probably be going to a professional print shop

[okular] [Bug 252596] okular printing options not working when printing to file (pdf/ps)

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=252596 Nate Graham changed: What|Removed |Added CC||matthewtresc...@gmail.com --- Comment #24 from

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408271 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408271 --- Comment #4 from Nate Graham --- My reasoning was that it's a duplicate in that fixing Bug 252596 will automatically fix this too. >From your other bug I see you're having a hard time making it print in sizes that are not A4 in general, so I

D15580: New annotation toolbar

2019-06-05 Thread Simone Gaiarin
simgunz updated this revision to Diff 59208. simgunz added a comment. - Use draw-polyline icon for Polygon - Increase version of part.rc - Change icon of strikethrough (remove symbolic suffix) - Add TODO in code - Rename PageViewToolBar to AnnotationActionHandler - No need to

D15580: New annotation toolbar

2019-06-05 Thread Simone Gaiarin
simgunz added a comment. I renamed PageViewToolBar and moved to a file by itself. I took inspiration from Dolphin for the name. There is still code to be cleaned though. INLINE COMMENTS > pageview.cpp:665 > > -d->aToggleAnnotator = new KToggleAction(QIcon::fromTheme( >

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #4 from Nate Graham --- Again I think it's important to avoid destructiveness in the default options. Rather than arguing over what a better default would be, perhaps we should explore alternatives that would bypass the issue entirely: -

[okular] [Bug 408355] New: Selection context menu missing find in this document

2019-06-05 Thread Edward Kigwana
https://bugs.kde.org/show_bug.cgi?id=408355 Bug ID: 408355 Summary: Selection context menu missing find in this document Product: okular Version: unspecified Platform: Gentoo Packages OS: Linux Status: REPORTED

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

2019-06-05 Thread Matthew Trescott
https://bugs.kde.org/show_bug.cgi?id=408271 --- Comment #3 from Matthew Trescott --- I don't think this is a duplicate. IIRC you can set it to Letter and it works. This is about changing the default. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

2019-06-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408272 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #2 from Nate Graham

[okular] [Bug 408355] Selection context menu missing find in this document

2019-06-05 Thread Edward Kigwana
https://bugs.kde.org/show_bug.cgi?id=408355 --- Comment #1 from Edward Kigwana --- SUMMARY: When using okular to view pdf schematics, it is handy to make a selection and then search within the document. I find it odd that it is possible to use the context selection to search google, youtube,