[okular] [Bug 421469] [Regression] Slow search in the contents pane

2020-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421469

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/793f1692
   ||db244621a0a603a2a7c404cc175
   ||7b9ab
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Albert Astals Cid  ---
Git commit 793f1692db244621a0a603a2a7c404cc1757b9ab by Albert Astals Cid, on
behalf of Ahmad Samir.
Committed on 23/05/2020 at 10:11.
Pushed by aacid into branch 'release/20.04'.

Fix filtering items in the contents treeview

When filtering the items in the contents panel, we start iterating over
them using rootIndex() to get all the children, don't do the same loop
for each and every item, one go is enough.

Also only use a regular expression if the regularExpression option is
enabled, otherwise just use string operations, the latter is always
faster. With this change, both regex and non-regex search are faster.

M  +13   -12   ui/ktreeviewsearchline.cpp

https://invent.kde.org/graphics/okular/commit/793f1692db244621a0a603a2a7c404cc1757b9ab

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421823] Okular downloads PDF file from samba share to local file system on opening

2020-05-23 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=421823

--- Comment #7 from Patrick Silva  ---
Initially I thought that Evince doesn't download the file to local file system
because it opens the file faster than Okular and plasma shows no notification.
I'm wrong. Evince downloads the file as I scroll throught its pages.
Apparently it's not possible to open all pages of a document without
downloading the file before like we can listen to an audio or watch a video
entirely without downloading them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421950] New: Page Up/Down overlap does not work on pdf file

2020-05-23 Thread Oscar Megia Lopez
https://bugs.kde.org/show_bug.cgi?id=421950

Bug ID: 421950
   Summary: Page Up/Down overlap does not work on pdf file
   Product: okular
   Version: 1.10.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: megia.os...@gmail.com
  Target Milestone: ---

SUMMARY

Setup Page Up/Down overlap to 50% or 0% does not make any difference.
If a line is cutted after press Page Up/Down is cutted in the other half in
both settings.

STEPS TO REPRODUCE
1. Setup Page Up/Down overlap to 50%
2. A line is cutted at end of page.
3. Press Page Down.
4. The line is cutted by other half.

The same issue if setup Page Up/Down overlap to 0%

Evince does not cut text lines and have a line overlap that make easier reading
pdf files.

OBSERVED RESULT

The page's last line is unreadable in both pages.

EXPECTED RESULT

The page's last line must be readable in both pages.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Archlinux kernel 5.6.13-arch1-1
(available in About System)
KDE Frameworks 5.70.0
Qt version: 5.14.2 (compiled with 5.14.2)
Windows system xcb
KDE Plasma Version: 5.18.5

ADDITIONAL INFORMATION
Same issue in OpenBox.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421823] Okular downloads PDF file from samba share to local file system on opening

2020-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421823

--- Comment #6 from Albert Astals Cid  ---
>  the notification that it is finished is useless

Is it? if it's a very long file i may have switched away to firefox to continue
looking at cat pictures and i want to be told when the "download" finishes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421984] Add adress bar, w current page ie [path/to/doc/doc.pdf#page=43], use as a link

2020-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=421984

9juh...@informatik.uni-hamburg.de changed:

   What|Removed |Added

 CC||9juh...@informatik.uni-hamb
   ||urg.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421987] New: I can't open any file in snap ubuntu package

2020-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=421987

Bug ID: 421987
   Summary: I can't open any file in snap ubuntu package
   Product: okular
   Version: 1.10.1
  Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: d.s.karpin...@hotmail.com
  Target Milestone: ---

SUMMARY


STEPS TO REPRODUCE
1. File→Open
2. It does nothing

OBSERVED RESULT
Nothing doesn't make. Any dialog window with files. 

EXPECTED RESULT
This open the dialog window for choice file to be open.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: elementary os  with LXDE and Xanmod Kernel 5.6.12
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
5.68.0
Qt Version: 
5.14.1

ADDITIONAL INFORMATION Okular snap Ubuntu package.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421823] Okular downloads PDF file from samba share to local file system on opening

2020-05-23 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=421823

--- Comment #8 from David Hurka  ---
(In reply to Albert Astals Cid from comment #6)
> >  the notification that it is finished is useless
> 
> Is it? if it's a very long file i may have switched away to firefox to
> continue looking at cat pictures and i want to be told when the "download"
> finishes

Good point, I think the current behavior is the intended behavior then. It is
probably more problematic than good to intelligently decide whether to show the
notification or not.

Then the remaining part of this bug is whether Okular could show the first
pages of a document while the last pages are still downloading. If Evince can
do that, Poppler apparently can do that, and I don’t see a reason why the
Generator interface of Okular couldn’t handle that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421950] Page Up/Down overlap does not work on pdf file

2020-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421950

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||aa...@kde.org,
   ||keziolio...@gmail.com,
   ||oliver.san...@tu-dresden.de

--- Comment #1 from Albert Astals Cid  ---
Another thing that regressed because of the QScroller patches :(

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421984] New: Add adress bar, w current page ie [path/to/doc/doc.pdf#page=43], use as a link

2020-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=421984

Bug ID: 421984
   Summary: Add adress bar, w current page ie
[path/to/doc/doc.pdf#page=43], use as a link
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: 9juh...@informatik.uni-hamburg.de
  Target Milestone: ---

Currently a document is being opened like the homepage (index.html) of a
website.

I would like an address bar like in a browser, with document path and *current*
page number.
There I could copy or enter a "link". Even like a browser.

In my thinking, a page of a document is like a subpage of a website. But the
browsers (ie okular) has no adress bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421823] Okular downloads PDF file from samba share to local file system on opening

2020-05-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=421823

--- Comment #5 from Christoph Feck  ---
The progress bar is fine, the notification that it is finished is useless,
because when it is finished, it will show the document anyway.

This is different from a regular download, where nothing happens when it is
finished (unless there was a "download finished" notification).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421984] Add adress bar, w current page ie [path/to/doc/doc.pdf#page=43], use as a link

2020-05-23 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=421984

David Hurka  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from David Hurka  ---
Okular is not a browser.

But you get an address bar (even with autocompletion) at Ctrl+O. AFAIK you can
even type the page number there, just without page=. You can input the path in
different formats, the KIO library is your browser there.

You can also configure Okular to show the document path in the window title
bar, and the page number is shown in the “page bar”, or optionally in the main
toolbar.

So what is the reason to add another bar for this purpose?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421987] I can't open any file in snap ubuntu package

2020-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421987

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org,
   ||j...@jriddell.org,
   ||sit...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421984] Add adress bar, w current page ie [path/to/doc/doc.pdf#page=43], use as a link

2020-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=421984

--- Comment #2 from 9juh...@informatik.uni-hamburg.de ---
The same reasons speak for an address bar as for an address bar in a browser.
There is no another address bar. An address bar is a dialog box, you can add or
remove something. In my opinion, the possibilities listed are monolog fields,
either-or-fields, and widely dispersed.

I work with long documents. It says in the text: see page 443. When I do that,
I can hardly find my original page afterwards, I want to continue where I was
originally. I would like to be able to click "Open in new window" without
leaving my current position. That's only an example. There are many cases for a
sensible, good use of an address bar. In modern browsers, it is also used to
enter a search phrase. This also lends itself to a document viewer.

However, it only becomes useful with URLs that contain the page or anchor and
are displayed dynamically, depending on the current position of my document in
the visible area. Then I can copy to paste in another instance (open in new
window), or save or share. Or do many other wonderful, simple and useful things
with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Should we revert the QScroller patch?

2020-05-23 Thread Oliver Sander
On 22.05.20 12:11, David Hurka wrote:
> As a user who doesn’t like smooth scrolling, I would like this to be 
> rejected. But touchscreen users would like the regressions to be fixed. So I 
> think we shouldn’t remove smooth scrolling, because many users would be 
> annoyed if it is added just to be removed in the next release.

I can see the case against smooth scrolling.  Maybe we should make this 
configurable?

Best,
Oliver



smime.p7s
Description: S/MIME Cryptographic Signature


[okular] [Bug 421823] Okular downloads PDF file from samba share to local file system on opening

2020-05-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421823

--- Comment #9 from Albert Astals Cid  ---
(In reply to David Hurka from comment #8)
> I don’t see a reason why
> the Generator interface of Okular couldn’t handle that.

The generators always get passed local files, this means they always need to be
complete. If you want to support streaming files, we're going to need to give
them a QIODevice, etc. Not totally trivial. Anyhow i'd say we should close this
bug and if you want to open one to support Linearized PDF files, there's
probably one around somewhere already :D

Also evince is probably just using gvfs which does a local mount of remote
files so in a sense it's much easier for them, kio is cool but doesn't really
help in this case in which we need to seek back and forth in the file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421482] Okular view overscrolls

2020-05-23 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=421482

Oliver Sander  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/ca1d6237
   ||2909f6310f437985cc7aab301c1
   ||b7165

--- Comment #1 from Oliver Sander  ---
Git commit ca1d62372909f6310f437985cc7aab301c1b7165 by Oliver Sander, on behalf
of Kezi Olio.
Committed on 23/05/2020 at 13:54.
Pushed by aacid into branch 'release/20.04'.

Disable scrolling overshoot

It was introduced in 51b90ecd73e37b9646d8a4bbb51e4fa815942912 together
with kinetic scrolling, but people do not like it.

M  +2-2ui/pageview.cpp

https://invent.kde.org/graphics/okular/commit/ca1d62372909f6310f437985cc7aab301c1b7165

-- 
You are receiving this mail because:
You are the assignee for the bug.