Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/ --- (Updated Aug. 5, 2011, 7:52 a.m.) Review request for Okular. Summary (updated) --- While on the plane Albert and I, we decided to fix okular stuff. This was something to do, hope that helps. Deletes a resource that is never freed. Diffs - generators/fictionbook/document.cpp e943566 Diff: http://git.reviewboard.kde.org/r/102220/diff Testing --- None, didn't have any fictionbook to try. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: Change mouse cursor when changing the current tool.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/ --- Review request for Okular. Summary --- Update the cursors when changing the current mode. Addresses the problems in the bug report. - Use a opened/closed hand for browsing. - Use cross for selection. This addresses bug 271816. http://bugs.kde.org/show_bug.cgi?id=271816 Diffs - ui/pageview.cpp f103b2f Diff: http://git.reviewboard.kde.org/r/102221/diff Testing --- Play around with okular and see if it works as expected, which does apparently. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 196590] [PDF 4.3beta2 regression] bad margins, printing cuts off parts of the document
https://bugs.kde.org/show_bug.cgi?id=196590 --- Comment #20 from André Fettouhi A Fettouhi gmail com 2011-08-05 14:42:23 --- Has anyone ever been able to fix this. I'm still having this problem with cut margins when printing with kde4 apps. Gone/gtk etc. apps print fine no matter what type of file it is. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 181290] Landscape pdf prints with wrong orientation when choosing landscape in print dialog
https://bugs.kde.org/show_bug.cgi?id=181290 --- Comment #123 from Kevin Kofler kevin kofler chello at 2011-08-05 20:45:27 --- I'd like this backported also, but I don't want to do this if the Okular maintainers don't want it done, it's not my program. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Okular Suggestion
Hi Klaus, please use bugs.kde.org for bug/wish reporting. It is easier to keep track of them using that software than using e-mail. Albert --- El jue, 4/8/11, Dr. Klaus Schröer k.schr...@t-online.de escribió: De: Dr. Klaus Schröer k.schr...@t-online.de Asunto: [Okular-devel] Okular Suggestion Para: okular-devel@kde.org Fecha: jueves, 4 de agosto, 2011 03:41 Ladies Gentlemen! I'm using Okular frequently. However, I've not yet found a solution for adaptation of document to paper size, e.g. I frequently receive pdf-documents in A4 which I have to print on US-letter format. Best regards, Klaus Schroer -- *** Dr. Klaus Schröer Privat - Deutschland: Am Havelufer 15 Fon: +49-(0)30 36 28 22 36 14089 Berlin e-mail: k.schr...@t-online.de Fax: +49-(0)322 237 626 35 Privat - USA: 8242 Double Eagle Court Fon: +1-423-598-3173 Ooltewah, TN 37363-7175 ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Change mouse cursor when changing the current tool.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/#review5418 --- Ship it! Push it with this changes to master. Thanks. ui/pageview.cpp http://git.reviewboard.kde.org/r/102221/#comment4885 Probably remove this todo ui/pageview.cpp http://git.reviewboard.kde.org/r/102221/#comment4886 Spacing in the if - Albert On Aug. 5, 2011, 7:59 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/ --- (Updated Aug. 5, 2011, 7:59 a.m.) Review request for Okular. Summary --- Update the cursors when changing the current mode. Addresses the problems in the bug report. - Use a opened/closed hand for browsing. - Use cross for selection. This addresses bug 271816. http://bugs.kde.org/show_bug.cgi?id=271816 Diffs - ui/pageview.cpp f103b2f Diff: http://git.reviewboard.kde.org/r/102221/diff Testing --- Play around with okular and see if it works as expected, which does apparently. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 271816] I want the cursor to change in browsing/selection mode
https://bugs.kde.org/show_bug.cgi?id=271816 Aleix Pol aleix...@kde.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Aleix Pol aleixpol kde org 2011-08-05 21:49:18 --- Git commit 390bf78eccf29e41a4c7915e256920ff2bf58b07 by Aleix Pol. Committed on 05/08/2011 at 23:47. Pushed by apol into branch 'master'. Change mouse cursor when changing the current tool Update the cursors when changing the current mode. Addresses the problems in the bug report. - Use a opened/closed hand for browsing. - Use cross for selection. BUG: 271816 REVIEW: 102221 M +7-1ui/pageview.cpp http://commits.kde.org/okular/390bf78eccf29e41a4c7915e256920ff2bf58b07 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Change mouse cursor when changing the current tool.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/#review5419 --- This review has been submitted with commit 390bf78eccf29e41a4c7915e256920ff2bf58b07 by Aleix Pol to branch master. - Commit On Aug. 5, 2011, 7:59 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/ --- (Updated Aug. 5, 2011, 7:59 a.m.) Review request for Okular. Summary --- Update the cursors when changing the current mode. Addresses the problems in the bug report. - Use a opened/closed hand for browsing. - Use cross for selection. This addresses bug 271816. http://bugs.kde.org/show_bug.cgi?id=271816 Diffs - ui/pageview.cpp f103b2f Diff: http://git.reviewboard.kde.org/r/102221/diff Testing --- Play around with okular and see if it works as expected, which does apparently. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/#review5420 --- I wonder if we can ever end up in this code, because - Albert On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/ --- (Updated Aug. 5, 2011, 7:52 a.m.) Review request for Okular. Summary --- While on the plane Albert and I, we decided to fix okular stuff. This was something to do, hope that helps. Deletes a resource that is never freed. Diffs - generators/fictionbook/document.cpp e943566 Diff: http://git.reviewboard.kde.org/r/102220/diff Testing --- None, didn't have any fictionbook to try. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do
On Aug. 5, 2011, 10:07 p.m., Albert Astals Cid wrote: I wonder if we can ever end up in this code, because Wops, here comes the full comment D I wonder if we can ever end up in this code, because the else is for zip files containing a fb2 file but the .desktop file of the plugin says it supports application/x-fictionbook+xml so i can not see a way that the code flow ends up in that else branch of the if, so we can either just push your code because it is techinically correct or remove all the if altogether :D - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/#review5420 --- On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/ --- (Updated Aug. 5, 2011, 7:52 a.m.) Review request for Okular. Summary --- While on the plane Albert and I, we decided to fix okular stuff. This was something to do, hope that helps. Deletes a resource that is never freed. Diffs - generators/fictionbook/document.cpp e943566 Diff: http://git.reviewboard.kde.org/r/102220/diff Testing --- None, didn't have any fictionbook to try. Thanks, Aleix ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
