[Okular-devel] [Bug 309902] New: Use KMessageWidget for informations rather than custom implementation

2012-11-11 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=309902

Bug ID: 309902
  Severity: wishlist
   Version: 0.15.3
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Use KMessageWidget for informations rather than custom
implementation
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

Now that we have that beautiful standard KMessageWidget Okular should use this
one rather than its custom implementation. This gives us a unified look and
feel, and also they transition in beautifully :)

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 309491] zooming in cuts off left side

2012-11-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=309491

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #3 from Albert Astals Cid aa...@kde.org ---


*** This bug has been marked as a duplicate of bug 305194 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 305194] When there is only one page, Opposite pages should have no effect

2012-11-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=305194

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||kde-b...@ginguppin.de

--- Comment #7 from Albert Astals Cid aa...@kde.org ---
*** Bug 309491 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 309729] Barcode from attached PDF is not printed corectly

2012-11-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=309729

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #4 from Albert Astals Cid aa...@kde.org ---
For printing pdf files (in this case convert it to ps and then i guess you used
something else to convert to pdf) we use the poppler library. Thus the bug in
the printing is something we can not fix in okular. Please go to the poppler
bug tracker and report the bug in there https://bugs.freedesktop.org

Thanks for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows

2012-11-11 Thread Bogdan Cristea


 On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote:
  I am sincerely not sure observer.h is ready for prime time installation, i 
  mean, it has a global list of ids/priorities hardcoded in it, maybe we 
  should rework the ids so that you can register yourself and get your id 
  back? About the priorities i guess we could rename them to be less 
  okularpart specific? What do you think?

Before I start to code, I would like to discuss the best approach. Hard coded 
IDs should be removed, so I propose to use instead Observers defined as 
singletons. When the observer is created an unique ID is generated (since all 
observers have a common base, one could use a static data member defined in the 
base class in order to generate unique IDs).


 On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote:
  conf/settings.kcfgc, line 7
  http://git.reviewboard.kde.org/r/107047/diff/2/?file=92392#file92392line7
 
  SettingsCore is part of libokularcore, so using OKULAR_EXPORT is fine, 
  no?

settings_core.h exposes methods found in okularcore library, while settings.h 
exposes methods found in okularpart library. In Windows, when the second 
library is build, settings_core.h should import its symbols, while settings.h 
should export them. For Linux there is no problem since all library symbols are 
exported by default.


- Bogdan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107047/#review21327
---


On Oct. 26, 2012, 7:57 a.m., Bogdan Cristea wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/107047/
 ---
 
 (Updated Oct. 26, 2012, 7:57 a.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 This patch is related to settings separation for the frontend and the 
 backend. It proposes the installation of core/observer.h and corrects 
 compilation of okular on Windows (using KDE on windows):
 - after separation, settings.h and settings_core.h need to use different 
 precompiler switches for exporting/importing symbols
 - add definitions needed to activate these switches on Windows
 
 
 Diffs
 -
 
   CMakeLists.txt 063778f 
   active/components/CMakeLists.txt 19b759e 
   conf/settings.kcfgc 5e2ec95 
   okular_part_export.h PRE-CREATION 
 
 Diff: http://git.reviewboard.kde.org/r/107047/diff/
 
 
 Testing
 ---
 
 yes
 
 
 Thanks,
 
 Bogdan Cristea
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request: Implement the handling of page rotations for source references

2012-11-11 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/#review21850
---


Michel, I want to apoligize, I've been ultra busy with lots of other stuff and 
could not make the review in time for this to be included in the 4.10 release. 
It is totally my fault, I will try to get it in 4.11. I hope this is not 
blocking the kile release that has live preview, right?

- Albert Astals Cid


On Sept. 26, 2012, 8:16 p.m., Michel Ludwig wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103060/
 ---
 
 (Updated Sept. 26, 2012, 8:16 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Implement the handling of page rotations for source references.
 
 
 Diffs
 -
 
   core/document.h d47acec 
   core/document.cpp 7f006e6 
   core/page.h a8f2761 
   core/page.cpp d746382 
   core/utils.h 8d5d5fc 
   core/utils.cpp 5dd8448 
   generators/dvi/generator_dvi.cpp 5cd327f 
   generators/poppler/generator_pdf.cpp fcc8dc4 
   part.cpp 2ef39d8 
   ui/pagepainter.cpp 537e5c5 
   ui/pageview.h 9f56620 
   ui/pageview.cpp 496abdc 
   ui/side_reviews.cpp a35f9ed 
   ui/thumbnaillist.cpp 60288cb 
 
 Diff: http://git.reviewboard.kde.org/r/103060/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Michel Ludwig
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel