[Okular-devel] [okular] [Bug 319625] Bookmarks annotations lost for renamed documents
https://bugs.kde.org/show_bug.cgi?id=319625 --- Comment #20 from Albert Astals Cid aa...@kde.org --- Yep, doing the move for a bookmarked file should be easy, for a only annotated one you need a special thing in the settings dialog. Fabio if you feel like specifying the two bugs in separate (actually i think there's something around for the metadata management one) it'd be cool so we can close this one (that asks for two separate things) and have two which asks just for one. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 309902] Use KMessageWidget for informations rather than custom implementation
https://bugs.kde.org/show_bug.cgi?id=309902 --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Kate now also uses a free-floating KMessageWidget derivate. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] [PATCHES] Customizable annotation tools
El Diumenge, 19 de maig de 2013, a les 01:03:49, Fabio D'Urso va escriure: Hi, As I said in IRC, I'd like to include customizable annotation tools in KDE 4.11, so I'm resurrecting this old thread. Since the original post, I've created a configurable-review-tools branch and pushed almost(*) all patches there. They have slightly been modified since the OP, but the overall structure is the same: - Tools can be configured from the configuration panel - Tools are still described through XML data - Configuration is saved in XML format in okularpartrc via kcfg I've merged master again, therefore it's possible to see a big dump of all changes with: git diff origin/master origin/configurable-review-tools A (imho) better way to see changes is: gitk origin/configurable-review-tools ^origin/master --no-merges which gives some sort of changelog. In the first patches, you can safely skip analysis of code that directly creates XML strings, as it is replaced by safer QDom methods in 3dcaa585587984a0d34daa41915dfe4d4d995d75. If you prefer a single big review request instead, please let me know. I'd appreciate if you reviewboard it, it's easier to leave comments in there. Anyhow a first batch of comments, you have a few slotXYZ (bool ) where then you don't use the bool, just remove it if you don't need it You have slotRowChanged that just calls updateButtons, why not change the connection to call updateButtons directly? I think i miss an Edit button in the settings dialog, double clicking is ok but not really discoverable unless you know you can do it. Overall it looks good :-) Cheers, Albert * = What's still missing is support for a new polyline tool, which I had initially posted, but I've noticed it needs some corrections (my first implementation ended the line on double-click, but kolourpaint uses right- click, and I'd like to mirror it for consistency). Thanks, Fabio On Wednesday, August 08, 2012 12:19:03 AM Albert Astals Cid wrote: El Dimecres, 1 d'agost de 2012, a les 03:04:31, Fabio D'Urso va escriure: On Wednesday, August 01, 2012 12:32:06 AM Albert Astals Cid wrote: Can we see screenshots of the other GUI changes you made for lazy people? Annotation widget changes (in all images old is on the left): - Do not show the font selection field in pop-up annotations (cmp-popup) I guess it was a forgotten if, because the same widget is used for inplace text annotations, where configuring the font makes sense. - Configurable line width in InkAnnotations (cmp-ink) - Configurable inner color in polygons (cmp-polygon) Note that even tough straight lines and polylines use the same widget, the inner color field is not shown in those annotations. In other words, their properties dialog were not changed. - Text alignment in inplace text annotations (cmp-inplace) This one can be done better (eg with icons) in future patches. I had had a quick look at koffice source and I remember that there were different cases for LTR and RTL languages, that's why I went the easy path. The Identity configuration page is replaced by an Annotations page, which contains the configurable tool list. You can see it in config-panel-new. Note that the privacy notice now appears as tooltip for text box. In config-panel-new, you can also see the dialog to create and edit tools. As I said in the previous post, it uses the same widgets used by the annotation properties dialog. The caption is Edit annotation tool if the user is editing an existing tool (like in the picture), or Create annotation tool if the user is creating a new tool. If the user hasn't set a customized name, the Name text box shows the default tool name in gray (placeholder text). The combo lets you choose the tool type. Changing its value also changes the type of properties that can be configured. Available choices are: Pop-up Note, Inline Note, Freehand Line, Straight Line, Polygon, Polyline, Text markup, Geometrical shape, Stamp. In this dialog, I used the term Freehand Line instead of Ink, and Straight Line, Polygon and Polyline instead of the generic Line which is used in the annotation properties dialog, because they sound clearer to me. If you agree, I'd make another patch to make the annotation properties dialog show these names too. It might be good adding some contents to PageViewAnnotator::defaultToolName since e.g. Underline can be read as a verb or as a noun. Yes, I see the issue. Currently we have Highlighter, but also Polygon, Stamp, Underlining and Ellipse, that are all nouns. I'll review that part. What happens when there are lots of items in the toolbar, do you get a double line of icons? Yes. I didn't change it and the existing code can do that (toolbar-wrap).
[Okular-devel] [okular] [Bug 319554] Select all wont works if the select text tool is enabled
https://bugs.kde.org/show_bug.cgi?id=319554 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||4.10.4 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/4e05cc2526aaa86ae9c0fb3c ||d276945b88164cda --- Comment #2 from Albert Astals Cid aa...@kde.org --- Git commit 4e05cc2526aaa86ae9c0fb3cd276945b88164cda by Albert Astals Cid. Committed on 20/05/2013 at 18:15. Pushed by aacid into branch 'KDE/4.10'. Fix wrong check Parker messed up the logic that force it to be in text selection mode to be on non text selecion mode when doing an unrelated change. As the bug as showed we can selectAll in non text selection mode as well so remove the check altogether Related: bug 159276 FIXED-IN: 4.10.4 M +0-3ui/pageview.cpp http://commits.kde.org/okular/4e05cc2526aaa86ae9c0fb3cd276945b88164cda -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 159276] Give warning on Select All in non-text select mode
https://bugs.kde.org/show_bug.cgi?id=159276 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In||4.10.4 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/4e05cc2526aaa86ae9c0fb3c ||d276945b88164cda --- Comment #4 from Albert Astals Cid aa...@kde.org --- Git commit 4e05cc2526aaa86ae9c0fb3cd276945b88164cda by Albert Astals Cid. Committed on 20/05/2013 at 18:15. Pushed by aacid into branch 'KDE/4.10'. Fix wrong check Parker messed up the logic that force it to be in text selection mode to be on non text selecion mode when doing an unrelated change. As the bug as showed we can selectAll in non text selection mode as well so remove the check altogether Related: bug 319554 FIXED-IN: 4.10.4 M +0-3ui/pageview.cpp http://commits.kde.org/okular/4e05cc2526aaa86ae9c0fb3cd276945b88164cda -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316802] okular crashes when adding a stamp
https://bugs.kde.org/show_bug.cgi?id=316802 --- Comment #9 from Albert Astals Cid aa...@kde.org --- Still works here :-/ Can you tell me, in the sidebar, which of the three buttons of the lower part of the annotations tab you have checked? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317551] PDF pages rendered blank at 100% Zoom
https://bugs.kde.org/show_bug.cgi?id=317551 --- Comment #11 from Albert Astals Cid aa...@kde.org --- Do this blank pages still have the okular logo on the top left of the page? Or they are completely blank? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317891] Okular takes 1 min to open some pdf files
https://bugs.kde.org/show_bug.cgi?id=317891 --- Comment #5 from Albert Astals Cid aa...@kde.org --- Just that i don't forget for the future. Seems like something inside poppler-qt4 is resolving lots of named destinations, which doesn't make much sense, named destinations should be resolved on use time. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 110566: Configurable review tools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110566/ --- Review request for Okular. Description --- Diff dump from the configurable-review-tools branch, as requested in http://mail.kde.org/pipermail/okular-devel/2013-May/015009.html This patch mainly addresses bug 159601, but it also adds GUI control to configure some annotation properties (text alignment in inline notes, stroke width in freehand lines, background color in polygons) and changes some texts. Use gitk origin/configurable-review-tools ^origin/master --no-merges for a detailed changelog. This addresses bug 159601. http://bugs.kde.org/show_bug.cgi?id=159601 Diffs - CMakeLists.txt 64c4c2a Messages.sh 6d0d0b0 conf/dlgannotations.h PRE-CREATION conf/dlgannotations.cpp PRE-CREATION conf/dlgannotationsbase.ui PRE-CREATION conf/dlgidentity.h 1bbd937 conf/dlgidentity.cpp 8585716 conf/dlgidentitybase.ui 15752eb conf/okular.kcfg 4a2aaf3 conf/preferencesdialog.h 3340487 conf/preferencesdialog.cpp 9f6d339 conf/settings.kcfgc 060f260 conf/widgetannottools.h PRE-CREATION conf/widgetannottools.cpp PRE-CREATION ui/annotationpropertiesdialog.h d1a1c27 ui/annotationpropertiesdialog.cpp 5d86d79 ui/annotationwidgets.h 1832876 ui/annotationwidgets.cpp ce8a91b ui/data/CMakeLists.txt 6501be5 ui/data/sources/tool-base-okular.svgz PRE-CREATION ui/data/sources/tool-highlighter-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-ink-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-note-inline-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-note-okular-colorizable.svgz PRE-CREATION ui/data/tool-base-okular.png PRE-CREATION ui/data/tool-ellipse-okular.png 6a3260e ui/data/tool-highlighter-okular-colorizable.png PRE-CREATION ui/data/tool-highlighter-okular.png 594ba41 ui/data/tool-ink-okular-colorizable.png PRE-CREATION ui/data/tool-ink-okular.png 8a2eeb0 ui/data/tool-line-okular.png a2dda94 ui/data/tool-note-inline-okular-colorizable.png PRE-CREATION ui/data/tool-note-inline-okular.png 4d8187f ui/data/tool-note-okular-colorizable.png PRE-CREATION ui/data/tool-note-okular.png a89c91b ui/data/tool-polygon-okular.png 66ba2cb ui/data/tool-stamp-okular.png e53a04a ui/data/tool-underline-okular.png 924772f ui/data/tools.xml 5e3cb84 ui/guiutils.h 73c0838 ui/guiutils.cpp af06000 ui/pagepainter.h 23ac845 ui/pagepainter.cpp 2890b56 ui/pageview.cpp 26f5516 ui/pageviewannotator.h 850d887 ui/pageviewannotator.cpp 035c1f3 ui/pageviewutils.h 0aaf057 ui/pageviewutils.cpp c2e0388 Diff: http://git.reviewboard.kde.org/r/110566/diff/ Testing --- Thanks, Fabio D'Urso ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 110566: Configurable review tools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110566/#review32856 --- Looks good overall, it's good taht it doesn't touch core/ at all so if we need to change something taht was horribly wrong and we didn't realize we can still do it in a minor revision. OTOH I'm kind of thinking that some of this code might make more sense in core/ (like the code that creates the definitions of the tools, etc) but we are always on time to move it down later if we need. Some minor stuff coming as comments conf/okular.kcfg http://git.reviewboard.kde.org/r/110566/#comment24382 Maybe add a kWarning here if annotationTools content is empty? The old code seemed to have them, no? conf/preferencesdialog.cpp http://git.reviewboard.kde.org/r/110566/#comment24383 Instead of draw-freehand maybe use the same icon we use in the side panel? conf/widgetannottools.cpp http://git.reviewboard.kde.org/r/110566/#comment24386 Would it make sense to try to reuse the defaultToolName function? conf/widgetannottools.cpp http://git.reviewboard.kde.org/r/110566/#comment24384 maybe i18nc here so it is clear that this is a noun and not a verb? ui/pageviewannotator.cpp http://git.reviewboard.kde.org/r/110566/#comment24385 Maybe some i18nc here too? - Albert Astals Cid On May 20, 2013, 7 p.m., Fabio D'Urso wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110566/ --- (Updated May 20, 2013, 7 p.m.) Review request for Okular. Description --- Diff dump from the configurable-review-tools branch, as requested in http://mail.kde.org/pipermail/okular-devel/2013-May/015009.html This patch mainly addresses bug 159601, but it also adds GUI control to configure some annotation properties (text alignment in inline notes, stroke width in freehand lines, background color in polygons) and changes some texts. Use gitk origin/configurable-review-tools ^origin/master --no-merges for a detailed changelog. This addresses bug 159601. http://bugs.kde.org/show_bug.cgi?id=159601 Diffs - CMakeLists.txt 64c4c2a Messages.sh 6d0d0b0 conf/dlgannotations.h PRE-CREATION conf/dlgannotations.cpp PRE-CREATION conf/dlgannotationsbase.ui PRE-CREATION conf/dlgidentity.h 1bbd937 conf/dlgidentity.cpp 8585716 conf/dlgidentitybase.ui 15752eb conf/okular.kcfg 4a2aaf3 conf/preferencesdialog.h 3340487 conf/preferencesdialog.cpp 9f6d339 conf/settings.kcfgc 060f260 conf/widgetannottools.h PRE-CREATION conf/widgetannottools.cpp PRE-CREATION ui/annotationpropertiesdialog.h d1a1c27 ui/annotationpropertiesdialog.cpp 5d86d79 ui/annotationwidgets.h 1832876 ui/annotationwidgets.cpp ce8a91b ui/data/CMakeLists.txt 6501be5 ui/data/sources/tool-base-okular.svgz PRE-CREATION ui/data/sources/tool-highlighter-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-ink-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-note-inline-okular-colorizable.svgz PRE-CREATION ui/data/sources/tool-note-okular-colorizable.svgz PRE-CREATION ui/data/tool-base-okular.png PRE-CREATION ui/data/tool-ellipse-okular.png 6a3260e ui/data/tool-highlighter-okular-colorizable.png PRE-CREATION ui/data/tool-highlighter-okular.png 594ba41 ui/data/tool-ink-okular-colorizable.png PRE-CREATION ui/data/tool-ink-okular.png 8a2eeb0 ui/data/tool-line-okular.png a2dda94 ui/data/tool-note-inline-okular-colorizable.png PRE-CREATION ui/data/tool-note-inline-okular.png 4d8187f ui/data/tool-note-okular-colorizable.png PRE-CREATION ui/data/tool-note-okular.png a89c91b ui/data/tool-polygon-okular.png 66ba2cb ui/data/tool-stamp-okular.png e53a04a ui/data/tool-underline-okular.png 924772f ui/data/tools.xml 5e3cb84 ui/guiutils.h 73c0838 ui/guiutils.cpp af06000 ui/pagepainter.h 23ac845 ui/pagepainter.cpp 2890b56 ui/pageview.cpp 26f5516 ui/pageviewannotator.h 850d887 ui/pageviewannotator.cpp 035c1f3 ui/pageviewutils.h 0aaf057 ui/pageviewutils.cpp c2e0388 Diff: http://git.reviewboard.kde.org/r/110566/diff/ Testing --- Thanks, Fabio D'Urso ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
