Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Christoph Feck
On July 25, 2013, 12:59 p.m., Jaydeep Solanki wrote: Can you please confirm if the links are shown properly Albert Astals Cid wrote: Christoph? Oh, I had the impression the question was directed to you (I looked at the To: field in the mail) The link color now works as intended,

Re: [Okular-devel] Dt. 9th August - status

2013-08-16 Thread Jaydeep Solanki
How it occurs : 1) Open an ePub 2) As soon as it opens, hold Right arrow key, till it reaches the end of document or crashes another way would be 2) Hold PgUp/ PgDn key, till it reaches the end of document or crashes. *Note:* it doesn't always crash. In fact the probability of it crashing is

Re: [Okular-devel] Review Request 110003: Best-fit zoom

2013-08-16 Thread Thomas Fischer
On Aug. 14, 2013, 9:55 p.m., Albert Astals Cid wrote: Second, I am trying to add Auto Fit as one of the default zoom settings in the configuration dialog. Although I was quite sure I did not miss a spot and the option turns up in the settings dialog, choosing Auto Fit does not get

Re: [Okular-devel] Dt. 9th August - status

2013-08-16 Thread Albert Astals Cid
El Divendres, 16 d'agost de 2013, a les 22:29:38, Jaydeep Solanki va escriure: How it occurs : 1) Open an ePub 2) As soon as it opens, hold Right arrow key, till it reaches the end of document or crashes another way would be 2) Hold PgUp/ PgDn key, till it reaches the end of document

Re: [Okular-devel] Review Request 110003: Best-fit zoom

2013-08-16 Thread Albert Astals Cid
On Aug. 14, 2013, 9:55 p.m., Albert Astals Cid wrote: Second, I am trying to add Auto Fit as one of the default zoom settings in the configuration dialog. Although I was quite sure I did not miss a spot and the option turns up in the settings dialog, choosing Auto Fit does not get

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated Aug. 16, 2013, 8:58 p.m.) Review request for Okular.

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- To be honest i'm a bit confused by all the different patches

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Christoph Feck
On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: To be honest i'm a bit confused by all the different patches trying to fix the same thing, there's this one, the other one that tries to use kcolorscheme, the other one that tries to let the user choose. And what I don't

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling pdftocairo

2013-08-16 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/ --- (Updated Aug. 16, 2013, 9:17 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling pdftocairo

2013-08-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/#review38002 --- core/generator.h

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Albert Astals Cid
On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: To be honest i'm a bit confused by all the different patches trying to fix the same thing, there's this one, the other one that tries to use kcolorscheme, the other one that tries to let the user choose. And what I don't

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Christoph Feck
On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: To be honest i'm a bit confused by all the different patches trying to fix the same thing, there's this one, the other one that tries to use kcolorscheme, the other one that tries to let the user choose. And what I don't

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-16 Thread Christoph Feck
On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: To be honest i'm a bit confused by all the different patches trying to fix the same thing, there's this one, the other one that tries to use kcolorscheme, the other one that tries to let the user choose. And what I don't

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-16 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 17, 2013, 2:02 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-16 Thread Jonathan Doman
On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: When I started looking at dbus, I couldn't get anything to work. Whenever I tried to run any org.kde.okular method in qdbusviewer, it would say unable to find method or something similar. So I thought the problem might be related to

Re: [Okular-devel] Review Request 110914: Tabbed interface

2013-08-16 Thread Jonathan Doman
On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: shell/shell.h, line 49 http://git.reviewboard.kde.org/r/110914/diff/2/?file=176095#file176095line49 Why are you changing the dbus names? This will break whatever scripts people where using. It seems my experiences were