Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.
> 
> Albert Astals Cid wrote:
> There's more things in Linux land than Plasma and Gnome, i'm worried 
> about such an ugly dialog for those people.
> 
> Aleix Pol Gonzalez wrote:
> Let's create a wiki for them to install the Plasma integration? This way 
> they'll be fixing all of it, not just this precise dialog.
> 
> Or I can discard this review and port it to use KFileWidget. Or 
> undeprecate KFileDialog?
> 
> Albert Astals Cid wrote:
> Any idea why i have 3 commic book entries and 2 PDF entries? 
> http://i.imgur.com/trqsguU.png

PDF is because there's 2 PDF mimetypes supported (?):
```
"application/x-pdf", "application/pdf"
```

There's 3 comic book entries because these 3 mimetypes have the same 
description (!):
```
"application/x-cbz" "comic book archive"
"application/x-cbr" "comic book archive"
"application/x-cbt" "comic book archive"
```

First one could probably be filtered in the okular side, but also should be 
fixed in KIO. In fact, `QMimeType` is smart enough to tell they're the same.

Second one, we can either include the suffix in the description or merge them. 
Opinions?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
---



Is this something that one would expect to set manually? Shouldn't it be 
detected from the file contents? Or that's just too hard/not optimal?


conf/dlggeneralbase.ui (line 388)


Why did you change the acceletaror?



ui/pageview.cpp (line 828)


Isn't that basically if (true) ?


- Albert Astals Cid


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126406: Okular should warn if closing with multiple tabs opened

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126406/#review92545
---




home/user/projects/OkularOriginal/shell/shell.cpp (line 495)


Please use the static functions of KMessageBox, probably questionYesNo ?


- Albert Astals Cid


On Jan. 28, 2016, 11:43 p.m., torham zed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126406/
> ---
> 
> (Updated Jan. 28, 2016, 11:43 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 334019
> http://bugs.kde.org/show_bug.cgi?id=334019
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Multi tab popup warning
> 
> 
> Diffs
> -
> 
>   home/user/projects/OkularOriginal/shell/shell.cpp d80def4 
> 
> Diff: https://git.reviewboard.kde.org/r/126406/diff/
> 
> 
> Testing
> ---
> 
> Opened several pdf files, closed entire program with multiple files open to 
> see if popup properly functions along with the 'yes' and 'no' buttons.
> 
> 
> Thanks,
> 
> torham zed
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Albert Astals Cid]

> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.
> 
> Albert Astals Cid wrote:
> There's more things in Linux land than Plasma and Gnome, i'm worried 
> about such an ugly dialog for those people.
> 
> Aleix Pol Gonzalez wrote:
> Let's create a wiki for them to install the Plasma integration? This way 
> they'll be fixing all of it, not just this precise dialog.
> 
> Or I can discard this review and port it to use KFileWidget. Or 
> undeprecate KFileDialog?

Any idea why i have 3 commic book entries and 2 PDF entries? 
http://i.imgur.com/trqsguU.png


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 2:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 2:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Albert Astals Cid]

> On Feb. 18, 2016, 12:16 a.m., Miklós Máté wrote:
> > ui/tocmodel.cpp, line 152
> > 
> >
> > No. This function marks all the TOC items that contain the current 
> > page, but later in the data() method they are filtered, and in the end only 
> > one triangle marker will be shown (depending on how the tree is expanded in 
> > the view). If there are multiple TOC items on the same level that point to 
> > the same page, this algorithm only marks the last one.

I'm not convinced marking the last one is the best, could we mark "the correct" 
one? After all we know the viewports for the two items so we know what's more 
correct than the other, no? If you need such a document i can send it to you.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92516
---


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> ---
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> fixes bug #342076
> 
> 
> Diffs
> -
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359555] New: Scalable Vector Graphics (SVG) support

[Thomas Fischer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359555

Bug ID: 359555
   Summary: Scalable Vector Graphics (SVG) support
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: New backend wishes
  Assignee: okular-devel@kde.org
  Reporter: fisc...@unix-ag.uni-kl.de

Back in the KDE4 days, there was a SVG rendering KPart that allowed viewing SVG
files (Scalable Vector Graphics) from within Konqueror. Said SVG KPart seems to
be dead now, the latest code commit is from 2011.
My proposal is to scrap whatever code is useful (it relies most likely on Qt's
QSvgRenderer class) and build a backend for Okular. I would even assume that
parts of the PDF renderer can be re-used, as a SVG graphics (apart from
animations that I personally see as non-essential) is in many aspects like a
single-page PDF file.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 351849] Margins often cut when printing

[James Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351849

--- Comment #4 from James Funk  ---
(In reply to James Funk from comment #3)
> I wonder if my problem is the same? Or is mine a similar problem?  When I
> try to print the PDF at
> http://www.ritetemp-thermostats.com/80XX/images/8082C_operation_guide.pdf  ,
> the printout has only part of the page. It is as if the page image had been
> enlarged, and the part of it gets printed on my 8.5 inch by 11 inch paper.

I neglected to mention some things. I'm using a Brother HL-5140 laser printer,
OpenSuSE 13.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 351849] Margins often cut when printing

[James Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351849

James Funk  changed:

   What|Removed |Added

 CC||marathon...@yahoo.com

--- Comment #3 from James Funk  ---
I wonder if my problem is the same? Or is mine a similar problem?  When I try
to print the PDF at
http://www.ritetemp-thermostats.com/80XX/images/8082C_operation_guide.pdf  ,
the printout has only part of the page. It is as if the page image had been
enlarged, and the part of it gets printed on my 8.5 inch by 11 inch paper.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126842/
---

(Updated Feb. 18, 2016, 11:51 a.m.)


Status
--

This change has been discarded.


Review request for Okular.


Repository: okular


Description
---

Some small changes are required to ensure build passes with ECM's new 
FindPoppler.cmake.


Diffs
-

  CMakeLists.txt 492de006c58904f0da94f4cfb9e2ca79ab839c45 
  cmake/modules/FindPoppler.cmake 80a78627438703a9db4d7cd97649098c41b1b2ce 
  generators/CMakeLists.txt ce1d9bfeeb401466c47648d1d828fbd2ff4b18f6 
  generators/poppler/CMakeLists.txt 740b6fd8d6311bee80845a034bba148d443afbd4 

Diff: https://git.reviewboard.kde.org/r/126842/diff/


Testing
---

Builds, PDFs still open.


Thanks,

Michael Palimaka

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel