[Okular-devel] Jenkins-kde-ci: okular Applications-16.08 stable-qt4 ยป Linux,gcc - Build # 1 - Successful!

2016-07-17 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20Applications-16.08%20stable-qt4/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 17 Jul 2016 21:15:13 +
Build duration: 2 min 28 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/16 (88%)FILES 120/184 (65%)CLASSES 120/184 (65%)LINE 12138/28761 
(42%)CONDITIONAL 4885/7473 (65%)

By packages
  
default>
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 880/1603 
(55%)CONDITIONAL 376/610 (62%)
conf
FILES 0/13 (0%)CLASSES 0/13 (0%)LINE 0/611 (0%)CONDITIONAL 0/0 
(100%)
core
FILES 39/48 (81%)CLASSES 39/48 (81%)LINE 4324/9001 
(48%)CONDITIONAL 1811/2525 (72%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/479 (0%)CONDITIONAL 0/0 
(100%)
generators.epub
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 185/332 (56%)CONDITIONAL 
78/117 (67%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 20/486 (4%)CONDITIONAL 
12/22 (55%)
generators.kimgio
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/83 (48%)CONDITIONAL 
15/28 (54%)
generators.kimgio.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 38/38 (100%)CONDITIONAL 
9/18 (50%)
generators.mobipocket
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 17/121 (14%)CONDITIONAL 
10/18 (56%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 18/1191 (2%)CONDITIONAL 
10/18 (56%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 618/1084 (57%)CONDITIONAL 
223/353 (63%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 17/51 (33%)CONDITIONAL 
10/18 (56%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/14 (86%)CONDITIONAL 
4/8 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 374/516 (72%)CONDITIONAL 
197/255 (77%)
tests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1668/1680 
(99%)CONDITIONAL 730/1308 (56%)
ui
FILES 32/50 (64%)CLASSES 32/50 (64%)LINE 3927/11471 
(34%)CONDITIONAL 1400/2175 (64%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2016-07-17 Thread Albert Astals Cid 


> On Oct. 17, 2015, 10:17 p.m., Albert Astals Cid wrote:
> > If you are doing a text select over a link (i.e. you click and start 
> > dragging on a link), i think the cursor should go back to the beam cursor, 
> > what do you think?
> 
> Olivier Churlaud wrote:
> @aacid: What is the status of this review?

I made a question, it has been unanswered, that's all i know.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124961/#review86987
---


On Sept. 15, 2015, 5:41 a.m., Jake  Linder wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124961/
> ---
> 
> (Updated Sept. 15, 2015, 5:41 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 318078
> http://bugs.kde.org/show_bug.cgi?id=318078
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Supercedes https://git.reviewboard.kde.org/r/124723/:
> 
> - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature)
> - Drop the refactoring patch (seperate problem), sticking with the code 
> duplication for now.
> - Added seperate patch (post changes) fixing whitespace issue in gargantuan 
> switch statement. Take it or leave it.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 
> 
> Diff: https://git.reviewboard.kde.org/r/124961/diff/
> 
> 
> Testing
> ---
> 
> - cursor switches to Hand when hovering over link in TextSelect mode.
> - clicking on hyperlink jumps to destination in TextSelect mode.
> - text selection & copy still works.
> - can text-select "over and across" hyperlink.
> - can text-select starting at text and ending selection in middle of 
> hyperlink.
> - can text-select starting from hyperlink with click and drag.
> - can jump to link while there's an active selection of text.
> - can jump to link while there's an active selection spanning a hyperlink.
> - doesn't crash when switching away from window and back + clicking off page
> - when textselect overlaps a link, r-click on the link gives the "follow this 
> link" content menu, r-click off link gives the "Copy Text"/etc' context menu
> - text selection works when selecting left to right or right to left 
> (begin/end selection works out no matter in what order user provides them)
> 
> 
> Thanks,
> 
> Jake  Linder
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 365362] Google Slides PDF render as blank pages

2016-07-17 Thread Albert Astals Cid via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=365362

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Albert Astals Cid  ---
Get a newer poppler

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-17 Thread Martin Tobias Holmedahl Sandsmark 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/
---

(Updated July 17, 2016, 6:09 p.m.)


Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.


Changes
---

use foreach for consistency and ensuring we don't accidentally detach the 
container (we can't use qAsConst(), that's too new).


Repository: okular


Description
---

Without the Plasma QPA now the file open dialog just lets you select a single 
random filetype to view at the time. This tries to improve that, but I'm not 
sure if that's something you/we want?


Diffs (updated)
-

  shell/shell.cpp bca7206 

Diff: https://git.reviewboard.kde.org/r/128435/diff/


Testing
---


Thanks,

Martin Tobias Holmedahl Sandsmark

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-17 Thread Martin Tobias Holmedahl Sandsmark 


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > 
> >
> > I think it would make sense to move that logic upstream.
> > 
> > It's not something specific about okular.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?
> 
> Aleix Pol Gonzalez wrote:
> Whichever QPT that is underwhelming you and pushed you to make this RR. 
> Or QFileDialog, if it's general.

Ah, it is the default implementation in QFileDialog itself.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---


On July 13, 2016, 9:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 9:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-17 Thread Aleix Pol Gonzalez 


> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > 
> >
> > I think it would make sense to move that logic upstream.
> > 
> > It's not something specific about okular.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?

Whichever QPT that is underwhelming you and pushed you to make this RR. Or 
QFileDialog, if it's general.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---


On July 13, 2016, 11:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 11:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-17 Thread Martin Tobias Holmedahl Sandsmark 


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 435
> > 
> >
> > Why? Shouldn't this depend on the standard in the platform? Why would 
> > we need to hide this?

because showing all the file endings leads to an unusably large dropdown.


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 440
> > 
> >
> > Use foreach or qAsConst.

isn't m_fileformats already detached?


> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > 
> >
> > I think it would make sense to move that logic upstream.
> > 
> > It's not something specific about okular.

move which logic to which upstream? QFileDialog?


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---


On July 13, 2016, 9:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 9:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2016-07-17 Thread Olivier Churlaud 


> On Oct. 18, 2015, 12:17 a.m., Albert Astals Cid wrote:
> > If you are doing a text select over a link (i.e. you click and start 
> > dragging on a link), i think the cursor should go back to the beam cursor, 
> > what do you think?

@aacid: What is the status of this review?


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124961/#review86987
---


On Sept. 15, 2015, 7:41 a.m., Jake  Linder wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124961/
> ---
> 
> (Updated Sept. 15, 2015, 7:41 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 318078
> http://bugs.kde.org/show_bug.cgi?id=318078
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Supercedes https://git.reviewboard.kde.org/r/124723/:
> 
> - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature)
> - Drop the refactoring patch (seperate problem), sticking with the code 
> duplication for now.
> - Added seperate patch (post changes) fixing whitespace issue in gargantuan 
> switch statement. Take it or leave it.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 
> 
> Diff: https://git.reviewboard.kde.org/r/124961/diff/
> 
> 
> Testing
> ---
> 
> - cursor switches to Hand when hovering over link in TextSelect mode.
> - clicking on hyperlink jumps to destination in TextSelect mode.
> - text selection & copy still works.
> - can text-select "over and across" hyperlink.
> - can text-select starting at text and ending selection in middle of 
> hyperlink.
> - can text-select starting from hyperlink with click and drag.
> - can jump to link while there's an active selection of text.
> - can jump to link while there's an active selection spanning a hyperlink.
> - doesn't crash when switching away from window and back + clicking off page
> - when textselect overlaps a link, r-click on the link gives the "follow this 
> link" content menu, r-click off link gives the "Copy Text"/etc' context menu
> - text selection works when selecting left to right or right to left 
> (begin/end selection works out no matter in what order user provides them)
> 
> 
> Thanks,
> 
> Jake  Linder
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 358595] "reload document on file change" is not working.

2016-07-17 Thread Olivier Churlaud via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358595

Olivier Churlaud  changed:

   What|Removed |Added

 CC||oliv...@churlaud.com

--- Comment #1 from Olivier Churlaud  ---
It works for me all the time... Can you confirm if the issue is still there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 339199] Opening multiple pdfs fails

2016-07-17 Thread Olivier Churlaud via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=339199

Olivier Churlaud  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||oliv...@churlaud.com

--- Comment #1 from Olivier Churlaud  ---
Seems to work now. Reopen if not the case

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 365362] Google Slides PDF render as blank pages

2016-07-17 Thread Olivier Churlaud via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=365362

Olivier Churlaud  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||oliv...@churlaud.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel