https://bugs.kde.org/show_bug.cgi?id=385384
Nate Graham changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever
aacid added a subscriber: apol.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8244
To: ervin, aacid
Cc: apol, #okular, aacid
aacid added a comment.
Added Aleix to here so we can to come to an agreement of what's the best way
to disable the "Save As" plugin
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8244
To: ervin, aacid
Cc: apol, #okular, aacid
sander added a comment.
Hi, thanks again for the review. I just updated the patch to include most of
your suggestions.
>> I tagged this option as 'experimental' in the GUI.
> Having it only in the tooltip is definitely not enough, this should be
directly in the combobox. The
https://bugs.kde.org/show_bug.cgi?id=383675
Orion Poplawski changed:
What|Removed |Added
CC||or...@cora.nwra.com
--
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #12 from Nate Graham ---
So that would mean, for bugs like these, we would close the bug against Okular
and re-open it against Poppler saying "Poppler should better handle the
following case of the PDF file being
sander updated this revision to Diff 20606.
sander added a comment.
Implement all of Henrik's suggestions.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7949?vs=19817=20606
REVISION DETAIL
https://phabricator.kde.org/D7949
AFFECTED FILES
generators/poppler/generator_pdf.cpp
ervin updated this revision to Diff 20605.
ervin added a comment.
Addressing extra comment
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20601=20605
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.txt
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #11 from Nate Graham ---
My strong preference would be to make Poppler more flexibly able to handle
malformed files like these. It isn't reasonable to expect all PDF documents to
be well-formed, given the apparent
ervin updated this revision to Diff 20601.
ervin added a comment.
Address aacid's comments
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20598=20601
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.txt
aacid added inline comments.
INLINE COMMENTS
> CMakeLists.txt:76
> +set(PURPOSE_FOUND 0)
> +endif()
>
Please also add a set_package_properties so that people see what they are
missing because they don't have purpose installed
REPOSITORY
R223 Okular
REVISION DETAIL
ervin updated this revision to Diff 20598.
ervin added a comment.
Making the purpose dependency optional
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8244?vs=20588=20598
REVISION DETAIL
https://phabricator.kde.org/D8244
AFFECTED FILES
CMakeLists.txt
aacid added a comment.
Can you investigate if there's a way to disable the Save As plugin?
It makes zero sense for Okular
INLINE COMMENTS
> part.cpp:3145
> +if (error) {
> +KMessageBox::error(widget(), i18n("There was a problem sharing the
> image: %1", message),
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124961/
---
(Updated Oct. 11, 2017, 1:05 p.m.)
Status
--
This change has been
> On Oct. 17, 2015, 10:17 p.m., Albert Astals Cid wrote:
> > If you are doing a text select over a link (i.e. you click and start
> > dragging on a link), i think the cursor should go back to the beam cursor,
> > what do you think?
>
> Olivier Churlaud wrote:
> @aacid: What is the status
https://bugs.kde.org/show_bug.cgi?id=318078
Albert Astals Cid changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/oku
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
Can you please make the dependency on purpose optional?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8244
To: ervin, aacid
Cc: #okular, aacid
ervin created this revision.
ervin added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
This is implemented using the Purpose framework.
REPOSITORY
R223 Okular
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #10 from Michael Weghorn ---
I analysed the problem with the attached PDF form. As far as I understand it so
far, the root cause is basically an "incorrect" PDF file, not Poppler.
For easier analysis in a text editor,
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #9 from Michael Weghorn ---
Created attachment 108282
--> https://bugs.kde.org/attachment.cgi?id=108282=edit
another sample PDF from which shows the same problem, cause a bit different
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #8 from Michael Weghorn ---
Created attachment 108281
--> https://bugs.kde.org/attachment.cgi?id=108281=edit
new version of the form from website of "Deutsche Bahn", works fine with Okular
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #7 from Michael Weghorn ---
Created attachment 108279
--> https://bugs.kde.org/attachment.cgi?id=108279=edit
given sample file with removed "DA" entry for field "Startbahnhof"
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=331697
--- Comment #6 from Michael Weghorn ---
Created attachment 108278
--> https://bugs.kde.org/attachment.cgi?id=108278=edit
given sample file, "cleaned" using "mutool"
--
You are receiving this mail because:
You are the assignee
23 matches
Mail list logo