KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 43 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/43/
 Project:
Applications okular kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 24 Oct 2017 03:11:48 +
 Build duration:
1 hr 48 min and counting
   CONSOLE OUTPUT
  [...truncated 23.97 KB...]Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision c84235908582fe8e821cfbab72c7ac3802e3036a (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f c84235908582fe8e821cfbab72c7ac3802e3036aCommit message: "Specific kolf rule, no more catch-all kdegames rule"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[Applications okular kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/prepare-dependencies.py --product Applications --project okular --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.9 --installTo "C:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9/install-prefix/" Retrieving: Applications-kguiaddons-kf5-qt5Retrieving: Applications-kcompletion-kf5-qt5Retrieving: Applications-ktexteditor-kf5-qt5Retrieving: Applications-syntax-highlighting-kf5-qt5Retrieving: Applications-knotifications-kf5-qt5Retrieving: Applications-kactivities-kf5-qt5Retrieving: Applications-kglobalaccel-kf5-qt5Retrieving: Applications-kidletime-kf5-qt5Retrieving: Applications-kdelibs4support-kf5-qt5Retrieving: Applications-knotifyconfig-kf5-qt5Retrieving: Applications-kconfig-kf5-qt5Retrieving: Applications-kross-kf5-qt5Retrieving: Applications-kitemviews-kf5-qt5Retrieving: Applications-extra-cmake-modules-kf5-qt5Retrieving: Applications-phonon-kf5-qt5Retrieving: Applications-kdesignerplugin-kf5-qt5Retrieving: Applications-kitemmodels-kf5-qt5Retrieving: Applications-kjs-kf5-qt5Retrieving: Applications-solid-kf5-qt5Retrieving: Applications-kdegraphics-mobipocket-kf5-qt5Retrieving: Applications-kwindowsystem-kf5-qt5Retrieving: Applications-qca-kf5-qt5Retrieving: Applications-kdeclarative-kf5-qt5Retrieving: Applications-attica-kf5-qt5Retrieving: Applications-plasma-framework-kf5-qt5Retrieving: Applications-kauth-kf5-qt5Retrieving: Applications-kdewebkit-kf5-qt5Retrieving: Applications-sonnet-kf5-qt5Retrieving: Applications-kinit-kf5-qt5Retrieving: Applications-kjobwidgets-kf5-qt5Retrieving: Applications-kconfigwidgets-kf5-qt5Retrieving: Applications-breeze-icons-kf5-qt5Retrieving: Applications-kcodecs-kf5-qt5Retrieving: Applications-kdnssd-kf5-qt5Retrieving: Applications-kio-kf5-qt5Retrieving: Applications-kwidgetsaddons-kf5-qt5Retrieving: Applications-kcrash-kf5-qt5Retrieving: Applications-kxmlgui-kf5-qt5Retrieving: Applications-ktextwidgets-kf5-qt5Retrieving: Applications-knewstuff-kf5-qt5Retrieving: Applications-karchive-kf5-qt5Retrieving: Applications-kdbusaddons-kf5-qt5Retrieving: Applications-kded-kf5-qt5Retrieving: Applications-kparts-kf5-qt5Retrieving: Applications-kunitconversion-kf5-qt5Retrieving: Applications-frameworkintegration-kf5-qt5Retrieving: Applications-kxmlrpcclient-kf5-qt5Retrieving: Applications-kservice-kf5-qt5Retrieving: Applications-kbookmarks-kf5-qt5Retrieving: Applications-kwallet-kf5-qt5Retrieving: Applications-kiconthemes-kf5-qt5Retrieving: Applications-ki18n-kf5-qt5Retrieving: Applications-kjsembed-kf5-qt5Retrieving: Applications-oxygen-icons5-kf5-qt5Retrieving: Applications-kemoticons-kf5-qt5Retrieving: Applications-kpackage-kf5-qt5Retrieving: Applications-kdoctools-kf5-qt5Retrieving: Applications-threadweaver-kf5-qt5Retrieving: Applications-libkexiv2-kf5-qt5Retrieving: Applications-kdewin-kf5-qt5Retrieving: Applications-kdeconnect-kde-kf5-qt5Retrieving: Applications-khtml-kf5-qt5Retrieving: Applications-kplotting-kf5-qt5Retrieving: Applications-kcoreaddons-kf5-qt5Retrieving: Applications-kcmutils-kf5-qt5Retrieving: Applications-purpose-kf5-qt5Unable to fetch: Applications-purpose-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Applications okular kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] 

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 93 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/93/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 24 Oct 2017 03:11:48 +
 Build duration:
1 hr 4 min and counting
   CONSOLE OUTPUT
  [...truncated 16.30 KB...]Cloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Applications okular kf5-qt5 FreeBSDQt5.7/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 535b1c344dad1aac19764f5bf9979f822b27a14e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 535b1c344dad1aac19764f5bf9979f822b27a14eCommit message: "kolf/master is KF5-based"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Applications okular kf5-qt5 FreeBSDQt5.7/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision c84235908582fe8e821cfbab72c7ac3802e3036a (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f c84235908582fe8e821cfbab72c7ac3802e3036aCommit message: "Specific kolf rule, no more catch-all kdegames rule"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Applications okular kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Applications --project okular --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.7 --installTo '/usr/home/jenkins/workspace/Applications okular kf5-qt5 FreeBSDQt5.7/install-prefix/'Retrieving: Applications-kdbusaddons-kf5-qt5Retrieving: Applications-kconfig-kf5-qt5Retrieving: Applications-kxmlrpcclient-kf5-qt5Retrieving: Applications-phonon-kf5-qt5Retrieving: Applications-kdoctools-kf5-qt5Retrieving: Applications-threadweaver-kf5-qt5Retrieving: Applications-kinit-kf5-qt5Retrieving: Applications-kcrash-kf5-qt5Retrieving: Applications-kwayland-kf5-qt5Retrieving: Applications-kcodecs-kf5-qt5Retrieving: Applications-kcmutils-kf5-qt5Retrieving: Applications-kdesignerplugin-kf5-qt5Retrieving: Applications-kdeclarative-kf5-qt5Retrieving: Applications-knotifications-kf5-qt5Retrieving: Applications-kservice-kf5-qt5Retrieving: Applications-kjobwidgets-kf5-qt5Retrieving: Applications-sonnet-kf5-qt5Retrieving: Applications-plasma-framework-kf5-qt5Retrieving: Applications-kitemmodels-kf5-qt5Retrieving: Applications-kdewebkit-kf5-qt5Retrieving: Applications-kguiaddons-kf5-qt5Retrieving: Applications-kidletime-kf5-qt5Retrieving: Applications-solid-kf5-qt5Retrieving: Applications-kwidgetsaddons-kf5-qt5Retrieving: Applications-kdeconnect-kde-kf5-qt5Retrieving: Applications-oxygen-icons5-kf5-qt5Retrieving: Applications-kactivities-kf5-qt5Retrieving: Applications-attica-kf5-qt5Retrieving: Applications-kwallet-kf5-qt5Retrieving: Applications-knewstuff-kf5-qt5Retrieving: Applications-kauth-kf5-qt5Retrieving: Applications-kxmlgui-kf5-qt5Retrieving: Applications-breeze-icons-kf5-qt5Retrieving: Applications-kpackage-kf5-qt5Retrieving: Applications-kparts-kf5-qt5Retrieving: Applications-kded-kf5-qt5Retrieving: Applications-libkexiv2-kf5-qt5Retrieving: Applications-khtml-kf5-qt5Retrieving: Applications-ktexteditor-kf5-qt5Retrieving: Applications-kunitconversion-kf5-qt5Retrieving: Applications-kglobalaccel-kf5-qt5Retrieving: Applications-kconfigwidgets-kf5-qt5Retrieving: Applications-kactivities-stats-kf5-qt5Retrieving: 

KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/87/
 Project:
Applications okular kf5-qt5 FedoraQt5.8
 Date of build:
Tue, 24 Oct 2017 03:11:48 +
 Build duration:
5 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 27.86 KB...] > git config core.sparsecheckout # timeout=10 > git checkout -f c84235908582fe8e821cfbab72c7ac3802e3036aCommit message: "Specific kolf rule, no more catch-all kdegames rule"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kapidox > git init /home/jenkins/workspace/Applications okular kf5-qt5 FedoraQt5.8/ci-tooling/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 16dfe9c5afa16b2f3d1e62bf0e0f5dc6c852ff5e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 16dfe9c5afa16b2f3d1e62bf0e0f5dc6c852ff5eCommit message: "GIT_SILENT Upgrade KF5 version to 5.39.0."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Applications okular kf5-qt5 FedoraQt5.8/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 4e8c366aa5157182e797446d503afe268d27ae74 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 4e8c366aa5157182e797446d503afe268d27ae74Commit message: "Script to Convert from Portage to Craft"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Applications okular kf5-qt5 FedoraQt5.8] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Applications --project okular --branchGroup kf5-qt5 --environment production --platform FedoraQt5.8 --installTo /home/jenkins//install-prefix/Retrieving: Applications-solid-kf5-qt5Retrieving: Applications-kcodecs-kf5-qt5Retrieving: Applications-kdbusaddons-kf5-qt5Retrieving: Applications-kidletime-kf5-qt5Retrieving: Applications-kio-kf5-qt5Retrieving: Applications-kservice-kf5-qt5Retrieving: Applications-kemoticons-kf5-qt5Retrieving: Applications-kdesignerplugin-kf5-qt5Retrieving: Applications-breeze-icons-kf5-qt5Retrieving: Applications-extra-cmake-modules-kf5-qt5Retrieving: Applications-karchive-kf5-qt5Retrieving: Applications-ki18n-kf5-qt5Retrieving: Applications-kpty-kf5-qt5Retrieving: Applications-plasma-framework-kf5-qt5Retrieving: Applications-sonnet-kf5-qt5Retrieving: Applications-knotifications-kf5-qt5Retrieving: Applications-phonon-kf5-qt5Retrieving: Applications-ktextwidgets-kf5-qt5Retrieving: Applications-syntax-highlighting-kf5-qt5Retrieving: Applications-kactivities-stats-kf5-qt5Retrieving: Applications-libkexiv2-kf5-qt5Retrieving: Applications-kjsembed-kf5-qt5Retrieving: Applications-kross-kf5-qt5Retrieving: Applications-kwidgetsaddons-kf5-qt5Retrieving: Applications-attica-kf5-qt5Retrieving: Applications-kactivities-kf5-qt5Retrieving: Applications-kcompletion-kf5-qt5Retrieving: Applications-kauth-kf5-qt5Retrieving: Applications-knotifyconfig-kf5-qt5Retrieving: Applications-kbookmarks-kf5-qt5Retrieving: Applications-kguiaddons-kf5-qt5Retrieving: Applications-kdoctools-kf5-qt5Retrieving: Applications-kxmlgui-kf5-qt5Retrieving: Applications-kjobwidgets-kf5-qt5Retrieving: Applications-knewstuff-kf5-qt5Retrieving: Applications-threadweaver-kf5-qt5Retrieving: Applications-kinit-kf5-qt5Retrieving: Applications-kdelibs4support-kf5-qt5Retrieving: Applications-kjs-kf5-qt5Retrieving: Applications-oxygen-icons5-kf5-qt5Retrieving: Applications-kpackage-kf5-qt5Retrieving: Applications-kwayland-kf5-qt5Retrieving: Applications-kglobalaccel-kf5-qt5Retrieving: 

[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385456

--- Comment #8 from bbdn...@gmail.com ---
poppler 0.60.1-1 is installed.
poppler-data is 0.4.8-1.
Distribution is Arch Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8415: Soften correctness of image file open check

[Albert Astals Cid]

aacid added a comment.


  Please consider fixing this in Qt before asking us to create a workaround.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid, progwolff

[okular] [Bug 385456] Okular do not print PDF containing vertical direction document.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=385456

--- Comment #7 from Albert Astals Cid  ---
which poppler version are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385468] "Missing \"Version=5\", file '/usr/share/kconf_update/okular.upd' will be skipped."

[Matthew Dawson]

https://bugs.kde.org/show_bug.cgi?id=385468

--- Comment #6 from Matthew Dawson  ---
(In reply to Albert Astals Cid from comment #5)
> (In reply to Matthew Dawson from comment #4)
> > Also, if the configuration update script is for KDE4 configuration files,
> > you can skip putting a Version=5 header at the top.  Instead, you can have
> > the fully updated file migrated to the new configuration file location and
> > start with a fresh update script for KF5.  Or continue adding to the file. 
> > Whatever works best for okular.
> 
> For my application there's no such thing as "KDE4" configuration files, they
> are just configuration files, and ideally one should be able to go from an
> old version (based on kdelibs4, irrelevant) where the okular.upd had not
> been run to the new version (based on KF5, irrelevant) and get okular.upd
> run and then the config be migrated to the new location.
> 
> As I understand you're saying that this is impossible and thus i basically
> should just remove the .upd file?

The situation may have changed since this was brought up.  At the time, you'd
use the Kdelibs4Migration class (
https://api.kde.org/frameworks/kcoreaddons/html/classKdelibs4Migration.html )
to move the file to the new KF5 location (using the XDG directory instead of
the .kde directory).  The upd file wasn't used for that purpose.

If using the upd file is now the recommended way to do the migration, then you
can ignore my suggestion.  I'm not sure though the upd file is flexible to
handle custom kde prefixes that Kdelibs4Migration does.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386110] ctrl+f highlighting only works for low zoom levels

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=386110

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=377487

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385458] pdf form remain blank in Bulgarian

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=385458

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386111] New: Selecting text moves it one pixel towards the bottom

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=386111

Bug ID: 386111
   Summary: Selecting text moves it one pixel towards the bottom
   Product: okular
   Version: 1.2.70
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de
  Target Milestone: ---

I think the following is a regression introduced by the hidpi branch:

- Open any pdf document
- Switch to selection mode (ctrl-3)
- Select any piece of text

When looking closely, you will see that the selected text has moved a small
amount towards the bottom of the page.  Unselecting it moves it back to its
original position.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7662: Draw a dark rectangle around highlighted search results

[Oliver Sander]

sander added a comment.


  I still cannot reproduce Albert's problems locally, but after reading 
Christoph's link (thanks!) I found out that I can move the upper left corner of 
the border one pixel towards the lower right without uncovering the yellow 
rectangle.  Please somebody test whether the new patch still produces these 
artifacts.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7662

To: sander, #okular
Cc: cfeck, aacid, ngraham

D7662: Draw a dark rectangle around highlighted search results

[Oliver Sander]

sander updated this revision to Diff 21180.
sander added a comment.


  Move the top left corner of the dark border one pixel towards the lower right.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7662?vs=19101=21180

REVISION DETAIL
  https://phabricator.kde.org/D7662

AFFECTED FILES
  ui/pagepainter.cpp

To: sander, #okular
Cc: cfeck, aacid, ngraham

[okular] [Bug 386110] New: ctrl+f highlighting only works for low zoom levels

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=386110

Bug ID: 386110
   Summary: ctrl+f highlighting only works for low zoom levels
   Product: okular
   Version: 1.2.70
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de
  Target Milestone: ---

When searching for text with ctrl+f, the found text is highlighted by yellow
rectangles.  However, this only works at low zoom levels (wild guess: all zoom
levels that work without tiling).

Steps to reproduce:
- Open any pdf document that contains text
- Search for a word that exists in the text
- If yellow highlight appears: zoom into the word, eventually
  the highlight will disappear
- If there is no highlight: zoom out, it will appear eventually.

I think (but didn't test) that this is a regression introduced by the hidpi
branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8415: Soften correctness of image file open check

[Julian Wolff]

progwolff added a comment.


  In https://phabricator.kde.org/D8415#158804, @aacid wrote:
  
  > Wouldn't it make more sense to fix this in QImageReader and not in every 
user of QImageReader ?
  
  
  From my perspective the behaviour of QImageReader is correct.
  
  QImage::read docs:
  
  > Reads an image from the device into image, which must point to a QImage. 
Returns true on success; otherwise, returns false.
  
  QImage::isNull docs:
  
  > Returns true if it is a null image, otherwise returns false.
  >  A null image has all parameters set to zero and no allocated data.
  
  It seems totally possible that an empty image file is read correctly. In this 
case read returns true, but the resulting image is a null image.
  
  For this patch I would however prefer a new error message, something like 
"the loaded document is empty".

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid, progwolff

D8415: Soften correctness of image file open check

[Albert Astals Cid]

aacid added a comment.


  Wouldn't it make more sense to fix this in QImageReader and not in every user 
of QImageReader ?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid, progwolff

D8415: Soften correctness of image file open check

[Julian Wolff]

progwolff added a comment.


  In https://phabricator.kde.org/D8415#158800, @trufanov wrote:
  
  > Also I heard I can add
  >  Differential Revision: https://phabricator.kde.org/D8415
  >  in commit message to automatically close phabricator review. Is it so?
  
  
  This is true, but it must be the last line. See 
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
 .
  
  You might also want to check out "arc", the command line tool for 
phabricator. 
  For example "arc land" will automatically commit, push and close the 
differential revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: progwolff, aacid

D8415: Soften correctness of image file open check

[Alexander Trufanov]

trufanov added a comment.


  Ok, I've edited summary. Didn't know that KDE Bugs could be referred in a 
such way in phabricator summary instead of commit message.
  Also I heard I can add
  Differential Revision: https://phabricator.kde.org/D8415
  in commit message to automatically close phabricator review. Is it so?
  
  As for testing. So far so good.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid

D8415: Soften correctness of image file open check

[Alexander Trufanov]

trufanov edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid

D8379: PDF: Support the new poppler renderToImage with update callback

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D8379#157771, @rkflx wrote:
  
  > That's a really great feature Okular's user will surely love. Does this 
solve https://bugs.kde.org/show_bug.cgi?id=344081?
  
  
  Yes
  
  > When testing (with https://phabricator.kde.org/D8378 and 
https://phabricator.kde.org/D8379 both applied at the same time – sorry for 
that –, as well as the Poppler patch), there were still some issues for me:
  > 
  > - After zooming in and rendering finished (i.e. CPU usage went back to 
zero), the display would not update. Only after panning enough so a request for 
a new tile triggered rendering again the display would also update. (Note: I 
tested whether this is a regression with the HiDPI commit, but it is not.)
  > - Same thing for zooming out.
  
  Right, thanks for finding this, that happens because Page::hasPixmap is not 
really const when the page has a tile manager, i've added a workaround and 
FIXME and i'll see if i can find some time to fix that properly, but i don't 
think we should block this feature of landing because of old code being broken.
  
  > - The progressive rendering seems to only work with Fit Page on startup, 
but not with 100% Zoom on startup or when zooming in later. (My first thought 
was that there might be some connection to the scaled raster images shown as a 
temporary preview, but apparently that is not always the case.)
  
  Nothing to do with Fit Page, basically if you got into tiled rendering the 
progressive rendering didn't happen, i've also fixed that now.
  
  > Also I am wondering if the partial updates might slow down the total 
rendering time, i.e. whether there should be some rate limiting to the partial 
updates (if there isn't already)?
  
  It totally does since there's more "here take this pixmap and put it into 
screen", but since the user seems things earlier the end result for his mind is 
"things are faster". I don't see a need to limit it really (other than the 
initial 500ms barrier)

INLINE COMMENTS

> rkflx wrote in generator_pdf.cpp:905
> Why not set this to something in the region of 30 to 60 fps (e.g. ~30ms 
> instead of 500ms)? This way some overhead would be avoided while potentially 
> still feeling somewhat fluent (i.e. not seeing Okular's loading icon) when 
> scrolling through pages.

Because it looks bad, lots of pages take more than 30ms and you don't really 
want to see them rendering just twice (say once at 30ms and one at 45ms when it 
finishes), your brain gets upset about it because you get a render with 66% of 
the rendering done and just 15ms later you get 100%.

Sure, this may also happen with the page taking 515ms to render and so you get 
an update at 500ms and one at 515ms, but in that case your brain gets a little 
less upset since you got a render with 97% of the rendering done and one with 
100%.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8379

To: aacid, #okular
Cc: rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid

D8379: PDF: Support the new poppler renderToImage with update callback

[Albert Astals Cid]

aacid updated this revision to Diff 21161.
aacid added a comment.


  Add BUGS

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8379?vs=21160=21161

BRANCH
  updateCallback (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8379

AFFECTED FILES
  core/document.cpp
  core/generator.cpp
  core/generator.h
  core/generator_p.h
  core/page.cpp
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp

To: aacid, #okular
Cc: rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid

D8379: PDF: Support the new poppler renderToImage with update callback

[Albert Astals Cid]

aacid updated this revision to Diff 21160.
aacid added a comment.


  Fix pixmaps not getting updated when the tile manager kicks in
  
  Also make the tile request be partially updated if that's what the request 
wants

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8379?vs=21008=21160

BRANCH
  updateCallback (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8379

AFFECTED FILES
  core/document.cpp
  core/generator.cpp
  core/generator.h
  core/generator_p.h
  core/page.cpp
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp

To: aacid, #okular
Cc: rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid