D10249: Option to exit after printing
dileepsankhla added a comment. @ngraham Can you please review my patch? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular, ngraham Cc: ngraham, aacid, #okular, michaelweghorn
D10050: [PATCH 4/4] Add autotest for AFSimple_Calculate script
aacid added a comment. Can you add the test i mentioned on the other about doing 3*0*4 ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10050 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham
D10049: [PATCH 3/4] Add initial support for built-in javascript functs
aacid added inline comments.
INLINE COMMENTS
> builtin.js:35
> +{
> +ret = 1;
> +}
why set ret to 1 if ret is 0? is this because you want to initialize? then you
should test i is 0 otherwise 3*0*4 will be 4?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10049
To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
D10048: [PATCH 2/4] Communicate calculate text change to formwidgets
aacid added a comment. Can you explain why we need this? isn't this already working https://www.youtube.com/watch?v=S-zmHc3WUhs ? Probably i'm misunderstanding something REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10048 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham
D10249: Option to exit after printing
dileepsankhla updated this revision to Diff 26453. dileepsankhla added a comment. - # Enter a commit message. 1. Updating https://phabricator.kde.org/D10249: Option to exit after printing # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended to create a new revision, use: 5. $ arc diff --create Option to exit after printing REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10249?vs=26371=26453 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10249 AFFECTED FILES autotests/mainshelltest.cpp part.cpp part.h shell/main.cpp shell/shell.cpp shell/shellutils.cpp shell/shellutils.h To: dileepsankhla, aacid, #okular, ngraham Cc: ngraham, aacid, #okular, michaelweghorn
[okular] [Bug 389836] New: Distinguish highlights containing a non-empty popup note inreview pane
https://bugs.kde.org/show_bug.cgi?id=389836 Bug ID: 389836 Summary: Distinguish highlights containing a non-empty popup note inreview pane Product: okular Version: 1.3.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: simg...@gmail.com Target Milestone: --- Considering the highlight annotations, in the "Reviews" panel all these annotation appears as "Highlight". Sometimes the annotation can contain a popup note as well. It would be useful to mark those annotations that have a non-empty popup note attached. For example, marking them with an asterisk as "Highlight*". This will simplify finding hidden annotations when there is a lot of highlighted text. This may apply to other types of annotations as well. -- You are receiving this mail because: You are the assignee for the bug.
