KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

2018-02-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Feb 2018 23:53:57 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

2018-02-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Feb 2018 23:53:25 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 57 - Fixed!

2018-02-05 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/57/
 Project:
Applications okular kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Feb 2018 23:54:15 +
 Build duration:
6 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(22/25)51%
(139/272)51%
(139/272)37%
(14716/39444)25%
(7018/27535)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)58%
(1075/1840)41%
(563/1361)autotests100%
(14/14)100%
(14/14)99%
(2300/2324)50%
(1470/2969)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core86%
(42/49)86%
(42/49)54%
(5140/9536)39%
(2482/6425)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3572)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)55%
(184/335)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/531)0%
(2/454)generators.kimgio100%
(1/1)100%
(1/1)63%
(44/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)52%
(694/1340)40%

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 56 - Unstable!

2018-02-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/56/
 Project:
Applications okular kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Feb 2018 23:32:49 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(22/25)48%
(130/272)48%
(130/272)31%
(12092/39353)19%
(5285/27527)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)47%
(866/1834)26%
(356/1361)autotests93%
(13/14)93%
(13/14)70%
(1607/2312)32%
(940/2967)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core82%
(40/49)82%
(40/49)46%
(4339/9500)31%
(2017/6421)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3572)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)54%
(180/334)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook40%
(2/5)40%
(2/5)1%
(7/529)0%
(0/454)generators.kimgio100%
(1/1)100%
(1/1)60%
(42/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket40%
(2/5)40%
(2/5)5%
(6/113)0%
(0/120)generators.ooo18%
(2/11)18%
(2/11)1%
(7/1123)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)48%
(638/1338)36%

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

2018-02-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Feb 2018 23:32:14 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-02-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/30/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Feb 2018 23:32:49 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D10022: Fix annoying warning

2018-02-05 Thread Albert Astals Cid 
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  bleh

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10022

To: apol, aacid
Cc: #okular, michaelweghorn, ngraham, aacid

D10022: Fix annoying warning

2018-02-05 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10022

To: apol, aacid
Cc: #okular, michaelweghorn, ngraham, aacid

[okular] [Bug 338742] Annotations incompatible with gzip

2018-02-05 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=338742

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/ad1160be1b370ca512a741c
   ||1a12f9eff0ca5848c

--- Comment #6 from Albert Astals Cid  ---
Git commit ad1160be1b370ca512a741c1a12f9eff0ca5848c by Albert Astals Cid, on
behalf of Henrik Fehlauer.
Committed on 05/02/2018 at 23:31.
Pushed by aacid into branch 'Applications/17.12'.

Fix saving annotations to gzipped files

Okular supports opening zipped files like document.pdf.gz by
transparently extracting them. However, since 559836c39270 saving
annotations back was broken. This is because this commit tries to
prevent saving back changes to externally modified files to prevent data
loss. The way this is checked by comparing timestamps mistakenly
triggered for unchanged zipped files, too.

This can be solved by always comparing the before/after timestamps of
the actual file, instead of the timestamp of the temporary copy of the
extracted file. The change has to be done in two places so saving
repeatedly works too.

Test plan
gzip autotests/data/file1.pdf && okular file1.pdf.gz
Add annotation, saving works now instead of showing an error.
touch normal.pdf still triggers modification warning.

Differential Revision: https://phabricator.kde.org/D9580

M  +2-2part.cpp

https://commits.kde.org/okular/ad1160be1b370ca512a741c1a12f9eff0ca5848c

-- 
You are receiving this mail because:
You are the assignee for the bug.

D9580: Fix saving annotations to gzipped files

2018-02-05 Thread Albert Astals Cid 
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.12

REVISION DETAIL
  https://phabricator.kde.org/D9580

To: rkflx, aacid, #okular
Cc: #okular, michaelweghorn, ngraham, aacid

D9580: Fix saving annotations to gzipped files

2018-02-05 Thread Albert Astals Cid 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:ad1160be1b37: Fix saving annotations to gzipped files 
(authored by rkflx, committed by aacid).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9580?vs=24521=26620

REVISION DETAIL
  https://phabricator.kde.org/D9580

AFFECTED FILES
  part.cpp

To: rkflx, aacid, #okular
Cc: #okular, michaelweghorn, ngraham, aacid

D10249: Option to exit after printing

2018-02-05 Thread Dileep Sankhla 
dileepsankhla updated this revision to Diff 26608.
dileepsankhla marked an inline comment as done.
dileepsankhla added a comment.


  Updating https://phabricator.kde.org/D10249: Option to exit after printing
  Initialized "isError" with false at the time of declaration.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=26550=26608

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 389912] feature request: file:send as

2018-02-05 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=389912

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 173896 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 173896] Sent-to menu entry or send-via-email menu-entry

2018-02-05 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=173896

Albert Astals Cid  changed:

   What|Removed |Added

 CC||dav1dblunk...@hotmail.com

--- Comment #30 from Albert Astals Cid  ---
*** Bug 389912 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

2018-02-05 Thread Albert Astals Cid 
aacid added inline comments.

INLINE COMMENTS

> part.cpp:3212
>  
> +bool isError;
>  if ( printDialog->exec() )

What is the value of isError when

  if ( printDialog->exec() )

returns false?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 389912] feature request: file:send as

2018-02-05 Thread Oliver Sander 
https://bugs.kde.org/show_bug.cgi?id=389912

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
This feature got implemented late last year.  Could you try a very new Okular,
and see whether that suits your needs?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389912] New: feature request: file:send as

2018-02-05 Thread davidblunkett 
https://bugs.kde.org/show_bug.cgi?id=389912

Bug ID: 389912
   Summary: feature request: file:send as
   Product: okular
   Version: 1.1.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: dav1dblunk...@hotmail.com
  Target Milestone: ---

feature request: file:send as email

It would be a nice option to be able to send the current file as an email.

I often need to do this with docs opened from the net and I know I can save to
a temp file, upload and then email but simply sending via my email client
(kmail) would be very handy - I use this feature all the time in LO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389909] New: Allow dragging navigation panel to the right

2018-02-05 Thread David 
https://bugs.kde.org/show_bug.cgi?id=389909

Bug ID: 389909
   Summary: Allow dragging navigation panel to the right
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: david.cortes.riv...@gmail.com
  Target Milestone: ---

Would be very convenient to allow okular to drag the navigation panel to the
right side of the screen, and also to have a small button to hide it at the
bottom or center of the panel itself (like vivaldi browser or old opera).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-02-05 Thread Oliver Sander 
https://bugs.kde.org/show_bug.cgi?id=383651

--- Comment #7 from Oliver Sander  ---
Should we split this into a set of separate smaller issues, then? E.g., issues
with stamps with standard appearances seem to be quite independent from custom
stamps.

-- 
You are receiving this mail because:
You are the assignee for the bug.