KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/27/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 08 Feb 2018 06:00:25 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 08 Feb 2018 04:52:14 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/33/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 08 Feb 2018 04:11:54 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Huon]

https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #6 from Huon  ---
Could you try to extract a page or two to a separate file? Like a blank page or
a page without copyrighted material?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Huon]

https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #5 from Huon  ---
Hmm, I'm new to the KDE (dev) world, not sure why the package version (and
versions on github) are different to the version reported by okular itself and
the bugtracker. I am also using 1.3.1 as reported by okular.

I guess someone needs to find a non-copyrighted PDF that causes the bug...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #4 from Michael D  ---
On this bug, the drop down the version maxes out at 1.3.1, "okular --version"
says 1.3.1, and even through the help gui it says 1.3.1, so...

Anyway, I can only reproduce it on certain files and not others. I would attach
the file here but it's a pdf book and copyrighted, so I can't do that. It may
not be helpful at all, but the metadata says that it was created by
PScript5.dll version 5.2, the producer is Adobe Acrobat Distiller 6.0
(Windows), format PDF v. 1.5. I thought it might be the pdf reloading and
showing bookmarks by default, but it seems not to be, because when I use the
hyperref package with LaTeX with bookmarksopen=true, I can't reproduce the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Huon]

https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #3 from Huon  ---
@Michael D - 1.3.1? 3.2.0 was released in 2004.

I tested saving with "Save" after adding annotations, still couldn't reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #2 from Michael D  ---
I'm using okular 1.3.1 and NOT using "save as" but just "save" after editing a
file with annotations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

[Huon]

https://bugs.kde.org/show_bug.cgi?id=389668

Huon  changed:

   What|Removed |Added

 CC||h...@plonq.org

--- Comment #1 from Huon  ---
I can't replicate this using olular 17.12.1 from the Arch repos.
I made sure the document I tested with had a Contents, switch to Thumbnail, and
saved using Save As... to a different location.

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/32/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 08 Feb 2018 02:27:28 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltest

D10048: [PATCH 2/4] Communicate calculate text change to formwidgets

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D10048#202336, @aheinecke wrote:
  
  > I had another look at this and I could not get it to work with 
refreshPixmaps and I don't understand how the FormWidget should be updated if 
the text of the underlying FormField changes. The only setTexts I see in the 
FormWidgets are in the Ctor or in the "slotHandleTextChangedByUndoRedo" I'm 
probably overlooking something :-/
  >
  > So I tried it out and added another Field "JSSum" to the example PDF I'm 
using F5696675: simple_calculate.pdf  
which had a calculate script that modified a field value through a JavaScript 
assignment and it also did not work there: F5696683: calculate-not-working.gif 
 So maybe there was a regression at some 
point?
  >
  > Could you attach a sample PDF where this is working?
  
  
  https://www.revenue.wi.gov/dorforms/2016-Form1f.pdf
  
  > Sorry I don't want to create additional work for you but I did not find one 
by searching for related bugs in BKO.
  > 
  > The Versions I tried were unmodified master 
(https://phabricator.kde.org/R223:e06883d102f06bf99ffcf29845fcc4e3e0622d62) and 
Okular 0.26.1 which I have from my debian distro.
  > 
  > To be clear:
  >  I'm still planning to make changes to this revision but I first want to 
figure out if there is an already working update mechanism between FormField 
and FormWidget that I have overlooked or if the one that was in place needs a 
fix.
  
  Well you need the refresh pixmaps for sure, because at least right now when 
hiding the forms the image of the pdf has the wrong value, so that needs fixing.
  
  As for the difference with the pdf i linked, i think i see the difference, 
the ones you linked the all the widgets are  so you need to update the "result" 
widgets values.
  
  Could you explore getting that value from the core of poppler and not setting 
the value in the ui manually? I mean if you force a pixmap refresh (by zooming 
in/out) the values of the rendered "image" update correctly so somewhere 
something knows the value changed. I'd prefer using that over going manually 
and setting the value "again"
  
  > Thanks,
  > Andre

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kjs_field.cpp:222
>  
> +KJSObject JSField::wrapField( KJSContext *ctx, FormField *field)
> +{

You really want ot use the verison with the page so refreshPixmaps happens

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

D10249: Option to exit after printing

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> mainshelltest.cpp:320
> + if (externalProcessExpectPrintDialogAndExit)
> +args << QStringLiteral("-print_and_exit");
>  p.start(QStringLiteral(OKULAR_BINARY), args);

Regarding this option: shouldn't it be -print-and-exit instead? I don't think 
that underscores are normally used in option names.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> part.cpp:3240
>  
> -void Part::doPrint(QPrinter )
> +bool Part::doPrint(QPrinter )
>  {

Can you please make doPrint return true on success and not on error?

It's a much saner API.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #14 from Michael Weghorn  ---
Thanks for the additional information.

(In reply to Attila from comment #11)
> - The printer is served by a Cups server. Is that the reason, why you said
> no "real" CUPS filters are processed?

Probably yes. I didn't know about your setup, but the error_log shows what
filters are processed. In case the printer is served by another CUPS server,
filtering should be done there, not locally, so this makes sense.

I suppose that the information that the printers are served by a CUPS server on
another machine is relevant for the problem. (The files I saw so far from the
local machine look "reasonable" to me at first sight.)

Do you by any chance have the possibility to do a printout on a printer that is
directly connected to the computer on which Okular is running?

Also, getting the CUPS error_log (with debugging enabled) and the PPD of the
printer from the machine where the CUPS server is running will probably be of
help to further analyse the issue. What kind of operating system is that
machine running and what version of CUPS is in use there?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #13 from Attila  ---
Created attachment 110406
  --> https://bugs.kde.org/attachment.cgi?id=110406=edit
PPD file HPM880

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #12 from Attila  ---
Created attachment 110405
  --> https://bugs.kde.org/attachment.cgi?id=110405=edit
File generated by Okular

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #11 from Attila  ---
Just two things to mention:

- This "bug" is not only related to the printer HPM880. I get the same result
on different printers.

- The printer is served by a Cups server. Is that the reason, why you said no
"real" CUPS filters are processed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #10 from Michael Weghorn  ---
(In reply to Attila from comment #7)
> You can check now the attached files error_log and the output of systemctl
> status cups.service

Thanks!

At first glance, I don't see anything obvious. What is interesting here is that
no "real" CUPS filters are processed, as the printer seems to support
"application/postscript".

Can you please also attach the PPD file for your printer? It should be located
at /etc/cups/ppd/HPM880.ppd

What would also be interesting is the print file generated by Okular. You can
for example get it as follows:

* stop the printer, command: "sudo cupsdisable HPM880"
* start print job from Okular as before

The file should then then be located under "/var/spool/cups/d-001"
(where "" needs to be replaced by the ID for the CUPS print job.
Can you please attach that file here as well?

(Then you can start the printer again (command "sudo cupsenable HPM880" and the
printout should take place.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #9 from Attila  ---
Created attachment 110403
  --> https://bugs.kde.org/attachment.cgi?id=110403=edit
Output of systemctl status cups.service

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #7 from Attila  ---
The ErrorLog directive was syslog.

You can check now the attached files error_log and the output of systemctl
status cups.service

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #8 from Attila  ---
Created attachment 110402
  --> https://bugs.kde.org/attachment.cgi?id=110402=edit
error_log

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #6 from Michael Weghorn  ---
(In reply to Attila from comment #4)
> LogLevel is set to debug. Did a restart. No logfile is written. Maybe a new
> bug. I wish I could send you the error_log.

That's interesting...

Does this mean the file /var/log/error_log does not exist at all?

What is the exact "ErrorLog" directive in "/etc/cups/cups-files.conf"? That one
specifies where the log output is written to. (It would be "ErrorLog
/var/log/cups/error_log" if that is the file to write to, but can also be sth
like "syslog", in which case the output needs to be retrieved another way...).

What is the output of the command "sudo systemctl status cups.service"?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #5 from Attila  ---
Created attachment 110395
  --> https://bugs.kde.org/attachment.cgi?id=110395=edit
Example to print

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #4 from Attila  ---
(In reply to Michael Weghorn from comment #3)
> I cannot reproduce the problem here.

I can always reproduce it.

> 
> Does it happen for every document you use? Can you attach one that is
> affected.

Yes for every document. Will attach one.

> 
> Does it happen when you choose "Print to File (PDF)" instead of a real
> printer?

No, that's OK.

> 
> In addition, it may be helpful to see what the CUPS log says. Can you do the
> following:
> * increase CUPS's log level by changing the "LogLevel" directive in
> /etc/cups/cupsd.conf to "LogLevel debug"
> * restart CUPS by running "sudo systemctl restart cups.service"
> * try to print an A4 PDF document on an A4 page from Okular
> * have a look and attach the CUPS log file /var/log/cups/error_log here

LogLevel is set to debug. Did a restart. No logfile is written. Maybe a new
bug. I wish I could send you the error_log.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10048: [PATCH 2/4] Communicate calculate text change to formwidgets

[Andre Heinecke]

aheinecke added a comment.


  I had another look at this and I could not get it to work with refreshPixmaps 
and I don't understand how the FormWidget should be updated if the text of the 
underlying FormField changes. The only setTexts I see in the FormWidgets are in 
the Ctor or in the "slotHandleTextChangedByUndoRedo" I'm probably overlooking 
something :-/
  
  So I tried it out and added another Field "JSSum" to the example PDF I'm 
using F5696675: simple_calculate.pdf  
which had a calculate script that modified a field value through a JavaScript 
assignment and it also did not work there: F5696683: calculate-not-working.gif 
 So maybe there was a regression at some 
point?
  
  Could you attach a sample PDF where this is working? Sorry I don't want to 
create additional work for you but I did not find one by searching for related 
bugs in BKO.
  
  The Versions I tried were unmodified master 
(https://phabricator.kde.org/R223:e06883d102f06bf99ffcf29845fcc4e3e0622d62) and 
Okular 0.26.1 which I have from my debian distro.
  
  To be clear:
  I'm still planning to make changes to this revision but I first want to 
figure out if there is an already working update mechanism between FormField 
and FormWidget that I have overlooked or if the one that was in place needs a 
fix.
  
  Thanks,
  Andre

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

[frameworks-kwidgetsaddons] [Bug 389981] Info bar shows blue text on blue background

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=389981

Kai Uwe Broulik  changed:

   What|Removed |Added

  Component|general |general
 CC||k...@privat.broulik.de,
   ||kdelibs-b...@kde.org
Product|okular  |frameworks-kwidgetsaddons
   Assignee|okular-devel@kde.org|cf...@kde.org

--- Comment #1 from Kai Uwe Broulik  ---
Re-assigning to KWidgetsAddons where KMessageWidget comes from.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

Michael Weghorn  changed:

   What|Removed |Added

Version|unspecified |1.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #3 from Michael Weghorn  ---
I cannot reproduce the problem here.

Does it happen for every document you use? Can you attach one that is affected.

Does it happen when you choose "Print to File (PDF)" instead of a real printer?

In addition, it may be helpful to see what the CUPS log says. Can you do the
following:
* increase CUPS's log level by changing the "LogLevel" directive in
/etc/cups/cupsd.conf to "LogLevel debug"
* restart CUPS by running "sudo systemctl restart cups.service"
* try to print an A4 PDF document on an A4 page from Okular
* have a look and attach the CUPS log file /var/log/cups/error_log here

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #2 from Attila  ---
I tried it on Fedora 27 with Okular 1.2.1 and with the latest version 1.3.1.
It doesn't help. Same result.

-- 
You are receiving this mail because:
You are the assignee for the bug.