D10249: Option to exit after printing

[Dileep Sankhla]

dileepsankhla marked an inline comment as done.
dileepsankhla added a comment.


  @aacid I have talked about using std::exit instead of QCoreApplication::exit 
here : https://phabricator.kde.org/D10249#200260
  
  With that, I want to add QCoreApplication::exit does nothing if the event 
loop is not running. You can find the info in the docs here: 
http://doc.qt.io/qt-5/qcoreapplication.html#exit

INLINE COMMENTS

> aacid wrote in part.cpp:3212
> What is the value of isError when
> 
>   if ( printDialog->exec() )
> 
> returns false?

Undefined behavior - isError can either be true or false, my bad. Submitting a 
new patch.

> aacid wrote in part.cpp:3217
> We discussed a bit on IRC but i don't remeber which your reason for not using 
> QCoreApplication::exit were, can you please remind me?

I have talked about using std::exit instead of QCoreApplication::exit here : 
https://phabricator.kde.org/D10249#200260

With that, I want to add that QCoreApplication::exit does nothing if the event 
loop is not running. You can find the info in the docs here: 
http://doc.qt.io/qt-5/qcoreapplication.html#exit

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 390135] PDF render is slow

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=390135

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #3 from Henrik Fehlauer  ---
Marcel: It would be great if you could add the version of Poppler in use. You
can check with "rpm -qi libpoppler-qt5-1".

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> part.cpp:3217
> +if ( success && m_cliPrintAndExit )
> +exit ( EXIT_SUCCESS );
> +else if ( m_cliPrintAndExit )

We discussed a bit on IRC but i don't remeber which your reason for not using 
QCoreApplication::exit were, can you please remind me?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #23 from Michael Weghorn  ---
I can reproduce the issue much more easily by just running the following
command on host B:

$ lp -d tofile-hp -o "fit-to-page orientation-requested=0" d02917-001

The problem you encounter seems to be related to those two options being set
together.

I'm wondering where the "orientation-requested=0" option comes from.
The CUPS documentation [1]  just lists the values 3,4,5 and 6 for the
"orientation-requested" option.

At first glance, it does not seem like either Okular or Qt would be setting
anything for the "orientation-requested" option. ("git grep
orientation-requested" in the Okular and Qt git repositories did not show any
result.) For me, the option is not set at all either when when I print using
Okular on Fedora 26.

Is there any file $HOME/.cups/lpoptions or /etc/cups/lpoptions present on host
A?
Or do you have any other ideas where this option might come frome?


[1] https://www.cups.org/doc/options.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 388288] some thumbnail of pdf not shown in dolphin, some are shown

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=388288

--- Comment #14 from Albert Astals Cid  ---
The problem is that gs doesn't like that file

$ gs yourfile.pdf 
GPL Ghostscript 9.22 (2017-10-04)
Copyright (C) 2017 Artifex Software, Inc.  All rights reserved.
This software comes with NO WARRANTY: see the file PUBLIC for details.
    Error reading a content stream. The page may be incomplete.
   Output may be incorrect.
Error: /typecheck in --run--
Operand stack:
   --dict:4/13(L)--   --dict:5/14(L)--   --dict:5/14(L)--   2099   17483090  
2099   0   --nostringval--   Parent   --nostringval--   Type   Page   MediaBox 
 --nostringval--   Resources   --nostringval--   ColorSpace   --nostringval--  
CS0   --nostringval--   CS1   --nostringval--   Indexed   201   --nostringval--
  DeviceGray
Execution stack:
   %interp_exit   .runexec2   --nostringval--   --nostringval--  
--nostringval--   2   %stopped_push   --nostringval--   --nostringval--  
--nostringval--   false   1   %stopped_push   2015   1   3   %oparray_pop  
2014   1   3   %oparray_pop   1998   1   3   %oparray_pop   --nostringval--  
--nostringval--   --nostringval--   --nostringval--   --nostringval--  
--nostringval--   --nostringval--   --nostringval--   %array_continue  
--nostringval--   --nostringval--   --nostringval--   %array_continue  
--nostringval--   --nostringval--   --nostringval--   %array_continue  
--nostringval--   --nostringval--
Dictionary stack:
   --dict:983/1684(ro)(G)--   --dict:1/20(G)--   --dict:83/200(L)--  
--dict:83/200(L)--   --dict:133/256(ro)(G)--   --dict:301/450(ro)(G)--  
--dict:26/32(L)--   --dict:4/10(L)--
Current allocation mode is local
GPL Ghostscript 9.22: Unrecoverable error, exit code 1


You probably want to open a bug in https://bugs.ghostscript.com/ and report
that gs on that file fails, once that is resolved, the thumbnailer will work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 388288] some thumbnail of pdf not shown in dolphin, some are shown

[kts]

https://bugs.kde.org/show_bug.cgi?id=388288

--- Comment #13 from kts  ---
Done sending it.

-- 
You are receiving this mail because:
You are the assignee for the bug.