D10566: Add support for code tags in fictionbook

[Christoph Feck]

cfeck added a comment.


  Thanks for the patch!
  
  Please adjust the spaces around parents to follow the surrounding code.
  
  Bonus points if you also add the missing support for 'sup' and 'sub', as 
investigated in the bug ticket.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10566

To: abogical, #okular
Cc: cfeck, ngraham, michaelweghorn, simgunz, aacid

D9857: Smooth Scrolling

[Ronald Macmaster]

rmacmaster abandoned this revision.
rmacmaster added a comment.


  Sorry, I sort of abandoned this patch because I got caught up in other things.
  
* Smooth scrolling: Scrolling using the scroll wheel, arrow keys, 
PageUp/PageDown keys, or the spacebar will results in an animated transition 
effect rather than the view "jumping" to the new location 
* Pixel scrolling: Doing a two-finger scroll gesture on a touchpad scrolls 
scroll pixel-by pixel proportionally with your fingers' movement, rather than 
the movement being interpreted as a scroll wheel and advancing the view by a 
fixed or user-configurable number of lines
  
  Originally, I was going for the first implementation, where users have the 
option to enable / disable the animation.
  I was inspired by the Mozilla Firefox UI, which allows users to toggle 
"smooth scrolling" in their preferences with a checkbox option.
  
  Smooth scrolling seems to be a controversial feature. Some people love it, 
but others really hate it and don't understand why others love it.
  I'm one of those people who's addicted to his phone, so I've grown spoiled by 
mobile scrolling.
  On a phone,  you can hold your finger on the screen and drag the text 
line-by-line smoothly.
  Okular's instant scrolling is a little hard on my eyes when I read text at 
different zoom levels. 
  Sometimes I need to hit the arrow key multiple times to feed a single line of 
text. 
  Sometimes one keystroke is too little, but two keystrokes is too much.
  
  The patch I wrote is basic and filled with bugs.
  It does two things poorly (controlling step size and animating the scroll).
  This could possibly be solved by experimenting with the timers built into 
Okular, but a better approach is probably more along the lines of what you 
mentioned.
  I think the responsibility of enabling smooth scrolling should fall on the Qt 
widgets rather than the Okular scroll event processing functions.
  Qt has a QScrollBar widget. Perhaps a QSmoothScrollBar or an instance method 
with a boolean option to enable smooth scrolling could be added.
  I'm running KDE on Debian, so I don't have a system setting I can change to 
universally enable smooth scrolling like those on Ubuntu might.
  
  - Step Size
  
  Changing the step size might be a nice feature to add on its own. 
  It's simple and can be added as a configuration parameter with a default 
value of 20. 
  This would allow users to fiddle with the step size so that it works 
comfortably at their desired zoom level.
  A step size of 20 may work well for 100% zoom, but what about 150%, 80%, full 
screen?
  
  Here are some links showing demand for a smooth scrolling feature:
  
http://okular-devel.kde.narkive.com/ZM0xtQx4/okular-bug-319870-new-add-smooth-scrolling
  
https://askubuntu.com/questions/66489/is-there-a-way-to-enable-smooth-scrolling-for-pdfs

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9857

To: rmacmaster, okular-devel, #okular, ngraham
Cc: ngraham, #okular, michaelweghorn, simgunz, aacid

[okular] [Bug 169847] split view feature

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=169847

--- Comment #28 from Nate Graham  ---
Feel free to read the documentation I linked to, which  will help you find what
you're looking for!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D9857: Smooth Scrolling

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Finally got a chance to give this a whirl.
  
  First, let's make sure we're talking about the same thing, because scroll 
terminology can otherwise be a bit imprecise:
  
  - **Smooth scrolling:** Scrolling using the scroll wheel, arrow keys, 
PageUp/PageDown keys, or the spacebar will results in an animated transition 
effect rather than the view "jumping" to the new location
  - **Pixel scrolling:** Doing a two-finger scroll gesture on a touchpad 
scrolls scroll pixel-by pixel proportionally with your fingers' movement, 
rather than the movement being interpreted as a scroll wheel and advancing the 
view by a fixed or user-configurable number of lines
  
  Okular already does pixel scrolling, but does **not** do smooth scrolling. 
However, your patch also does not implement smooth scrolling; it allows the 
user to override the default number of "lines" per scroll wheel tick or arrow 
key press, and instead scroll by a user-configurable number of pixels.
  
  Without tweaking the "Scroll Step" parameter, scrolling using the arrow keys, 
scroll wheel, or touchpad becomes interminably slow. Increasing Scroll Step 
gradually  returns the behavior closer to the default.
  
  As currently implemented, I'm not sure what value this adds to the typical 
Okular user. I played with the new setting a bunch but all of the values felt 
worse than the default. Can you maybe describe your use case, and what value 
this brings to you?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9857

To: rmacmaster, okular-devel, #okular, ngraham
Cc: ngraham, #okular, michaelweghorn, simgunz, aacid

[okular] [Bug 169847] split view feature

[Musikolo]

https://bugs.kde.org/show_bug.cgi?id=169847

--- Comment #27 from Musikolo  ---
Sounds fair! Can you please pass me a link to the source code?

This said, I had no intention of pushing, because as you said, open source
software is all good will... ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 169847] split view feature

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=169847

--- Comment #26 from Nate Graham  ---
There's always a chance! But this is a mostly volunteer project, and it needs a
developer to do the work. You, maybe? ;)

https://community.kde.org/Get_Involved/development

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 169847] split view feature

[Musikolo]

https://bugs.kde.org/show_bug.cgi?id=169847

--- Comment #25 from Musikolo  ---
Is there any chance this feature gets eventually implemented? 

I'm asking because it was originally requested over 9 years ago, and I see
nothing that suggests it's coming anytime in the future.

Thank you and long live Okular!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389909] Allow dragging navigation panel to the right

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=389909

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=141289

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 141289] Allow navigation panel on the bottom instead of side

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=141289

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=389909

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389951] Add option to open new window/tab with the same document

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=389951

Christoph Feck  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Christoph Feck  ---
See also bug 339971.

*** This bug has been marked as a duplicate of bug 169847 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 169847] split view feature

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=169847

Christoph Feck  changed:

   What|Removed |Added

 CC||david.cortes.rivera@gmail.c
   ||om

--- Comment #24 from Christoph Feck  ---
*** Bug 389951 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10566: Add support for code tags in fictionbook

[Nathaniel Graham]

ngraham added a comment.


  Thanks for your patch! For the summary section, please see 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch for 
information about how to format the BUG: tag to connect this patch with the 
Bugzilla ticket.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10566

To: abogical, #okular
Cc: ngraham, michaelweghorn, simgunz, aacid

[okular] [Bug 387426] FB2 module do not display content inside tags

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387426

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387426] FB2 module do not display content inside tags

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=387426

--- Comment #2 from abogi...@gmail.com ---
patch pending approval:
https://phabricator.kde.org/D10566

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10566: Add support for code tags in fictionbook

[Abdel-Rahman A .]

abogical created this revision.
abogical added a reviewer: Okular.
Restricted Application added a project: Okular.
abogical requested review of this revision.

REVISION SUMMARY
  Fixes https://bugs.kde.org/show_bug.cgi?id=387426 


TEST PLAN
  Open this book  and verify 
that the code is visible in a monospace font.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10566

AFFECTED FILES
  generators/fictionbook/converter.cpp
  generators/fictionbook/converter.h

To: abogical, #okular
Cc: michaelweghorn, ngraham, simgunz, aacid

[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |UPSTREAM

--- Comment #36 from Michael Weghorn  ---
(In reply to Attila from comment #35)
> I have got great news.
> The following did it:
> 
> $ sudo systemctl stop cups-browsed.service
> $ sudo rm /var/cache/cups/cups-browsed-options-tofile-hp 
> $ sudo systemctl start cups-browsed.service
> 
> The file /var/cache/cups/cups-browsed-options-HPM880 doesn't contain
> "orientation-requested-default=no-value" any more.
> I can print and the output is as it should be. Great, isn't it?

Thanks for the update! I'm glad to hear this fixes the problem.
It actually is/was a cups-browsed problem then.


> Please leave this bug open for a couple of days, because I would like to
> monitor the result. I hope it will last for ever.

Please do leave a comment here what the result is and whether the problem
reappears.

However, I'm "officially" closing this bug report now, since the cause has been
found (and is outside Okular).
The fact that the bug is closed won't keep you from commenting and I'll also
get a notification regardless of whether the bug is closed or not, so I don't
think there's a real need to keep it open.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #35 from Attila  ---
I have got great news.
The following did it:

$ sudo systemctl stop cups-browsed.service
$ sudo rm /var/cache/cups/cups-browsed-options-tofile-hp 
$ sudo systemctl start cups-browsed.service

The file /var/cache/cups/cups-browsed-options-HPM880 doesn't contain
"orientation-requested-default=no-value" any more.
I can print and the output is as it should be. Great, isn't it?
Please leave this bug open for a couple of days, because I would like to
monitor the result. I hope it will last for ever.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke added a comment.


  In D10547#207085 , @ltoscano wrote:
  
  > (I can't comment on the content of the stream of the patches, but I think 
you don't need the [PATCH] in the title in any of them - they are clearly 
patches if they are defined here. And probably not even the (1/3) in the other 
patches)
  
  
  My intention with this is to make it obvious which differential is a 
standalone patch and which are parts of a series. But yes for standalone 
patches I will omit this. For a series I think it adds a bit clarity, 
especially if you exchange one patch in a series against another patch etc.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: ltoscano, michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Luigi Toscano]

ltoscano added a comment.


  (I can't comment on the content of the stream of the patches, but I think you 
don't need the [PATCH] in the title in any of them - they are clearly patches 
if they are defined here. And probably not even the (1/3) in the other patches)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: ltoscano, michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke created this revision.
aheinecke added a reviewer: Okular.
aheinecke added a project: Okular.
aheinecke requested review of this revision.

REVISION SUMMARY
  notifyFormChanged is called by documentcommands when
  Form fields are changed. E.g. by Undo / Redo.
  We need to recalculate after such changes.

TEST PLAN
  Tested with simple_calculate example.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

AFFECTED FILES
  core/document.cpp

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, simgunz, aacid

D10547: [PATCH] Recalculate forms after command form changes

[Andre Heinecke]

aheinecke added a task: T7805: Okular: Add support for JavaScript 
AFSimple_Calculate and textfield content calculation.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10547

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, simgunz, aacid

D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Andre Heinecke]

aheinecke marked 3 inline comments as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

[Andre Heinecke]

aheinecke updated this revision to Diff 27266.
aheinecke added a comment.


  Update to build event with non const page ref after change in D10073 


REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10048?vs=27257=27266

REVISION DETAIL
  https://phabricator.kde.org/D10048

AFFECTED FILES
  core/document.cpp
  core/document.h
  core/script/kjs_field.cpp
  ui/formwidgets.cpp
  ui/formwidgets.h

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz

D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Andre Heinecke]

aheinecke updated this revision to Diff 27264.
aheinecke added a comment.


  Use non const page refs for source and target page.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10073?vs=26760=27264

REVISION DETAIL
  https://phabricator.kde.org/D10073

AFFECTED FILES
  CMakeLists.txt
  core/script/event.cpp
  core/script/event_p.h
  core/script/executor_kjs.cpp
  core/script/executor_kjs_p.h
  core/script/kjs_event.cpp
  core/script/kjs_event_p.h
  core/script/kjs_field.cpp
  core/scripter.cpp
  core/scripter.h

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz

D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Andre Heinecke]

aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in kjs_field.cpp:222
> Or just don't store the page as const pointer?

I passed it as const as I only saw API in document to get a const page 
reference and recalculateForms also used a const reference.
But yes I see now that document private can easily access a non const page 
reference thorugh the page vector.

I'll change it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

[Andre Heinecke]

aheinecke updated this revision to Diff 27257.
aheinecke added a comment.


  Changed comment about version which added the new signal.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10048?vs=26761=27257

REVISION DETAIL
  https://phabricator.kde.org/D10048

AFFECTED FILES
  core/document.cpp
  core/document.h
  core/script/kjs_field.cpp
  ui/formwidgets.cpp
  ui/formwidgets.h

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/36/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Feb 2018 09:15:18 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest