D10974: PDF: Make the "fit-to-page" print option configurable

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#217646 , @aacid wrote:
  
  > so you worded point 4 and point 6 (second point 5) differently "the 
document is not scaled at all now." vs "The document is scaled to the full page 
size", i would not expect Force Rasterize to cause different behaviour.
  >
  > Is it just that you wrote it differently or does Force Rasterize actually 
change the behaviour of "Fit to printable area"?
  
  
  As of now, it actually does behave differently. The "Force rasterization" 
option does not use `FilePrinter`, but Qt's "normal way of printing" (which is 
why e.g. n-up-printing also behaves a little different there). For the "Force 
rasterization" case, the only thing that changes is whether the printer margin 
is taken into account or not. If you print an A4 document to A3 paper and 
unselecting the "Fit to printable area", currently
  
  - `FilePrinter` would not scale the document at all, thus leaving a lot of 
blank space on the printout.
  - The "force rasterization" option would scale the document to A3, ignoring 
the printer hardware margins.
  
  Thinking about this again, I think `FilePrinter` should react to the value 
returned by `QPrinter::fullPage()` in the same way as the "force rasterization" 
option, since this is what the option actually means [1]:
  
  > `void QPrinter::setFullPage(bool fp)`
  >  If fp is true, enables support for painting over the entire page; 
otherwise restricts painting to the printable area reported by the device.
  
  Rather than not setting the "fit-to-page" option, the margins should not be 
set in FilePrinter in this case.
  
  When document page size and the printer's page size is the same, this does 
not make any difference as compared to not setting the `fit-to-page` option. 
But it does make a diference when the two page sizes do not match (as described 
above).
  
  What do you think?
  
  1: http://doc.qt.io/qt-5/qprinter.html#fullPage

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: aacid, ngraham, michaelweghorn

[okular] [Bug 391363] okular crashes when refreshing deleted document

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=391363

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #1 from Henrik Fehlauer  ---
Thanks for the report, but cannot reproduce.

Does this happen for every file and every storage location? Which Okular +
Poppler version is this? Could you provide a backtrace?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=381328

--- Comment #5 from Henrik Fehlauer  ---
Would "protocol" be a more appropriate terminology? Regardless, let's focus on
the crash in this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #11 from Zakhar  ---
It was enabled without me knowing it. Is there a bug to fix zooming with trim
margins enabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391363] New: okular crashes when refreshing deleted document

[Andrius Štikonas]

https://bugs.kde.org/show_bug.cgi?id=391363

Bug ID: 391363
   Summary: okular crashes when refreshing deleted document
   Product: okular
   Version: unspecified
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: andr...@stikonas.eu
  Target Milestone: ---

Okular crashes here when I:

1) Open PDF file
2) delete it
3) Click F5 in Okular

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=381328

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
Henrik where did you get a zip ioslave from?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #10 from Albert Astals Cid  ---
(In reply to Zakhar from comment #9)
> Just found were trim margins is disabled it and no issue. 

You mean you had it enabled and when you disabled it the bug is gone?

> This IS a
> legitimate bug, the least that can be done is ship Okular with trim margins
> disabled.

Trim Margins is disabled by default, you must have enabled it at some point.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #9 from Zakhar  ---
Just found were trim margins is disabled it and no issue. This IS a legitimate
bug, the least that can be done is ship Okular with trim margins disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10867: [3/5] Add support to set read only from scripts

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> form.h:90
>  /**
> + * Whether the field is read-only.
> + */

missing since marker

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10867

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #8 from Albert Astals Cid  ---
(In reply to Zakhar from comment #5)
> No, not to my knowledge.

Maybe your knowledge is wrong, could you please check?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #7 from Zakhar  ---
Rest of the pages seem to work well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #6 from Zakhar  ---
The first page is the non zoom out page.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #5 from Zakhar  ---
No, not to my knowledge.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10865: [1/5] Access readOnly state of FormWidgets dynamically

[Albert Astals Cid]

aacid added a comment.


  BTW next time  please use arc so phabricator shows the context of the diff.

INLINE COMMENTS

> formwidgets.cpp:304
>  m_widget->clearFocus();
> -m_widget->setVisible( visible );
> +m_widget->setVisible( visible && !m_ff->isReadOnly() );
>  return hadfocus;

i would really prefer this to be moved to whoever calls setVisiblity, it's kind 
of weird for setVisiblity to sometimes not do what you ask it to do.

> formwidgets.cpp:310
>  {
> -m_widget->setEnabled( fill && m_canBeEnabled );
> +m_widget->setEnabled( fill && !m_ff->isReadOnly() );
>  }

Do we need this at all? the widget won't ge visible when it's readonly, so what 
do we care if it's enabled or not?

> aheinecke wrote in pageview.cpp:1002
> Without this change the PartTest::testSaveAsUndoStackForms would segfault 
> because the underlying fields are destroyed but setCanBeFilled now accesses 
> them to check for readOnly.

If we remove the use of visiblity as i commented already we can get this back 
to how it was?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10865

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #4 from Albert Astals Cid  ---
I can mouse wheel zoom just fine in that file.

Ah wait are you using Trim Margins? Don't do that, it's buggy.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #3 from Zakhar  ---
Okular 17.12.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

--- Comment #2 from Zakhar  ---
Sure, download here because it exceeds size limit:
https://nofile.io/f/GkbszdO37C2/Pentagon+Aliens+William+Lyne.pdf

totally reproducible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] Okular does not zoom out with mouser wheel.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=391352

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Which version are you running?

Can you attach a document you have this problem with?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391352] New: Okular does not zoom out with mouser wheel.

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=391352

Bug ID: 391352
   Summary: Okular does not zoom out with mouser wheel.
   Product: okular
   Version: unspecified
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: zakhar.nasi...@gmail.com
  Target Milestone: ---

Steps to reproduce:
-Open PDF with few pages
-Zoom out with mousewheel

Results: Does not zoom out past current zoom setting, or at least 1 step after
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10974: PDF: Make the "fit-to-page" print option configurable

[Albert Astals Cid]

aacid added a comment.


  so you worded point 4 and point 6 (second point 5) differently "the document 
is not scaled at all now." vs "The document is scaled to the full page size", i 
would not expect Force Rasterize to cause different behaviour.
  
  Is it just that you wrote it differently or does Force Rasterize actually 
change the behaviour of "Fit to printable area"?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: aacid, ngraham, michaelweghorn

[okular] [Bug 201092] Drag to scroll in Okular's text mode and KDE wide

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=201092

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Albert Astals Cid  ---
Please describe what you want more clearly, because by reading "PDF drag to
scroll even when the text selection mode is activated" i don't understand what
you want.

Describe it step by step, what would you do as a user and what/how you think
Okular should react.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 201092] Drag to scroll in Okular's text mode and KDE wide

[Ben Creasy]

https://bugs.kde.org/show_bug.cgi?id=201092

Ben Creasy  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |okular-devel@kde.org
  Component|general |general
 CC||b...@bencreasy.com
Product|kde |okular

--- Comment #1 from Ben Creasy  ---
Moving this to Okular for now

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/48/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Mar 2018 17:02:26 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

[okular] [Bug 342927] More Vim-like shortcuts

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=342927

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
   Keywords|junior-jobs |

--- Comment #5 from Albert Astals Cid  ---
so gg and G you can change on the shortcut settings on the settings menu.

The rest of shortcuts seems there's not much agreement here of what they should
be and what they should do, since like 4 people commented and the 4 had
different opitnions. i'm going to put it to needs info, and you try to reach
into an agreement and then maybe we'll give it a try at implementing them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/47/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Mar 2018 16:35:05 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D10249: Option to exit after printing

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:09b7b079ac92: Option to exit after printing (authored by 
dileepsankhla, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10249?vs=28360=28500#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=28360=28500

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/09b7b079ac92bd1da7bac6b
   ||04e2bed139506f2f8
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #27 from Albert Astals Cid  ---
Git commit 09b7b079ac92bd1da7bac6b04e2bed139506f2f8 by Albert Astals Cid, on
behalf of Dileep Sankhla.
Committed on 03/03/2018 at 16:36.
Pushed by aacid into branch 'master'.

Option to exit after printing

Summary:
When running okular with the parameter --print to directly open the print mode,
it doesn't exit after acknowledging the print dialog. Hence adding
--print_and_exit option exits Okular after acknowledging the print dialog and
thus is useful for the command line batch processing or a Dolphin service as
the issue suggests.

Test Plan:
1. open a file in Okular using the parameter --print. It will open Okular in
print mode with the print dialog
2. Either print the file or cancel the print dialog
3. You will find that Okular stays open
4. Now using this patch, see for available options with the --help parameter.
You will find --print_and_exit option
5. Now open a file in Okular using the parameter --print_and_exit. It will open
Okular in print mode with the print dialog
6. Either print the file or cancel the print dialog
7. You will find that Okular closes after acknowledging the dialog

Reviewers: aacid, #okular, ngraham

Subscribers: ltoscano, ngraham, aacid, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D10249

M  +11   -11   autotests/mainshelltest.cpp
M  +19   -4part.cpp
M  +3-1part.h
M  +1-0shell/main.cpp
M  +2-0shell/shell.cpp
M  +22   -13   shell/shellutils.cpp
M  +3-2shell/shellutils.h

https://commits.kde.org/okular/09b7b079ac92bd1da7bac6b04e2bed139506f2f8

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks good now :)

REPOSITORY
  R223 Okular

BRANCH
  fixing

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 350366] Tree view search bar in left side bar is not searching root items of the tree view.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=350366

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.