D11051: Remembering side navigation panel state

[Dileep Sankhla]

dileepsankhla added a comment.


  https://paste.kde.org/pepnfuzxq 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: aacid, sander, #okular, michaelweghorn, ngraham

D11051: Remembering side navigation panel state

[Albert Astals Cid]

aacid added a comment.


  In D11051#237655 , @dileepsankhla 
wrote:
  
  > Following is the log of running valgrind on okular:
  >
  > https://paste.kde.org/pmyjdscmw/ohzvag 

  
  
  This paste is password protected, why did you do that?
  
  Can you please paste it again without a password?
  
  > I have no luck in understanding the verbose. May you please help me by 
checking it out?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: aacid, sander, #okular, michaelweghorn, ngraham

[okular] [Bug 392463] Okular segfaults all the time when used with emacs/latex

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392463

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Can you provide a backtrace?

Read
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
if you do not understand what backtrace means or how to get one

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392537] All toolbars should be movable, and it would be nice to have toolbar modes for wide image on narrow display, and narrow image on wide display.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392537

Albert Astals Cid  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10792: Raise annotation window when clicking on annotation

[Albert Astals Cid]

aacid added a comment.


  In D10792#237792 , @simgunz wrote:
  
  > I have few questions regarding the internal structure of okular and how to 
write autotests:
  >
  > 1. To click on an annotation to open the annotation window I though to do 
the following (partially copied from other tests):
  >
  >   ``` const int width =  part.m_pageView->horizontalScrollBar()->maximum() 
+ part.m_pageView->viewport()->width(); const int height = 
part.m_pageView->verticalScrollBar()->maximum() + 
part.m_pageView->viewport()->height();
  >
  >   NormalizedPoint pt = annot1->boundingRectangle().center();
  >
  >   QTest::mouseDClick(part.m_pageView->viewport(), Qt::LeftButton, 
Qt::NoModifier, QPoint(width * pt.x,  height * pt.y)); ```
  >
  >   but in this way I don't correctly click on the annotation. For now I 
manually set the QPoint to hit correctly the annotation.
  >
  >   I don't understand what the normalized area where a NormalizedPoint can 
be corresponds to. Can someone explain me better this mechanics?
  
  
  On a quick look i feel it should work.
  
  What you don't understand about NormalizedXXX, they are basically a 0 to 1 
representation of the position of something on the page
  
  > Why is width equal to the maximum value of the scrollbar plus the viewport?
  
  So let's say your content is 1000 wide, and your viewport is 700 wide, what 
will be the maximum value of your scroll bar? 300
  
  So if you want to know the width of the content you add up 700 and 300
  
  Does this make sense?
  
  > 2. When I run an autotest I saw a window appearing showing the file opened 
in okular. I cannot interact with this window though.
  
  Sure you can
  
  > What is the purpose of that?
  
  That is the purpose of what?
  
  > How can I have a visual feedback on the code I am writing in the autotest?
  
  Not sure i understand the question, you mean you want to look at the window? 
  Add QTest::qWait(someseonds)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10792

To: simgunz, #okular, aacid
Cc: ngraham, #okular, michaelweghorn, aacid

D10792: Raise annotation window when clicking on annotation

[Albert Astals Cid]

aacid added a comment.


  In D10792#237224 , @simgunz wrote:
  
  > Ok. I figured it out myself.
  >
  > I need to export `AnnotWindow` (add `OKULARCORE_EXPORT` to the class 
`AnnotWindow`)  if I want to use `findChild` to retrieve it. I am not sure if 
this should be exported just for the autotest. Maybe  there is an alternative 
method to avoid this.
  
  
  Do you need AnnotWindow itself? Probably you're just fine searching/using 
QFrame (its parent class)? In this case you don't need to export AnnowWindow.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10792

To: simgunz, #okular, aacid
Cc: ngraham, #okular, michaelweghorn, aacid

D10792: Raise annotation window when clicking on annotation

[Simone Gaiarin]

simgunz added a comment.


  I have few questions regarding the internal structure of okular and how to 
write autotests:
  
  1. To click on an annotation to open the annotation window I though to do the 
following (partially copied from other tests):
  
const int width =  part.m_pageView->horizontalScrollBar()->maximum() +
   part.m_pageView->viewport()->width();
const int height = part.m_pageView->verticalScrollBar()->maximum() +
   part.m_pageView->viewport()->height();

NormalizedPoint pt = annot1->boundingRectangle().center();

QTest::mouseDClick(part.m_pageView->viewport(), Qt::LeftButton, 
Qt::NoModifier, QPoint(width * pt.x,  height * pt.y));
  
  but in this way I don't correctly click on the annotation. For now I manually 
set the QPoint to hit correctly the annotation.
  
  I don't understand what the normalized area where a NormalizedPoint can be 
corresponds to. Can someone explain me better this mechanics?
  
  Why is width equal to the maximum value of the scrollbar plus the viewport?
  
  2. When I run an autotest I saw a window appearing showing the file opened in 
okular. I cannot interact with this window though. What is the purpose of that? 
How can I have a visual feedback on the code I am writing in the autotest?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10792

To: simgunz, #okular, aacid
Cc: ngraham, #okular, michaelweghorn, aacid

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

[Simone Gaiarin]

https://bugs.kde.org/show_bug.cgi?id=353401

--- Comment #22 from Simone Gaiarin  ---
I cannot comment about the technicalities of poppler, but I agree that both
TypeWriter and Inline note need a better WYSIWIG than a popup widget.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11051: Remembering side navigation panel state

[Dileep Sankhla]

dileepsankhla added a comment.


  Following is the log of running valgrind on okular:
  
  https://paste.kde.org/pmyjdscmw/ohzvag 

  
  I have no luck in understanding the verbose. May you please help me by 
checking it out?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: aacid, sander, #okular, michaelweghorn, ngraham

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=353401

--- Comment #21 from Tobias Deiminger  ---
> typewriter tool is to write text without any background anywhere (e.g to fill 
> forms)
> inline notes are to add post-its like notes in the document (with a 
> background)

Yeah, nice sum up, thanks!

Can we agree that both are for different user intent, but are technically
almost the same? I mean, both are FreeText annotations under the hood (one with
IT=FreeText, the other one with IT=FreeTextTypeWriter).

And both share the problem, that if we care for true WYSIWIG live editing we
can't simply use a KTextEdit widget, because it could only approximate what we
get in the end. We'd need something similar, but generator/poppler has to do
the rendering. Such generator-rendered widgets would be a new concept in
Okular, and they would need finer grained interaction of Okular <=> Poppler
than what's currently possible. Patch [0] is a start, but may still not be
enough. Do we care?

[0] https://bugs.freedesktop.org/show_bug.cgi?id=105796

-- 
You are receiving this mail because:
You are the assignee for the bug.