KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

2018-05-16 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/8/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 17 May 2018 01:36:47 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 34335.
apol added a comment.


  Remove hardcoded path

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34297=34335

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-05-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #8 from Albert Astals Cid  ---
Most probably

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #9 from Christoph Feck  ---
Erik, did comment #8 help to resolve the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #7 from Christoph Feck  ---
Duplicate of bug 394226?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394226] Okular having random crash (archlinux)

2018-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=394226

Christoph Feck  changed:

   What|Removed |Added

Version|unspecified |1.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394226] Okular having random crash (archlinux)

2018-05-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394226

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
This is with 99.99% probability not Okular's fault.

I've opened bugs in gstreamer and pulseaudio for it, my backtrace is not the
same as yours but since it's also pulseaudio/gstreamer related i have a hunch
it's the same thing

https://bugzilla.gnome.org/show_bug.cgi?id=796162
https://bugs.freedesktop.org/show_bug.cgi?id=106540

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Albert Astals Cid
aacid added inline comments.

INLINE COMMENTS

> main.qml:33
> +titleIcon: "okular"
> +bannerImageSource: 
> "file:///home/apol/devel/kde5/share/wallpapers/Next/contents/images/1920x1080.png"
> +

That path is WHAAAT

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


D11723: Add FormFieldSignature to Okular namespace

2018-05-16 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34307.
chinmoyr added a comment.


  Removed code unrelated to this revision.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=30645=34307

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  core/form.cpp
  core/form.h
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid


[okular] [Bug 394336] Okular snap package cannot print files

2018-05-16 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=394336

Harald Sitter  changed:

   What|Removed |Added

   Assignee|okular-devel@kde.org|sit...@kde.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
 CC||sit...@kde.org

--- Comment #1 from Harald Sitter  ---
I have a look at it. I do not understand the way this works internally, but
this may well be a solvable problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394336] Okular snap package cannot print files

2018-05-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=394336

ostrok...@gmail.com changed:

   What|Removed |Added

URL||https://forum.snapcraft.io/
   ||t/okular-package-cannot-pri
   ||nt-files/5455/4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394336] New: Okular snap package cannot print files

2018-05-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=394336

Bug ID: 394336
   Summary: Okular snap package cannot print files
   Product: okular
   Version: 1.1.3
  Platform: Mint (Ubuntu based)
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: ostrok...@gmail.com
  Target Milestone: ---

Trying to print a PDF document using okular installed as a snap package on
linux mint 18.3 produces an error:

```
Could not print the document. Detailed error is "Could not find a suitable
binary for printing. Make sure CUPS lpr binary is available". Please report to
bugs.kde.org
```

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol marked an inline comment as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 34297.
apol added a comment.


  Don't add logic in core/ just in case

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34168=34297

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


D12884: Remove the internal file navigation from the global drawer

2018-05-16 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> aacid wrote in document.cpp:2362
> I don't think it's a good idea changing the behaviour, can't you fix the 
> mobile app to do the right thing?

Sure, I did it because it feels like broken API. It just complains and doesn't 
do anything when you openDocument twice.
Will move into the QtQuick side.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


D10455: Add RTL support for search, copy & paste in pdf

2018-05-16 Thread Fahad Al-Saidi
fahadalsaidi added a comment.


  In D10455#263014 , @ngraham wrote:
  
  > @fahadalsaidi, are you able to work on those?
  
  
  Sorry, I don't have  knowledge & time to fix the memory leaks. For the other 
question , I've already answered, here is it:
  
  >   The other back-ends have many problem not related to this patch as 
following:
  > 
  > - xps: okular crash when open arabic xps file and if it can open it, it 
renders it in wrong way.
  > - dejuv: searching & copying Arabic text are fine since dejuv back-end has 
it own search function.
  > - odt: there is broken in LTR or RTL. There is no text to search at all.
  > - chm: Although okular can open it but searching is bad for LTR & RTL text, 
it is basically broken.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: okular-devel, chfanzil, ngraham, aacid