[okular] [Bug 394429] New: Okular crashed after reboot

https://bugs.kde.org/show_bug.cgi?id=394429 Bug ID: 394429 Summary: Okular crashed after reboot Product: okular Version: 1.4.1 Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED Keywords: drkonqi

D10974: PDF: Allow to ignore print margins

michaelweghorn added a comment. In D10974#264672 , @aacid wrote: > [...] > The feature it's not really "Fit to printable area", it's more "Take Margins into account" or if we negate it "Ignore printer margins", because "printable area" is

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Applications okular kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 15:28:05 + Build duration: 48 min and counting JUnit Tests

D7662: Draw a dark rectangle around highlighted search results

This revision was automatically updated to reflect the committed changes. Closed by commit R223:004efa70e4a7: Draw a dark rectangle around highlighted search results (authored by sander, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7662?vs=21180=34440#toc

[okular] [Bug 355043] Cannot differentiate between review and search highlights

https://bugs.kde.org/show_bug.cgi?id=355043 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest

D7662: Draw a dark rectangle around highlighted search results

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. That is a fix, not the ideal fix, now that i've had time to look at the problem, the problem is. Basically that we're writting in the "buffered" area of the painter, which means we

D11725: [RFC] Show signature status as a popup

chinmoyr added a comment. In D11725#264703 , @aacid wrote: > This doesn't work anymore right? signValidationInfoList doesn't exist in D11723 It requires revision 30645 to work. REPOSITORY R223

Queries regarding adding a new 'typewriter' annotation tool to the toolbar

Hello everyone, I'm working on my GSoC project[0] with my mentor Tobias Deiminger and I need to add a new 'typewriter' tool to the annotation toolbar with a new icon and a setting dialogue to customize its font [and font color]. I have few things to ask before getting

D11725: [RFC] Show signature status as a popup

aacid added a comment. Restricted Application added a subscriber: okular-devel. This doesn't work anymore right? signValidationInfoList doesn't exist in D11723 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11725 To: chinmoyr,

D10974: PDF: Allow to ignore print margins

aacid added a comment. Actually on a second read of the texts i'm not sure i like them. The feature it's not really "Fit to printable area", it's more "Take Margins into account" or if we negate it "Ignore printer margins", because "printable area" is the area of the page where the

D10974: PDF: Allow to ignore print margins

aacid added a comment. Restricted Application added a subscriber: okular-devel. Looks good, i'm going to try to make the PrintScalingOptionWidget be shown for all the formats and not only for PDF before commiting, should "hopefully" not be very hard. REPOSITORY R223 Okular REVISION

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/12/ Project: Applications okular kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 13:18:28 + Build duration: 26 min and counting JUnit Tests

D11723: Add FormFieldSignature to Okular namespace

aacid added a comment. I understand you're mimicing the poppler API at some points but that doesn't always makes sense since poppler is a multi-purpose library and okular is a document viewer. INLINE COMMENTS > form.cpp:284 > + > +void setValue( const QString& v ) override > +

D10792: Raise annotation window when clicking on annotation

This revision was automatically updated to reflect the committed changes. Closed by commit R223:48b9ca66a6fd: Raise annotation window when clicking on annotation (authored by simgunz, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10792?vs=33907=34434#toc REPOSITORY

[okular] [Bug 388532] Clicking a popup note icon should bring the popup note to the top

https://bugs.kde.org/show_bug.cgi?id=388532 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|

D10792: Raise annotation window when clicking on annotation

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R223 Okular BRANCH raise-annotation-window REVISION DETAIL https://phabricator.kde.org/D10792 To: simgunz, #okular, aacid Cc: okular-devel, ngraham, #okular, aacid

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Applications okular kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 12:42:38 + Build duration: 2 min 16 sec and counting JUnit Tests

D12825: Fix recalculating forms twice

aacid added a comment. Will you upload an updated patch or should i just do it ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12665: Support additional widget actions in PDF Forms

aacid added inline comments. Restricted Application added a subscriber: okular-devel. INLINE COMMENTS > CMakeLists.txt:86 >l->nextLinks(); > + f->additionalAction(Poppler::Annotation::CursorEnteringAction); > } You need to move this to a whole new block since it has to be in a check for

D12825: Fix recalculating forms twice

aheinecke added a comment. Ugh, Sorry for overlooking these. Yes. They also call notifyFormChanges in their redo. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aacid added a comment. Should we remove the recalculateForms from editFormList and editFormCombo too then? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid