D13203: Add Typewriter annotation tool in Okular
dileepsankhla updated this revision to Diff 35383. dileepsankhla added a comment. Updating annotation popup window background color REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35333=35383 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13203 AFFECTED FILES conf/editannottooldialog.cpp conf/editannottooldialog.h core/annotations.cpp ui/annotationpropertiesdialog.cpp ui/annotationwidgets.cpp ui/annotationwidgets.h ui/annotwindow.cpp ui/data/CMakeLists.txt ui/data/sources/tool-typewriter-okular-colorizable.svgz ui/data/tool-typewriter-okular-colorizable.png ui/data/tool-typewriter-okular-coloriza...@2x.png ui/data/tools.xml ui/guiutils.cpp ui/pagepainter.cpp ui/pageviewannotator.cpp To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
dileepsankhla reopened this revision. dileepsankhla marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
dileepsankhla marked an inline comment as done. dileepsankhla added a comment. The revision is closed. I'm unable to update it. Maybe someone with admin privileges should reopen it? INLINE COMMENTS > tobiasdeiminger wrote in annotwindow.cpp:262 > `QColor(m_annot->style().color().name())` is a bit arcane way of saying > "force alpha of the popup window background color to 1.0" If that's what > you've actually intended? > > How about removing const of newcolor (not bad, local scope only) and do > `newcolor.setAlpha(1.);`? > Or something like > > const QColor newcolor = m_annot->style().color().isValid() ? > QColor(m_annot->style().color().red(), m_annot->style().color().green(), > m_annot->style().color().blue(), 255) : Qt::yellow; > > if you want to keep const. That would be more explicit and obvious. > > Btw., sorry for commenting on an older revision. But ui/annotwindow.cpp is > not included in the latest revision. Phabricator seems to be a bit too smart > for our intended workflow. I agree. It should be straightforward without any latent meaning. Updating the revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.10/6/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 01 Jun 2018 22:50:59 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest
[okular] [Bug 394926] New: Okular crash
https://bugs.kde.org/show_bug.cgi?id=394926 Bug ID: 394926 Summary: Okular crash Product: okular Version: 1.4.1 Platform: unspecified OS: Linux Status: UNCONFIRMED Keywords: drkonqi Severity: crash Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: prote...@hotmail.it Target Milestone: --- Application: okular (1.4.1) Qt Version: 5.10.0 Frameworks Version: 5.46.0 Operating System: Linux 4.13.0-43-generic x86_64 Distribution: KDE neon User Edition 5.12 -- Information about the crash: - What I was doing when the application crashed: I was selcting the title of the PDF docuent on the list of titles whose page I wanted to view so the program crashed. The docment I was viewing concerned with the manual of my motherboard downloaded from asus site, that is the mximus extreme. -- Backtrace: Application: Okular (okular), signal: Segmentation fault Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". [Current thread is 1 (Thread 0x7f83a2b7f900 (LWP 16413))] Thread 2 (Thread 0x7f8385ecd700 (LWP 16416)): #0 0x7f839e94874d in poll () at ../sysdeps/unix/syscall-template.S:84 #1 0x7f83996fa38c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #2 0x7f83996fa49c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #3 0x7f839f27b5db in QEventDispatcherGlib::processEvents (this=0x7f8388e0, flags=...) at kernel/qeventdispatcher_glib.cpp:425 #4 0x7f839f22265a in QEventLoop::exec (this=this@entry=0x7f8385eccc90, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212 #5 0x7f839f042554 in QThread::exec (this=) at thread/qthread.cpp:522 #6 0x7f839f69e2c5 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5 #7 0x7f839f0476eb in QThreadPrivate::start (arg=0x7f839f912d60) at thread/qthread_unix.cpp:376 #8 0x7f839b8bb6ba in start_thread (arg=0x7f8385ecd700) at pthread_create.c:333 #9 0x7f839e95441d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 Thread 1 (Thread 0x7f83a2b7f900 (LWP 16413)): [KCrash Handler] #6 Okular::Page::number (this=this@entry=0x18) at /workspace/build/core/page.cpp:157 #7 0x7f83849acd42 in Okular::Part::showMenu (this=0x24be4e0, page=0x18, point=..., bookmarkTitle=..., vp=...) at /workspace/build/part.cpp:2947 #8 0x7f839f2517c6 in QtPrivate::QSlotObjectBase::call (a=0x7ffdc6504850, r=0x24be4e0, this=) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:378 #9 QMetaObject::activate (sender=sender@entry=0x24f6be0, signalOffset=, local_signal_index=local_signal_index@entry=1, argv=argv@entry=0x7ffdc6504850) at kernel/qobject.cpp:3749 #10 0x7f839f251da7 in QMetaObject::activate (sender=sender@entry=0x24f6be0, m=m@entry=0x7f8384cb3b80 , local_signal_index=local_signal_index@entry=1, argv=argv@entry=0x7ffdc6504850) at kernel/qobject.cpp:3628 #11 0x7f8384a4d01f in TOC::rightClick (this=this@entry=0x24f6be0, _t1=..., _t2=..., _t3=...) at /workspace/build/obj-x86_64-linux-gnu/moc_toc.cpp:162 #12 0x7f8384a4d1d7 in TOC::contextMenuEvent (this=0x24f6be0, e=0x7ffdc6504ab0) at /workspace/build/ui/toc.cpp:187 #13 0x7f83a04c3c73 in QWidget::event (this=0x24f6be0, event=0x7ffdc6504ab0) at kernel/qwidget.cpp:8995 #14 0x7f83a0483acc in QApplicationPrivate::notify_helper (this=, receiver=0x24f6be0, e=0x7ffdc6504ab0) at kernel/qapplication.cpp:3732 #15 0x7f83a048bc0e in QApplication::notify (this=, receiver=0x25a45e0, e=0x7ffdc6504c70) at kernel/qapplication.cpp:3352 #16 0x7f839f2243d8 in QCoreApplication::notifyInternal2 (receiver=0x25a45e0, event=0x7ffdc6504c70) at kernel/qcoreapplication.cpp:1044 #17 0x7f839f224422 in QCoreApplication::forwardEvent (receiver=receiver@entry=0x25a45e0, event=event@entry=0x7ffdc6504c70, originatingEvent=originatingEvent@entry=0x7ffdc6505070) at kernel/qcoreapplication.cpp:1059 #18 0x7f83a04dd09f in QWidgetWindow::handleMouseEvent (this=this@entry=0x28e7e70, event=event@entry=0x7ffdc6505070) at kernel/qwidgetwindow.cpp:662 #19 0x7f83a04df97b in QWidgetWindow::event (this=0x28e7e70, event=0x7ffdc6505070) at kernel/qwidgetwindow.cpp:273 #20 0x7f83a0483acc in QApplicationPrivate::notify_helper (this=, receiver=0x28e7e70, e=0x7ffdc6505070) at kernel/qapplication.cpp:3732 #21 0x7f83a048b417 in QApplication::notify (this=0x7ffdc6505400, receiver=0x28e7e70, e=0x7ffdc6505070) at kernel/qapplication.cpp:3491 #22 0x7f839f2243d8 in QCoreApplication::notifyInternal2 (receiver=receiver@entry=0x28e7e70, event=event@entry=0x7ffdc6505070) at kernel/qcoreapplication.cpp:1044 #23 0x7f839fcdc020 in QCoreApplication::sendSpontaneousEvent (event=0x7ffdc6505070, receiver=0x28e7e70) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:237 #24 QGuiApplicationPrivate::processMouseEvent (e=0x2a9c0c0) at kernel/qguiapplication.cpp:1973 #25
D13203: Add Typewriter annotation tool in Okular
tobiasdeiminger added inline comments.
INLINE COMMENTS
> annotwindow.cpp:262
> {
> -const QColor newcolor = m_annot->style().color().isValid() ?
> m_annot->style().color() : Qt::yellow;
> +const QColor newcolor = m_annot->style().color().isValid() ?
> QColor(m_annot->style().color().name()) : Qt::yellow;
> if ( newcolor != m_color )
`QColor(m_annot->style().color().name())` is a bit arcane way of saying "force
alpha of the popup window background color to 1.0" If that's what you've
actually intended?
How about removing const of newcolor (not bad, local scope only) and do
`newcolor.setAlpha(1.);`?
Or something like
const QColor newcolor = m_annot->style().color().isValid() ?
QColor(m_annot->style().color().red(), m_annot->style().color().green(),
m_annot->style().color().blue(), 255) : Qt::yellow;
if you want to keep const. That would be more explicit and obvious.
Btw., sorry for commenting on an older revision. But ui/annotwindow.cpp is not
included in the latest revision. Phabricator seems to be a bit too smart for
our intended workflow.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D13203
To: dileepsankhla
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
dileepsankhla added a comment. Hell! Sorry for this mistake again. Whenever I update the revision, I push the commit to the gsoc2018_typewriter branch too and the revision landed in need review state by that commit (both have the same hash). @ltoscano May you please reopen this revision? Should I push the commit to the gsoc branch or not? I usually update revision in this manner: 1. `git branch` *gsoc2018_typewriter master 2. `vim file.cpp` 3. `git commit -m "msg"` 4. `git checkout master` 5. `git merge gsoc2018_typewriter` 6. `arc diff --update D13203` It sends two new commit, one created in the gsoc branch and one at the point of merging to master branch 7. `git reset --hard ` Here is the last commit before merging gsoc2018_typewriter branch 8. `git checkout gsoc2018_typewriter` 9. `git push origin gsoc2018_typewriter` And finally, pushing the commit to origin/gsoc2018_typewriter branch. Can you suggest me where I'm wrong? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:f0063e548b1b: Fixed initial typewriter width to 0 (authored by dileepsankhla). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13203?vs=35332=35333#toc REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35332=35333 REVISION DETAIL https://phabricator.kde.org/D13203 AFFECTED FILES ui/data/tools.xml To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
dileepsankhla updated this revision to Diff 35332. dileepsankhla added a comment. Fixed initial typewriter border width to 0 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35240=35332 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13203 AFFECTED FILES conf/editannottooldialog.cpp conf/editannottooldialog.h core/annotations.cpp ui/annotationpropertiesdialog.cpp ui/annotationwidgets.cpp ui/annotationwidgets.h ui/annotwindow.cpp ui/data/CMakeLists.txt ui/data/sources/tool-typewriter-okular-colorizable.svgz ui/data/tool-typewriter-okular-colorizable.png ui/data/tool-typewriter-okular-coloriza...@2x.png ui/data/tools.xml ui/guiutils.cpp ui/pagepainter.cpp ui/pageviewannotator.cpp To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
D13203: Add Typewriter annotation tool in Okular
tobiasdeiminger added a comment. Typewriter annotations created with the initial typewriter tool have a border of width=1 (Okular started without existing okularpartrc). But we always want border width = 0 for typewriter, is it? It could even be hardcoded into drawing code. This is because you set width = 0 only for EditAnnotToolDialog::m_stubann. But the initial tool entry created out of tools.xml does not use this stub annotation to determine properties. Only further typewriter tools created with the EditAnnotTool config dialog use the stub annotation. So my okularpartrc looks like this: [Reviews] AnnotationTools=[...], As you see, only the second typewriter has width=0. The first uses default width (=1). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
[okular] [Bug 394917] New: Confusing message about ‘internal storage’
https://bugs.kde.org/show_bug.cgi?id=394917 Bug ID: 394917 Summary: Confusing message about ‘internal storage’ Product: okular Version: 1.3.3 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: k...@equaeghe.nospammail.net Target Milestone: --- I opened a pdf file with a form that I had filled with an earlier version of okular and got the message "This document contains annotations or form data that were saved internally by a previous Okular version. Internal storage is no longer supported. Please save to a file in order to move them if you want to continue to edit the document." It is not clear at all what is meant by ‘internal storage’. I first thought it was ‘internal to the pdf’. It is only after searching on-line that it referred to ‘internal to okular configuration files’ *external* to the file. (I didn't even know okular did that. It explains a lot of trouble I had with filling in forms with okular and not being able to get rid of ‘zombie data’.) The current message is totally confusing and should be replaced with something that is not confusing and also indicates where the data is stored ‘internally’. I suggest something like the following: "For this document, annotations or form data were saved by a previous Okular version to the local file "/home/user/.local/share/okular/file.pdf.xml". This type of storage is no longer supported. Please save to a file in order to preserve the annotations and form data; these will be saved inside the pdf file itself." -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 394851] Configure Web Shortcut Error
https://bugs.kde.org/show_bug.cgi?id=394851 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |UNMAINTAINED Status|UNCONFIRMED |RESOLVED --- Comment #9 from Kai Uwe Broulik --- Please try again with a 5.x based version. Closing. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 384695] Configurable horizontal scrolling key (ALT or SHIFT) + WHEEL
https://bugs.kde.org/show_bug.cgi?id=384695 Kenneth Hanson changed: What|Removed |Added CC||khanson...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
