KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 22 - Still Unstable!

2018-06-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/22/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 05 Jun 2018 01:39:07 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 137 - Fixed!

2018-06-04 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/137/
 Project:
Applications okular kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 05 Jun 2018 01:39:07 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(23/26)56%
(157/280)56%
(157/280)40%
(16077/40161)27%
(7642/28415)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)59%
(1089/1859)42%
(569/1371)autotests100%
(16/16)100%
(16/16)98%
(2468/2508)47%
(1611/3443)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core88%
(43/49)88%
(43/49)55%
(5320/9618)40%
(2607/6469)core.script100%
(12/12)100%
(12/12)37%
(238/643)17%
(44/266)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3572)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)55%
(184/335)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/570)0%
(2/476)generators.kimgio100%
(1/1)100%
(1/1)63%
(44/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)53%
(734/1391)40%
   

[okular] [Bug 395013] Okular crashed while saving

2018-06-04 Thread Ankit Sadana
https://bugs.kde.org/show_bug.cgi?id=395013

--- Comment #2 from Ankit Sadana  ---
(In reply to Albert Astals Cid from comment #1)
> This sounds totally like https://bugs.kde.org/show_bug.cgi?id=393334 but it
> should be fixed for 1.4.1 that you're running
> 
> Is there any chance the okular you had running was an old running version
> from before you updated to 1.4.1 (aka 18.04.1)? I guess not but asking is
> for free :D

Sadly no, last system-wide package update I did was 2 days ago, so this should
be 1.4.1. However if it helps at all I had woken my laptop up from suspend
while doing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 379749] Crash when saving/closing a PDF with forms

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=379749

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #10 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 393334 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393334] Okular crashed during closing after saving a pdf form

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393334

Albert Astals Cid  changed:

   What|Removed |Added

 CC||bugzi...@cablelink.at

--- Comment #2 from Albert Astals Cid  ---
*** Bug 379749 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 395029] Segmentation fault when changing opened PDF

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=395029

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |UNMAINTAINED
 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
You're using an Okular version that is more than two years old, sadly we can't
really offer support for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394926] Okular crash

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394926

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||aa...@kde.org
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Albert Astals Cid  ---
Can you reproduce it?

Can you attach the pdf that caused the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 395013] Okular crashed while saving

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=395013

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
This sounds totally like https://bugs.kde.org/show_bug.cgi?id=393334 but it
should be fixed for 1.4.1 that you're running

Is there any chance the okular you had running was an old running version from
before you updated to 1.4.1 (aka 18.04.1)? I guess not but asking is for free
:D

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394999] Fonts mangled when printed but look fine on screen

2018-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=394999

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org

--- Comment #5 from Albert Astals Cid  ---
waiting for reproducer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394999] Fonts mangled when printed but look fine on screen

2018-06-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=394999

--- Comment #4 from char...@mcevoy.com ---
The 'force rasterization' workaround works well - thank you
The PDF <-> Inkscape produces a PDF that prints beautifully! But that's
obviously not helpful.
I don't mind sending the original PDF to an individual if anyone wants to have
a look at the problem, but I'd rather not post it in public. Otherwise I'll
just keep my eyes open for another example.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

2018-06-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/21/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 04 Jun 2018 17:25:31 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

[okular] [Bug 395029] New: Segmentation fault when changing opened PDF

2018-06-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=395029

Bug ID: 395029
   Summary: Segmentation fault when changing opened PDF
   Product: okular
   Version: 0.25.0
  Platform: Mint (Ubuntu based)
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: krzmb...@gmail.com
  Target Milestone: ---

I am creating a document using LaTeX and while doing so I like having the
created PDf opend in Okular in order to properly inspect it.
However after recompiling the LaTeX source and thus recreating the PDf file
Okular tends to crash. This behaviour is rather new (I experienced it in the
last couple of weeks but before everything worked well) and it doesn't occur
always but pretty often.

I am experiencing this bug on Linux Mint 18.3 and here's the output of okular
--version:
Qt: 4.8.7
KDE Development Platform: 4.14.22
Okular: 0.25.0

And this is the backtrace as created by the KDE bug-report manager:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[KCrash Handler]
#6  __memcpy_avx_unaligned () at
../sysdeps/x86_64/multiarch/memcpy-avx-unaligned.S:245
#7  0x7ff4f1d31bcf in GooString::Set(char const*, int, char const*, int) ()
from /usr/lib/x86_64-linux-gnu/libpoppler.so.58
#8  0x7ff4f1ce612c in Object::copy(Object*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#9  0x7ff4f1c79d71 in Array::getString(int, GooString*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#10 0x7ff4f1c7bfb1 in NameTree::Entry::Entry(Array*, int) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#11 0x7ff4f1c7c58a in NameTree::parse(Object*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#12 0x7ff4f1c7c626 in NameTree::parse(Object*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#13 0x7ff4f1c7c626 in NameTree::parse(Object*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#14 0x7ff4f1c7c64f in NameTree::init(XRef*, Object*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#15 0x7ff4f1c7d87f in Catalog::getDestNameTree() () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#16 0x7ff4f1c7d919 in Catalog::findDest(GooString*) () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.58
#17 0x7ff4f204a648 in
Poppler::LinkDestination::LinkDestination(Poppler::LinkDestinationData const&)
() from /usr/lib/x86_64-linux-gnu/libpoppler-qt4.so.4
#18 0x7ff4f2041897 in Poppler::Document::linkDestination(QString const&) ()
from /usr/lib/x86_64-linux-gnu/libpoppler-qt4.so.4
#19 0x7ff4f22956c3 in ?? () from /usr/lib/kde4/okularGenerator_poppler.so
#20 0x7ff4f811c471 in Okular::Document::metaData(QString const&, QVariant
const&) const () from /usr/lib/libokularcore.so.7
#21 0x7ff4f849552f in ?? () from /usr/lib/kde4/okularpart.so
#22 0x7ff4f84957a8 in ?? () from /usr/lib/kde4/okularpart.so
#23 0x7ff4f849613e in ?? () from /usr/lib/kde4/okularpart.so
#24 0x7ff4f8493c3e in TOC::notifySetup(QVector const&, int)
() from /usr/lib/kde4/okularpart.so
#25 0x7ff4f8131e07 in Okular::Document::openDocument(QString const&, KUrl
const&, KSharedPtr const&, QString const&) () from
/usr/lib/libokularcore.so.7
#26 0x7ff4f840c43d in Okular::Part::doOpenFile(KSharedPtr
const&, QString const&, bool*) () from /usr/lib/kde4/okularpart.so
#27 0x7ff4f840dce0 in Okular::Part::openFile() () from
/usr/lib/kde4/okularpart.so
#28 0x7ff509c4e674 in ?? () from /usr/lib/libkparts.so.4
#29 0x7ff509c50f4d in KParts::ReadOnlyPart::openUrl(KUrl const&) () from
/usr/lib/libkparts.so.4
#30 0x7ff4f8404906 in Okular::Part::slotDoFileDirty() () from
/usr/lib/kde4/okularpart.so
#31 0x7ff4f840f965 in ?? () from /usr/lib/kde4/okularpart.so
#32 0x7ff50862bf80 in QMetaObject::activate(QObject*, QMetaObject const*,
int, void**) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#33 0x7ff508631bf3 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQtCore.so.4
#34 0x7ff50795cfdc in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#35 0x7ff507963f16 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQtGui.so.4
#36 0x7ff50931c6ba in KApplication::notify(QObject*, QEvent*) () from
/usr/lib/libkdeui.so.5
#37 0x7ff5086178bd in QCoreApplication::notifyInternal(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#38 0x7ff50864a6f0 in ?? () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#39 0x7ff508647899 in ?? () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#40 0x7ff5037c4197 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#41 0x7ff5037c43f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#42 0x7ff5037c449c in g_main_context_iteration () from

D13203: Add Typewriter annotation tool in Okular

2018-06-04 Thread Tobias Deiminger
tobiasdeiminger added inline comments.

INLINE COMMENTS

> editannottooldialog.cpp:128
>  
> -const QString color = m_stubann->style().color().name();
> +const QString color = m_stubann->style().color().name(QColor::HexArgb);
>  const QString opacity = QString::number( m_stubann->style().opacity() );

So from now on ALL annotations (even ink, highlight, inline note etc) that are 
created by a user-defined tool will store color as #AARRGGBB in *.okular 
document archive, right? Formerly it was #RRGGBB.

What will happen if user A with new Okular saves an inline note to mydoc.okular 
and sends mydoc.okular to user B who has an older Okular version. Will the 
older version be able to deal with #AARRGGBB? How is it vice versa, user B 
sending something to user A?

If this change is indeed forwards and backwards compatible, I think it's good 
to go this way. We prepare other annotations types for transparency without 
destroying something. Then we should however also adapt the color=... 
attributes of the default tools in tools.xml to the new #AARRGGBB format, for 
the sake of consistency.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel


D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 35513.
chinmoyr added a comment.


  Added validateSignatures() to validate signatures while loading a page.
  Added to document info whether or not a pdf is digitally signed.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=35510=35513

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid


[okular] [Bug 377688] No output to print for PDF since update to 1.0.3

2018-06-04 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=377688

--- Comment #30 from Luigi Toscano  ---
Also Fedora ships newer Ghostscript versions (9.22 in F27, 9.23 in F28).

Ghostscript in the past had a mixed development model with commercial versions
released before the FLOSS ones, then they changed a bit, and I don't remember
recent changes. Do you have any reference to recent changes? Anyway, if two
major distribution which checks licenses carefully are shipping a newer
version, I'm sure that it's possible for others too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394999] Fonts mangled when printed but look fine on screen

2018-06-04 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=394999

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #3 from Oliver Sander  ---
I am afraid there is not much we can do without an example document.  You could
try to load the document into Inkscape, remove all compromising stuff there and
write back to pdf.  

For a workaround: have you tried printing with the "force rasterization" option
set in the "pdf options" tab?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11725: [RFC] Show signature status as a popup

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependency: D11723: Add FormFieldSignature to Okular 
namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: okular-devel, aacid, sander, ngraham


D12901: Add unit test for SignatureFormField

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12901

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid


D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependent revision(s), added 1: D12901: Add unit test for 
SignatureFormField; removed 1: D11725: [RFC] Show signature status as a popup.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid


D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 35510.
chinmoyr added a comment.


  Removed the unnecessary static_cast
  Used QScopedPointer for d_ptr

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=35040=35510

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid


D13203: Add Typewriter annotation tool in Okular

2018-06-04 Thread Dileep Sankhla
dileepsankhla updated this revision to Diff 35508.
dileepsankhla added a comment.


  Diff changed after commiting to gsoc2018_typewriter branch. Updating it.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13203?vs=35507=35508

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13203

AFFECTED FILES
  conf/editannottooldialog.cpp
  conf/editannottooldialog.h
  core/annotations.cpp
  ui/annotationpropertiesdialog.cpp
  ui/annotationwidgets.cpp
  ui/annotationwidgets.h
  ui/annotwindow.cpp
  ui/data/CMakeLists.txt
  ui/data/sources/tool-typewriter-okular-colorizable.svgz
  ui/data/tool-typewriter-okular-colorizable.png
  ui/data/tool-typewriter-okular-coloriza...@2x.png
  ui/data/tools.xml
  ui/guiutils.cpp
  ui/pagepainter.cpp
  ui/pageviewannotator.cpp

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel


D13203: Add Typewriter annotation tool in Okular

2018-06-04 Thread Dileep Sankhla
dileepsankhla reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel


D13203: Add Typewriter annotation tool in Okular

2018-06-04 Thread Dileep Sankhla
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
dileepsankhla marked an inline comment as done.
Closed by commit R223:66c70934b82c: popup window background color (authored by 
dileepsankhla).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13203?vs=35383=35507#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13203?vs=35383=35507

REVISION DETAIL
  https://phabricator.kde.org/D13203

AFFECTED FILES
  ui/annotwindow.cpp

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel