D15580: New annotation toolbar

2018-10-03 Thread Simone Gaiarin
simgunz updated this revision to Diff 42831. simgunz added a comment. - Check if chosen color is valid before storing it - Notify PageViewAnnotator when the color has changed - Add missing annotation tools actions - Add XML annotation tools and connect corresponding actions REPOSITORY

[okular] [Bug 399360] Okular CHM cannot open any chm file and input chinese

2018-10-03 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=399360 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #2 from Yuri

[okular] [Bug 399360] Okular CHM cannot open any chm file and input chinese

2018-10-03 Thread Evel
https://bugs.kde.org/show_bug.cgi?id=399360 --- Comment #1 from Evel --- I am not sure where I can get the debug info for your reference when open a *.chm file. If requied, please tell me how to get it and I will submit later. -- You are receiving this mail because: You are the assignee for

[okular] [Bug 399360] New: Okular CHM cannot open any chm file and input chinese

2018-10-03 Thread Evel
https://bugs.kde.org/show_bug.cgi?id=399360 Bug ID: 399360 Summary: Okular CHM cannot open any chm file and input chinese Product: okular Version: 1.5.1 Platform: Manjaro OS: Linux Status: REPORTED

Re: Brainstorm idea - OCR integration

2018-10-03 Thread David Hurka
Hi, I had this idea many times already, because some PDFs have bitmap-only passages or are completely bitmap-only. Selection and the search function don't work there. The search function in Okular should be able to compensate typos, because OCR will probably introduce some typos. The OCR

[okular] [Bug 398771] EPub backend: changing default font size doesn't update the page number

2018-10-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=398771 --- Comment #1 from Christoph Feck --- Document generators currently cannot inform the Okular core of a changed page count. It might be needed to reload the document. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 398427] Add support for Subj entry of PDF markup annotations

2018-10-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=398427 --- Comment #2 from Christoph Feck --- Friedrich, any success with the link from comment #1? -- You are receiving this mail because: You are the assignee for the bug.

D15205: Support setting font color for typewriter annotation

2018-10-03 Thread Tobias Deiminger
tobiasdeiminger marked 2 inline comments as done. tobiasdeiminger added a comment. Should be ready to land. I'll push tomorrow, time frame for last objections is open now ;-) REPOSITORY R223 Okular BRANCH typewriter_td_fontcolor (branched from master) REVISION DETAIL

D15205: Support setting font color for typewriter annotation

2018-10-03 Thread Tobias Deiminger
tobiasdeiminger updated this revision to Diff 42798. tobiasdeiminger added a comment. More review fixes - Refine doxygen comments on TextAnnotation::textColor and TextAnnotation::setTextColor - Colorize toolbar icon in with text color instead of black - Remove accidential whitespace

D15205: Support setting font color for typewriter annotation

2018-10-03 Thread Tobias Deiminger
tobiasdeiminger added a comment. In D15205#335752 , @sander wrote: > I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue. Thanks for reviewing. > I'd

[okular] [Bug 399256] Crash when trying to open a DJVU file with Okular

2018-10-03 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=399256 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de --- Comment #6 from

D15205: Support setting font color for typewriter annotation

2018-10-03 Thread Oliver Sander
sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH typewriter_td_fontcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger, sander Cc: kde-doc-english, sander, okular-devel, ngraham,