D15691: Add unarchiver support for cbr files

2018-10-18 Thread Fabio Bolz 
fb updated this revision to Diff 43886.
fb edited the summary of this revision.
fb added a comment.


  Okay, I added the virtual functions and created the ProcessArgs type, for a 
better structure of the processed arguments.
  These variables will then be used by the startSyncProcess function.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15691?vs=42137=43886

BRANCH
  unar-patch

REVISION DETAIL
  https://phabricator.kde.org/D15691

AFFECTED FILES
  .gitignore
  generators/comicbook/document.cpp
  generators/comicbook/unrar.cpp
  generators/comicbook/unrar.h
  generators/comicbook/unrarflavours.cpp
  generators/comicbook/unrarflavours.h

To: fb
Cc: aacid, okular-devel, ngraham

D16285: Remember printing option and print range in the print dialog

2018-10-18 Thread Kai Uwe Broulik 
broulik added a comment.


  > This new information is saved/remembered per-document and not globally, 
right?
  
  Given it's in a `document.cpp` I would assume so, that's probably also where 
scroll position and what not is persisted

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16285

To: ahmadosama, #okular
Cc: broulik, ngraham, okular-devel, aacid