D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#394712 , @aacid wrote: > The only way i can think of is making the long form not havve default values > > https://paste.kde.org/p55lx6vrh Thanks, that looks good. I have done it this way now.

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49715. michaelweghorn added a comment. Changes in this revision: - make new 'printFiles()' have no default values for parameters, so that param order can be the same as in the original one (thanks Albert!) - add "TODO" comment to merge

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#394709 , @aacid wrote: > I don't really have the time to spend print stuff to check if this does what it says it does, so i'm just doing code review from the pure formal way. Many thanks for

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn marked 4 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn updated this revision to Diff 49697. michaelweghorn added a comment. Adapted according to Albert's feedback: - Remove (now) unneeded imclude - remove 'virtual' keyword in derived class REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

[okular] [Bug 403263] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=403263 --- Comment #4 from Sergio --- Mentioning the item above as distributions are typically happy to incorporate/backport mere bug fixes, but typically not sympathetic to requests to update to totally new versions of software nor to backport new features

[okular] [Bug 403263] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=403263 --- Comment #3 from Sergio --- May not be an exact duplicate as but 348172 looks more like as an enhancement request or a request to restore functionality that got lost in the KDE 4 -> KDE 5 transition, while this is a bug. While the provision of

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

simgunz added a comment. I use the side review panel only when I need to go through all the reviews one by one, so it is annoying having to expand all the elements by hand. Maybe a expand/collapse all solution would be a better solution. (The long answer is in T8553

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

https://bugs.kde.org/show_bug.cgi?id=330820 --- Comment #13 from Vasiliy Glazov --- Bug still present. -- You are receiving this mail because: You are the assignee for the bug.

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

simgunz added a task: T8553: Improve review side panel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18283 To: joaonetto Cc: simgunz, aacid, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

https://bugs.kde.org/show_bug.cgi?id=330820 Vasiliy Glazov changed: What|Removed |Added CC||vasc...@gmail.com -- You are receiving this