knambiar updated this revision to Diff 58625.
knambiar marked 2 inline comments as done.
knambiar added a comment.
Add `Q_ASSERT` for the configs.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21332?vs=58571=58625
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=407828
Rafael Linux User changed:
What|Removed |Added
CC||rafael.linux.u...@gmail.com
--- Comment #2
https://bugs.kde.org/show_bug.cgi?id=402017
--- Comment #5 from David Hurka ---
Just discovered a class FileKeeper, which should do this.
Added in commit 6531398b919e58def8c6ba4711d20ea517147189, eleven years ago.
Just grep for #ifdef OKULAR_KEEP_FILE_OPEN
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=407884
David Hurka changed:
What|Removed |Added
Summary|Previous/Next Bookmark |Previous/Next Bookmark
|don’t
https://bugs.kde.org/show_bug.cgi?id=407884
--- Comment #3 from Albert Astals Cid ---
yes, they do what they were coded to do, so it is intended they do that.
You get confused by the heading, fair enough, my guess is that orignally there
was no heading. It's basically the same menu that you get
aacid added inline comments.
INLINE COMMENTS
> pagepainter.cpp:947
> +{
> +double fImageWidth = (double) image.width();
> +double fImageHeight = (double) image.height();
const here and for fImageHeight and penWidth
REPOSITORY
R223 Okular
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=407884
--- Comment #2 from David Hurka ---
So it’s intended that they don’t do what the menu says, but do what the menu
would say if invoked another way?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=407884
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #1 from Albert
https://bugs.kde.org/show_bug.cgi?id=407869
--- Comment #3 from Albert Astals Cid ---
or this would probably make sense in okular
diff --git a/part.cpp b/part.cpp
index c831f8793..229ff7fcb 100644
--- a/part.cpp
+++ b/part.cpp
@@ -576,7 +576,7 @@ m_cliPresentation(false), m_cliPrint(false),
https://bugs.kde.org/show_bug.cgi?id=180443
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
Status|CONFIRMED
https://bugs.kde.org/show_bug.cgi?id=407869
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #2 from Albert
https://bugs.kde.org/show_bug.cgi?id=407731
Albert Astals Cid changed:
What|Removed |Added
CC||alf...@gmail.com
--- Comment #10 from
https://bugs.kde.org/show_bug.cgi?id=407903
Albert Astals Cid changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=407903
--- Comment #4 from Nate Graham ---
Is this fixed in a newer version of Okular or Popper?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=407903
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #3 from Albert
https://bugs.kde.org/show_bug.cgi?id=407903
Nate Graham changed:
What|Removed |Added
CC||n...@kde.org
--- Comment #2 from Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407883
Nate Graham changed:
What|Removed |Added
CC||n...@kde.org
--
You are receiving this mail
aacid added a comment.
One proposal i have is actually saying we don't support poppler 0.50
poppler-0.50.0 was released on Dec 15, 2016, we require Qt 5.8.0 released on
January 26, 2017 and KF5 5.44.0 released on March 10, 2018
Any reason you want to support such an old poppler?
tobiasdeiminger added inline comments.
INLINE COMMENTS
> knambiar wrote in annotationwidgets.cpp:499
> Is the `nullptr` check really necessary?
No, I'd accept anyways. I just think the implication "object pointer !=
nullptr" => "object valid" is more obvious to new contributors than "some
https://bugs.kde.org/show_bug.cgi?id=407903
--- Comment #1 from Alfeno Rodrigues ---
Created attachment 120287
--> https://bugs.kde.org/attachment.cgi?id=120287=edit
backtraces segmation faulf of okular.
backtraces segmation faulf of okular for debug this issue.
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=407903
Bug ID: 407903
Summary: Okular Crashes when try to open a specific pdf file
Product: okular
Version: 1.7.1
Platform: Neon Packages
OS: Linux
Status: REPORTED
21 matches
Mail list logo
