D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka
davidhurka added a comment. In D21734#478372 , @aacid wrote: > In D21734#477729 , @davidhurka wrote: > > > Oh, does someone know any intended purpose division between setupActions(),

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread David Hurka
davidhurka added a comment. Using cursor position for Ctrl+Scroll, but not for Ctrl+Plus/Minus makes sense to me. Can this be extended to using the initial cursor position for middle-button-drag zooming? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21759

D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka
davidhurka marked 6 inline comments as done. davidhurka added inline comments. INLINE COMMENTS > aacid wrote in pageview.h:56 > i kind of know how this works, and i don't understand what "shown pages" is > supposed to mean. Made the item “Content area” more general, to explain its purpose not

D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka
davidhurka updated this revision to Diff 59687. davidhurka added a comment. Looked over the whole patch again. Several wording improvements, and made some less specific or more accurate. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

[okular] [Bug 408620] New: Not able to view full PDF

2019-06-12 Thread Matt
https://bugs.kde.org/show_bug.cgi?id=408620 Bug ID: 408620 Summary: Not able to view full PDF Product: okular Version: 1.7.0 Platform: Ubuntu Packages OS: Linux Status: REPORTED Severity: minor

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21759 To: steffenh, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)

2019-06-12 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=213508 Mayank Choudhary changed: What|Removed |Added CC||mayankch...@gmail.com -- You are receiving

[okular] [Bug 185636] More printing options for page control

2019-06-12 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=185636 Michael Weghorn changed: What|Removed |Added Resolution|--- |UPSTREAM Status|CONFIRMED

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread Steffen Hartleib
steffenh created this revision. steffenh added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. steffenh requested review of this revision. REVISION SUMMARY This patch hold (if possibly) the zoom center below the mouse position (zoom with Ctrl +

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-12 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=402015 Yuri Chornoivan changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-12 Thread Brian Pokin
https://bugs.kde.org/show_bug.cgi?id=402015 --- Comment #3 from Brian Pokin --- I took the hint and used the neon-user-20190606-1138.iso, which has okular 19.04.1. A local print queue, aaa, was set up and the print dialog also offered a number of remote queues to print to. With cups-browsed

D15580: New annotation toolbar

2019-06-12 Thread Simone Gaiarin
simgunz added inline comments. INLINE COMMENTS > aacid wrote in pageview.cpp:665 > You're right, it seems it never has. Can you use the other one? Is it there a clean way to obtain a reference to the toolbar from within this class? I guess that KMainWindow::toolBar(name) is a possibility, but