[okular] [Bug 410778] New: Okular does not respect EXIF orientation tag

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=410778

Bug ID: 410778
   Summary: Okular does not respect EXIF orientation tag
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: 20l8kxxl8...@opayq.com
  Target Milestone: ---

SUMMARY
Okular does not respect EXIF orientation tag of JPG files, displaying the
images in wrong orientation.

STEPS TO REPRODUCE
1. Take some photos, but in a wrong orientation.
2. View the files using Gwenview. The photos need to be rotated.
3. Use exiftran to fix the orientation.
4. View the resulting files using Gwenview. The photos are now displayed
properly because Gwenview respects EXIF orientation tag.
5. Rename the files to 001.jpg, 002.jpg, etc. and compress them into a ZIP
archive.
6. Rename the archive to .cbz so that Okular can open it using the Comicbook
backend.
7. View the file using Okular.

OBSERVED RESULT
Okular does not rotate the photos according to the EXIF orientation tag.

EXPECTED RESULT
Okular rotates the photos automatically according to the EXIF orientation tag.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga added a comment.


  @aacid Please check your email. I noticed that your public key 
(0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my 
message anyway.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:a738c98c2082: Add information about substituting font 
into properties dialog (authored by jgrulich, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23027?vs=63395=63454#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63395=63454

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks, good, i'll commit a slightly modified version that checks 
substituteName != fontname too, wanted to save us all the roundtrip

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Albert Astals Cid]

aacid added a comment.


  In D23037#509088 , @broulik wrote:
  
  > Works well, thanks a lot! Let's wait for Okular maintainer approval.
  
  
  If by maintainer you mean me, the code looks sane.
  
  Now nhiga, can you give us your full name and email for git history?

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

[okular] [Bug 410041] I can not click in a reference if I highlight a text

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=410041

--- Comment #3 from Albert Astals Cid  ---
The context menu should mention both the link and the higlighter.

Can you please add the file you're having trouble with?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22262: Thumbnails sidebar always open when okular starts

[Mayank Choudhary]

mayankchoudhary added a comment.


  I want to use the mouse to click on the sidebar.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22262

To: mayankchoudhary, aacid, ngraham, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

[okular] [Bug 163493] 'Full screen mode' is better in View menu than Settings menu (usability)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=163493

madworm_de@spitzenpfeil.org changed:

   What|Removed |Added

 CC||madworm_de.kde@spitzenpfeil
   ||.org

--- Comment #11 from madworm_de@spitzenpfeil.org ---
Today I was looking for "Full Screen" view as well, found it in the "settings"
menu after way too much time, was expecting it int "view".

This is not a very intuitive place to look for it, "view" is the natural place
for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga added a subscriber: broulik.
nhiga added a comment.


  Sorry for the mess, I accidentally changed the status and subscriber list.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga reclaimed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Jan Grulich]

jgrulich updated this revision to Diff 63395.
jgrulich added a comment.


  Better use of i18nc API

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63393=63395

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Pino Toscano]

pino added a comment.


  why did you abandon this?

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga removed subscribers: broulik, pino.
nhiga abandoned this revision.
nhiga marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid, broulik, pino

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga updated this revision to Diff 63394.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23037?vs=63392=63394

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Jan Grulich]

jgrulich updated this revision to Diff 63393.
jgrulich added a comment.


  Use translatable string

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23027?vs=63387=63393

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23027

AFFECTED FILES
  core/fontinfo.cpp
  core/fontinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/config-okular-poppler.h.cmake
  generators/poppler/generator_pdf.cpp
  ui/propertiesdialog.cpp

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Kai Uwe Broulik]

broulik added a comment.


  Works well, thanks a lot! Let's wait for Okular maintainer approval.

INLINE COMMENTS

> okularApplication_comicbook.desktop:168
>  NoDisplay=true
> -X-KDE-Keywords=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ar]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bg]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bs]=cbr, cbz, cbt, Comic Book,stripovi
> -X-KDE-Keywords[ca]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ca@valencia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[cs]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[da]=cbr,cbz,cbt,Comic Book
> -X-KDE-Keywords[de]=cbr, cbz, cbt, Comic-Book
> -X-KDE-Keywords[el]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[en_GB]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[es]=cbr, cbz, cbt, libro de cómic
> -X-KDE-Keywords[et]=cbr, cbz, cbt, Comic Book, koomiks
> -X-KDE-Keywords[eu]=cbr, cbz, cbt, komiki-liburua
> -X-KDE-Keywords[fi]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[fr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ga]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[gl]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[hu]=cbr, cbz, cbt, Képregény
> -X-KDE-Keywords[ia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[is]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[it]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ja]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[kk]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[km]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ko]=cbr, cbz, cbt, Comic Book,만화책
> -X-KDE-Keywords[lt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[lv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[mr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[nb]=cbr, cbz, cbt, tegneserie
> -X-KDE-Keywords[nds]=cbr, cbz, cbt, Comicbook
> -X-KDE-Keywords[nl]=cbr, cbz, cbt, Stripverhaal
> -X-KDE-Keywords[nn]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pa]=cbr, cbz, cbt, ਕਾਮਿਕ ਬੁੱਕ
> -X-KDE-Keywords[pl]=cbr, cbz, cbt, Komiks
> -X-KDE-Keywords[pt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pt_BR]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ro]=cbr, cbz, cbt, benzi desenate, comic
> -X-KDE-Keywords[ru]=cbr, cbz, cbt, Comic Book, комикс
> -X-KDE-Keywords[sk]=cbr, cbz, cbt, Comic Book, Kniha komiksov
> -X-KDE-Keywords[sl]=cbr, cbz, cbt, strip
> -X-KDE-Keywords[sr]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavian]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavianlatin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sr@latin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[tr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[uk]=cbr,cbz,cbt,Comic Book,комікс
> -X-KDE-Keywords[x-test]=xxcbrxx,xx cbzxx,xx cbtxx,xx Comic Bookxx
> -X-KDE-Keywords[zh_CN]=cbr, cbz, cbt, Comic Book,漫画书,漫画,连环画
> -X-KDE-Keywords[zh_TW]=cbr, cbz, cbt, Comic Book
> +X-KDE-Keywords=cbr, cbz, cbt, cb7, Comic Book
> +X-KDE-Keywords[ar]=cbr, cbz, cbt, cb7, Comic Book

Yes, please only change the untranslated key (the ones without `[language]`), 
the rest is taken care by a script :)

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[N. Higa]

nhiga updated this revision to Diff 63392.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23037?vs=63385=63392

REVISION DETAIL
  https://phabricator.kde.org/D23037

AFFECTED FILES
  generators/comicbook/document.cpp
  generators/comicbook/libokularGenerator_comicbook.json
  generators/comicbook/okularApplication_comicbook.desktop
  generators/comicbook/okularComicbook.desktop
  generators/comicbook/org.kde.mobile.okular_comicbook.desktop
  generators/comicbook/org.kde.okular-comicbook.metainfo.xml

To: nhiga, #okular, aacid
Cc: pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
ngraham, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> propertiesdialog.cpp:361
> +if (m_fonts.at( index.row() ).embedType() == 
> Okular::FontInfo::NotEmbedded && !substituteName.isEmpty() && 
> !fontname.isEmpty()) {
> +return QString("%1 (substituting with 
> %2)").arg(fontname).arg(substituteName);
> +}

i18n please, with a context explaining the message

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23027

To: jgrulich, aacid
Cc: pino, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Pino Toscano]

pino added a comment.


  Please do **not** manually change translated keys in desktop files: there is 
an automatic system that takes care of them.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
ngraham, darcyshen, aacid