D25484: Enable closing a tab by middle click
bdbai updated this revision to Diff 70387. bdbai added a comment. Fixed code styles REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25484?vs=70349=70387 REVISION DETAIL https://phabricator.kde.org/D25484 AFFECTED FILES autotests/mainshelltest.cpp shell/shell.cpp shell/shell.h shell/shell.rc To: bdbai, #vdg Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
D25553: Port away from deprecated Bar|Desktop|SmallIcon methods
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25553 To: vkrause Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
D25553: Port away from deprecated Bar|Desktop|SmallIcon methods
vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D25553 AFFECTED FILES conf/dlgperformance.cpp ui/ktreeviewsearchline.cpp ui/pageviewutils.cpp ui/presentationwidget.cpp ui/thumbnaillist.cpp To: vkrause Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
[okular] [Bug 414357] table markdown is not pretty
https://bugs.kde.org/show_bug.cgi?id=414357 Andi Sardina changed: What|Removed |Added CC||andysardin...@gmail.com --- Comment #1 from Andi Sardina --- The problem here is that after the markdown is converted to HTML no CSS is applied to it. Also, the support for CSS in the QTextDocument is limited, so, there is no much that can be done with it. Does anybody know if inside the KDE Framework there is something that could help with this? I was thinking about using QWebEnginePage but I don't know how to generate pixmaps for the pages. -- You are receiving this mail because: You are the assignee for the bug.
D25484: Enable closing a tab by middle click
ngraham added a comment.
Thanks, this looks great. It works just fine and the UI seems sane to me. I
have some code comments:
INLINE COMMENTS
> shell.cpp:660
> +m_undoCloseTab->setEnabled( true );
> +m_closedTabUrls.push_back( url );
>
prefer `append()`
> shell.cpp:778
> +{
> +if ( m_closedTabUrls.size() == 0 )
> +return;
coding style: always use braces
> shell.cpp:778
> +{
> +if ( m_closedTabUrls.size() == 0 )
> +return;
`m_closedTabUrls.isEmpty()`
> shell.cpp:783
> +
> +if ( m_closedTabUrls.size() == 0 )
> +m_undoCloseTab->setEnabled(false);
ditto
> shell.h:175
>QList m_tabs;
> + QLinkedList m_closedTabUrls;
>QAction* m_nextTabAction;
A regular old QList of QUrls would seem to do just fine as it doesn't seem that
you're using any functionality present in QLinkedList not in QList.
> shell.rc:8
>
> +
>
Need to bump the version number at the top of this file anything you change
anything
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D25484
To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh,
andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella,
darcyshen
D25484: Enable closing a tab by middle click
bdbai updated this revision to Diff 70349. bdbai added a comment. - Added "undo tab close" - Added a test REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25484?vs=70197=70349 REVISION DETAIL https://phabricator.kde.org/D25484 AFFECTED FILES autotests/mainshelltest.cpp shell/shell.cpp shell/shell.h shell/shell.rc To: bdbai, #vdg Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
