[okular] [Bug 418345] New: Desktop file lacks keywords and mimetypes

2020-02-29 Thread Nathaniel Beaver
https://bugs.kde.org/show_bug.cgi?id=418345

Bug ID: 418345
   Summary: Desktop file lacks keywords and mimetypes
   Product: okular
   Version: 1.3.3
  Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: nathanielmbea...@gmail.com
  Target Milestone: ---

Created attachment 126509
  --> https://bugs.kde.org/attachment.cgi?id=126509=edit
Patch for the desktop file.

SUMMARY
Okular desktop file could be improved.

STEPS TO REPRODUCE
1. Open any menu search.
2. Search for "PDF".
3. Look for Okular.

OBSERVED RESULT
Okular does not show up in search results.

EXPECTED RESULT
Okular shows up in search results.

ADDITIONAL INFORMATION

I've attached a patch that adds the "keywords" and "tryexec" fields, as well as
more mimetypes.

This is for the most recent version of "org.kde.okular.desktop" here:

https://cgit.kde.org/okular.git/tree/shell/org.kde.okular.desktop?id=341875b342d7ae5fdbf7fa411c1d11354983caa8

https://cgit.kde.org/okular.git/tree/shell/org.kde.okular.desktop

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications » okular » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Still unstable!

2020-02-29 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications/job/okular/job/stable-kf5-qt5%20WindowsMSVCQt5.14/13/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 01 Mar 2020 01:13:22 +
 Build duration:
3 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 10 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.addremoveannotationtestFailed: projectroot.autotests.annotationstestFailed: projectroot.autotests.calculatetexttestFailed: projectroot.autotests.documenttestFailed: projectroot.autotests.editannotationcontentstestFailed: projectroot.autotests.editformstestFailed: projectroot.autotests.modifyannotationpropertiestestFailed: projectroot.autotests.searchtestFailed: projectroot.autotests.signatureformtestFailed: projectroot.autotests.translateannotationtestName: projectroot.conf Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.generators Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.generators.kimgio.kimgiotest

[okular] [Bug 339971] Detach Tabs / Combine multiple windows in tabs

2020-02-29 Thread Postix
https://bugs.kde.org/show_bug.cgi?id=339971

Postix  changed:

   What|Removed |Added

 CC||newmrde...@gmail.com

--- Comment #4 from Postix  ---
*** Bug 411911 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 411911] Detachable tabs

2020-02-29 Thread Postix
https://bugs.kde.org/show_bug.cgi?id=411911

Postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu
 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #1 from Postix  ---


*** This bug has been marked as a duplicate of bug 339971 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339971] Detach Tabs / Combine multiple windows in tabs

2020-02-29 Thread Postix
https://bugs.kde.org/show_bug.cgi?id=339971

Postix  changed:

   What|Removed |Added

   See Also||https://bugreports.qt.io/br
   ||owse/QTBUG-3160

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339971] Detach Tabs / Combine multiple windows in tabs

2020-02-29 Thread Postix
https://bugs.kde.org/show_bug.cgi?id=339971

Postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications » okular » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Failure!

2020-02-29 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications/job/okular/job/stable-kf5-qt5%20WindowsMSVCQt5.14/12/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 29 Feb 2020 22:21:20 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 1052 lines...][2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\CI\Job Build\core\area.h(668): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] NormalizedShape=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\CI\Job Build\core\area.h(946): note: see reference to class template instantiation 'Okular::RegularArea' being compiled[2020-02-29T22:33:41.991Z] [82/329] Building CXX object CMakeFiles\okularcore.dir\core\script\kjs_display.cpp.obj[2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T22:33:41.991Z] T=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\CI\Job Build\core\area.h(668): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T22:33:41.991Z] with[2020-02-29T22:33:41.991Z] [[2020-02-29T22:33:41.991Z] NormalizedShape=Okular::NormalizedRect[2020-02-29T22:33:41.991Z] ][2020-02-29T22:33:41.991Z] C:\CI\Job Build\core\area.h(946): note: see reference to class template instantiation 'Okular::RegularArea' being compiled[2020-02-29T22:33:42.250Z] [83/329] Building CXX object CMakeFiles\okularcore.dir\core\script\executor_kjs.cpp.obj[2020-02-29T22:33:42.250Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-02-29T22:33:42.250Z] with[2020-02-29T22:33:42.250Z] [[2020-02-29T22:33:42.250Z] T=Okular::NormalizedRect[2020-02-29T22:33:42.250Z] ][2020-02-29T22:33:42.250Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T22:33:42.250Z] with[2020-02-29T22:33:42.250Z] [[2020-02-29T22:33:42.250Z] T=Okular::NormalizedRect[2020-02-29T22:33:42.250Z] ][2020-02-29T22:33:42.250Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T22:33:42.250Z] with[2020-02-29T22:33:42.250Z] [[2020-02-29T22:33:42.250Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T22:33:42.250Z] T=Okular::NormalizedRect[2020-02-29T22:33:42.250Z] ][2020-02-29T22:33:42.250Z] C:\CI\Job Build\core\area.h(668): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T22:33:42.250Z] 

T10243: Some KDE applications could use better icons

2020-02-29 Thread Nathaniel Graham
ngraham added a revision: D25123: New yakuake logo/icon.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: ngraham
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender


KDE CI: Applications » okular » kf5-qt5 WindowsMSVCQt5.14 - Build # 32 - Still unstable!

2020-02-29 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20WindowsMSVCQt5.14/32/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 29 Feb 2020 10:34:31 +
 Build duration:
3 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 10 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.addremoveannotationtestFailed: projectroot.autotests.annotationstestFailed: projectroot.autotests.calculatetexttestFailed: projectroot.autotests.documenttestFailed: projectroot.autotests.editannotationcontentstestFailed: projectroot.autotests.editformstestFailed: projectroot.autotests.modifyannotationpropertiestestFailed: projectroot.autotests.searchtestFailed: projectroot.autotests.signatureformtestFailed: projectroot.autotests.translateannotationtestName: projectroot.conf Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.generators Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.generators.kimgio.kimgiotest

KDE CI: Applications » okular » kf5-qt5 WindowsMSVCQt5.14 - Build # 31 - Failure!

2020-02-29 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20WindowsMSVCQt5.14/31/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 29 Feb 2020 09:00:29 +
 Build duration:
1 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 1078 lines...][2020-02-29T09:02:06.724Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.724Z] ][2020-02-29T09:02:06.724Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T09:02:06.724Z] with[2020-02-29T09:02:06.724Z] [[2020-02-29T09:02:06.724Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.724Z] ][2020-02-29T09:02:06.724Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T09:02:06.724Z] with[2020-02-29T09:02:06.724Z] [[2020-02-29T09:02:06.724Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T09:02:06.724Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.724Z] ][2020-02-29T09:02:06.724Z] C:\CI\Job Build\core\area.h(671): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T09:02:06.724Z] with[2020-02-29T09:02:06.724Z] [[2020-02-29T09:02:06.724Z] NormalizedShape=Okular::NormalizedRect[2020-02-29T09:02:06.724Z] ][2020-02-29T09:02:06.724Z] C:\CI\Job Build\core\area.h(949): note: see reference to class template instantiation 'Okular::RegularArea' being compiled[2020-02-29T09:02:06.724Z] [79/329] Building CXX object CMakeFiles\okularcore.dir\core\textdocumentsettings.cpp.obj[2020-02-29T09:02:06.990Z] [80/329] Linking CXX executable bin\urldetecttest.exe[2020-02-29T09:02:06.990Z] [81/329] Linking CXX executable bin\editdrawingtooldialogtest.exe[2020-02-29T09:02:06.990Z] [82/329] Building CXX object CMakeFiles\okularcore.dir\core\script\event.cpp.obj[2020-02-29T09:02:06.990Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-02-29T09:02:06.990Z] with[2020-02-29T09:02:06.990Z] [[2020-02-29T09:02:06.990Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.990Z] ][2020-02-29T09:02:06.990Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T09:02:06.990Z] with[2020-02-29T09:02:06.990Z] [[2020-02-29T09:02:06.990Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.990Z] ][2020-02-29T09:02:06.990Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T09:02:06.990Z] with[2020-02-29T09:02:06.990Z] [[2020-02-29T09:02:06.990Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T09:02:06.990Z] T=Okular::NormalizedRect[2020-02-29T09:02:06.990Z] ][2020-02-29T09:02:06.990Z] C:\CI\Job Build\core\area.h(671): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T09:02:06.990Z] with[2020-02-29T09:02:06.990Z] [[2020-02-29T09:02:06.990Z] NormalizedShape=Okular::NormalizedRect[2020-02-29T09:02:06.990Z] ][2020-02-29T09:02:06.990Z] C:\CI\Job Build\core\area.h(949): note: see reference to class template instantiation 'Okular::RegularArea' being compiled[2020-02-29T09:02:07.255Z] [83/329] Building CXX object CMakeFiles\okularcore.dir\core\fileprinter.cpp.obj[2020-02-29T09:02:07.255Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-02-29T09:02:07.255Z] with[2020-02-29T09:02:07.255Z] [[2020-02-29T09:02:07.255Z] T=Okular::NormalizedRect[2020-02-29T09:02:07.255Z] ][2020-02-29T09:02:07.255Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-02-29T09:02:07.255Z] with[2020-02-29T09:02:07.255Z] [[2020-02-29T09:02:07.255Z] T=Okular::NormalizedRect[2020-02-29T09:02:07.255Z] ][2020-02-29T09:02:07.255Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-02-29T09:02:07.255Z] with[2020-02-29T09:02:07.255Z] [[2020-02-29T09:02:07.255Z] NormalizedShape=Okular::NormalizedRect,[2020-02-29T09:02:07.255Z] T=Okular::NormalizedRect[2020-02-29T09:02:07.255Z] ][2020-02-29T09:02:07.255Z] C:\CI\Job Build\core\area.h(671): note: see reference to class template instantiation 'QList' being compiled[2020-02-29T09:02:07.255Z]   

KDE CI: Applications » okular » kf5-qt5 SUSEQt5.12 - Build # 177 - Fixed!

2020-02-29 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20SUSEQt5.12/177/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 29 Feb 2020 08:02:07 +
 Build duration:
3 min 34 sec and counting
   BUILD ARTIFACTS
  acc/Okular5-1.9.70.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)Name: projectroot.conf Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.generators Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report89%
(24/27)60%
(165/277)60%
(165/277)43%
(18575/43042)29%
(7858/27134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(4/4)100%
(4/4)61%
(1186/1942)43%
(536/1245)autotests100%
(20/20)100%
(20/20)99%
(3209/3236)46%
(1567/3403)conf7%
(1/14)7%
(1/14)6%
(52/841)0%
(1/252)conf.autotests100%
(1/1)100%
(1/1)100%
(16/16)50%
(5/10)core86%
(43/50)86%
(43/50)58%
(5673/9864)43%
(2604/6105)core.script100%
(13/13)100%
(13/13)60%
(601/1008)38%
(146/386)generators.comicbook33%
(2/6)33%
(2/6)2%
(10/436)0%
(0/457)generators.dvi2%
(1/44)2%
(1/44)0%
(10/3536)0%
(1/2283)generators.epub100%
(3/3)100%
(3/3)69%
(230/334)55%
(111/203)generators.epub.autotests100%
(1/1)100%
(1/1)100%
(32/32)50%
(12/24)generators.fax17%
(1/6)17%
(1/6)2%
(7/430)0%
(0/585)generators.fictionbook67%
(2/3)67%
(2/3)3%
(15/566)0%
(2/416)generators.kimgio100%
(1/1)100%
(1/1)65%
(46/71)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(48/48)44%
(14/32)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/116)0%
(0/106)generators.ooo29%
(2/7)29%
(2/7)1%
(13/1113)0%
(0/648)generators.plucker100%
(1/1)100%