[okular] [Bug 424310] Several actions share icons
https://bugs.kde.org/show_bug.cgi?id=424310 Nate Graham changed: What|Removed |Added Severity|normal |minor Status|REPORTED|CONFIRMED Summary|Different items in toolbar |Several actions share icons |have same icon | CC||n...@kde.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 353560] Shift-draw straight annotation line to make vertical/horizontal
https://bugs.kde.org/show_bug.cgi?id=353560 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #5 from Luigi Toscano --- (In reply to David Hurka from comment #4) > (The actual code implementing this feature was submitted by Luca Citi. > Thanks!) Can you please revert and use the authorship information in git to properly attribute the commits? (also for other similar fixes). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 353560] Shift-draw straight annotation line to make vertical/horizontal
https://bugs.kde.org/show_bug.cgi?id=353560 --- Comment #4 from David Hurka --- (The actual code implementing this feature was submitted by Luca Citi. Thanks!) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 410723] Freehand annotation jagged lines with stylus
https://bugs.kde.org/show_bug.cgi?id=410723 --- Comment #27 from David Hurka --- (Credits for the patch go to Rene.) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 410723] Freehand annotation jagged lines with stylus
https://bugs.kde.org/show_bug.cgi?id=410723 David Hurka changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/15ac564b ||93a3c17b7ccdf2ce701bac88bb4 ||3d741 Version Fixed In||1.11 Status|CONFIRMED |RESOLVED --- Comment #26 from David Hurka --- Git commit 15ac564b93a3c17b7ccdf2ce701bac88bb43d741 by David Hurka. Committed on 16/07/2020 at 22:58. Pushed by davidhurka into branch 'release/20.08'. Annotations: explicitly accept tablet event when it is handled This fixes the jagged freehand lines problem. It was caused because tablet events were not accepted, and so were delivered again as mouse event, creating an additional line point slightly offset, causing sharp line angles. FIXED-IN: 1.11 M +3-0ui/pageview.cpp https://invent.kde.org/graphics/okular/commit/15ac564b93a3c17b7ccdf2ce701bac88bb43d741 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424312] New: Okular doesn't print letter size sends print job as A4
https://bugs.kde.org/show_bug.cgi?id=424312 Bug ID: 424312 Summary: Okular doesn't print letter size sends print job as A4 Product: okular Version: 1.9.3 Platform: Kubuntu Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: printing Assignee: okular-devel@kde.org Reporter: cciet...@gmail.com Target Milestone: --- SUMMARY STEPS TO REPRODUCE 1. Paper is set to "Letter" everywhere even in print dialog. 2. Print 3. OBSERVED RESULT: Print sent by Okular as A4 so printer is looking for A4 and doesn't print EXPECTED RESULT: Print as usual as every other app on Kubuntu is printing fine and printer has no issues either. SOFTWARE/OS VERSIONS Operating System: Kubuntu 20.04 KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.68.0 Qt Version: 5.12.8 Kernel Version: 5.4.0-40-generic OS Type: 64-bit Processors: 2 × Intel® Core™2 Duo CPU P8700 @ 2.53GHz Memory: 7.5 GiB of RAM ADDITIONAL INFORMATION: Same issue already discussed here https://forums.opensuse.org/showthread.php/532281-KDE-applications-always-print-A4-paper-size -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 353560] Shift-draw straight annotation line to make vertical/horizontal
https://bugs.kde.org/show_bug.cgi?id=353560 David Hurka changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||1.11 Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/34708565 ||caeb5d5fe9b8c14b9cd0af1a8ab ||8d5fe Status|ASSIGNED|RESOLVED --- Comment #3 from David Hurka --- Git commit 34708565caeb5d5fe9b8c14b9cd0af1a8ab8d5fe by David Hurka. Committed on 16/07/2020 at 22:32. Pushed by davidhurka into branch 'release/20.08'. Add Constrain Angle action for annotation tools, alternative to pressing Shift This adds a KToggleAction which sets annotation tools to constrain angle mode. It provides an alternative user interface to the Shift button, which is used to constrain angles since MR !210. The action and the Shift button are XOR-ed, i. e. if constrain angle mode is activated, pressing Shift temporarily disables it. The action state is remembered accross sessions, for consistency with most other actions. It should be difficult to check this action without knowing of its existence, since it is not in any toolbar or menu, just in the action collection. The meaning of AnnotatorEngine::Modifiers was generalized a bit, moving the responsibility about whether to constrain angles back to PageViewAnnotator, because AnnotatorEngine does not know about the action. FIXED-IN: 1.11 M +4-7doc/index.docbook M +23 -2ui/annotationactionhandler.cpp M +2-6ui/annotationtools.cpp M +4-3ui/annotationtools.h M +23 -6ui/pageviewannotator.cpp M +11 -0ui/pageviewannotator.h M +1-1ui/presentationwidget.cpp https://invent.kde.org/graphics/okular/commit/34708565caeb5d5fe9b8c14b9cd0af1a8ab8d5fe -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 330364] presentation window raises upon gaining focus, does not obey window manager settings
https://bugs.kde.org/show_bug.cgi?id=330364 --- Comment #2 from David Hurka --- I agree that this behavior is frustrating. As far as I can reproduce it now, it is not an Okular issue. On my KDE Neon, any fullscreen window (including non-Qt applications) raises automatically when it gets focus. Might be interesting which window manager you use and how it is configured. Maybe it is possible to configure fullscreen windows to behave like any other window? (Would probably mean that the panel is visible.) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424310] New: Different items in toolbar have same icon
https://bugs.kde.org/show_bug.cgi?id=424310 Bug ID: 424310 Summary: Different items in toolbar have same icon Product: okular Version: 1.10.1 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: med.medin.2...@gmail.com Target Milestone: --- Created attachment 130192 --> https://bugs.kde.org/attachment.cgi?id=130192=edit Duplicated icons for different items in toolbar When I use Only icons for items in toolbar, I get duplicated icons and there is no way to differentiate between them, for example : - Next and Forward have same icon. - Previous and Back have same icon. - Find Next and Next Bookmark have same icon. - Find Previous and Previous Bookmark have same icon. - Auto Fit, Fit Page and Zoom have same icon. - See my attached image for more info. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424285] Shortcut or button to toggle accessibility
https://bugs.kde.org/show_bug.cgi?id=424285 --- Comment #2 from medin --- (In reply to David Hurka from comment #1) > 1. Restart Okular, the shortcut should work now. > Thats another bug exclusively shipped with Okular, new shortcuts are lost > until a restart. > > 2. A toolbar button is already available as patch, but not until 20.08 > (deadline would be today...). Until now, you can use the “Toggle Change > Colors” push button, e. g. add it with Settings -> Configure Toolbars to the > toolbar. The only problem is that it doesn’t toggle itself, only the > viewport toggles. Thanks that was really helpful, You are right the problem with shortcut was persistent because I never close Okular I kept it always opened with all my needed pdf files, but after closing all my files and restarting the shortcut is working again. And I also added “Toggle Change Colors” push button to toolbar and it seems to work really good. You saved me a lot of time because I always keep Okular colors to White (foreground) on top of dark gray (background) to avoid hurting my eyes especially at night, but for some files that have technical drawings I need to always temporary disable the changed colors to see correctly its contents. Really big thanks to you :) -- You are receiving this mail because: You are the assignee for the bug.
T10243: Some KDE applications could use better icons
ngraham added a comment. @alex-l nobody shares your opinion that app icons are different from logos and that therefore they should have a minimal, understated style and do not need to mimic the original version. This isn't a self-evident design truth, it's just your opinion on icon design, and nobody else seems to agree with you. Breeze icons are a theme among many themes, and not the canonical source of truth regarding apps' icons; changing an icon radically requires the consent of the app's author for them to change not only the Breeze icon, but also to change the original icon, potentially adopting the Breeze icon as the new original icon. You keep decrying that no real designers are reviewing icons yet you don't want to step up and do this, other than complaining that everyone else's work is crap. You should help guide new designers rather than just telling them to stop doing anything because the status quo is perfect. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender
[okular] [Bug 424296] Quick annotation action gets wrongly activated on protected pdf
https://bugs.kde.org/show_bug.cgi?id=424296 --- Comment #1 from David Hurka --- AFAIK PDF protection is only a hypothetical thing. If you uncheck Configure Okular -> General -> Obey DRM limitations, annotation tools should be activated, and annotations are saved in the PDF as usual. So yes, the annotation tools are only disabled to pretend that the PDF is protected. What do you mean with “gets activated”? “I wanted to select text, but it gave me an annotation tool instead”? Or just that annotation actions become enabled? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424285] Shortcut or button to toggle accessibility
https://bugs.kde.org/show_bug.cgi?id=424285 David Hurka changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |NOT A BUG --- Comment #1 from David Hurka --- 1. Restart Okular, the shortcut should work now. Thats another bug exclusively shipped with Okular, new shortcuts are lost until a restart. 2. A toolbar button is already available as patch, but not until 20.08 (deadline would be today...). Until now, you can use the “Toggle Change Colors” push button, e. g. add it with Settings -> Configure Toolbars to the toolbar. The only problem is that it doesn’t toggle itself, only the viewport toggles. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424296] New: Quick annotation action gets wrongly activated on protected pdf
https://bugs.kde.org/show_bug.cgi?id=424296 Bug ID: 424296 Summary: Quick annotation action gets wrongly activated on protected pdf Product: okular Version: unspecified Platform: Manjaro OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: simg...@gmail.com Target Milestone: --- SUMMARY When a pdf is protected PageView does not activate the annotation tools, so also "Quick Annotations" should be inactive all the time. Actually this bug exposed me the fact that if the annotation tools are active, I can actually add annotations to a protected pdf, and save it. But apparently the annotations are not saved IN the pdf, but probably in an overlay managed by Okular, right? The point of disabling the annotations tools is to disable this behaviour? STEPS TO REPRODUCE 1. Open a protected pdf (e.g. autotests/data/protected.pdf) 2. Select "Text Selection" OBSERVED RESULT "Quick annotation" gets activated EXPECTED RESULT "Quick annotation" remains deactivated SOFTWARE/OS VERSIONS Operating System: Manjaro Linux KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.70.0 Qt Version: 5.15.0 Kernel Version: 5.4.44-1-MANJARO OS Type: 64-bit -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #12 from Simone Gaiarin --- >From what I understand from the gdb backtrace it seems that it fails in the cast after the assert, so does not seem exactly 423335 (sorry for changing my mind three times). I would be good to test this again with the fix to 423335 (I am not sure the version of Okular you are using has that fix yet) and in case reopen this bug. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 423335] Assert crash at closing focused tab with new annotation toolbar
https://bugs.kde.org/show_bug.cgi?id=423335 Albert Astals Cid changed: What|Removed |Added CC||sepa...@gmail.com --- Comment #5 from Albert Astals Cid --- *** Bug 424249 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Albert Astals Cid --- *** This bug has been marked as a duplicate of bug 423335 *** -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424285] New: Shortcut or button to toggle accessibility
https://bugs.kde.org/show_bug.cgi?id=424285 Bug ID: 424285 Summary: Shortcut or button to toggle accessibility Product: okular Version: 1.10.3 Platform: Other OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: med.medin.2...@gmail.com Target Milestone: --- I use change color in accessibility to adapt okular to my eye in the night, so I wish we have some shortcut or button in the toolbar to enable/disable accessibility in okular. I tried using shortcut but the chosen shortcut worked once then stoped working for second time, and after checking the shortcut setting in okular the saved shortcut is gone. -- You are receiving this mail because: You are the assignee for the bug.
T10243: Some KDE applications could use better icons
tosta added a comment. @alex-l can you say me what's wrong with these icons? I'm trying to do it following all HIG recommendations (sizes, margins, colors...). I'm not a specialist as you said, @ngraham does not recruited me, and I'm aware his OK is not a approval. But I'm trying to help because I love KDE and I'm doing personal hacks and improvements for years. Please contact me privately if you want. TASK DETAIL https://phabricator.kde.org/T10243 To: tosta Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #10 from ParsaMousavi --- Created attachment 130167 --> https://bugs.kde.org/attachment.cgi?id=130167=edit Okular debugging in GDB -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #9 from Simone Gaiarin --- Can you execute `gdb okular` then `run` and attach the trace of gdb after the crash. (should say something about an assert failing). Actually seems to be 423335, now that I've read better the trace. This should be fixed in the 20.08 release of Okular. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #8 from ParsaMousavi --- Created attachment 130157 --> https://bugs.kde.org/attachment.cgi?id=130157=edit Okular crash backtrace when closing a tab with the middle-click -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #7 from ParsaMousavi --- Created attachment 130156 --> https://bugs.kde.org/attachment.cgi?id=130156=edit Okular crash backtrace when pressing the X close button -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #6 from ParsaMousavi --- Yes.Please take a look at the two new attachments. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts
https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #5 from Simone Gaiarin --- Does not seem to be 423335. Does the crash happen if you close the current focused tab with the middle click of the mouse or the X close button? -- You are receiving this mail because: You are the assignee for the bug.
T10243: Some KDE applications could use better icons
alex-l added a comment. @ngraham can you stop this please? You all are ruining all our previous work. Aren't you able to see how much wrong these icons are? Can we please stop recruiting pleale without the needed skills for this work and don't give OKs by people who contribute in other areas (you)? This is serious stuff exactly like code, don't treat imagery like a second citizen. In other communities (Mozilla, GNOME, Elementary) this doesn't happen. TASK DETAIL https://phabricator.kde.org/T10243 To: alex-l Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender