D22903: Improve search field

apol accepted this revision. REPOSITORY R223 Okular BRANCH improve-searchfield REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham, apol Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D12250: Install okularpart with the rest of kparts

apol abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12250 To: apol, #okular, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18397 To: vkrause, apol Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D16544: Properly find the Purpose framework

apol added a comment. \o/ REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16544 To: apol, #okular, aacid Cc: okular-devel, ngraham, darcyshen, aacid

D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R223 Okular BRANCH Applications/18.12 REVISION DETAIL https://phabricator.kde.org/D17196 To: heikobecker, #okular, apol Cc: okular-devel, ngraham, darcyshen, aacid

D16544: Properly find the Purpose framework

apol abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16544 To: apol, #okular, aacid Cc: okular-devel, ngraham, aacid

D16544: Properly find the Purpose framework

apol created this revision. apol added reviewers: Okular, aacid. Herald added a project: Okular. Herald added a subscriber: okular-devel. apol requested review of this revision. REPOSITORY R223 Okular BRANCH findkf5purpose REVISION DETAIL https://phabricator.kde.org/D16544 AFFECTED FILES

D14102: Add share action to selection context menu

apol added a comment. I'd say it would make sense to just make it possible to drag and drop this to the quick share plasmoid. Or just put it on the clipboard and paste it there. INLINE COMMENTS > pageview.cpp:60 > #include > +#include > +#include Purpose is already used in other parts

D12884: Remove the internal file navigation from the global drawer

This revision was automatically updated to reflect the committed changes. Closed by commit R223:600e72100b13: Remove the internal file navigation from the global drawer (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34335=34371

D12884: Remove the internal file navigation from the global drawer

apol updated this revision to Diff 34335. apol added a comment. Remove hardcoded path REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34297=34335 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 AFFECTED FILES

D12884: Remove the internal file navigation from the global drawer

apol marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

apol updated this revision to Diff 34297. apol added a comment. Don't add logic in core/ just in case REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12884?vs=34168=34297 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 AFFECTED FILES

D12884: Remove the internal file navigation from the global drawer

apol added inline comments. INLINE COMMENTS > aacid wrote in document.cpp:2362 > I don't think it's a good idea changing the behaviour, can't you fix the > mobile app to do the right thing? Sure, I did it because it feels like broken API. It just complains and doesn't do anything when you

D12884: Remove the internal file navigation from the global drawer

apol created this revision. apol added reviewers: Okular, mart, aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. apol requested review of this revision. REVISION SUMMARY Instead include an "open" item. TEST PLAN opened a file

D12770: Android: Make it possible to associate with files

This revision was automatically updated to reflect the committed changes. Closed by commit R223:cf4bb5e3b178: Android: Make it possible to associate with files (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12770?vs=33858=33998#toc REPOSITORY R223 Okular CHANGES

D12770: Android: Make it possible to associate with files

apol created this revision. apol added reviewers: Okular, aacid, mart. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Put the file into a file descriptor and open this file descriptor. Just application/pdf for now. TEST PLAN opened

D12672: Use a target in FindDiscount (modern cmake) rather than variables

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It's actually fixing the build when discount is in its own prefix. Also I agree that it's better using targets. REPOSITORY R223 Okular BRANCH Applications/18.04 REVISION DETAIL

D12352: Make it possible to disable the build of okularkirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:1fb77446a737: Make it possible to disable the build of okularkirigami (authored by apol). REPOSITORY R223 Okular

D12352: Make it possible to disable the build of okularkirigami

apol updated this revision to Diff 32616. apol added a comment. Improve description REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12352?vs=32569=32616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12352 AFFECTED FILES CMakeLists.txt

D12352: Make it possible to disable the build of okularkirigami

apol created this revision. apol added reviewers: Okular, mart, aacid, lbeltrame. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Some distros seem to have the option. BUG: 393119 TEST PLAN Still builds, can disable build

D12299: Android: include metadata for okular kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R223:77049d3b80c2: Android: include metadata for okular kirigami (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12299?vs=32434=32523#toc REPOSITORY R223 Okular CHANGES SINCE

D12299: Android: include metadata for okular kirigami

apol created this revision. apol added reviewers: Okular, mart, aacid. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Include an AndroidManifest.xml file so when it's installed it has a proper icon and name. Include appdata

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32353. apol added a comment. The shell needs to know where the plugin is REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32348=32353 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32348. apol added a comment. And another REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32347=32348 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED FILES CMakeLists.txt

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32347. apol added a comment. There's more desktop files pointing to okularpart REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32319=32347 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32319. apol added a comment. Unsure why it worked for me, point to the library like katepart does REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32300=32319 BRANCH installprefix REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32318. apol added a comment. Oops REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32317=32318 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32317. apol added a comment. Unsure why it works on my system, adopt the same way to point to the path katepart uses REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32303=32317 BRANCH master REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32303. apol added a comment. Shouldn't comment the include... REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32302=32303 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32302. apol added a comment. Typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32296=32302 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12250: Install okularpart with the rest of kparts

apol created this revision. apol added reviewers: Okular, aacid. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY We have a directory with all kparts, okular should integrate there TEST PLAN Uninstalled, installed with the patch

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32296. apol added a comment. Address Albert's concern REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32072=32296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

apol created this revision. apol added a reviewer: Okular. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Disables KWallet integration if there's no KWallet, KJS if there's no KJS and KDocTools. Here's a list of frameworks that don't

D12176: Turn okularkirigami into an executable

This revision was automatically updated to reflect the committed changes. Closed by commit R223:5f8f84d53cf8: Turn okularkirigami into an executable (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12176?vs=32070=32071 REVISION DETAIL

D10007: Fix Build with Purpose

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Shouldn't be needed anymore. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10007 To: tcanabrava, #okular, apol Cc: michaelweghorn, aacid, ltoscano,

D10022: Fix annoying warning

apol created this revision. apol added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Warning for every plugin was: The file includes the moc file

D10007: Fix Build with Purpose

apol added a comment. I changed it so KDEExperimental still works with newer Purpose. I'd say let's keep the old one and when it's released again, then just change to just KF5::Purpose. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10007 To: tcanabrava, #okular,

Re: Review Request 129347: add metadata for kimgio, mobipocket, ooo, plucker, poppler, spectre, txt, xps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129347/#review100739 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 6

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote: > > shell/shell.cpp, line 441 > > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441> > > > > I think it would make sense to move that logic upstream. > > &g

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote: > > shell/shell.cpp, line 441 > > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441> > > > > I think it would make sense to move that logic upstream. > > &g

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

Use foreach or qAsConst. shell/shell.cpp (line 441) <https://git.reviewboard.kde.org/r/128435/#comment65725> I think it would make sense to move that logic upstream. It's not something specific about okular. - Aleix Pol Gonzalez On July 13, 2016, 11:57 p.m., Martin Tobias H

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

usage that I ported. Diffs - shell/shell.cpp c97054a Diff: https://git.reviewboard.kde.org/r/127021/diff/ Testing --- Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf Thanks, Aleix Pol

Re: [Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

xport macros at configure time. - Aleix Pol Gonzalez On March 14, 2016, 1:17 a.m., Thomas Friedrichsmeier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

shell/shell.cpp c97054a Diff: https://git.reviewboard.kde.org/r/127042/diff/ Testing --- Now I can open files with a space in it. Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

https://git.reviewboard.kde.org/r/127042/diff/ Testing --- Now I can open files with a space in it. Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) >

[Okular-devel] Review Request 127042: Fix QUrl string encoding

- shell/okular_main.cpp 9bdc1fe Diff: https://git.reviewboard.kde.org/r/127042/diff/ Testing --- Now I can open files with a space in it. Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

oded. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127042/#review92284 --- On Feb. 11, 2016, 8:50 p.m., Aleix Pol

[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

://git.reviewboard.kde.org/r/127021/diff/ Testing --- Opening dialog seems to work fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127021/#review92202 --- On Feb. 9, 2016, 3:51 p.m., Aleix Pol Gonzalez wrote: > > ---

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

fine, tests still pass except for parttest, but I'm unsure it's related: https://paste.kde.org/p37pdubgf Thanks, Aleix Pol Gonzalez ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

> On Dec. 16, 2015, 5:42 p.m., Alex Richardson wrote: > > ui/guiutils.cpp, line 207 > > > > > > Not really related but it would be nice to handle remote URLs here as > > well, QFileDialog::getSaveFileUrl() and

Re: [Okular-devel] Review Request 126913: use QScreen unconditionally instead of libkscreen

> On Jan. 30, 2016, 4:15 p.m., Albert Astals Cid wrote: > > Hold an A4 paper against your screen at 100% zoom, is the page of proper > > size? I just tested it, looks good. - Aleix --- This is an automatically generated e-mail. To

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

t; Patrick Spendrin wrote: > Yes, I only saw that after the review was opened, I'll adapt this to the > way the other generators handle it. > > Aleix Pol Gonzalez wrote: > I'll fix it and commit the patch.

Re: [Okular-devel] Review Request 126379: Windows string fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126379/#review90208 --- +1 - Aleix Pol Gonzalez On Dec. 27, 2015, 1:28 a.m

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

--- On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102220/ --- (Updated Aug. 5, 2011, 7:52 a.m.) Review request for Okular. Summary

[Okular-devel] Review Request: Change mouse cursor when changing the current tool.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102221/ --- Review request for Okular. Summary --- Update the cursors when