[Okular-devel] [okular] [Bug 311037] Okular Crashs
https://bugs.kde.org/show_bug.cgi?id=311037 --- Comment #9 from Christoph Feck --- If you can provide the information requested in comment #8, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 313601] Okular displays blank pages in Print Preview, blank pages on printer (print failure without crash)
https://bugs.kde.org/show_bug.cgi?id=313601 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 313986] various lines are displayed at one line
https://bugs.kde.org/show_bug.cgi?id=313986 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 313984] Okular crashed after changing the colour of some highlighted text
https://bugs.kde.org/show_bug.cgi?id=313984 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 289468] PDF Form entry not displaying
https://bugs.kde.org/show_bug.cgi?id=289468 --- Comment #5 from Christoph Feck --- If you can provide the information requested in comment #4, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 314693] Crash when printing A3 & A4 mixed PDF
https://bugs.kde.org/show_bug.cgi?id=314693 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [kdelibs] [Bug 313984] Okular crashed after changing the colour of some highlighted text
https://bugs.kde.org/show_bug.cgi?id=313984 Christoph Feck changed: What|Removed |Added Component|general |general Version|0.15.5 |4.9.5 Assignee|okular-devel@kde.org|kdelibs-b...@kde.org Product|okular |kdelibs -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317422] crash while printing pdf from ps
https://bugs.kde.org/show_bug.cgi?id=317422 Christoph Feck changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316890] Intelligent automatic reload
https://bugs.kde.org/show_bug.cgi?id=316890 --- Comment #9 from Christoph Feck --- I am not really sure, but I think Nepomuk developers found a way to only get notified when a file is finally closed after writing (e.g. download finished), instead of whenever it is modified. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317551] PDF pages rendered blank at >100% Zoom
https://bugs.kde.org/show_bug.cgi?id=317551 --- Comment #9 from Christoph Feck --- If you can provide the information requested in comment #8, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317885] keyboard focus issues
https://bugs.kde.org/show_bug.cgi?id=317885 --- Comment #3 from Christoph Feck --- Albert, does comment #2 provide the requested information? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318048] okular hangs up for about 2 minutes while loading a new epub
https://bugs.kde.org/show_bug.cgi?id=318048 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317422] crash while printing pdf from ps
https://bugs.kde.org/show_bug.cgi?id=317422 --- Comment #14 from Christoph Feck --- You can use "dpkg -s packagename" to get information about packages. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318048] okular hangs up for about 2 minutes while loading a new epub
https://bugs.kde.org/show_bug.cgi?id=318048 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 319507] Nowhere to print annotations
https://bugs.kde.org/show_bug.cgi?id=319507 --- Comment #3 from Christoph Feck --- If you can provide the information requested in comment #2, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316802] okular crashes when adding a stamp
https://bugs.kde.org/show_bug.cgi?id=316802 --- Comment #10 from Christoph Feck --- If you can provide the information in comment #9, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317551] PDF pages rendered blank at >100% Zoom
https://bugs.kde.org/show_bug.cgi?id=317551 --- Comment #12 from Christoph Feck --- If you can provide the information requested in comment #11, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320220] okular crashes when opening any pdf
https://bugs.kde.org/show_bug.cgi?id=320220 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Christoph Feck --- *** This bug has been marked as a duplicate of bug 270442 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320291] Ocular crashed after changing the printer settings
https://bugs.kde.org/show_bug.cgi?id=320291 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320317] pages shown in thumbnails displayed as blank in main area
https://bugs.kde.org/show_bug.cgi?id=320317 --- Comment #7 from Christoph Feck --- If you can provide the information requested in comment #6, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320695] This pdf: 'GNU/Linux Basic operating system' the bookmarks & links are not active/visible.
https://bugs.kde.org/show_bug.cgi?id=320695 --- Comment #4 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320960] Okular crash closing window during startup of pdf view
https://bugs.kde.org/show_bug.cgi?id=320960 --- Comment #3 from Christoph Feck --- Albert, is there any additional information you need from the reporter? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321956] Make paragraphs look nicer (indent them properly)
https://bugs.kde.org/show_bug.cgi?id=321956 Christoph Feck changed: What|Removed |Added Severity|normal |minor --- Comment #3 from Christoph Feck --- The line and uneven letter spacing adds to the impression. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 201108] thumbnail sidebar always gets shown; no way to disable
https://bugs.kde.org/show_bug.cgi?id=201108 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321212] copy/paste big text from words to a form textbox makes the render go crazy
https://bugs.kde.org/show_bug.cgi?id=321212 --- Comment #10 from Christoph Feck --- If I understand the discussion correctly, this bug should be marked confirmed? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321556] printig multible pages per site results in to small pages
https://bugs.kde.org/show_bug.cgi?id=321556 --- Comment #2 from Christoph Feck --- So do you agree to close this bug? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321900] okular crashes when closing pdfs with a video inside (movie15)
https://bugs.kde.org/show_bug.cgi?id=321900 --- Comment #3 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. For help about installing debug packages please ask in a forum of your distribution or see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322310] Konqueror crashed trying to open pdf from sukl.cz
https://bugs.kde.org/show_bug.cgi?id=322310 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de Component|general |general Version|4.10.4 |unspecified Assignee|konq-b...@kde.org |okular-devel@kde.org Product|konqueror |okular -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322298] Midi support for turn page.
https://bugs.kde.org/show_bug.cgi?id=322298 --- Comment #1 from Christoph Feck --- I do not think this is Okular-specific. There could be a software/driver generating regular XI input events from this devices, so that all applications could set up shortcuts using this device. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321900] okular crashes when closing pdfs with a video inside (movie15)
https://bugs.kde.org/show_bug.cgi?id=321900 --- Comment #4 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322127] Okular crashes on CHM files
https://bugs.kde.org/show_bug.cgi?id=322127 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 253583] Okular uses font color from system settings, but ignores the background color from there.
https://bugs.kde.org/show_bug.cgi?id=253583 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de --- Comment #11 from Christoph Feck --- Albert, before I look into this, would you rather like the background to use the system color, or the text color to be hard coded to black? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- Review request for Okular and Albert Astals Cid. Description --- As indicated in bug 322547, some documents do not specify a text color, and probably assume the default text color to be black. QTextDocument, however, defaults to using the system text color. This patch changes the default text color to Qt::black. It should affect epub, fb2, odt, and plain text generators. I think it is better to use this approach instead of changing the paper color to use the system background color (see bug 253583), because 1) the document might specify a text color in some places, 2) the user is able to change the fg/bg colors anyway using Okular's Accessibility options, and those probably expect black on white. This addresses bugs 253583 and 322547. http://bugs.kde.org/show_bug.cgi?id=253583 http://bugs.kde.org/show_bug.cgi?id=322547 Diffs - core/textdocumentgenerator.cpp b260b3f Diff: http://git.reviewboard.kde.org/r/111681/diff/ Testing --- I tested the document from bug 322547 comment #3. Thanks, Christoph Feck ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 253583] Okular uses font color from system settings, but ignores the background color from there.
https://bugs.kde.org/show_bug.cgi?id=253583 --- Comment #12 from Christoph Feck --- Scratch that, see https://git.reviewboard.kde.org/r/111681/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated July 25, 2013, noon) Review request for Okular and Albert Astals Cid. Changes --- Also set default Link colors. Description --- As indicated in bug 322547, some documents do not specify a text color, and probably assume the default text color to be black. QTextDocument, however, defaults to using the system text color. This patch changes the default text color to Qt::black. It should affect epub, fb2, odt, and plain text generators. I think it is better to use this approach instead of changing the paper color to use the system background color (see bug 253583), because 1) the document might specify a text color in some places, 2) the user is able to change the fg/bg colors anyway using Okular's Accessibility options, and those probably expect black on white. This addresses bugs 253583 and 322547. http://bugs.kde.org/show_bug.cgi?id=253583 http://bugs.kde.org/show_bug.cgi?id=322547 Diffs (updated) - core/textdocumentgenerator.cpp b260b3f Diff: http://git.reviewboard.kde.org/r/111681/diff/ Testing --- I tested the document from bug 322547 comment #3. Thanks, Christoph Feck ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322127] Okular crashes on CHM files
https://bugs.kde.org/show_bug.cgi?id=322127 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322357] PDF Annotations in certain pages crash Okular
https://bugs.kde.org/show_bug.cgi?id=322357 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322407] Okular does not properly display some gradients
https://bugs.kde.org/show_bug.cgi?id=322407 --- Comment #2 from Christoph Feck --- Please attach a PDF document showing the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322547] Using a Dark Colorscheme frequently leads to unreadable text.
https://bugs.kde.org/show_bug.cgi?id=322547 --- Comment #4 from Christoph Feck --- Duplicate of bug 253583 or bug 306572. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322993] Okular always prints in duplex mode
https://bugs.kde.org/show_bug.cgi?id=322993 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320317] pages shown in thumbnails displayed as blank in main area
https://bugs.kde.org/show_bug.cgi?id=320317 --- Comment #8 from Christoph Feck --- Alex, if this is still an issue, please attach the PDF. Note that you have to attach files using this web page's "Add an attachment" link. Attaching them to the reply mail will not work. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On July 25, 2013, 12:59 p.m., Jaydeep Solanki wrote: > > Can you please confirm if the links are shown properly > > Albert Astals Cid wrote: > Christoph? Oh, I had the impression the question was directed to you (I looked at the To: field in the mail) The link color now works as intended, but I only have this one test file (see Testing above). - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review36480 --- On July 25, 2013, noon, Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated July 25, 2013, noon) > > > Review request for Okular and Albert Astals Cid. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don't understand is why we need these patches. I would > > understand that if an epub sets the background color it will also set the > > text color (so all is fine, none of "our" colors is used) and if no color > > is set, i would undertand that the color scheme by the user provides > > acceptable colors. > > > > So where is the problem? The problem is not documents that set colors, but those that set no colors (for example, plain text files). In the rendering code, the pixmap is pre-filled with hard-coded white color, but the text is actually rendered using the system's foreground color. This leads to "white on white" with dark color schemes (which usually use white text). There are, as you see, several ways to fix it. Why I believe this one makes more sense that using the system's background color: See my rationale at "Description" above. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- On Aug. 16, 2013, 8:58 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 16, 2013, 8:58 p.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don't understand is why we need these patches. I would > > understand that if an epub sets the background color it will also set the > > text color (so all is fine, none of "our" colors is used) and if no color > > is set, i would undertand that the color scheme by the user provides > > acceptable colors. > > > > So where is the problem? > > Christoph Feck wrote: > The problem is not documents that set colors, but those that set no > colors (for example, plain text files). > > In the rendering code, the pixmap is pre-filled with hard-coded white > color, but the text is actually rendered using the system's foreground color. > This leads to "white on white" with dark color schemes (which usually use > white text). > > There are, as you see, several ways to fix it. Why I believe this one > makes more sense that using the system's background color: See my rationale > at "Description" above. > > Albert Astals Cid wrote: > Ok, can you try Jaydeep's branch epub-qtextdoc according to > https://www.dropbox.com/s/mgf778ug6yjie2l/GSoC%20patches.odt the color issues > are fixed there. Can you confirm? Is the solution acceptable for you? >From quickly checking commit 1823cf9998555e22c6f3d8701728882dc34b244b (which >is documented to fix the color issue), I see that Jaydeep injects CSS code to >change QTextDocument's default color to Qt::black. While this might have the >same result, my approach is simpler and uses less resources. Additionally, it looks like his patch is limited to epub, while my patch works for all generators that use textdocumentgenerator.cpp? Jaydeep might clarify, if I am wrong. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- On Aug. 16, 2013, 8:58 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 16, 2013, 8:58 p.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don't understand is why we need these patches. I would > > understand that if an epub sets the background color it will also set the > > text color (so all is fine, none of "our" colors is used) and if no color > > is set, i would undertand that the color scheme by the user provides > > acceptable colors. > > > > So where is the problem? > > Christoph Feck wrote: > The problem is not documents that set colors, but those that set no > colors (for example, plain text files). > > In the rendering code, the pixmap is pre-filled with hard-coded white > color, but the text is actually rendered using the system's foreground color. > This leads to "white on white" with dark color schemes (which usually use > white text). > > There are, as you see, several ways to fix it. Why I believe this one > makes more sense that using the system's background color: See my rationale > at "Description" above. > > Albert Astals Cid wrote: > Ok, can you try Jaydeep's branch epub-qtextdoc according to > https://www.dropbox.com/s/mgf778ug6yjie2l/GSoC%20patches.odt the color issues > are fixed there. Can you confirm? Is the solution acceptable for you? > > Christoph Feck wrote: > From quickly checking commit 1823cf9998555e22c6f3d8701728882dc34b244b > (which is documented to fix the color issue), I see that Jaydeep injects CSS > code to change QTextDocument's default color to Qt::black. While this might > have the same result, my approach is simpler and uses less resources. > > Additionally, it looks like his patch is limited to epub, while my patch > works for all generators that use textdocumentgenerator.cpp? > > Jaydeep might clarify, if I am wrong. (Let me add that I wasn't aware about his work while I wrote the patch. I have no intention to disturb his work.) - Christoph ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- On Aug. 16, 2013, 8:58 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 16, 2013, 8:58 p.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated Aug. 20, 2013, 10:40 a.m.) Review request for Okular. Changes --- * do not set LinkVisited color as it is not used * change link color to blue instead of darkBlue to match Jaysee's patch Description --- As indicated in bug 322547, some documents do not specify a text color, and probably assume the default text color to be black. QTextDocument, however, defaults to using the system text color. This patch changes the default text color to Qt::black. It should affect epub, fb2, odt, and plain text generators. I think it is better to use this approach instead of changing the paper color to use the system background color (see bug 253583), because 1) the document might specify a text color in some places, 2) the user is able to change the fg/bg colors anyway using Okular's Accessibility options, and those probably expect black on white. This addresses bugs 253583 and 322547. http://bugs.kde.org/show_bug.cgi?id=253583 http://bugs.kde.org/show_bug.cgi?id=322547 Diffs (updated) - core/textdocumentgenerator.cpp b260b3f Diff: http://git.reviewboard.kde.org/r/111681/diff/ Testing --- I tested the document from bug 322547 comment #3. Thanks, Christoph Feck ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don't understand is why we need these patches. I would > > understand that if an epub sets the background color it will also set the > > text color (so all is fine, none of "our" colors is used) and if no color > > is set, i would undertand that the color scheme by the user provides > > acceptable colors. > > > > So where is the problem? > > Christoph Feck wrote: > The problem is not documents that set colors, but those that set no > colors (for example, plain text files). > > In the rendering code, the pixmap is pre-filled with hard-coded white > color, but the text is actually rendered using the system's foreground color. > This leads to "white on white" with dark color schemes (which usually use > white text). > > There are, as you see, several ways to fix it. Why I believe this one > makes more sense that using the system's background color: See my rationale > at "Description" above. > > Albert Astals Cid wrote: > Ok, can you try Jaydeep's branch epub-qtextdoc according to > https://www.dropbox.com/s/mgf778ug6yjie2l/GSoC%20patches.odt the color issues > are fixed there. Can you confirm? Is the solution acceptable for you? > > Christoph Feck wrote: > From quickly checking commit 1823cf9998555e22c6f3d8701728882dc34b244b > (which is documented to fix the color issue), I see that Jaydeep injects CSS > code to change QTextDocument's default color to Qt::black. While this might > have the same result, my approach is simpler and uses less resources. > > Additionally, it looks like his patch is limited to epub, while my patch > works for all generators that use textdocumentgenerator.cpp? > > Jaydeep might clarify, if I am wrong. > > Christoph Feck wrote: > (Let me add that I wasn't aware about his work while I wrote the patch. I > have no intention to disturb his work.) > > Jaydeep Solanki wrote: > For sure, you patch addresses a bigger issue by fixing this for all > generators that use TextDocumentGenerator. > I'd be happy to remove my patch for this patch, but I'm still not finding > the links in blue color. > Albert can you please confirm, if the links show up in blue. > > Jaydeep Solanki wrote: > Okay, it seems that my color scheme was the culprit for not showing links > in blue. I changed color scheme and now it works. > Albert, IMHO this patch seems more appropriate. The other one with > KColorScheme doesn't seem so good, as it changes the background color of the > document which is not necessary. > > Albert Astals Cid wrote: > Hmmm, well, but you're saying that the links in blue still depend on the > color scheme, no? That's still not good. Christoph any idea why that may > happen? I updated the patch to use the (brighter) blue color, instead of darkBlue. It should now match the color Jaydeep uses. I prefer the darker version, though, because it makes text with many links easier to read. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- On Aug. 20, 2013, 10:40 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 20, 2013, 10:40 a.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probabl
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don't understand is why we need these patches. I would > > understand that if an epub sets the background color it will also set the > > text color (so all is fine, none of "our" colors is used) and if no color > > is set, i would undertand that the color scheme by the user provides > > acceptable colors. > > > > So where is the problem? > > Christoph Feck wrote: > The problem is not documents that set colors, but those that set no > colors (for example, plain text files). > > In the rendering code, the pixmap is pre-filled with hard-coded white > color, but the text is actually rendered using the system's foreground color. > This leads to "white on white" with dark color schemes (which usually use > white text). > > There are, as you see, several ways to fix it. Why I believe this one > makes more sense that using the system's background color: See my rationale > at "Description" above. > > Albert Astals Cid wrote: > Ok, can you try Jaydeep's branch epub-qtextdoc according to > https://www.dropbox.com/s/mgf778ug6yjie2l/GSoC%20patches.odt the color issues > are fixed there. Can you confirm? Is the solution acceptable for you? > > Christoph Feck wrote: > From quickly checking commit 1823cf9998555e22c6f3d8701728882dc34b244b > (which is documented to fix the color issue), I see that Jaydeep injects CSS > code to change QTextDocument's default color to Qt::black. While this might > have the same result, my approach is simpler and uses less resources. > > Additionally, it looks like his patch is limited to epub, while my patch > works for all generators that use textdocumentgenerator.cpp? > > Jaydeep might clarify, if I am wrong. > > Christoph Feck wrote: > (Let me add that I wasn't aware about his work while I wrote the patch. I > have no intention to disturb his work.) > > Jaydeep Solanki wrote: > For sure, you patch addresses a bigger issue by fixing this for all > generators that use TextDocumentGenerator. > I'd be happy to remove my patch for this patch, but I'm still not finding > the links in blue color. > Albert can you please confirm, if the links show up in blue. > > Jaydeep Solanki wrote: > Okay, it seems that my color scheme was the culprit for not showing links > in blue. I changed color scheme and now it works. > Albert, IMHO this patch seems more appropriate. The other one with > KColorScheme doesn't seem so good, as it changes the background color of the > document which is not necessary. > > Albert Astals Cid wrote: > Hmmm, well, but you're saying that the links in blue still depend on the > color scheme, no? That's still not good. Christoph any idea why that may > happen? > > Christoph Feck wrote: > I updated the patch to use the (brighter) blue color, instead of > darkBlue. It should now match the color Jaydeep uses. I prefer the darker > version, though, because it makes text with many links easier to read. > > Jaydeep Solanki wrote: > Christoph, I guess Albert is talking about a scenario when the color > scheme has a non blue color for links. Like in my case, I previously used > "Krita-dark" color scheme, which has links in white. In such cases too Okular > needs to display links in blue. Oh, you are right, for links it still uses the scheme color (where I also used dark blue). Sorry for the confusion. QTextCursor::insertHtml() creates CSS styles using the global palette for links, so changing the palette later has no effect. In other words, to change the color of links, we still need to change the CSS manually. Unless epub is the only format offering links, I would suggest to move the CSS fixup code from the epub generator to TextDocumentGenerator, so that other generators benefit from that as well. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- On Aug. 20, 2013, 10:40 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ >
[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom
https://bugs.kde.org/show_bug.cgi?id=249364 --- Comment #12 from Christoph Feck --- Albert, Version-Fixed-In == 4.12, or do you want to use the Okular version now? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 320317] pages shown in thumbnails displayed as blank in main area
https://bugs.kde.org/show_bug.cgi?id=320317 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #9 from Christoph Feck --- No response, changing status. Please reopen, if you have more information. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322127] Okular crashes on CHM files
https://bugs.kde.org/show_bug.cgi?id=322127 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #4 from Christoph Feck --- No response, changing status. Please reopen, if you have more information. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322407] Okular does not properly display some gradients
https://bugs.kde.org/show_bug.cgi?id=322407 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #2. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322357] PDF Annotations in certain pages crash Okular
https://bugs.kde.org/show_bug.cgi?id=322357 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323391] Impossible to reduce the width of documents with portrait and landscape pages
https://bugs.kde.org/show_bug.cgi?id=323391 --- Comment #10 from Christoph Feck --- So should this bug be reassigned to Kile developers? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322993] Okular always prints in duplex mode
https://bugs.kde.org/show_bug.cgi?id=322993 --- Comment #11 from Christoph Feck --- You could check if this also shows with pure Qt applications, for example qpdfview. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly
https://bugs.kde.org/show_bug.cgi?id=323563 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |WORKSFORME --- Comment #6 from Christoph Feck --- I just tested with a clean config. Trim Margins is not enabled by default, so at some point you enabled it. I think it makes sense that Okular remembers this option between invokations, because someone might be highly annoyed, if he had to change it every time. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323721] Okular crashes on corrupted pdf
https://bugs.kde.org/show_bug.cgi?id=323721 --- Comment #6 from Christoph Feck --- Francesco, if you can provide the information requested in comment #5, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 322357] PDF Annotations in certain pages crash Okular
https://bugs.kde.org/show_bug.cgi?id=322357 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #4 from Christoph Feck --- No response, changing status. Please reopen, if you have more information. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323391] Impossible to reduce the width of documents with portrait and landscape pages
https://bugs.kde.org/show_bug.cgi?id=323391 Christoph Feck changed: What|Removed |Added CC||michel.lud...@kdemail.net --- Comment #12 from Christoph Feck --- Adding Kile developer to CC list. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323721] Okular crashes on corrupted pdf
https://bugs.kde.org/show_bug.cgi?id=323721 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |WORKSFORME --- Comment #9 from Christoph Feck --- Thanks for the update. If you see this bug again, please reopen or add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323810] PDF not rendered correctly
https://bugs.kde.org/show_bug.cgi?id=323810 --- Comment #8 from Christoph Feck --- If you can provide the information requested in comment #7, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 200947] Crash if /tmp partition is full
https://bugs.kde.org/show_bug.cgi?id=200947 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC||christ...@maxiom.de Resolution|--- |BACKTRACE --- Comment #3 from Christoph Feck --- This crash report is at least 3 years old and there were no further comments or status updates since then. Therefore we believe that this crash is already fixed in recent KDE 4 versions or the backtrace is no longer applicable to the current KDE 4 sources. If the crash still happens with a recent KDE version (4.10.5 or 4.11), please add an updated backtrace or provide steps to reproduce. For more information, see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports (To prevent automatic closing of this bug in the future, please set the bug status to ASSIGNED or CONFIRMED) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 241087] Okular crashes when sending two documents to a network printer right after another
https://bugs.kde.org/show_bug.cgi?id=241087 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC||christ...@maxiom.de Resolution|--- |BACKTRACE --- Comment #4 from Christoph Feck --- This crash report is at least 3 years old and there were no further comments or status updates since then. Therefore we believe that this crash is already fixed in recent KDE 4 versions or the backtrace is no longer applicable to the current KDE 4 sources. If the crash still happens with a recent KDE version (4.10.5 or 4.11), please add an updated backtrace or provide steps to reproduce. For more information, see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports (To prevent automatic closing of this bug in the future, please set the bug status to ASSIGNED or CONFIRMED) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 213671] churning hard disk freezes KDE, when loading pdf from freakcomputer
https://bugs.kde.org/show_bug.cgi?id=213671 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC||christ...@maxiom.de Resolution|--- |BACKTRACE --- Comment #3 from Christoph Feck --- This crash report is at least 3 years old and there were no further comments or status updates since then. Therefore we believe that this crash is already fixed in recent KDE 4 versions or the backtrace is no longer applicable to the current KDE 4 sources. If the crash still happens with a recent KDE version (4.10.5 or 4.11), please add an updated backtrace or provide steps to reproduce. For more information, see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports (To prevent automatic closing of this bug in the future, please set the bug status to ASSIGNED or CONFIRMED) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 198335] Okular crashes while opening big chm file
https://bugs.kde.org/show_bug.cgi?id=198335 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC||christ...@maxiom.de Resolution|--- |BACKTRACE --- Comment #9 from Christoph Feck --- This crash report is at least 3 years old and there were no further comments or status updates since then. Therefore we believe that this crash is already fixed in recent KDE 4 versions or the backtrace is no longer applicable to the current KDE 4 sources. If the crash still happens with a recent KDE version (4.10.5 or 4.11), please add an updated backtrace or provide steps to reproduce. For more information, see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports (To prevent automatic closing of this bug in the future, please set the bug status to ASSIGNED or CONFIRMED) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 323391] Impossible to reduce the width of documents with portrait and landscape pages
https://bugs.kde.org/show_bug.cgi?id=323391 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Christoph Feck --- Okay :) *** This bug has been marked as a duplicate of bug 323466 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 324731] opening an pdf document, it crash
https://bugs.kde.org/show_bug.cgi?id=324731 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325190] Wish : Reading mode in okular
https://bugs.kde.org/show_bug.cgi?id=325190 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs CC||christ...@maxiom.de --- Comment #1 from Christoph Feck --- This sounds relatively easy to implement, but I doubt Okular developers have time to look at it. Might be a good start for someone to learn about actions, menus, and KDE windows. Marking as a junior job. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325194] Crash on pdf page forward
https://bugs.kde.org/show_bug.cgi?id=325194 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de Component|general |general Version|4.10.5 |0.16.5 Assignee|konq-b...@kde.org |okular-devel@kde.org Product|konqueror |okular --- Comment #1 from Christoph Feck --- If this is reproducible without the nvidia binary driver, please add an updated backtrace. Developers looking at the current backtrace could easily believe the crash to be caused by nvidia memory management patches, while the real issue might indeed be double-free in Okular code. If possible, please try to run this in valgrind. For more information, please see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_with_Valgrind -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325190] Wish : Reading mode in okular
https://bugs.kde.org/show_bug.cgi?id=325190 --- Comment #3 from Christoph Feck --- Thanks Sayantan, nice to know you would like to work on it. Was not really expecting reaction so fast, looks like we need more new junior jobs :) I guess you should wait a bit, until Okular maintainers confirm they would indeed add the feature, once a good patch is available. Nevertheless, you are invited to start reading around in Okular source code, and ask questions on kde-devel or okular-devel mailing lists. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325190] Wish : Reading mode in okular
https://bugs.kde.org/show_bug.cgi?id=325190 --- Comment #4 from Christoph Feck --- D'oh! I just noticed that you are the reporter, no wonder the reaction was so fast... -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? Albert, the issue is that some documents do not indicate text color, they just assume. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review40816 --- On Aug. 20, 2013, 10:40 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 20, 2013, 10:40 a.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color
> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? > > Christoph Feck wrote: > Albert, the issue is that some documents do not indicate text color, they > just assume. > > Albert Astals Cid wrote: > Right, so if they assume and we follow the color scheme, all is nice, no? > You'll get your weird black on red as defined on your color scheme? Or that's > something we don't like and we want it to be black on white not obeying your > color scheme? Yes, you can follow the color scheme, but then you have to do it for both background and foreground. But right now, Okular uses a white background. In the description I explained why I think following the color scheme might be bad: If you follow the color scheme, then you can break (i.e. render invisible) documents that _do_ set text colors, especially for users that use a dark color scheme. Of course, a third option would be to ignore all colors in the document, and force both background and foreground to use the color scheme, but then "colorful" documents would look boring. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review40816 ------- On Aug. 20, 2013, 10:40 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111681/ > --- > > (Updated Aug. 20, 2013, 10:40 a.m.) > > > Review request for Okular. > > > Description > --- > > As indicated in bug 322547, some documents do not specify a text color, and > probably assume the default text color to be black. QTextDocument, however, > defaults to using the system text color. > > This patch changes the default text color to Qt::black. It should affect > epub, fb2, odt, and plain text generators. > > I think it is better to use this approach instead of changing the paper color > to use the system background color (see bug 253583), because > > 1) the document might specify a text color in some places, > > 2) the user is able to change the fg/bg colors anyway using Okular's > Accessibility options, and those probably expect black on white. > > > This addresses bugs 253583 and 322547. > http://bugs.kde.org/show_bug.cgi?id=253583 > http://bugs.kde.org/show_bug.cgi?id=322547 > > > Diffs > - > > core/textdocumentgenerator.cpp b260b3f > > Diff: http://git.reviewboard.kde.org/r/111681/diff/ > > > Testing > --- > > I tested the document from bug 322547 comment #3. > > > Thanks, > > Christoph Feck > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325083] Okular displays SVG files as plain text
https://bugs.kde.org/show_bug.cgi?id=325083 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de --- Comment #2 from Christoph Feck --- Okular does not render SVG right now, but using an image viewer does not sound like a suitable replacement. When printing using Gwenview (and possibly other image viewers), it will first convert the SVG to raster data, which degrades the quality of the print-out. I suggest to re-evaluate this report, and possibly mark it as a wish. EDIT: I just checked, Gwenview does not even allow SVG to be printed. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325083] Okular displays SVG files as plain text
https://bugs.kde.org/show_bug.cgi?id=325083 --- Comment #3 from Christoph Feck --- After checking on IRC with okular developers, if SVG support is needed in Okular in the future, please report it separately as a wish for "okular/New backend wishes", stating use case. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325650] reading direction Right to Left
https://bugs.kde.org/show_bug.cgi?id=325650 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #2 from Christoph Feck --- What does this option change? Scrolling direction on key presses? Please clarify exactly how Okular should work with this option enabled. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325650] reading direction Right to Left
https://bugs.kde.org/show_bug.cgi?id=325650 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #6 from Christoph Feck --- Thanks for the update, swapping the two facing pages makes sense in RTL reading mode. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de --- Comment #1 from Christoph Feck --- Works here with openSUSE unrar package (unrar-5.0.11-2.1.5.i586). > unrar --version UNRAR 5.00 freeware Copyright (c) 1993-2013 Alexander Roshal Please add the output of "unrar --version". Could you also please enable all messages with "kdebugdialog" in Konsole, and add the output from Okular when trying to open the .cbr? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 113163: Fix cbr (rar) listing with unrar 5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113163/ --- Review request for Okular and Albert Astals Cid. Bugs: 325677 http://bugs.kde.org/show_bug.cgi?id=325677 Repository: okular Description --- The new unrar version includes the paths in its "bare listing" (unrar lb), while it still extracts only the filename without the path. Thus, the Unrar::list() function fails. This patch strips the path away. Diffs - generators/comicbook/unrar.cpp 87f8bbb Diff: http://git.reviewboard.kde.org/r/113163/diff/ Testing --- Works with both unrar 4 and unrar 5 on both test archives from bug 325677. Thanks, Christoph Feck ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #8 from Christoph Feck --- Thanks for the test files. The only .cbr files I had did not use sub-directories. Patch is at https://git.reviewboard.kde.org/r/113163 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #9 from Christoph Feck --- > Seems like line 117 in generators/comicbook/unrar.cpp needs to be > > int ret = startSyncProcess( QStringList() << "x" << mFileName << > > mTempDir->name() ); > for unrar version 5+. That would also be possible, but I am not sure, if Okular handles nested directories for the temporary extracted files everywhere (e.g. when later cleaning up etc.). Also, I am not sure how unrar behaves when absolute paths are present in the archive. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Christoph Feck changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #12 from Christoph Feck --- Thanks for testing, but we resolve the bug, when the commit was made :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325650] reading direction Right to Left
https://bugs.kde.org/show_bug.cgi?id=325650 Christoph Feck changed: What|Removed |Added Component|PDF backend |general -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 324504] Okular crashes when closing window
https://bugs.kde.org/show_bug.cgi?id=324504 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 324731] opening an pdf document, it crash
https://bugs.kde.org/show_bug.cgi?id=324731 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325909] okular crashed after opening with CBUS125EPM001007.epub
https://bugs.kde.org/show_bug.cgi?id=325909 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |UPSTREAM -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 113163: Fix cbr (rar) listing with unrar 5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113163/ --- (Updated Oct. 13, 2013, 9:55 p.m.) Status -- This change has been marked as submitted. Review request for Okular and Albert Astals Cid. Bugs: 325677 http://bugs.kde.org/show_bug.cgi?id=325677 Repository: okular Description --- The new unrar version includes the paths in its "bare listing" (unrar lb), while it still extracts only the filename without the path. Thus, the Unrar::list() function fails. This patch strips the path away. Diffs - generators/comicbook/unrar.cpp 87f8bbb Diff: http://git.reviewboard.kde.org/r/113163/diff/ Testing --- Works with both unrar 4 and unrar 5 on both test archives from bug 325677. Thanks, Christoph Feck ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 324731] opening an pdf document, it crash
https://bugs.kde.org/show_bug.cgi?id=324731 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #4 from Christoph Feck --- No response, changing status. Please reopen, if you have more information. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326711] Okular *.desktop files are missing "-icon" in front of %i
https://bugs.kde.org/show_bug.cgi?id=326711 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326361] printed correctly but the screen is blank
https://bugs.kde.org/show_bug.cgi?id=326361 --- Comment #3 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup
https://bugs.kde.org/show_bug.cgi?id=327641 Christoph Feck changed: What|Removed |Added CC||christ...@maxiom.de -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 292707] okular crashes when I resize window
https://bugs.kde.org/show_bug.cgi?id=292707 --- Comment #3 from Christoph Feck --- > [OT] But how can drkonqi gives possible duplicates when it doesn't know the > backtrace ? Maybe it found all crashes (empty backtrace matching everything), and added only the five most recent? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 308367] Print margins are not saved
https://bugs.kde.org/show_bug.cgi?id=308367 --- Comment #2 from Christoph Feck --- Duplicate of bug 198172? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326361] printed correctly but the screen is blank
https://bugs.kde.org/show_bug.cgi?id=326361 --- Comment #4 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 326987] Konqueror crashed on closing tabs
https://bugs.kde.org/show_bug.cgi?id=326987 --- Comment #3 from Christoph Feck --- Since this is a probably a memory double free(), a valgrind trace would be nice. For more information, please see http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_with_Valgrind -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup
https://bugs.kde.org/show_bug.cgi?id=327641 --- Comment #2 from Christoph Feck --- The issue is when using Okular inside Konqueror. Often, but not always, the sidebar shows, even while the checkbox in the menu is unchecked. I just googled "test pdf", and got three links. The first two work correctly (no sidebar), while the third one opens with the sidebar. http://www.education.gov.yk.ca/pdf/pdf-test.pdf http://www.tobcon.ie/assets/files/test.pdf http://www.dmhc.ca.gov/testpage.pdf -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup
https://bugs.kde.org/show_bug.cgi?id=327641 --- Comment #4 from Christoph Feck --- On the third link, this is reproducible here. After opening it, navigation panel (not sidebar, sorry) is open, and checkbox in menu unchecked. When I turn on the checkbox "Show Navigation Panel", it keeps visible, unchecking it again it finally hides. When I close the window, and again click the third link, it is shown again. When I close the window with the checkbox set, it remembers the setting, and starts with panel on all three links. Maybe it has something to do with the contents of the third pdf (it shows a top message "...has forms"). Additionally, with the third link, it always start at the Contents pane. For the other links, the Contents pane is disabled. So it looks like when it even finds a contents table in the PDF, it enforces opening the panel? KDE daily master, btw. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327958] okular-gv.png wrong size
https://bugs.kde.org/show_bug.cgi?id=327958 --- Comment #2 from Christoph Feck --- I noticed that 16x16 is actually only 16x14, which is less of a problem, because Qt does not upscale icons, afaik. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327958] okular-gv.png wrong size
https://bugs.kde.org/show_bug.cgi?id=327958 Christoph Feck changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 327942] Misrendering of PDF with Maths
https://bugs.kde.org/show_bug.cgi?id=327942 --- Comment #8 from Christoph Feck --- On my system, it works perfectly on all zoom levels. It could indeed be related to fonts. If in doubt, install Microsoft font package, those give best compatibility with "standard" documents. poppler 0.24.3, freetype 2.5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
