[okular] [Bug 435075] Multiple instances of Okular mess up recently opened files

2021-04-09 Thread Chinmoy Ranjan Pradhan
https://bugs.kde.org/show_bug.cgi?id=435075 Chinmoy Ranjan Pradhan changed: What|Removed |Added Status|REPORTED|CONFIRMED CC

D13114: Add DocumentRevision to Okular

2019-01-19 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. chinmoyr added a comment. @aacid Sorry for late reply. This got lost in my inbox. This diff is not required. The relevant code for generating revision is already in poppler_generator. REPOSITORY R223 Okular REVISION DETAIL

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14748 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14734 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14696 To: chinmoyr, aacid, ngraham Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14656 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14655 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14654 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14816: Add signature panel

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14816 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:0696f4cb55a7: Add API for signature form field, and other helper classes (authored by chinmoyr). REPOSITORY R223

D14816: Add signature panel

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:bb1dbebb4f68: Add signature panel (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D14656: Add utitlity functions for use in digital signature verification

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:53e095439724: Add utitlity functions for use in digital signature verification (authored by chinmoyr). REPOSITORY

D14696: Add certificate viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:35965f914548: Add certificate viewer (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D14734: Add revision viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:b7a841e8eed1: Add revision viewer (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:29cea9796ca7: Add unit test for SignatureFormField (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:d6e0577a0141: Reimplement signature form field and related utility classes in poppler… (authored by chinmoyr).

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependencies, added: D14655: Reimplement signature form field and related utility classes in poppler generator; removed: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: chinmoyr, aacid Cc:

D11723: Add FormFieldSignature to Okular namespace

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D12901: Add unit test for SignatureFormField. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D12901: Add unit test for SignatureFormField. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14655 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39701. chinmoyr edited the summary of this revision. chinmoyr added a dependency: D14816: Add signature panel. chinmoyr added a comment. Went with @ngraham's suggestion of showing a separate message for signature. But the "Show Signature" button will

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependency: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D13484: Show signature validation summary as popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

2018-08-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14748 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-11 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39466. chinmoyr edited the summary of this revision. chinmoyr added a dependency: D14748: Add signature properties dialog. chinmoyr added a comment. Added screenshot Rebased on master REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D14734: Add revision viewer

2018-08-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D14748: Add signature properties dialog. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14734 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

2018-08-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This dialog shows signature validation status, document

D14734: Add revision viewer

2018-08-10 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14734 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

2018-08-10 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39420. chinmoyr added a comment. Removed junk files REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14734?vs=39419=39420 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14734 AFFECTED FILES

D14696: Add certificate viewer

2018-08-10 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D14734: Add revision viewer. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14696 To: chinmoyr, aacid, ngraham Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

2018-08-10 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This makes use of print preview dialog to view signed version

D14696: Add certificate viewer

2018-08-08 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14696 To: chinmoyr, aacid, ngraham Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

2018-08-08 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: aacid, ngraham. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This adds a dialog to view details of a digital

D14656: Add utitlity functions for use in digital signature verification

2018-08-08 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D14696: Add certificate viewer. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14656 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39212. chinmoyr added a comment. Removed unnecessary files REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14656?vs=39211=39212 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14656 AFFECTED FILES

D14656: Add utitlity functions for use in digital signature verification

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39211. chinmoyr retitled this revision from "#Add utitlity functions for use in gui components #Summary: #Test Plan: #Reviewers: aacid #Subscribers: Add utitlity functions for use in digital signature verification" to "Add utitlity functions for use

D14656: #Add utitlity functions for use in gui components#Summary: #Test Plan: #Reviewers: aacid#Subscribers: Add utitlity functions for use in digital signature verification

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY Adds functions to get signature form fields and convert various

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D14656: #Add utitlity functions for use in gui components #Summary: #Test Plan: #Reviewers: aacid #Subscribers: Add utitlity functions for use in digital signature verification. REPOSITORY R223 Okular REVISION DETAIL

D14654: Add API for signature form field, and other helper classes

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D14655: Reimplement signature form field and related utility classes in poppler generator. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14654 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This adds class PopplerFormFieldSignature, PopplerSignatureInfo

D14654: Add API for signature form field, and other helper classes

2018-08-06 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This adds class FormFieldSignature which will represent a

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-26 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. chinmoyr added a comment. Outdated diff INLINE COMMENTS > aacid wrote in signaturewidgets.cpp:158 > Fixed size is usually not a good idea, why are you doing it? Well it's the result of taking your advice of "do what adobe does" bit too far. Just curious,

D11723: Add FormFieldSignature to Okular namespace

2018-06-26 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. chinmoyr added a comment. Outdated revision REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13483 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13484: Show signature validation summary as popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependencies, added: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog; removed: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham,

D11723: Add FormFieldSignature to Okular namespace

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13484: Show signature validation summary as popup

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds support for validating all signatures present

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 36014. chinmoyr added a comment. Rebased on master Made use of SignatureSummaryDialog and SignaturePropertiesDialog REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13366?vs=35637=36014 BRANCH master REVISION

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY SignatureSummaryDialog will display the signature validation

D11723: Add FormFieldSignature to Okular namespace

2018-06-10 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 35983. chinmoyr added a comment. Revert to previous version. Now signatures will not be validated upfront. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11723?vs=35513=35983 BRANCH master REVISION DETAIL

D11723: Add FormFieldSignature to Okular namespace

2018-06-05 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-05 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-05 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds SignatureEdit widget which subclasses

D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 35513. chinmoyr added a comment. Added validateSignatures() to validate signatures while loading a page. Added to document info whether or not a pdf is digitally signed. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D11725: [RFC] Show signature status as a popup

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependency: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11725 To: chinmoyr, #okular Cc: okular-devel, aacid, sander, ngraham

D12901: Add unit test for SignatureFormField

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependent revision(s), added 1: D12901: Add unit test for SignatureFormField; removed 1: D11725: [RFC] Show signature status as a popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-06-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 35510. chinmoyr added a comment. Removed the unnecessary static_cast Used QScopedPointer for d_ptr REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11723?vs=35040=35510 BRANCH master REVISION DETAIL

D13114: Add DocumentRevision to Okular

2018-05-28 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D13114#269280 , @aacid wrote: > Can you explain what's the use case for this? Adobe reader allows user to view different signed revisions of a PDF. This patch intends to implement that feature. > I

D13114: Add DocumentRevision to Okular

2018-05-25 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds DocumentRevision class to Okular which stores

D11723: Add FormFieldSignature to Okular namespace

2018-05-23 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > aacid wrote in form.cpp:284 > What's this used for? For other formfields it can be used to set their default states. But for signature field I have no idea. > aacid wrote in form.h:390 > What would be the usecase for this force? I never

D11723: Add FormFieldSignature to Okular namespace

2018-05-23 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34717. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Updated API. Removed cases with no use cases. Removed redundant enums. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11723?vs=34307=34717

D11725: [RFC] Show signature status as a popup

2018-05-22 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11725 To: chinmoyr, #okular Cc: okular-devel, aacid, sander, ngraham

D11725: [RFC] Show signature status as a popup

2018-05-19 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D11725#264976 , @aacid wrote: > Sorry you lost me here, what's revision 30645 ? My bad, I was actually referring to https://phabricator.kde.org/D11723?id=30645 REPOSITORY R223 Okular REVISION DETAIL

D11725: [RFC] Show signature status as a popup

2018-05-18 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D11725#264703 , @aacid wrote: > This doesn't work anymore right? signValidationInfoList doesn't exist in D11723 It requires revision 30645 to work. REPOSITORY R223

D12901: Add unit test for SignatureFormField

2018-05-17 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34385. chinmoyr edited the summary of this revision. chinmoyr added a comment. Updated test PDF. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12901?vs=34212=34385 BRANCH master REVISION DETAIL

D11723: Add FormFieldSignature to Okular namespace

2018-05-16 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34307. chinmoyr added a comment. Removed code unrelated to this revision. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11723?vs=30645=34307 REVISION DETAIL https://phabricator.kde.org/D11723 AFFECTED FILES

D12901: Add unit test for SignatureFormField

2018-05-15 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY Test the type of form field and the type of signature.

D11723: Add FormFieldSignature to Okular namespace

2018-05-14 Thread Chinmoy Ranjan Pradhan
chinmoyr retitled this revision from "[RFC] Add FormFieldSignature to Okular's namespace" to "Add FormFieldSignature to Okular namespace". chinmoyr edited reviewers, added: aacid; removed: Okular. Restricted Application added a subscriber: okular-devel. REPOSITORY R223 Okular REVISION DETAIL

D12049: Obey umask rules when saving new file

2018-04-17 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12049 To: chinmoyr, #okular, aacid Cc: michaelweghorn, ngraham, aacid

D12098: Resize content area to correct dimensions after zooming to Auto Fit

2018-04-17 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12098 To: chinmoyr, #okular, aacid Cc: michaelweghorn, ngraham, aacid

D12098: Resize content area to correct dimensions after zooming to Auto Fit

2018-04-10 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Okular, aacid. Restricted Application added a project: Okular. chinmoyr requested review of this revision. REVISION SUMMARY After going from high zoom to "Auto Fit" a resize event is generated and the resize event handler tries to

D12049: Obey umask rules when saving new file

2018-04-08 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 31692. chinmoyr added a comment. Fix coding style REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12049?vs=31691=31692 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12049 AFFECTED FILES part.cpp

D12049: Obey umask rules when saving new file

2018-04-08 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Okular, aacid. Restricted Application added a project: Okular. chinmoyr requested review of this revision. REVISION SUMMARY Okular saves a new file with permissions 0600 completely ignoring the umask value. This is because it makes

D11725: [RFC] Show signature status as a popup

2018-03-26 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11725 To: chinmoyr, #okular Cc: michaelweghorn, ngraham, aacid

D11723: [RFC] Add FormFieldSignature to Okular's namespace

2018-03-26 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D11725: [RFC] Show signature status as a popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, #okular Cc: michaelweghorn, ngraham, aacid

D11725: [RFC] Show signature status as a popup

2018-03-26 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D11723: [RFC] Add FormFieldSignature to Okular's namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11725 To: chinmoyr, #okular Cc: michaelweghorn, ngraham, aacid

D11725: [RFC] Show signature status as a popup

2018-03-26 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: Okular. Restricted Application added a project: Okular. chinmoyr requested review of this revision. REVISION SUMMARY This is a PoC that makes use of the signature validation information generated in D11723

D11723: [RFC] Add FormFieldSignature to Okular's namespace

2018-03-26 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: Okular. Restricted Application added a project: Okular. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds the abstract class FormFieldSignature, implements it in poppler generator and modifies poppler