D20488: Fix build with poppler <0.58

2019-04-13 Thread Heiko Becker
heikobecker added a comment. Thanks for landing. Not sure how common that poppler version still is, but do you think it's worth a respin for 19.04? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20488 To: heikobecker, aacid Cc: aacid, okular-devel, joaonetto,

D20488: Fix build with poppler <0.58

2019-04-12 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. heikobecker requested review of this revision. REVISION SUMMARY - Poppler::FormFieldSignature::signatureType - Poppler::SignatureValidationInfo::hashAlgorithm -

D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled

2018-11-27 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R223:140638a0b360: Explicitly import Qt 5.7s QtQuick for Connections.enabled (authored by heikobecker). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled

2018-11-27 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Okular, apol. Herald added a project: Okular. Herald added a subscriber: okular-devel. heikobecker requested review of this revision. REVISION SUMMARY It was introduced in that version and apparently Qt 5.12 is stricter about

D8879: generators: Use a specific description for libzip

2017-11-19 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R223:f099d5fa2aac: generators: Use a specific description for libzip (authored by heikobecker). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8879?vs=22560=22619

D8879: generators: Use a specific description for libzip

2017-11-18 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Okular. Restricted Application added a project: Okular. REVISION SUMMARY It appears it's copied and pasted from LibCHM and while it's indeed needed to support displaying CHM files, it's a library of its own. REPOSITORY R223

D7241: Search for Kirigami

2017-08-30 Thread Heiko Becker
heikobecker added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7241 To: heikobecker, #okular, mart Cc: aacid

D7241: Search for Kirigami

2017-08-10 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Okular. REVISION SUMMARY Makes it a bit more obvious that Kirigami is needed at runtime. TEST PLAN Show a nice status message REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL

Re: Review Request 129805: Invoke the correct KCModule

2017-01-11 Thread Heiko Becker
marked as submitted. Review request for Okular and David Rosca. Changes --- Submitted with commit f968296c51889499bc0d42217874ea7c4d191327 by Heiko Becker to branch Applications/16.12. Repository: okular Description --- The webshortcuts KCM has been renamed from 'ebrowsing

Review Request 129805: Invoke the correct KCModule

2017-01-11 Thread Heiko Becker
popup menu for marked text) works with the patch. Thanks, Heiko Becker

Re: [Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

2015-04-19 Thread Heiko Becker
marked as submitted. Review request for Okular. Changes --- Submitted with commit 966e19582c519a4462e7970cd19c0bb1d9ec9c80 by Heiko Becker to branch Applications/15.04. Repository: okular Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment

Re: [Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

2015-04-18 Thread Heiko Becker
) - cmake/modules/FindLibSpectre.cmake 8d5dc76 Diff: https://git.reviewboard.kde.org/r/123393/diff/ Testing --- Configured and built okular successfully and checked that it links to libspectre. Thanks, Heiko Becker ___ Okular-devel mailing list

[Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

2015-04-17 Thread Heiko Becker
/ Testing --- Configured and built okular successfully and checked that it links to libspectre. Thanks, Heiko Becker ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 122155: Use co-installable qca-qt5 version

2015-01-30 Thread Heiko Becker
61054bd8f01af0ac5bee42c58f46f54b2f560f92 Diff: https://git.reviewboard.kde.org/r/122155/diff/ Testing --- Successfully built with -DCMAKE_DISABLE_FIND_PACKAGE_Qca-qt5:BOOL=FALSE AND TRUE and okular linked to the right version of qca in the former case. Thanks, Heiko Becker

[Okular-devel] Review Request 122155: Use co-installable qca-qt5 version

2015-01-19 Thread Heiko Becker
/ Testing --- Successfully built with -DCMAKE_DISABLE_FIND_PACKAGE_Qca-qt5:BOOL=FALSE AND TRUE and okular linked to the right version of qca in the former case. Thanks, Heiko Becker ___ Okular-devel mailing list Okular-devel@kde.org https

[Okular-devel] [Bug 305761] okular and strigi aren't actually optional

2012-08-25 Thread Heiko Becker
https://bugs.kde.org/show_bug.cgi?id=305761 --- Comment #1 from Heiko Becker he...@shruuf.de --- Created attachment 73463 -- https://bugs.kde.org/attachment.cgi?id=73463action=edit patch to fix the above issue -- You are receiving this mail because: You are the assignee for the bug