[okular] [Bug 438882] Quick annotations toolbar button does nothing

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=438882

--- Comment #3 from Kai Uwe Broulik  ---
> If you open the dropdown and click on a tool, does the main button change to 
> show that tool?

There's just "show more annotation tools" and "configure annotations". When I
select a tool from the annotation toolbar, nothing changes, the "quick
annotations" button never changes and never does anything when clicked.

> Do you have “Quick annotation” tools defined?

Looks like I do not. At least in "configure annotations" the list is empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438882] New: Quick annotations toolbar button does nothing

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=438882

Bug ID: 438882
   Summary: Quick annotations toolbar button does nothing
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: k...@privat.broulik.de
  Target Milestone: ---

SUMMARY
The "Quick annotations" toolbar button does nothing when clicked. I can only
click the dropdown next to it to then access the annotations bar

STEPS TO REPRODUCE
1. Start Okular
2. Click "Quick annotations"

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
I guess the last (or some default not used before) tool is selected? Or the
annotation bar should show or something.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: git master as of 2021-06-17
Qt Version: 5.15.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 419221] Presentation toolbar: Checkmarks in drawing tool buttons blurry on HiDPI

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=419221

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #3 from Kai Uwe Broulik  ---
Probably just needs to use devicePixelRatio on the pixmap in
ui/drawingtoolactions.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415502] Searching spinner is blurry on HiDPI

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=415502

--- Comment #4 from Kai Uwe Broulik  ---
Sorry.

I also don't care enough about the issue that I would invest anymore time in
it. Was annoying enough that I had to set up a GitLab thing just to submit a
twoliner. Feel free to ifdef it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415502] Searching spinner is blurry on HiDPI

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=415502

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
No, because of Okular's ridiculously low Frameworks dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Moved to GitLab: https://invent.kde.org/kde/okular/merge_requests/71

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

To: broulik, #okular, aacid
Cc: sander, sitter, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Okular, aacid.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's a lot nicer than manually painting a `KPixmapSequence` and supports high 
dpi out of the box.

TEST PLAN
  T11637 
  It is pretty new, so maybe too new for the frameworks dep of KDE Applications 
/ Okular
  
  - Busy indicator is prety now
  
  F7344007: Screenshot_20190912_182434.png 


REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

AFFECTED FILES
  ui/searchlineedit.cpp
  ui/searchlineedit.h

To: broulik, #okular, aacid
Cc: okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, 
kezik, tfella, ngraham, darcyshen, aacid

D23037: Add support for cb7 comic book archives

[Kai Uwe Broulik]

broulik added a comment.


  Works well, thanks a lot! Let's wait for Okular maintainer approval.

INLINE COMMENTS

> okularApplication_comicbook.desktop:168
>  NoDisplay=true
> -X-KDE-Keywords=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ar]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bg]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[bs]=cbr, cbz, cbt, Comic Book,stripovi
> -X-KDE-Keywords[ca]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ca@valencia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[cs]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[da]=cbr,cbz,cbt,Comic Book
> -X-KDE-Keywords[de]=cbr, cbz, cbt, Comic-Book
> -X-KDE-Keywords[el]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[en_GB]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[es]=cbr, cbz, cbt, libro de cómic
> -X-KDE-Keywords[et]=cbr, cbz, cbt, Comic Book, koomiks
> -X-KDE-Keywords[eu]=cbr, cbz, cbt, komiki-liburua
> -X-KDE-Keywords[fi]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[fr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ga]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[gl]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[hu]=cbr, cbz, cbt, Képregény
> -X-KDE-Keywords[ia]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[is]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[it]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ja]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[kk]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[km]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ko]=cbr, cbz, cbt, Comic Book,만화책
> -X-KDE-Keywords[lt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[lv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[mr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[nb]=cbr, cbz, cbt, tegneserie
> -X-KDE-Keywords[nds]=cbr, cbz, cbt, Comicbook
> -X-KDE-Keywords[nl]=cbr, cbz, cbt, Stripverhaal
> -X-KDE-Keywords[nn]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pa]=cbr, cbz, cbt, ਕਾਮਿਕ ਬੁੱਕ
> -X-KDE-Keywords[pl]=cbr, cbz, cbt, Komiks
> -X-KDE-Keywords[pt]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[pt_BR]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[ro]=cbr, cbz, cbt, benzi desenate, comic
> -X-KDE-Keywords[ru]=cbr, cbz, cbt, Comic Book, комикс
> -X-KDE-Keywords[sk]=cbr, cbz, cbt, Comic Book, Kniha komiksov
> -X-KDE-Keywords[sl]=cbr, cbz, cbt, strip
> -X-KDE-Keywords[sr]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavian]=cbr, cbz, cbt, Comic Book,комикбук
> -X-KDE-Keywords[sr@ijekavianlatin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sr@latin]=cbr, cbz, cbt, Comic Book,ComicBook
> -X-KDE-Keywords[sv]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[tr]=cbr, cbz, cbt, Comic Book
> -X-KDE-Keywords[uk]=cbr,cbz,cbt,Comic Book,комікс
> -X-KDE-Keywords[x-test]=xxcbrxx,xx cbzxx,xx cbtxx,xx Comic Bookxx
> -X-KDE-Keywords[zh_CN]=cbr, cbz, cbt, Comic Book,漫画书,漫画,连环画
> -X-KDE-Keywords[zh_TW]=cbr, cbz, cbt, Comic Book
> +X-KDE-Keywords=cbr, cbz, cbt, cb7, Comic Book
> +X-KDE-Keywords[ar]=cbr, cbz, cbt, cb7, Comic Book

Yes, please only change the untranslated key (the ones without `[language]`), 
the rest is taken care by a script :)

REVISION DETAIL
  https://phabricator.kde.org/D23037

To: nhiga, #okular, aacid
Cc: broulik, pino, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen, aacid

D18730: Use breeze icons for search providers

[Kai Uwe Broulik]

broulik added a comment.


  Check out D18730 
  
  Then you can put `Icon=foo` in the respective search provider desktop file

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

[Kai Uwe Broulik]

broulik added a comment.


  Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a 
proper icon.
  
  https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps 
needs to have icons added

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D17054: Retina Support for MacOS

[Kai Uwe Broulik]

broulik added a comment.


  Given you've been doing the same patch for multipple apps now, any chance 
this can be generated using an ECM macro, pernhaps populated from the app's 
desktop file or appstream data?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

To: darcyshen, #okular
Cc: broulik, ltoscano, okular-devel, ngraham, darcyshen, aacid

D16285: Remember printing option and print range in the print dialog

[Kai Uwe Broulik]

broulik added a comment.


  > This new information is saved/remembered per-document and not globally, 
right?
  
  Given it's in a `document.cpp` I would assume so, that's probably also where 
scroll position and what not is persisted

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16285

To: ahmadosama, #okular
Cc: broulik, ngraham, okular-devel, aacid

D15344: Fix isNull check for RegularArea

[Kai Uwe Broulik]

broulik added a reviewer: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15344

To: tobiasdeiminger, aacid
Cc: okular-devel, ngraham, aacid

[okular] [Bug 394851] Configure Web Shortcut Error

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=394851

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |UNMAINTAINED
 Status|UNCONFIRMED |RESOLVED

--- Comment #9 from Kai Uwe Broulik  ---
Please try again with a 5.x based version. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394851] Configure Web Shortcut Error

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=394851

--- Comment #4 from Kai Uwe Broulik  ---
oh, I see. Here clicking that button does open webshortcut settings.
Can you run kcmshell5 webshortcuts from console and see what it says?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 394851] Configure Web Shortcut Error

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=394851

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
I think it only lists those marked as "Preferred"

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik added a comment.


  When I do `m_part->actionCollection()->action(KStandardAction::Print)` I get 
the "next bookmark" action in Okular and none in Kate. I tried 
`QMetaObject::invokeMethod` but sometimes it's called `print` and sometimes 
`slotPrint` and I don't find where Konqueror actually handles the "print" 
action.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: dfaure, ngraham, aacid

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik added a comment.


  So, Ark should get a print action (I could add one next to the "Close" button 
which would make it quite obvious) and Kate is wrong to show it in the menu?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: dfaure, ngraham, aacid

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik added a comment.


  So, the situation is: the "Print" action comes from Konqueror. Kate part, for 
instance, adds its own "Print" action, so you get two but only one in Ark. So I 
don't know how this could be fixed in both cases. Either you end up with 
duplicate actions in Konqueror or none in Ark (or duplicate in Ark if we add 
one there).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: ngraham, aacid

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik added a comment.


  Oh, I see. So Okular's Print action must go then. There is currently no way 
to print a PDF file from within Ark.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: ngraham, michaelweghorn, aacid

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik planned changes to this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: ngraham, michaelweghorn, aacid

D12067: [Okular Part] Add "Print" action

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Okular, aacid.
Restricted Application added a project: Okular.
broulik requested review of this revision.

REVISION SUMMARY
  There's "Print Preview" but not "Print"

TEST PLAN
  Successfully printed a PDF I viewed in Ark's previewer

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

AFFECTED FILES
  part.cpp
  part.h

To: broulik, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 391460] print dialogue does not show advanced options

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=391460

Kai Uwe Broulik <k...@privat.broulik.de> changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED
 CC||k...@privat.broulik.de

--- Comment #3 from Kai Uwe Broulik <k...@privat.broulik.de> ---
That is a Qt bug that was recently resolved, see
https://code.qt.io/cgit/qt/qtbase.git/commit/?id=b4330bc391bbb08898f192ea3469b73aed09134c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-kwidgetsaddons] [Bug 389981] Info bar shows blue text on blue background

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=389981

Kai Uwe Broulik <k...@privat.broulik.de> changed:

   What|Removed |Added

  Component|general |general
 CC||k...@privat.broulik.de,
   ||kdelibs-b...@kde.org
Product|okular  |frameworks-kwidgetsaddons
   Assignee|okular-devel@kde.org|cf...@kde.org

--- Comment #1 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Re-assigning to KWidgetsAddons where KMessageWidget comes from.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92196
---




shell/shell.cpp (lines 401 - 402)
<https://git.reviewboard.kde.org/r/127021/#comment62890>

Braces (I guess?)

Also, range-for


- Kai Uwe Broulik


On Feb. 9, 2016, 2:51 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 9, 2016, 2:51 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 4530c33 
>   generators/mobipocket/CMakeLists.txt 87995e3 
>   shell/CMakeLists.txt 7a6af74 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 338452] New: Mousewheel zoom resets to minimum after exceeding maximum

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=338452

Bug ID: 338452
   Summary: Mousewheel zoom resets to minimum after exceeding
maximum
   Product: okular
   Version: 0.20.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: k...@privat.broulik.de

Starting in KDE SC 4.14 when using Ctrl+Mousewheel to zoom in it will wrap from
1600% to 10% a couple of times and then freeze eating up all CPU and RAM. It
shouldn't wrap, it should stop at maximum.

Steps to reproduce:
- Open a PDF file
- Use Ctrl+Mousewheel to zoom in a while

Note how it goes from 10% all the way to 1600% and then back to 10% and all the
way to 1600% and often it freezes then with 100% cpu usage eating up all my RAM
(5GB+)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 118950: Use correct #include for abs(int)

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118950/#review62017
---


Same as with Review 119133: What about just using qAbs instead of std::abs?

- Kai Uwe Broulik


On Juli 9, 2014, 3:57 nachm., Vadim Zhukov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118950/
 ---
 
 (Updated Juli 9, 2014, 3:57 nachm.)
 
 
 Review request for Okular, Jon Mease, Luigi Toscano, and Tingnan Zhang.
 
 
 Repository: okular
 
 
 Description
 ---
 
 Both C and C++ have abs() function. C one is abs(int), declared in 
 stdlib.h; and C++ has std::abs(int), std::abs(long) and std::abs(long long) 
 in cstdlib.h. But C++ has even more overloaded abs() versions in cmath, 
 that do operate on floating point values.
 
 core/utils.cpp incorrectly includes cmath while std::abs() calls near line 
 140 use integer versions really:
 
  
 std::abs(static_castint(selectedOutput-edid()-width()*10) - szMM.width()) 
  10
  
 std::abs(static_castint(selectedOutput-edid()-height()*10) - 
 szMM.height())  10)
 
 This patch changes include to cstdlib.
 
 
 Diffs
 -
 
   core/utils.cpp 71442f0 
 
 Diff: https://git.reviewboard.kde.org/r/118950/diff/
 
 
 Testing
 ---
 
 Tested on OpenBSD/i386. Without this patch, build fails.
 
 
 Thanks,
 
 Vadim Zhukov
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 119133: Include cstdlib instead of cmath for std::abs(int).

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119133/#review61653
---


What about just using qAbs instead of std::abs?

- Kai Uwe Broulik


On Juli 5, 2014, 4:10 nachm., Raphael Kubo da Costa wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119133/
 ---
 
 (Updated Juli 5, 2014, 4:10 nachm.)
 
 
 Review request for Okular.
 
 
 Repository: okular
 
 
 Description
 ---
 
 This fixes the build with libc++ after 8872524:
 
 core/utils.cpp:142:24: error: call to 'abs' is ambiguous
  
 std::abs(static_castint(selectedOutput-edid()-width()*10) - szMM.width()) 
  10
^~~~
 /usr/include/c++/v1/cmath:660:1: note: candidate function
 abs(float __x) _NOEXCEPT {return fabsf(__x);}
 ^
 /usr/include/c++/v1/cmath:664:1: note: candidate function
 abs(double __x) _NOEXCEPT {return fabs(__x);}
 ^
 /usr/include/c++/v1/cmath:668:1: note: candidate function
 abs(long double __x) _NOEXCEPT {return fabsl(__x);}
 ^
 
 core/utils.cpp:143:24: error: call to 'abs' is ambiguous
  
 std::abs(static_castint(selectedOutput-edid()-height()*10) - 
 szMM.height())  10)
^~~~
 /usr/include/c++/v1/cmath:660:1: note: candidate function
 abs(float __x) _NOEXCEPT {return fabsf(__x);}
 ^
 /usr/include/c++/v1/cmath:664:1: note: candidate function
 abs(double __x) _NOEXCEPT {return fabs(__x);}
 ^
 /usr/include/c++/v1/cmath:668:1: note: candidate function
 abs(long double __x) _NOEXCEPT {return fabsl(__x);}
 ^
 
 
 Diffs
 -
 
   core/utils.cpp 71442f0e60bc3998c676ac9670964dbd9213e146 
 
 Diff: https://git.reviewboard.kde.org/r/119133/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Raphael Kubo da Costa
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115596/#review49336
---


 I originally thought about porting it to KMessageWidget, but it was more 
 complex

Wouldn't the free-floating MessageWidget KatePart incorporates, have been 
suitable for replacing Okular's custom implementation?

- Kai Uwe Broulik


On Feb. 9, 2014, 12:45 a.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115596/
 ---
 
 (Updated Feb. 9, 2014, 12:45 a.m.)
 
 
 Review request for Okular.
 
 
 Repository: okular
 
 
 Description
 ---
 
 So far the messages displayed by PageViewMessage are quite short (grep for 
 emit {error|warning|info} in the code). The widget does not resize with 
 long messages, nor does it resize on viewparent resize. The patch fixes this 
 (with a bit of heuristic in the calculation of the boundary).
 
 Side note: I originally thought about porting it to KMessageWidget, but it 
 was more complex (with a different behavior in the end) that fixing it. On 
 the other side, PageViewTopMessage is a better candidate for being ported 
 (it's already used in layouts), but that's another story.
 
 
 Diffs
 -
 
   ui/pageviewutils.h bc77cc9 
   ui/pageviewutils.cpp 3f99248 
 
 Diff: https://git.reviewboard.kde.org/r/115596/diff/
 
 
 Testing
 ---
 
 Tested normally and --reverse. I will attach a patch that allows to quickly 
 test it.
 
 
 File Attachments
 
 
 Patch to test the change
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/02/09/1f06fce0-68d5-4cb1-bd45-a1727e7e3789__test_longmessage.diff
 
 
 Thanks,
 
 Luigi Toscano
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 309902] Use KMessageWidget for informations rather than custom implementation

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=309902

--- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de ---
Kate now also uses a free-floating KMessageWidget derivate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] New: Add option to exit after printing

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=318998

Bug ID: 318998
   Summary: Add option to exit after printing
Classification: Unclassified
   Product: okular
   Version: 0.16.60
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: k...@privat.broulik.de

With current master you can run okular with the parameter --print to directly
open the print mode. When acknowledging the dialog, however, Okular stays open,
making this option not really useful for cmdline batch processing or a Dolphin
service menu. There should be an option to have Okular exit once the dialog
closed.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318999] New: Ship Service Menu for printing PDF files

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=318999

Bug ID: 318999
   Summary: Ship Service Menu for printing PDF files
Classification: Unclassified
   Product: okular
   Version: 0.16.60
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: k...@privat.broulik.de

[Somewhat depends on Bug 318998]

Okular should ship a Service Menu that contains a Print entry, so you can
easily and quickly print certain PDF (and/or other document) files.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 299359] TAB character has no impact in annotations

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=299359

Kai Uwe Broulik k...@privat.broulik.de changed:

   What|Removed |Added

   Platform|unspecified |Ubuntu Packages
Version|unspecified |0.16.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312899] Feauture Request: Configurable and Movable Toolbars

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=312899

Kai Uwe Broulik k...@privat.broulik.de changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik k...@privat.broulik.de ---
You already can:
- Hide the menubar (File/Edit/View/…) in Settings → uncheck Show Menubar
- Hide the toolbar in Settings → uncheck Show Toolbar
- Move the toolbar to another side of the window or have it as free floating
window, right click the toolbar → Lock Toolbars and drag the toolbar around
using the handle that appears on the left of the toolbar
- Hide the status bar in Settings → Show page navigation bar. You can add a
Page indicator to the toolbar (like I do because the status bar wastes space)
by right clicking the toolbar, choosing Configure Toolbars, choosing Main
Toolbar okular_part and on the left there is a Page number widget that you
can add
- Make the icons on the left (content, preview, bookmarks) smaller by right
clicking and eg. unchecking Show Text and/or choosing a smaller icon size there

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312771] New: When zooming in using Ctrl+Mousewheel zoom in to the cursor position

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=312771

Bug ID: 312771
   Summary: When zooming in using Ctrl+Mousewheel zoom in to the
cursor position
Classification: Unclassified
   Product: okular
   Version: 0.15.3
  Hardware: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: k...@privat.broulik.de

When I zoom in using Ctrl+Mousewheel the document just zooms in. It would be
better if it zoomed towards the mouse pointer, like Gwenview does, so you can
just hover the area you want to enlarge and Ctrl+Mousewheel without needing to
scroll where you want to look at all the time.
(Btw the new tiled rendering is awesome)

Reproducible: Always

Steps to Reproduce:
1. Open a big PDF file (such as public transport lines or a map)
2. Move your mouse over a town/station in some corner of the document
3. Zoom in using Ctrl and your mousewheel
Actual Results:  
The document will zoom towards the center of the document

Expected Results:  
The document will zoom towards your mouse cursor so you will eventually have
the desired town/station magnified.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 311417] New: Add Send via E-Mail to File menu

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=311417

Bug ID: 311417
  Severity: wishlist
   Version: 0.15.3
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Add Send via E-Mail to File menu
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

When I have a PDF document open, I'd like to be able to easily share this file
via E-Mail, so a Send by Mail entry should be added to the File menu hooking
into KMail or so.

Reproducible: Always

Steps to Reproduce:
1. Open PDF file
2. Go to File
3.
Actual Results:  
No option to send via Mail

Expected Results:  
Option to send via Mail

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 309902] New: Use KMessageWidget for informations rather than custom implementation

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=309902

Bug ID: 309902
  Severity: wishlist
   Version: 0.15.3
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Use KMessageWidget for informations rather than custom
implementation
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

Now that we have that beautiful standard KMessageWidget Okular should use this
one rather than its custom implementation. This gives us a unified look and
feel, and also they transition in beautifully :)

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: GUI to configure the Graphics Anti-alias.

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106660/#review19645
---



conf/dlgperformancebase.ui
http://git.reviewboard.kde.org/r/106660/#comment15644

Why not add a checkbox here rather than a separate group with two radio 
boxes?


- Kai Uwe Broulik


On Sept. 30, 2012, 9:53 a.m., Jaydeep Solanki wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/106660/
 ---
 
 (Updated Sept. 30, 2012, 9:53 a.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Graphics Anti-alias can be enabled/disabled from Okular settings..
 
 
 This addresses bug 164759.
 http://bugs.kde.org/show_bug.cgi?id=164759
 
 
 Diffs
 -
 
   conf/dlgperformancebase.ui 3a9f9aa 
 
 Diff: http://git.reviewboard.kde.org/r/106660/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jaydeep Solanki
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 307525] New: Add Print option to Okular KPart (that is embedded in Ark eg.)

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=307525

Bug ID: 307525
  Severity: wishlist
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Add Print option to Okular KPart (that is embedded in
Ark eg.)
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

Ark opens files in a Previewer that looks like using a KPart to show PDF files
using Okular. This preview sports the known sidebar with Bookmarks,
Annotations, etc. Hoewever, it does not have a Print option. This renders the
entire feature really useless.
Situation is: I get an encrypted ZIP file (which I have to open in Ark, and so
I cannot use the ZIP kio slave that works with Dolphin) and I want to print a
PDF that is inside that file.
At the moment I have to drag the file out to the desktop (and Folderview widget
accepts the drag event at random, so not reliable there), open it in Okular,
print it, and then delete it afterwards.

So, we really need a Print function/button there.

Reproducible: Always

Steps to Reproduce:
1. Have an encrypted ZIP file in Ark
2. Open the PDF inside the ZIP file
3. Preview opens
Actual Results:  
There is no print option

Expected Results:  
There is a print option

I already filed this to Ark but Ark seems rather unmaintained and I think this
is an Okular issue, so I hope you can help here. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 305194] New: When there is only one page, Opposite pages should have no effect

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=305194

Bug ID: 305194
  Severity: minor
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: When there is only one page, Opposite pages should
have no effect
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

I usually do Opposite pages view (not the one with Opposite pages, first
page centered). When there is only one page in the document, this page should
be full-screen regardless of the setting.

Reproducible: Always

Steps to Reproduce:
1. Open PDF that has only one page
2. Do View → View Mode → Opposite pages
3.
Actual Results:  
The page is aligned to the left border of the screen

Expected Results:  
The page is centered nontheless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 305194] When there is only one page, Opposite pages should have no effect

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=305194

--- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de ---
Created attachment 73179
  -- https://bugs.kde.org/attachment.cgi?id=73179action=edit
Okular opposite wrong display

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 298730] Add option to print annotations as well

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=298730

--- Comment #2 from Kai Uwe Broulik k...@privat.broulik.de ---
I just tried today's git checkout of Okular and I can nowhere find an option
(neither in printer dialog nor in Okular settings) and it also does not print
annotations. Am I blind?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 299359] New: TAB character has no impact in annotations

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=299359

Bug ID: 299359
  Severity: normal
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: TAB character has no impact in annotations
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

When creating annotations, and you e.g. want a quick'n'dirty list/table, you
are likely to use the TAB key. The Tab however is not displayed when the
annotation is finalized. In the editor, the tab is shown properly but once you
save it, the tab is lost.
See attachment.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 299359] TAB character has no impact in annotations

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=299359

--- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de ---
Created attachment 70852
  -- https://bugs.kde.org/attachment.cgi?id=70852action=edit
Tab missing

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 298851] Okular crashed when trying to add annotation

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=298851

--- Comment #2 from Kai Uwe Broulik k...@privat.broulik.de ---
Ah, thought so, DrKonqui presented me the other bugs but their description was
not about annotations. But thanks :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 298851] New: Okular crashed when trying to add annotation

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=298851

Bug ID: 298851
  Severity: crash
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Okular crashed when trying to add annotation
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Ubuntu Packages
Status: UNCONFIRMED
 Component: general
   Product: okular

Application: okular (0.14.2)
KDE Platform Version: 4.8.2 (4.8.2)
Qt Version: 4.8.1
Operating System: Linux 3.2.0-23-generic x86_64
Distribution: Ubuntu 12.04 LTS

-- Information about the crash:
- What I was doing when the application crashed:
I was opening the PDF file and rapidly pressed the key 2 for Yellow Inline
annotation, then Okular crashed. Same happened, when I rapidly pressed F6
(to enable Annotation bar, that is NOT remembered …), then 2,

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
[Current thread is 1 (Thread 0x7fac291ab780 (LWP 6263))]

Thread 2 (Thread 0x7fac1f571700 (LWP 6264)):
#0  0x0038b2ce6b03 in __GI___poll (fds=optimized out, nfds=optimized
out, timeout=optimized out) at ../sysdeps/unix/sysv/linux/poll.c:87
#1  0x0038b4447ff6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x0038b4448124 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x0038b95aa426 in QEventDispatcherGlib::processEvents
(this=0x7fac180008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#4  0x0038b9579c82 in QEventLoop::processEvents (this=optimized out,
flags=...) at kernel/qeventloop.cpp:149
#5  0x0038b9579ed7 in QEventLoop::exec (this=0x7fac1f570dd0, flags=...) at
kernel/qeventloop.cpp:204
#6  0x0038b9478fa7 in QThread::exec (this=optimized out) at
thread/qthread.cpp:501
#7  0x0038b95599ff in QInotifyFileSystemWatcherEngine::run (this=0xfd4b70)
at io/qfilesystemwatcher_inotify.cpp:248
#8  0x0038b947bfcb in QThreadPrivate::start (arg=0xfd4b70) at
thread/qthread_unix.cpp:298
#9  0x0038b3407e9a in start_thread (arg=0x7fac1f571700) at
pthread_create.c:308
#10 0x0038b2cf24bd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#11 0x in ?? ()

Thread 1 (Thread 0x7fac291ab780 (LWP 6263)):
[KCrash Handler]
#6  Okular::Page::setTextPage (this=0x0, textPage=0x7fac1400e070) at
../core/page.cpp:476
#7  0x7fac226ce971 in Okular::GeneratorPrivate::textpageGenerationFinished
(this=optimized out) at ../core/generator.cpp:133
#8  0x0038b9594446 in QObject::event (this=0xae5180, e=optimized out) at
kernel/qobject.cpp:1195
#9  0x0038bc7cb894 in notify_helper (e=0x7fac1401b440, receiver=0xae5180,
this=0xa5a060) at kernel/qapplication.cpp:4559
#10 QApplicationPrivate::notify_helper (this=0xa5a060, receiver=0xae5180,
e=0x7fac1401b440) at kernel/qapplication.cpp:4531
#11 0x0038bc7d0713 in QApplication::notify (this=0x7fffa37ab520,
receiver=0xae5180, e=0x7fac1401b440) at kernel/qapplication.cpp:4420
#12 0x0038bec36b46 in KApplication::notify (this=0x7fffa37ab520,
receiver=0xae5180, event=0x7fac1401b440) at
../../kdeui/kernel/kapplication.cpp:311
#13 0x0038b957ae9c in QCoreApplication::notifyInternal
(this=0x7fffa37ab520, receiver=0xae5180, event=0x7fac1401b440) at
kernel/qcoreapplication.cpp:876
#14 0x0038b957ec6a in sendEvent (event=0x7fac1401b440, receiver=0xae5180)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#15 QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0,
data=0xa2e670) at kernel/qcoreapplication.cpp:1500
#16 0x0038b95a9f93 in sendPostedEvents () at
../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:236
#17 postEventSourceDispatch (s=optimized out) at
kernel/qeventdispatcher_glib.cpp:279
#18 0x0038b4447c9a in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#19 0x0038b4448060 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#20 0x0038b4448124 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#21 0x0038b95aa3bf in QEventDispatcherGlib::processEvents (this=0xa2fb30,
flags=...) at kernel/qeventdispatcher_glib.cpp:424
#22 0x0038bc873d6e in QGuiEventDispatcherGlib::processEvents
(this=optimized out, flags=...) at kernel/qguieventdispatcher_glib.cpp:204
#23 0x0038b9579c82 in QEventLoop::processEvents (this=optimized out,
flags=...) at kernel/qeventloop.cpp:149
#24 0x0038b9579ed7 in QEventLoop::exec (this=0x7fffa37ab4b0, flags=...) at
kernel/qeventloop.cpp:204
#25 0x0038b957ef67 in QCoreApplication::exec () at
kernel/qcoreapplication.cpp:1148
#26 0x004079c6 in main (argc=optimized out, argv=optimized out) at
../../shell/main.cpp:85

Possible duplicates by query: bug 297379, bug 293542.

Reported using DrKonqi

-- 
You are 

[Okular-devel] [Bug 298730] New: Add option to print annotations as well

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=298730

Bug ID: 298730
  Severity: wishlist
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Add option to print annotations as well
Classification: Unclassified
OS: Linux
  Reporter: k...@privat.broulik.de
  Hardware: Other
Status: UNCONFIRMED
 Component: general
   Product: okular

Our lecture notes at the university have gaps that need to be filled in.
Because I am not a guy that loves paper, I used Okular and added annotations
(i.e. those notes that directly display in the document, not the popup ones) to
complement the document.
When I wanted to print the file to get a complete PDF that also contains the
annotations, the annotations were not printed. I did not find an option in
printer settings or view options to have annotations printed as well. (I know
there is a document archive but I want a shareable ready PDF)

Reproducible: Always

Steps to Reproduce:
1. Open a PDF in Okular
2. Add some annotations (specifically visible ones, no popup notes)
3. Print the file
Actual Results:  
The PDF is printed but the annotations are not

Expected Results:  
The PDF is printed and if you check the option Print annotations in PDF
options tab of printer settings, annotations are printed and the document
looks exactly like it was presented onscreen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 287370] New: Make Okular’s scroll bar background dark-grey like Gwenview’s

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=287370

   Summary: Make Okular’s scroll bar background dark-grey like
Gwenview’s
   Product: okular
   Version: unspecified
  Platform: Ubuntu Packages
OS/Version: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
AssignedTo: okular-devel@kde.org
ReportedBy: k...@privat.broulik.de


Version:   unspecified (using KDE 4.7.3) 
OS:Linux

In the populer document viewers in KDE (Gwenview and Okular) the empty
background is dark-grey which is good. Gwenview also makes the background of
the scrollbar dark-grey, so only the handle is visible and to avoid the grey
bar being there all the time.
Okular, however, does not, and so, especially because I have hidden all other
UI elements (statusbar, left pane, menu bar, etc) I still get that grey bar at
the right where the scrollbar is.
The scroll bar background should be dark-grey as well; maybe copying the code
from Gwenview is possible.

Reproducible: Always



Expected Results:  
Make the scrollbar background grey to match the background of the window.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel