[Active] [Bug 308240] active-documentviewer crashes by using zoom gestures
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |UNMAINTAINED -- You are receiving this mail because: You are on the CC list for the bug.
D12884: Remove the internal file navigation from the global drawer
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid
D12770: Android: Make it possible to associate with files
mart accepted this revision. This revision is now accepted and ready to land. Restricted Application added a subscriber: okular-devel. REPOSITORY R223 Okular BRANCH filesAndroid REVISION DETAIL https://phabricator.kde.org/D12770 To: apol, #okular, aacid, mart Cc: okular-devel, ngraham, aacid
D12299: Android: include metadata for okular kirigami
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for the icon, maybe a png version of https://cgit.kde.org/breeze-icons.git/tree/icons/apps/48/okular.svg which is the breeze icon REPOSITORY R223 Okular BRANCH okularkirigamiandroid REVISION DETAIL https://phabricator.kde.org/D12299 To: apol, #okular, mart, aacid Cc: michaelweghorn, ngraham, aacid
D12176: Turn okularkirigami into an executable
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12176 To: apol, #kirigami, #okular, mart Cc: plasma-devel, michaelweghorn, ngraham, apol, aacid, davidedmundson, mart, hein
[Okular-devel] Review Request 121326: initial port of QML components to QtQuick2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121326/ --- Review request for Okular. Repository: okular Description --- this is an initial port of the qml component set of okular to qtquick2 it's straightforward, except pageitem that right now is a qquickpainteditem, that works fine, but a bit slower than generating and uploading the textures by hand (that may be an eventual future port) the okular active application is still missing, but the components can be used from anywhere in qml Diffs - active/components/okularplugin.cpp a7cbff1 active/components/pageitem.h 932bde3 active/components/pageitem.cpp f9d48f0 active/components/qmldir d62e2ae active/components/thumbnailitem.h ad3a341 active/components/thumbnailitem.cpp e56170c CMakeLists.txt d56c02e active/components/CMakeLists.txt 07eac9b active/components/documentitem.cpp c8f7ee4 active/components/okularplugin.h c229c53 Diff: https://git.reviewboard.kde.org/r/121326/diff/ Testing --- files open and render from a simple qml file Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 121326: initial port of QML components to QtQuick2
On Dec. 2, 2014, 12:20 p.m., Albert Astals Cid wrote: Target is frameworks branch, right? yes, for frameworks branch - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121326/#review71246 --- On Dec. 2, 2014, 12:08 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121326/ --- (Updated Dec. 2, 2014, 12:08 p.m.) Review request for Okular. Repository: okular Description --- this is an initial port of the qml component set of okular to qtquick2 it's straightforward, except pageitem that right now is a qquickpainteditem, that works fine, but a bit slower than generating and uploading the textures by hand (that may be an eventual future port) the okular active application is still missing, but the components can be used from anywhere in qml Diffs - active/components/okularplugin.cpp a7cbff1 active/components/pageitem.h 932bde3 active/components/pageitem.cpp f9d48f0 active/components/qmldir d62e2ae active/components/thumbnailitem.h ad3a341 active/components/thumbnailitem.cpp e56170c CMakeLists.txt d56c02e active/components/CMakeLists.txt 07eac9b active/components/documentitem.cpp c8f7ee4 active/components/okularplugin.h c229c53 Diff: https://git.reviewboard.kde.org/r/121326/diff/ Testing --- files open and render from a simple qml file Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 121326: initial port of QML components to QtQuick2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121326/ --- (Updated Dec. 2, 2014, 7:41 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Repository: okular Description --- this is an initial port of the qml component set of okular to qtquick2 it's straightforward, except pageitem that right now is a qquickpainteditem, that works fine, but a bit slower than generating and uploading the textures by hand (that may be an eventual future port) the okular active application is still missing, but the components can be used from anywhere in qml Diffs - active/components/okularplugin.cpp a7cbff1 active/components/pageitem.h 932bde3 active/components/pageitem.cpp f9d48f0 active/components/qmldir d62e2ae active/components/thumbnailitem.h ad3a341 active/components/thumbnailitem.cpp e56170c CMakeLists.txt d56c02e active/components/CMakeLists.txt 07eac9b active/components/documentitem.cpp c8f7ee4 active/components/okularplugin.h c229c53 Diff: https://git.reviewboard.kde.org/r/121326/diff/ Testing --- files open and render from a simple qml file Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115751: QML PageItem: Handle document path changes
On Feb. 14, 2014, 7:15 p.m., Marco Martin wrote: looks fine to me (would like a +1 from okular people too tough) Albert Astals Cid wrote: I am wondering who sets m_page back to something other than 0, but if you say it works, let's ship it :D whatever qml client instantiates it it can set the page number to anything - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115751/#review49796 --- On Feb. 14, 2014, 7:10 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115751/ --- (Updated Feb. 14, 2014, 7:10 p.m.) Review request for Okular and Marco Martin. Repository: okular Description --- QML PageItem: Handle document path changes PageItem works quite well if the DocumentItem has the path on construction, but it does not update if the path is initially blank and then later changed. Diffs - active/components/pageitem.h b4fe828 active/components/pageitem.cpp ea5ce10 Diff: https://git.reviewboard.kde.org/r/115751/diff/ Testing --- Yup. It now works when the path is provided after the DocumentItem's construction. Thanks, Vishesh Handa ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Active] [Bug 308240] active-documentviewer crashes by using zoom gestures
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin notm...@gmail.com changed: What|Removed |Added CC||okular-devel@kde.org --- Comment #28 from Marco Martin notm...@gmail.com --- the file crashes in desktop okular as well, slightly different bt (this is from master): Application: Okular (okular), signal: Aborted Using host libthread_db library /lib/libthread_db.so.1. [KCrash Handler] #7 0xb7767424 in __kernel_vsyscall () #8 0xb57c931f in raise () from /lib/libc.so.6 #9 0xb57cac03 in abort () from /lib/libc.so.6 #10 0xb5b76e5e in qt_message_output(QtMsgType, char const*) () from /usr/lib/libQtCore.so.4 #11 0xb5b77059 in ?? () from /usr/lib/libQtCore.so.4 #12 0xb5b77178 in qFatal(char const*, ...) () from /usr/lib/libQtCore.so.4 #13 0xb5b771f5 in qt_assert(char const*, char const*, int) () from /usr/lib/libQtCore.so.4 #14 0xb365ac97 in Okular::DocumentPrivate::sendGeneratorPixmapRequest (this=0x88a51c8) at /home/diau/git/kdegit/KDE/kdegraphics/okular/core/document.cpp:1104 #15 0xb366ba79 in Okular::Document::qt_static_metacall (_o=0x883f240, _c=QMetaObject::InvokeMetaMethod, _id=22, _a=0xbfcf3cdc) at /home/diau/git/kdegit/KDE/kdegraphics/okular/build/document.moc:133 #16 0xb5cacac2 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/lib/libQtCore.so.4 #17 0xb5cb3cb5 in ?? () from /usr/lib/libQtCore.so.4 #18 0xb5cb3d7c in ?? () from /usr/lib/libQtCore.so.4 #19 0xb5caa894 in QObject::event(QEvent*) () from /usr/lib/libQtCore.so.4 #20 0xb6381b9c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4 #21 0xb638659f in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4 #22 0xb6f1b6b1 in KApplication::notify (this=0xbfcf44e8, receiver=0x89ce368, event=0xbfcf4220) at /home/diau/kdesrc/kde/kdelibs/kdeui/kernel/kapplication.cpp:311 #23 0xb5c9476e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/libQtCore.so.4 #24 0xb5cc9047 in ?? () from /usr/lib/libQtCore.so.4 #25 0xb5cc60c8 in ?? () from /usr/lib/libQtCore.so.4 #26 0xb4dc47d3 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #27 0xb4dc4b70 in ?? () from /usr/lib/libglib-2.0.so.0 #28 0xb4dc4c51 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #29 0xb5cc6741 in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4 #30 0xb643348a in ?? () from /usr/lib/libQtGui.so.4 #31 0xb5c9323c in QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4 #32 0xb5c93531 in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4 #33 0xb5c987ea in QCoreApplication::exec() () from /usr/lib/libQtCore.so.4 #34 0xb637fa14 in QApplication::exec() () from /usr/lib/libQtGui.so.4 #35 0x0804fd22 in main (argc=2, argv=0xbfcf4634) at /home/diau/git/kdegit/KDE/kdegraphics/okular/shell/main.cpp:94 -- You are receiving this mail because: You are on the CC list for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] okular active: rendering issues with document scrolling
On Tuesday 09 July 2013, Fabio D'Urso wrote: Hi, I'm getting some rendering issue while scrolling a document with okular active. Video: http://fdurso1.xoom.it/okularActive-doc-scroll.ogv pdf file: http://wwwimages.adobe.com/www.adobe.com/content/dam/Adobe/en/devnet/pdf/pd fs/PDF32000_2008.pdf After scrolling, some portions of the document look low-res until the document is scrolled again. It only seems to happen at a certain zoom level. i tried the linked pdf document with okular active master branch, the document seems to re-render correctly when zooming -- Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: You prefer this over the TryExec solution? Works for me. Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master) hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur will convert to TryExec. however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found
On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: You prefer this over the TryExec solution? Works for me. Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master) Marco Martin wrote: hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur will convert to TryExec. however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch Albert Astals Cid wrote: okular active is definitely there in the KDE/4.10 branch, see http://quickgit.kde.org/?p=okular.gita=treehb=fd22b42b264f6f8e35934eb8fb5a6a0e1d1313ae ah, yeah, i see, okular active was there, but all the mimetypes were in the only desktop file of the app, were moved to different desktop files for generators afterwards. do i port 4.10 to separate desktop files as well, or leave only master? - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19, 2013, 8:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- (Updated Feb. 19, 2013, 8:04 p.m.) Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built
https://bugs.kde.org/show_bug.cgi?id=314981 Marco Martin notm...@gmail.com changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/27c37c1fd1b87e8db40bfb3c ||46f1489559749286 --- Comment #2 from Marco Martin notm...@gmail.com --- Git commit 27c37c1fd1b87e8db40bfb3c46f1489559749286 by Marco Martin. Committed on 20/02/2013 at 11:14. Pushed by mart into branch 'master'. use TryExec to not appear when not installed when okular active is not installed, it should not appear in the open with menu, so add TryExec to see if the executable exists this is used instead of conditional install to make easier for distributions to package the desktop and active versions separately REVIEW:109047 M +1-0generators/chm/active-documentviewer_chm.desktop M +1-0generators/comicbook/active-documentviewer_comicbook.desktop M +1-0generators/djvu/active-documentviewer_djvu.desktop M +1-0generators/dvi/active-documentviewer_dvi.desktop M +1-0generators/epub/active-documentviewer_epub.desktop M +1-0generators/fax/active-documentviewer_fax.desktop M +1-0generators/fictionbook/active-documentviewer_fb.desktop M +1-0generators/kimgio/active-documentviewer_kimgio.desktop M +1-0generators/ooo/active-documentviewer_ooo.desktop M +1-0generators/plucker/active-documentviewer_plucker.desktop M +1-0generators/poppler/active-documentviewer_pdf.desktop M +1-0generators/spectre/active-documentviewer_ghostview.desktop M +1-0generators/tiff/active-documentviewer_tiff.desktop M +1-0generators/txt/active-documentviewer_txt.desktop M +1-0generators/xps/active-documentviewer_xps.desktop http://commits.kde.org/okular/27c37c1fd1b87e8db40bfb3c46f1489559749286 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built
https://bugs.kde.org/show_bug.cgi?id=314981 --- Comment #3 from Marco Martin notm...@gmail.com --- i added tryexec in the end so distributions can't include all that is in generators in the same package without having to worry to move out the files of active, if they want to make separate packages of both -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109047: Install active desktop file only when active found
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- Review request for Okular. Description --- this should solve https://bugs.kde.org/show_bug.cgi?id=314981 when the active app is not compiled the active desktop files don't get installed Diffs - CMakeLists.txt e40cfd6 active/CMakeLists.txt 1a8ff74 generators/chm/CMakeLists.txt e54affc generators/comicbook/CMakeLists.txt 4df23a6 generators/djvu/CMakeLists.txt 8ca545c generators/dvi/CMakeLists.txt 30b7394 generators/epub/CMakeLists.txt f076ed9 generators/fax/CMakeLists.txt f3a321c generators/fictionbook/CMakeLists.txt 4fe3877 generators/kimgio/CMakeLists.txt b0a61eb generators/ooo/CMakeLists.txt 5d11daf generators/plucker/CMakeLists.txt c376467 generators/poppler/CMakeLists.txt 0964fff generators/spectre/CMakeLists.txt 617047a generators/tiff/CMakeLists.txt bab056f generators/txt/CMakeLists.txt 5a126b7 generators/xps/CMakeLists.txt 6bd8e58 Diff: http://git.reviewboard.kde.org/r/109047/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
On Oct. 19, 2012, 5:45 p.m., Albert Astals Cid wrote: Now this poses an interesting question, we are installing both okular and active-documentviewer saying they open the same mimetypes and saying they have the same initial preference, thus on a system that has both installed, which one wins? One would say that on desktop Albert Astals Cid wrote: ..continue.. One would say that on desktop you want okular to have a higher initial preference and the reverse on touch systems, but how do we do that? with a cmake switch? eh, in ideal world that priority should be able to switch back and forth dynamically.. but that doesn't seem much changeable in the short term.. anyways, i would give to the active version less priority than the desktop one, so normal okular still in use on the desktop if both are installed, while on active only the touch version would be installed. other problem i noticed with the patch is that it installs the active desktop files unconditionally, i'll fix that - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/#review20581 --- On Oct. 18, 2012, 9:09 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/ --- (Updated Oct. 18, 2012, 9:09 a.m.) Review request for Okular. Description --- splits the desktop file of the active app per mimetype, as is done for the desktop version and for the part, so only the ones that were actually built will be supported Diffs - active/app/active-documentviewer.desktop 66c751e generators/chm/CMakeLists.txt 3f28603 generators/chm/active-documentviewer_chm.desktop PRE-CREATION generators/comicbook/CMakeLists.txt 067a07a generators/comicbook/active-documentviewer_comicbook.desktop PRE-CREATION generators/djvu/CMakeLists.txt dc9b998 generators/djvu/active-documentviewer_djvu.desktop PRE-CREATION generators/dvi/CMakeLists.txt d517b42 generators/dvi/active-documentviewer_dvi.desktop PRE-CREATION generators/epub/CMakeLists.txt f05bf38 generators/epub/active-documentviewer_epub.desktop PRE-CREATION generators/fax/CMakeLists.txt 79e7faa generators/fax/active-documentviewer_fax.desktop PRE-CREATION generators/fictionbook/CMakeLists.txt 821cdbf generators/fictionbook/active-documentviewer_fb.desktop PRE-CREATION generators/kimgio/CMakeLists.txt 07d9f0c generators/ooo/CMakeLists.txt 2496fbb generators/ooo/active-documentviewer_ooo.desktop PRE-CREATION generators/plucker/CMakeLists.txt c79d59a generators/plucker/active-documentviewer_plucker.desktop PRE-CREATION generators/poppler/CMakeLists.txt 78885fc generators/poppler/active-documentviewer_pdf.desktop PRE-CREATION generators/spectre/CMakeLists.txt d3d6f80 generators/spectre/active-documentviewer_ghostview.desktop PRE-CREATION generators/tiff/CMakeLists.txt 31186ea generators/tiff/active-documentviewer_tiff.desktop PRE-CREATION generators/xps/CMakeLists.txt 50eec71 generators/xps/active-documentviewer_xps.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106930/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/ --- (Updated Oct. 18, 2012, 9:09 a.m.) Review request for Okular. Description --- splits the desktop file of the active app per mimetype, as is done for the desktop version and for the part, so only the ones that were actually built will be supported Diffs (updated) - active/app/active-documentviewer.desktop 66c751e generators/chm/CMakeLists.txt 3f28603 generators/chm/active-documentviewer_chm.desktop PRE-CREATION generators/comicbook/CMakeLists.txt 067a07a generators/comicbook/active-documentviewer_comicbook.desktop PRE-CREATION generators/djvu/CMakeLists.txt dc9b998 generators/djvu/active-documentviewer_djvu.desktop PRE-CREATION generators/dvi/CMakeLists.txt d517b42 generators/dvi/active-documentviewer_dvi.desktop PRE-CREATION generators/epub/CMakeLists.txt f05bf38 generators/epub/active-documentviewer_epub.desktop PRE-CREATION generators/fax/CMakeLists.txt 79e7faa generators/fax/active-documentviewer_fax.desktop PRE-CREATION generators/fictionbook/CMakeLists.txt 821cdbf generators/fictionbook/active-documentviewer_fb.desktop PRE-CREATION generators/kimgio/CMakeLists.txt 07d9f0c generators/ooo/CMakeLists.txt 2496fbb generators/ooo/active-documentviewer_ooo.desktop PRE-CREATION generators/plucker/CMakeLists.txt c79d59a generators/plucker/active-documentviewer_plucker.desktop PRE-CREATION generators/poppler/CMakeLists.txt 78885fc generators/poppler/active-documentviewer_pdf.desktop PRE-CREATION generators/spectre/CMakeLists.txt d3d6f80 generators/spectre/active-documentviewer_ghostview.desktop PRE-CREATION generators/tiff/CMakeLists.txt 31186ea generators/tiff/active-documentviewer_tiff.desktop PRE-CREATION generators/xps/CMakeLists.txt 50eec71 generators/xps/active-documentviewer_xps.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106930/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: Split active app desktop file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/ --- Review request for Okular. Description --- splits the desktop file of the active app per mimetype, as is done for the desktop version and for the part, so only the ones that were actually built will be supported Diffs - active/app/active-documentviewer.desktop 66c751e generators/chm/CMakeLists.txt 3f28603 generators/chm/active-documentviewer_chm.desktop PRE-CREATION generators/comicbook/CMakeLists.txt 067a07a generators/comicbook/active-documentviewer_comicbook.desktop PRE-CREATION generators/djvu/CMakeLists.txt dc9b998 generators/djvu/active-documentviewer_djvu.desktop PRE-CREATION generators/dvi/CMakeLists.txt d517b42 generators/dvi/active-documentviewer_dvi.desktop PRE-CREATION generators/epub/CMakeLists.txt f05bf38 generators/epub/active-documentviewer_epub.desktop PRE-CREATION generators/fax/CMakeLists.txt 79e7faa generators/fax/active-documentviewer_fax.desktop PRE-CREATION generators/fictionbook/CMakeLists.txt 821cdbf generators/fictionbook/active-documentviewer_fb.desktop PRE-CREATION generators/kimgio/CMakeLists.txt 07d9f0c generators/ooo/CMakeLists.txt 2496fbb generators/ooo/active-documentviewer_ooo.desktop PRE-CREATION generators/plucker/CMakeLists.txt c79d59a generators/plucker/active-documentviewer_plucker.desktop PRE-CREATION generators/poppler/CMakeLists.txt 78885fc generators/poppler/active-documentviewer_pdf.desktop PRE-CREATION generators/spectre/CMakeLists.txt d3d6f80 generators/spectre/active-documentviewer_ghostview.desktop PRE-CREATION generators/tiff/CMakeLists.txt 31186ea generators/tiff/active-documentviewer_tiff.desktop PRE-CREATION generators/xps/CMakeLists.txt 50eec71 generators/xps/active-documentviewer_xps.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106930/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 14, 2012, 6:32 p.m., Albert Astals Cid wrote: So are you happy enough with the feature set now? Anything else you want to work on before we do the final merge review? from my side, good to go - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review20324 --- On Oct. 12, 2012, 12:54 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 12, 2012, 12:54 p.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 12, 2012, 12:54 p.m.) Review request for Okular. Changes --- removed most of QML warnings (some in okular active, some in kde-runtime components) full urls as bookmarks, functions to go to a specific bookmark or fetch specific position of it Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs (updated) - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: Little summary since the other block is getting huge :D * Messages.sh tweaking after merge * .desktop for format support tweaking after merge * Bookmark viewport vs page number * Pagepainter API to disable AA I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's public qml API related, not that we have to promise API stability on the QML side either... So what do you say, you want to me to merge now or finish the fixup these things? Albert Astals Cid wrote: Ah, there's also the issue that i get this on running file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: module org.kde.plasma.extras is not installed import org.kde.plasma.extras 0.1 as PlasmaExtras Marco Martin wrote: with qmlviewer or with the compiled app? the plasmaextras import exists since 4.9, so it should work if it's with qmlviewer it's known, because it doesn't know where the import folder is (we can't use the global hardcoded /usr/imports since we have to respect the install prefix) so qml files using any import from org.kde.* needs qmlviewer -I prefix/lib/kde4/imports filename.qml Marco Martin wrote: something that i would like to do before merge still is the bookmark management (since may require quite some changes in the qml part as well, still not sure how much invasive). how do you think it should be done? ie, how would you expose the bookmarks in qml? i still don't have clear exactly what a bookmark url represents, so i need a more informed idea ;) Albert Astals Cid wrote: Fixed the import thing, was a PEBKAC. About the bookmarks, well, a bookmarl url represents the url to the document and the viewport to move to the document. DocumentViewport knows how to handle that you shouldn't need to know more, just feed it to the document and that's it. Also there is the binding loop we talked about on IRC that would be good if was fixed before merging. I am starting to make use of DocumentViewport to have more info about the bookmarks (pushed in branch). one thing i still wish to have is to avoid the bookmark urls to be exposed, but have a model with document, page, position roles - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: Little summary since the other block is getting huge :D * Messages.sh tweaking after merge * .desktop for format support tweaking after merge * Bookmark viewport vs page number * Pagepainter API to disable AA I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's public qml API related, not that we have to promise API stability on the QML side either... So what do you say, you want to me to merge now or finish the fixup these things? Albert Astals Cid wrote: Ah, there's also the issue that i get this on running file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: module org.kde.plasma.extras is not installed import org.kde.plasma.extras 0.1 as PlasmaExtras Marco Martin wrote: with qmlviewer or with the compiled app? the plasmaextras import exists since 4.9, so it should work if it's with qmlviewer it's known, because it doesn't know where the import folder is (we can't use the global hardcoded /usr/imports since we have to respect the install prefix) so qml files using any import from org.kde.* needs qmlviewer -I prefix/lib/kde4/imports filename.qml Marco Martin wrote: something that i would like to do before merge still is the bookmark management (since may require quite some changes in the qml part as well, still not sure how much invasive). how do you think it should be done? ie, how would you expose the bookmarks in qml? i still don't have clear exactly what a bookmark url represents, so i need a more informed idea ;) Albert Astals Cid wrote: Fixed the import thing, was a PEBKAC. About the bookmarks, well, a bookmarl url represents the url to the document and the viewport to move to the document. DocumentViewport knows how to handle that you shouldn't need to know more, just feed it to the document and that's it. Also there is the binding loop we talked about on IRC that would be good if was fixed before merging. Marco Martin wrote: I am starting to make use of DocumentViewport to have more info about the bookmarks (pushed in branch). one thing i still wish to have is to avoid the bookmark urls to be exposed, but have a model with document, page, position roles for how bookmarkmanager works doesn't seem possible to map directly when a new bookmark is inserted or removed, but you know only when something changed, so would be necessary to do a complete model reset every time? maybe this would be too expensive? - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: Little summary since the other block is getting huge :D * Messages.sh tweaking after merge * .desktop for format support tweaking after merge * Bookmark viewport vs page number * Pagepainter API to disable AA I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's public qml API related, not that we have to promise API stability on the QML side either... So what do you say, you want to me to merge now or finish the fixup these things? Albert Astals Cid wrote: Ah, there's also the issue that i get this on running file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: module org.kde.plasma.extras is not installed import org.kde.plasma.extras 0.1 as PlasmaExtras with qmlviewer or with the compiled app? the plasmaextras import exists since 4.9, so it should work if it's with qmlviewer it's known, because it doesn't know where the import folder is (we can't use the global hardcoded /usr/imports since we have to respect the install prefix) so qml files using any import from org.kde.* needs qmlviewer -I prefix/lib/kde4/imports filename.qml - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: Little summary since the other block is getting huge :D * Messages.sh tweaking after merge * .desktop for format support tweaking after merge * Bookmark viewport vs page number * Pagepainter API to disable AA I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's public qml API related, not that we have to promise API stability on the QML side either... So what do you say, you want to me to merge now or finish the fixup these things? Albert Astals Cid wrote: Ah, there's also the issue that i get this on running file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: module org.kde.plasma.extras is not installed import org.kde.plasma.extras 0.1 as PlasmaExtras Marco Martin wrote: with qmlviewer or with the compiled app? the plasmaextras import exists since 4.9, so it should work if it's with qmlviewer it's known, because it doesn't know where the import folder is (we can't use the global hardcoded /usr/imports since we have to respect the install prefix) so qml files using any import from org.kde.* needs qmlviewer -I prefix/lib/kde4/imports filename.qml something that i would like to do before merge still is the bookmark management (since may require quite some changes in the qml part as well, still not sure how much invasive). how do you think it should be done? ie, how would you expose the bookmarks in qml? i still don't have clear exactly what a bookmark url represents, so i need a more informed idea ;) - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Changes --- mainly relicense Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs (updated) - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: You seem to be missing a Message.sh file Marco Martin wrote: i added a couple of messages.sh and catalogs. org.kde.active.documentviewer.pot for the app, both qml and c++ parts org.kde.okular.pot for the qml components: maybe that should be together okular.pot? Albert Astals Cid wrote: What maybe we should do is split okular into okularcore and regular okular application, but i think we can have that after we merge this stuff in. +1 ;) On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: active/app/package/contents/ui/Bookmarks.qml, line 5 http://git.reviewboard.kde.org/r/10/diff/1/?file=87953#file87953line5 The chosen license looks a bit strage given all the rest of Okular code is just GPL, is this a conscious selection or just something that happened by cp? Marco Martin wrote: i usually prefer lgpl for qml files to make it less of an hassle if some piece has to be moved in a component, but if here the preference is for gpl i can relicense it. btw i can see quite some problems if the okular core library is going to be used around Albert Astals Cid wrote: The problem is that if your qml files say LGPL, i can easy go and use them from a non free app and not realize i'm breaking the license. What do you mean with some problems? my files are all gpl now. since the rest of the kde libraries are lgpl there may be contexts (either proprietary or just opensource but incompatible licenses) where is possible to use any kde library but okularcore. Probably the case of qml components (or the kpart) is a bit different since is loading a plugin at runtime rather than linking, but I don't know those legal technicalities :p On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: active/components/documentitem.cpp, line 113 http://git.reviewboard.kde.org/r/10/diff/1/?file=87968#file87968line113 Looks like we are losing some precision here by only returning the page number, no? Marco Martin wrote: yes. it was kept simple since the ui only used that. it should get more complete (it has a page plus a qrect right?) since qml can only understand qobjects, this should become either a list of qobjects, or probably a model, even just QStandardItemModel Albert Astals Cid wrote: It contains a Okular::DocumentViewport i see the bookmarks have an url of the form file:///home/diau/print.pdf#1;C2:0.499232:0.715558:1 is documented somewhere how to encode/decode that? i guess is possible to construct a DocumentViewport from that string? maybe PageItem may have directly a viewport property that is a string encoded that way so from qml you would just pass that then the c++ side of PageItem parses and sets right page number and scroll value? On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: active/app/active-documentviewer.desktop, line 13 http://git.reviewboard.kde.org/r/10/diff/1/?file=87952#file87952line13 This is not correct, active-documentviewer will only support pdf if the poppler generator is built, you should probably imitate the billions of *.desktop files we have in the generators folders Marco Martin wrote: are they assembled in a single desktop file in the end? what about generating a desktop file with the right mimetypes with cmake? Albert Astals Cid wrote: No, they are still different desktop files (one per mimetype), but kbuildsycoca knows how to handle that fine Creating the desktop file from cmake seems ok too, but more work for my not so cmake able mind may the desktop files be in the generators folder as well? then the installation of the desktop file would be conditional if the active ui is built or, if it may make easierto even split the desktop app in the future, it may have those desktop files in an own directory (then on a second moment the desktop app would change to a similar structure, if want to be splitted from core) - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19712 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
--- On Oct. 1, 2012, 11:32 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 1, 2012, 11:32 a.m.) Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/pagepainter.h PRE-CREATION active/components/pagepainter.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/test.qml PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: QML components and touch optimized okular version
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 2, 2012, 12:21 p.m.) Review request for Okular. Changes --- implemented some of the suggested changes Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs (updated) - active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/Messages.sh PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/Messages.sh PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: QML components and touch optimized okular version
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- Review request for Okular. Description --- This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering) Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active Diffs - CMakeLists.txt a057e82 active/CMakeLists.txt PRE-CREATION active/app/CMakeLists.txt PRE-CREATION active/app/active-documentviewer.desktop PRE-CREATION active/app/package/contents/ui/Bookmarks.qml PRE-CREATION active/app/package/contents/ui/Browser.qml PRE-CREATION active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION active/app/package/contents/ui/TableOfContents.qml PRE-CREATION active/app/package/contents/ui/Thumbnails.qml PRE-CREATION active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION active/app/package/contents/ui/bookmark.png PRE-CREATION active/app/package/contents/ui/bookmark.svgz PRE-CREATION active/app/package/contents/ui/main.qml PRE-CREATION active/app/package/metadata.desktop PRE-CREATION active/app/src/CMakeLists.txt PRE-CREATION active/app/src/main.cpp PRE-CREATION active/components/CMakeLists.txt PRE-CREATION active/components/documentitem.h PRE-CREATION active/components/documentitem.cpp PRE-CREATION active/components/okularplugin.h PRE-CREATION active/components/okularplugin.cpp PRE-CREATION active/components/pageitem.h PRE-CREATION active/components/pageitem.cpp PRE-CREATION active/components/pagepainter.h PRE-CREATION active/components/pagepainter.cpp PRE-CREATION active/components/qmldir PRE-CREATION active/components/test.qml PRE-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] merging the mart/okularActive branch into master
On Monday 01 October 2012, Albert Astals Cid wrote: When something is merged into okular master I am taking a the responsability as maintainer, and to be honest i can't even build Marco's branch at the moment in my regular KDE development system, feels a bit adventureus to me to commit that much. it requires a small 48k library that at the moment resides in the plasma- mobile repo. that's not optimal, but at the moment i can't think of a better place for it (could be own repo, but wouldn't make it any easier to build i think) with frameworks it will probably be all in a single plasma frameworks place. the need for this library is quite important, because removes quite a lot of boilerplate needed to do an app with qml only ui, that's quite too easy to get it wrong * if someone wants to roll a Plasma Active based product release on a schedule that conflicts with okular release schedules, that could be an issue (branches essentially fix this issue; and really, it is preferable to always take the latest stable release rather than some random snapshot even if the touch app was in a separate repo) * more code in one repository (not really sure that matters in this case, but trying to list all issues i can think of :) those are the pro's/con's as i see them. please add / subtract as you see fit and then come up with a decision as the maintainer of okular. i really don't want this to become a discussion where each side asks questions of the other with increasingly clever debate ;) i just want an answer to what should we do with that branch. i've shared my ideas, and explained my thinking above, and simply need your decision as maintainer so i can do what ever is needed to make it happen. My opinion was quite clear when Marco came with the Okular Active code back then, put it in a separate repo. there probably were a misunderstanding, i didn't have a clear idea where that should have gone (I still not completely do ;) But you want an answer to end the discussion so here it comes: * When I add up the pros and cons i end up with a number that is quite close to zero. * To me this means invoking the the one that code is the one that decides rule. - Marco says he doesn't have a strong opinion on this. a topic i have a strong one however, is the effort not being isolated, what i would really want is this app to be well integrated in the okulat community, if it has something done in a wrong way technically, it should be fixed, but i would like to end up with something that's widely accepted by the okular community. not disliked for some technical reason (that can be fixed;) nor ignored as not my problem the latter is perfectly legitimate (not feeling the need for it) if that's the case there should be a more indepth explanation from my part why i think it's very important (at least the qml components, since they would be the public api in which any qml ui would use okular), but then yeah, we can move it elsewhere ;) - You are the other one that has done coding on the active branch and you want it merged in master So so let's see the patch in reviewboard to merge this into master and discuss over hard facts :-) here ;) https://git.reviewboard.kde.org/r/10/ Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] merging the mart/okularActive branch into master
On Saturday 29 September 2012, Albert Astals Cid wrote: El Divendres, 28 de setembre de 2012, a les 22:04:32, Aaron J. Seigo va escriure: Hi... Hi I would like to merge the mart/okularActive branch into okular master so that we can more easily take advantage of improvements in the master branch as well as make the touch based application more readily accessible to people. I thought that it was agreed back when Marco announced the code that this would end up in a different repo. Any reason why you no longer agree with that? I don't have very strong opinions on this, however, how this is done should be a policy global to kde, since many more applications will incur in this situation, so where possible it should be consistent. in defense of the same repo argument, having a single repo for all mobile versions of applications doesn't scale (for many application won't be even possible) having separate repos one for each mobile application becomes pretty quickly a mess. (besides, i hope in some future desktop applications will start to be qml based as well) Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Okular active
On Tuesday 15 May 2012, Albert Astals Cid wrote: El Dilluns, 14 de maig de 2012, a les 21:04:49, Marco Martin va escriure: Hi all, Hi (please maintain CC: since not everybody is subscribed to both lists) Looking at the current status of applications that are shipped with Plasma active (and will be on the first device) we seen that there wasn't a satisfying application for reading ebooks. Okular is preinstalled, but with a touch screen has some problems, especially small screens. Another application was developed, tablet reader but had some problems (wasn't really integrated with kde or plasma active, no possibility to open remote files, had a custom file selection dialog, two separate declarative views) But, looking at the Okular core library, we seen that is very widget-agnostic, clean and gives all for free (multiple types, tables of contents..) in the branch mart/okularActive, there is: * a qml plugin that depends only on okularcore (only had to duplicate pagepainter from ui/ hopefully will be possible to avoid that) * a small qml application that uses plasma components and the small app library from Plasma Active (conditional build over that library) Since doesn't have particular dependencies the component can be used not only in plasma active byt anywhere in qml. The app is purposedly very barebone, so far looks like this: http://wstaw.org/m/2012/05/14/plasma-desktopXi3533.png It is supposed to view a single document, still very basic, (is just possible to see a page or a thumbnail grid of all pages, things like table of contents, bookmarks, annotations will come eventually), and is supposed to be launched by clicking on a file on a filemanager (or the active file browser) so it's hidden from the menu and doesn't even start alone. The qml components just let to paint pages for now, i hope will be possible soon to add search, table of contents and support for hyperlinks (maybe the api will have to be changed a bit to have that) Looks great, I'm thinking that since okularcore headers are installed it might make sense in the future for it to live in separate repo (once the potential issues you might find with the library are ironed out). yeah, I agree, moving it outside would be better, and if it helps making okular core an independent library it's a plus ;) biggest issues atm i think are needing pagepainter (perhaps simplified and in okular core?) and the association between document and viewers (limited number, hardcoded ids) but i'm just looking at the okularcore library for the first time, so probably i forgotten details, I'm using the 1% of it, probably is going to stay quite minimal tough. i'm not sure about the qml bindings, i guess for bindings of various stuff the alternative is to put each one in the repo they depend on, or doing a repo of bindings (of which kde-runtime is kinda doing the task atm but not optimal) with each of them built conditionally, both have advantages and disadvantages, but this is for another thread ;) Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Okular active
Hi all, (please maintain CC: since not everybody is subscribed to both lists) Looking at the current status of applications that are shipped with Plasma active (and will be on the first device) we seen that there wasn't a satisfying application for reading ebooks. Okular is preinstalled, but with a touch screen has some problems, especially small screens. Another application was developed, tablet reader but had some problems (wasn't really integrated with kde or plasma active, no possibility to open remote files, had a custom file selection dialog, two separate declarative views) But, looking at the Okular core library, we seen that is very widget-agnostic, clean and gives all for free (multiple types, tables of contents..) in the branch mart/okularActive, there is: * a qml plugin that depends only on okularcore (only had to duplicate pagepainter from ui/ hopefully will be possible to avoid that) * a small qml application that uses plasma components and the small app library from Plasma Active (conditional build over that library) Since doesn't have particular dependencies the component can be used not only in plasma active byt anywhere in qml. The app is purposedly very barebone, so far looks like this: http://wstaw.org/m/2012/05/14/plasma-desktopXi3533.png It is supposed to view a single document, still very basic, (is just possible to see a page or a thumbnail grid of all pages, things like table of contents, bookmarks, annotations will come eventually), and is supposed to be launched by clicking on a file on a filemanager (or the active file browser) so it's hidden from the menu and doesn't even start alone. The qml components just let to paint pages for now, i hope will be possible soon to add search, table of contents and support for hyperlinks (maybe the api will have to be changed a bit to have that) Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
