/
Testing
---
Thanks,
Miklós Máté
ui/presentationwidget.cpp e6ecdc5
Diff: https://git.reviewboard.kde.org/r/129286/diff/
Testing
---
Thanks,
Miklós Máté
> On Jan. 7, 2017, 2:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If
> > it's the case, it's probably a no-go.
>
> Miklós Máté wrote:
> Oh, sorry I didn't realize how important this is:
>
> &q
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129286/#review102792
---
On Oct. 30, 2016, 3:29 p.m., Miklós M
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 59dd04766c46193baca9e16f78e0a539229d3257 by Albert Astals
Cid on behalf of Miklós Máté to branch master.
Repository: okular
Description
---
There are too many viewport setters already.
Diffs
> On Jan. 7, 2017, 2:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If
> > it's the case, it's probably a no-go.
>
> Miklós Máté wrote:
> Oh, sorry I didn't realize how important this is:
>
> &q
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129832/#review102029
---
Interesting hack.
- Miklós Máté
On Jan. 14, 2017, 7:23
> On Jan. 7, 2017, 2:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If
> > it's the case, it's probably a no-go.
>
> Miklós Máté wrote:
> Oh, sorry I didn't realize how important this is:
>
> &q
---
Okular core prints lots of debug messages, stop that in release builds.
Diffs
-
OkularConfigureChecks.cmake 70fe8768
ui/formwidgets.cpp 7e68b5c7
Diff: https://git.reviewboard.kde.org/r/129785/diff/
Testing
---
Thanks,
Miklós Máté
-
generators/plucker/unpluck/qunpluck.cpp 8363dd3
Diff: https://git.reviewboard.kde.org/r/129288/diff/
Testing
---
Thanks,
Miklós Máté
generators/txt/libokularGenerator_txt.json 97325db
Diff: https://git.reviewboard.kde.org/r/129584/diff/
Testing
---
Thanks,
Miklós Máté
ts.git/tree/src/imageformats
>
> Okular from git master displays eps files fine here using the kimgio
> backend.
> Though spectre would still be the better choice of course.
>
> Miklós Máté wrote:
> On my system (Debian Unstable) kimgio says unsupported file f
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit e81fb3d639400df03d47749e4c5532b32394b45c by Albert Astals
Cid on behalf of Miklós Máté to branch Applications/16.12.
Repository: okular
Description
---
Stopping on the first inherit match can prevent
ts.git/tree/src/imageformats
>
> Okular from git master displays eps files fine here using the kimgio
> backend.
> Though spectre would still be the better choice of course.
>
> Miklós Máté wrote:
> On my system (Debian Unstable) kimgio says unsupported file f
itted a new review request that can replace the last hunk.
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129584/#review101206
-------
/
Testing
---
Thanks,
Miklós Máté
://git.reviewboard.kde.org/r/129584/diff/
Testing
---
Thanks,
Miklós Máté
ialized warning.
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129286/#review100919
---
On Oct. 30, 2016, 3
le is used to track whether to
> > start or end a formatted string span (represented by tags in the
> > explode tool).
>
> Martin Tobias Holmedahl Sandsmark wrote:
>
> https://cgit.kde.org/okular.git/commit/?id=d9a31fa02ad92c663b3c5bd0fc5be38b09bc761f
> for mor
my repository doesn't contain that commit.
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129288/#review100941
------
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 4520ac7192f5c505e8fed5a14f66df85214f6620 by Albert Astals
Cid on behalf of Miklós Máté to branch Applications/16.12.
Repository: okular
Description
---
Fewer warnings is good.
Diffs
---
There are too many viewport setters already.
Diffs
-
ui/thumbnaillist.cpp 8a6b12d
Diff: https://git.reviewboard.kde.org/r/129287/diff/
Testing
---
Thanks,
Miklós Máté
://git.reviewboard.kde.org/r/129288/diff/
Testing
---
Thanks,
Miklós Máté
w.cpp bb540cb
Diff: https://git.reviewboard.kde.org/r/129284/diff/
Testing
---
Thanks,
Miklós Máté
---
Fewer warnings is good.
Diffs
-
generators/dvi/TeXFont_PFB.cpp 6b27093
Diff: https://git.reviewboard.kde.org/r/129285/diff/
Testing
---
Thanks,
Miklós Máté
/diff/
Testing
---
Thanks,
Miklós Máté
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit c183dd8bd300b39e55e3309b6b279b6e7b8e19c2 by Albert Astals
Cid on behalf of Miklós Máté to branch Applications/16.04.
Repository: okular
Description
---
https://bugs.kde.org/show_bug.cgi?id=328686
---
https://bugs.kde.org/show_bug.cgi?id=328686
Also fix the mouse cursor shape (could be a separate patch, but I don't know
how to post a series here)
Diffs
-
ui/thumbnaillist.cpp 8704bfa
Diff: https://git.reviewboard.kde.org/r/127526/diff/
Testing
---
Thanks,
Miklós Máté
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 1371ccfa28cf777dd04d3f67a1947e41b02dba0d by Albert Astals
Cid on behalf of Miklós Máté to branch Applications/16.04.
Repository: okular
Description
---
fixes bug #342076
Diffs
-
ui
---
v4: only show 1 triangle in mobile version
Repository: okular
Description
---
fixes bug #342076
Diffs (updated)
-
ui/tocmodel.cpp ce93366
Diff: https://git.reviewboard.kde.org/r/127013/diff/
Testing
---
Thanks,
Miklós Máté
w (i.e. onyl the last one
> > has the triangle)?
>
> Miklós Máté wrote:
> Without information about the expanded nodes the best we can do is to put
> triangles at every containing node. Using only the last node is not good,
> because it may be hidden within a collapsed
w (i.e. onyl the last one
> > has the triangle)?
>
> Miklós Máté wrote:
> Without information about the expanded nodes the best we can do is to put
> triangles at every containing node. Using only the last node is not good,
> because it may be hidden within a collapsed
sed parent node.
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review93378
---
On March 9, 2016, 8
---
v3: fix for the mobile version
Repository: okular
Description
---
fixes bug #342076
Diffs (updated)
-
ui/tocmodel.cpp ce93366
Diff: https://git.reviewboard.kde.org/r/127013/diff/
Testing
---
Thanks,
Miklós Máté
)
> * Introduce a new role named someting like PathToLeaf that returns the
> arrow item for the whole path (except the leaf) (for that we do not need view
> info)
> * In pageitemdeleate (that is tied to the view) you can inspect the view
> expanded/collapsed status + the ne
w about "dynamic_cast< QTreeView* >
( QObject::parent() );" and only filter the highlighted items when this returns
not NULL?
- Miklós
---
This is an automatically generated e-mail. To reply, visit:
https://g
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92846
-------
On Feb. 27, 2016, 10:30 a.m., Miklós Máté wrote:
>
> --
-d973dbcb5b64__okular_marker_v2.diff
Thanks,
Miklós Máté
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
> On Feb. 18, 2016, 12:16 a.m., Miklós Máté wrote:
> > ui/tocmodel.cpp, line 152
> > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443812#file443812line152>
> >
> > No. This function marks all the TOC items that contain the current
> &g
> On Feb. 18, 2016, 12:16 a.m., Miklós Máté wrote:
> > ui/tocmodel.cpp, line 152
> > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443812#file443812line152>
> >
> > No. This function marks all the TOC items that contain the current
> &g
items on the same level that point to the same
page, this algorithm only marks the last one.
- Miklós Máté
On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443811#file443811line44>
> >
> > The model has to know about the treeview, see line 209. This also makes
> > sure
> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443811#file443811line44>
> >
> > The model has to know about the treeview, see line 209. This also makes
> > sure
ment62944>
Instead of marking the toc items that point to the current page I mark the
toc items that *contain* the current page.
- Miklós Máté
On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
>
> ---
> This is an automatic
---
fixes bug #342076
Diffs
-
ui/toc.cpp 09625af
ui/tocmodel.cpp ce93366
Diff: https://git.reviewboard.kde.org/r/127013/diff/
Testing
---
Thanks,
Miklós Máté
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman
45 matches
Mail list logo
