T10812: KDE Applications

ngraham closed this task as "Resolved". ngraham added a comment. We renamed it the "release service" and no longer use "KDE Applications" as a brand name, in favor of using individual apps' names whenever possible. TASK DETAIL https://phabricator.kde.org/T10812 To: ngraham Cc: fusitter,

T10243: Some KDE applications could use better icons

ngraham added a comment. You have a long history with Breeze icons and care a great deal about design. Maybe **you** should be reviewing icon patches and suggesting improvements and working on new versions of problematic icons. Be the change you wish to see in the world. :) TASK DETAIL

T10243: Some KDE applications could use better icons

ngraham added a comment. I get it, you think that there is or should be a meaningful difference between an application's icon and its logo, and that the breeze icon theme should be full of icons, not logos. But there doesn't seem to be much agreement with this idea: not among the current

T10243: Some KDE applications could use better icons

ngraham added a comment. @alex-l nobody shares your opinion that app icons are different from logos and that therefore they should have a minimal, understated style and do not need to mimic the original version. This isn't a self-evident design truth, it's just your opinion on icon design,

T10243: Some KDE applications could use better icons

ngraham added a comment. Cool stuff. Could you start submitting your icons are merge requests to the breeze-icons repo? https://invent.kde.org/frameworks/breeze-icons/-/merge_requests TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: tosta, johanneszarl, Leon0402,

T10243: Some KDE applications could use better icons

ngraham added a comment. I have a feeling they will, with some polish. :) TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid,

T10243: Some KDE applications could use better icons

ngraham added a comment. With Okular, I'm interested in being more faithful to the original if we're going to redo the icon. See up-thread: T10243#201368 . TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: tosta, johanneszarl,

T10243: Some KDE applications could use better icons

ngraham added a comment. I like those! TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau,

D29246: D361740 - Disable warning "The document requested to be launched in presentation mode" on document reload

ngraham added a comment. Thanks for the patch! Okular uses GitLab now. Can you re-submit this as a Merge Request at https://invent.kde.org/kde/okular/-/merge_requests/? Documentation can be found at https://community.kde.org/Infrastructure/GitLab REPOSITORY R223 Okular REVISION

T10243: Some KDE applications could use better icons

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau,

T10243: Some KDE applications could use better icons

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau,

T10243: Some KDE applications could use better icons

ngraham added a revision: D25123: New yakuake logo/icon. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, lesliezhai, elvisangelaccio,

D15580: New annotation toolbar

ngraham added a comment. See also https://community.kde.org/Infrastructure/GitLab REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D15580: New annotation toolbar

ngraham added a comment. Thanks! REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D15580: New annotation toolbar

ngraham added a comment. Looks like the dependent patch has landed, so we can more forward with this. Still LGTM. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc:

T10243: Some KDE applications could use better icons

ngraham added a comment. We should probably discuss this somewhere else so as to avoid derailing this poor task too much. :) TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts,

T10243: Some KDE applications could use better icons

ngraham added a comment. I see it in the about window: F7931541: Screenshot_20200124_082434.PNG But not in the window's titlebar, or the window switcher, or Kate's task manager icon. Basically anything outside of Kate's direct control is using the

T10243: Some KDE applications could use better icons

ngraham added a comment. Meanwhile I'm not actually seeing the new icon after updating the app from current git master. It should really be added to the Breeze icon theme. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l,

T10243: Some KDE applications could use better icons

ngraham added a comment. It's quite lovely! Much more aesthetically attractive than the current icon. However I fear that the recognizability as being a text editor has been lost; nothing about the icon connotes that it's for a text editor, which is compounded by the fact that the name

D21971: Replace ToolAction by ToggleActionMenu

ngraham added a comment. @davidhurka friendly ping. :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka, simgunz Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella,

D21971: Replace ToolAction by ToggleActionMenu

ngraham added a comment. Needs a rebase for sure REPOSITORY R223 Okular BRANCH create-configurable-toggleactionmenu REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka, simgunz Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre,

T12254: Create new icons for KPhotoAlbum

ngraham added a comment. That's not too bad! Needs a bit of work, but I think it's a solid foundation. I'll hand this over to #VDG 's icon design pros now. :) TASK DETAIL https://phabricator.kde.org/T12254 To: ngraham Cc: genkiginchan, ngraham, #vdg,

D21971: Replace ToolAction by ToggleActionMenu

ngraham added a comment. Sorry, this technical discussion is beyond me. :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella,

D22118: Shifts focus to the document when collapsing a sidebar view

ngraham closed this revision. ngraham added a comment. This was moved to invent at https://invent.kde.org/kde/okular/merge_requests/22 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham,

D25484: Enable closing a tab by middle click

ngraham added a comment. Since you've moved it over there, you can Abandon this from the Add Action... menu. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa,

D21759: Hold zoom center below center/mouse position

ngraham added a comment. Behaviorally this works great, but visually there's now a big regression: the content itself is no longer visible during the zoom operation; the view blanks out and displays the default white background. REPOSITORY R223 Okular REVISION DETAIL

D25647: Set the default font family for EPub's according to the user preference

ngraham added a comment. Can you put this on invent instead? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25647 To: yurchor, #okular Cc: ngraham, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D25484: Enable closing a tab by middle click

ngraham added a comment. Thanks, this looks great. It works just fine and the UI seems sane to me. I have some code comments: INLINE COMMENTS > shell.cpp:660 > +m_undoCloseTab->setEnabled( true ); > +m_closedTabUrls.push_back( url ); > prefer `append()` > shell.cpp:778 >

D25484: Enable closing a tab by middle click

ngraham added a comment. I think we can assume that, but check in the code. I don't think we necessarily need to save anything in memory except the URL for the document shown in the closed tab. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg

D25484: Enable closing a tab by middle click

ngraham added a comment. In D25484#567112 , @bdbai wrote: > In D25484#566490 , @pino wrote: > > > ... > > > > In D25484#566483 , @romangg wrote: > >

D25484: Enable closing a tab by middle click

ngraham added a comment. The KDE Community is transitioning away from Phabricator and towards GitLab. The transition is not yet complete, which is why the documentation still points you towards Phab. Individual apps--such as Okular--have already made the jump as "early adopters", so to

T10243: Some KDE applications could use better icons

ngraham added a comment. Sure, go ahead and edit the task. If you're dissatisfied with KPhotoAlbum's icon, VDG is happy to help. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts,

D25484: Enable closing a tab by middle click

ngraham added a comment. Undoable tab closing seems totally uncontroversial to me. Web browsers have it, Dolphin has it... It's really just a matter of consistency. On that subject, here's how Dolphin does it: F7782117: Screenshot_20191124_111840.png

D21759: Hold zoom center below center/mouse position

ngraham added a reviewer: kezik. ngraham added a comment. Oops, sorry I lost track of this patch. Can you rebase it please so we can continue the review? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21759 To: steffenh, #okular, ngraham, aacid, kezik Cc: ngraham,

D25484: Enable closing a tab by middle click

ngraham added a comment. @bdbai, to move this forward, do you think you could also make tab closing undoable? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa,

D25484: Enable closing a tab by middle click

ngraham added a comment. In D25484#566477 , @pino wrote: > > Do people frequently misclick with the middle mouse button? > > It can happen, and more often with a touchpad. I assume you're talking about Libinput's virtual middle mouse

D21971: Replace ToolAction by ToggleActionMenu

ngraham added a comment. Sorry, what is it that you'd like my input on? This conversation is rather long and I'd like to be 100% sure I understand what you're asking about. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka Cc: ngraham, simgunz,

D15580: New annotation toolbar

ngraham added a dependent revision: D25229: Update docs to the new annotation toolbar. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor,

D25229: Update docs to the new annotation toolbar

ngraham edited the summary of this revision. ngraham added a dependency: D15580: New annotation toolbar. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25229 To: yurchor, #okular Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, maguirre,

D25229: Update docs to the new annotation toolbar

ngraham added a comment. Wow, this must have been a huge amount of work. Very nice. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25229 To: yurchor, #okular Cc: ngraham, okular-devel, kde-doc-english, johnzh, andisa, siddharthmanthan, maguirre, gennad,

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D21971 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: davidhurka, aacid, okular-devel, johnzh,

D15580: New annotation toolbar

ngraham edited the summary of this revision. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#206539 , @alex-l wrote: > Thank you for your replies. As I said I discussed a new icon for Activities time ago but Ivan decided to stay with the 3-dots one. I can't always be around to check that previous

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#206510 , @ndavis wrote: > These things are what happens when the experienced people with all the unwritten knowledge go away. The redesigning of icons is a direct result of that. People redesign when they

D15580: New annotation toolbar

ngraham added a comment. In D15580#557314 , @andreashurka wrote: > - stamps won't get printed (both to pdf and paper) This is a pre-existing issue: https://bugs.kde.org/show_bug.cgi?id=383651 Definitely needs to be fixed eventually

D15580: New annotation toolbar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm happy with the UI now. :) Subsequent improvements and polish can be delivered in follow-up patches. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu

D15580: New annotation toolbar

ngraham added a comment. `window-close-symbolic` is black instead of red FWIW. Maybe we should just use that for now @trickyricky26 and #vdg , I do agree that our red close buttons draw too much attention to themselves for non-destructive close

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#554079 , @simgunz wrote: > I have never seen a close button on a standard toolbar. Are you sure it is a correct design pattern? This isn't a standard toolbar; it's a toolbar that can be shown and

D15580: [WIP] New annotation toolbar

ngraham added a comment. All right, that works! I think there's only one remaining thing I noticed, then I'm ready to give it a UI stamp of approval: the toolbar should have a close button on the far-right side (you can use an expanding spacer to position it there) so people don't have

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#552455 , @simgunz wrote: > When an annotation is selected its annotation toolbar button is checked and Browse Mode is checked, exactly as in the current Okular version. > When you select a quick annotation

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#552381 , @davidhurka wrote: > Yeah, but [_] Annotation Toolbar would be more natural, I think. At least for users who figured out the meaning of “toolbar”. That's a good idea. It would be: `[ ] Show

D15580: [WIP] New annotation toolbar

ngraham added a comment. This is super fantastic. I have a few more observations from use: - When using one of the quick annotations, the Quick Annotations button should have a checked state so you can tell that one of its tools is active (otherwise the previously-active toolbar

D15580: [WIP] New annotation toolbar

ngraham added a comment. Those color pickers are great. Can we get the tool buttons moved back to being icons-only so they'll fit in one row for an un-maximized window? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc:

D15580: [WIP] New annotation toolbar

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre,

D15580: [WIP] New annotation toolbar

ngraham added a comment. Typically the color chooser includes a "transparent" item. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel,

D24606: Prevent user changing the stamp opacity

ngraham added a comment. Do we know why it's rendered incorrectly when not opaque? Is this a bug in Okular or Poppler? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D24606 To: simgunz, #okular, #vdg Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre,

T10243: Some KDE applications could use better icons

ngraham added a comment. @mglb would you be interesting in submitting patches with those new icons? TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig,

D15580: [WIP] New annotation toolbar

ngraham added a comment. Yeah. `draw-highlight` is coming too in D24493 . With the better icons, maybe we can move the inviditual tools back to being icons-only to save a ton of space, and then everything will fit into a toolbar when the window isn't

T10243: Some KDE applications could use better icons

ngraham added a comment. Those are amazing and I love them! Especially the Yakuake icon where you've made the > character look like a subtle Y. That's just genius. The Konsole icon with the K in it might be a bit too complicated, but the simple version is top-notch. I would strongly

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#202038 , @mglb wrote: > We already explicitly suggest to make 48px application icons only (only few have more sizes). Titlebar and taskbar use ~22px icons, so

D15580: [WIP] New annotation toolbar

ngraham added a comment. If you don't like the proposed vertical toolbar, that's okay, but then we're going to need to sort out a lot of tricky UI issues for the horizontal toolbar and have perfect icons. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To:

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#201370 , @alex-l wrote: > I don't think glasses will ever look good at small sizes, can't we use something else for Okular? A clip? A highlighter? Looks okay to me at 32px: F7379054:

T10243: Some KDE applications could use better icons

ngraham added a comment. That's not a bad icon, but again, I think we owe it to the app developers to be as true to the original icon as possible. That text-origami-bird icon is cool, but it has nothing to do with Kate's original icon. The HIG specifically recommends against this: >

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#201332 , @alex-l wrote: > @ngraham I don't know about macOS, but ElementaryOS icons look so good because they are designed for each size and I don't think we have the manpower to do that to Breeze icons.

T10243: Some KDE applications could use better icons

ngraham added a comment. In T10243#201329 , @alex-l wrote: > EDIT: I have already said this here and there but please don't run any automated script to SVG icons, because when opening them back in Inkscape they are corrupted and everytime I

T10243: Some KDE applications could use better icons

ngraham added a comment. I have a problem with //extreme// minimalism in same the way that I have a problem with extreme ornamentation. I don't like either one, when taken too far. The problem with doing this is that it irritates people who really dislike that style, and they push you to go

T10243: Some KDE applications could use better icons

ngraham added a comment. The problem I have with Gwenview's icon is that it just feels inferior to the Oxygen one. The Oxygen icon has presence and communicates a style and brand, but doesn't really do a good job indicating what the app does. The Breeze icon feels like it tries to fix

T10243: Some KDE applications could use better icons

ngraham added a comment. Yeah, an app's icon is a part of its branding. It //should// look distinctive, not generic. Ideally it communicates both its purpose ("I'm a text editor!") as well as its identity ("I'm Kate!"). I think the problem with some of these icons is that they on;y do the

D23421: Add "find in this document" to selection context menu

ngraham added a comment. It's possible the #Okular people are all looking only at GitLab merge requests since Okular has migrated to GitLab.. It's possible you'll get more eyeballs on it if you re-submit this at

D11051: Remembering side navigation panel state

ngraham abandoned this revision. ngraham added a comment. This is on GitLab now: https://invent.kde.org/kde/okular/merge_requests/22 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: ngraham, #okular, aacid, dileepsankhla Cc: okular-devel, tobiasdeiminger,

D11051: Remembering side navigation panel state

ngraham commandeered this revision. ngraham added a reviewer: dileepsankhla. Herald added a subscriber: okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: ngraham, #okular, aacid, dileepsankhla Cc: okular-devel, tobiasdeiminger, aacid, sander,

D23421: Add "find in this document" to selection context menu

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. #Okular people, any comments? REPOSITORY R223 Okular BRANCH search_withing_document (branched from master) REVISION DETAIL

D23421: Add "find in this document" to selection context menu

ngraham added inline comments. INLINE COMMENTS > part.cpp:526 > connect( m_pageView.data(), ::rightClick, this, > ::slotShowMenu ); > +connect( m_pageView, ::triggerSearch, this, > ::slotShowFindBarWithInitialText ); > connect( m_document, ::error, this, ::errorMessage ); You

D23421: Add "find in this document" to selection context menu

ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

ngraham added a comment. Works great. I have some UI suggestions below: INLINE COMMENTS > pageview.cpp:4371 > const QString squeezedText = KStringHandler::rsqueeze( > searchText, 21 ); > -webShortcutsMenu->setTitle( i18n( "Search for '%1' with", > squeezedText ) );

D23421: Add "find in this document" to selection context menu

ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

ngraham retitled this revision from "Fixing: Bug 408355 - Selection context menu missing find in this document" to "Add "find in this document" to selection context menu". ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#515250 , @davidhurka wrote: > In D15580#514707 , @ngraham wrote: > > > In D15580#513826 , @simgunz wrote: > > > >

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#513826 , @simgunz wrote: > - How would you fit the annotation actions in the Reviews tab? > - Would you create a sub-tab in it (as in Gwenview where the tabs are at the bottom)? - > - Can you provide a

D15580: [WIP] New annotation toolbar

ngraham added a comment. In D15580#513395 , @davidhurka wrote: > In D15580#513253 , @ngraham wrote: > > > Some thoughts: > > > These thoughts sound good to me. > > > - Show a button on

D15580: [WIP] New annotation toolbar

ngraham added a comment. Some thoughts: - Instead of using a horizontal toolbar below the main toolbar, instead I might experiment with a vertical toolbar like the one shown in Gwenview's View mode. We could make the toolbar live inside the Reviews tab, which appears to be somewhat

D15580: [WIP] New annotation toolbar

ngraham added a comment. Thanks, I was indeed not seeing the latest version. After deleting the necessary config files, I see the latest version in its own toolbar below the main one. This is a lot better than the current one already, but I think we can polish it even more. I have a lot of

D23037: Add support for cb7 comic book archives

ngraham added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23037 To: nhiga, #okular, aacid Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23027: Add information about substituting font into properties dialog

ngraham added a comment. I agree, yeah. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23027 To: jgrulich, aacid Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D15580: [WIP] New annotation toolbar

ngraham added a reviewer: VDG. ngraham added a comment. Thanks @simgunz, this is really excellent work. Adding @VDG for more UI review comments. For my own UI review, I must continue to push for putting the annotation tools on a second toolbar that appears below the main one when

D15580: [WIP] New annotation toolbar

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D22903: Improve search field

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R223 Okular BRANCH improve-searchfield REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham Cc: ognarb, ngraham,

D22903: Improve search field

ngraham added inline comments. INLINE COMMENTS > Thumbnails.qml:33 > id: searchField > -anchors.fill: parent > +placeholderText: i18n("Search in document…") > enabled: documentItem ? documentItem.supportsSearching : false Placeholder text should

D22903: Improve search field

ngraham added a comment. Sigh, I guess so REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D22903: Improve search field

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Use `Kirigami.SearchField` instead; it takes care of everything for you. You'll need to import Kirigami 2.8 or later for this. Also the changes to `ThumbnailsBase.qml` are

D22904: Fix bookmark action

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH fix-bookmark REVISION DETAIL https://phabricator.kde.org/D22904 To: jbbgameich, #okular, #plasma:_mobile, ngraham Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto,

D22904: Fix bookmark action

ngraham added inline comments. INLINE COMMENTS > MainView.qml:36 > +onCheckedChanged: pageArea.page.bookmarked = checked > +text: pageArea.page.bookmarked ? i18n("remove bookmark") : > i18n("bookmark this page") > } Capitalize the first letters of each tooltip; tooltips

D21196: [RFC] Move Continuous option to View Mode submenu

ngraham added a comment. The new icons will land in KDE Frameworks 5.61. If you request icons that don't exist, nothing bad happens, they just don't get displayed. So you should be able to add your `setIcon()` calls anyway, and users with frameworks 5.61 will get them, and everyone else

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7069d6f0cb3d: Add view-pages-* icons, as needed in Okular for page layout selection (authored by davidhurka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ngraham added a comment. Thanks very much! So now we can expect to see an Okular patch, right? :) REPOSITORY R266 Breeze Icons BRANCH add-icons-for-pagelayouts REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel,

D22064: General improvements to stamp annotation

ngraham edited the summary of this revision. REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella,

D22064: General improvements to stamp annotation

ngraham accepted this revision. ngraham added a comment. +1, I say shipit! REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas,

D22064: General improvements to stamp annotation

ngraham added a comment. In D22064#501601 , @simgunz wrote: > In D22064#501557 , @ngraham wrote: > > > Exactly what I was imagining!I might also add at the beginning something like: "Warning:

D22064: General improvements to stamp annotation

ngraham accepted this revision. ngraham added a comment. Looks good to go from my perspective. My vote goes to shipping it after you tweak the string in the way I suggested. Nice work!  REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL

  1   2   3   4   5   >